e82c858481db7af8c15d9e383294480d06a964cf
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 7
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method private runUpdate(mailboxId CassandraId, set MessageRange, flagsUpdateCalculator FlagsUpdateCalculator) : List<UpdatedFlags> renamed to private handleUpdatesStagedRetry(mailboxId CassandraId, flagUpdateCalculator FlagsUpdateCalculator, firstResult FlagsUpdateStageResult) : FlagsUpdateStageResult in class org.apache.james.mailbox.cassandra.mail.CassandraMessageMapper | From | To | |
| Rename Method public keepSuccess() : FlagsUpdateStageResult renamed to public keepSucceded() : FlagsUpdateStageResult in class org.apache.james.mailbox.cassandra.mail.utils.FlagsUpdateStageResult | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type succeeded : List<UpdatedFlags> to succeeded : ImmutableList<UpdatedFlags> in method package FlagsUpdateStageResult(failed ImmutableList<MessageUid>, succeeded ImmutableList<UpdatedFlags>) in class org.apache.james.mailbox.cassandra.mail.utils.FlagsUpdateStageResult | From | To | |
| Change Parameter Type uidChunk : List<MessageUid> to uidChunk : Collection<MessageUid> in method private expungeUidChunk(mailboxId CassandraId, uidChunk Collection<MessageUid>) : CompletableFuture<Stream<SimpleMailboxMessage>> in class org.apache.james.mailbox.cassandra.mail.CassandraMessageMapper | From | To | |
| Change Parameter Type failed : List<MessageUid> to failed : ImmutableList<MessageUid> in method package FlagsUpdateStageResult(failed ImmutableList<MessageUid>, succeeded ImmutableList<UpdatedFlags>) in class org.apache.james.mailbox.cassandra.mail.utils.FlagsUpdateStageResult | From | To | |
| Rename Variable | 2 | ||
| Rename Variable toBeUpdated : Stream<ComposedMessageIdWithMetaData> to idsFailed : Stream<ComposedMessageIdWithMetaData> in method private retryUpdatesStage(mailboxId CassandraId, flagsUpdateCalculator FlagsUpdateCalculator, failed List<MessageUid>) : FlagsUpdateStageResult in class org.apache.james.mailbox.cassandra.mail.CassandraMessageMapper | From | To | |
| Rename Variable composedMessageIdWithMetaData : ComposedMessageIdWithMetaData to newMetadata : ComposedMessageIdWithMetaData in method private updateFlags(oldMetadata ComposedMessageIdWithMetaData, newFlags Flags, newModSeq long) : CompletableFuture<Boolean> in class org.apache.james.mailbox.cassandra.mail.CassandraMessageMapper | From | To | |
| Change Return Type | 4 | ||
| Change Return Type List<UpdatedFlags> to FlagsUpdateStageResult in method private handleUpdatesStagedRetry(mailboxId CassandraId, flagUpdateCalculator FlagsUpdateCalculator, firstResult FlagsUpdateStageResult) : FlagsUpdateStageResult in class org.apache.james.mailbox.cassandra.mail.CassandraMessageMapper | From | To | |
| Change Return Type Collector<D,?,Map<Integer,List<D>>> to Collector<D,?,Stream<Collection<D>>> in method public chunker(chunkSize int) : Collector<D,?,Stream<Collection<D>>> in class org.apache.james.util.streams.JamesCollectors | From | To | |
| Change Return Type FlagsUpdateStageResult to CompletableFuture<FlagsUpdateStageResult> in method private tryFlagsUpdate(flagUpdateCalculator FlagsUpdateCalculator, newModSeq long, oldMetaData ComposedMessageIdWithMetaData) : CompletableFuture<FlagsUpdateStageResult> in class org.apache.james.mailbox.cassandra.mail.CassandraMessageMapper | From | To | |
| Change Return Type boolean to CompletableFuture<Boolean> in method private updateFlags(oldMetadata ComposedMessageIdWithMetaData, newFlags Flags, newModSeq long) : CompletableFuture<Boolean> in class org.apache.james.mailbox.cassandra.mail.CassandraMessageMapper | From | To | |
| Move Class | 1 | ||
| Move Class org.apache.james.mailbox.cassandra.mail.CassandraMessageMapper.FlagsUpdateStageResult moved to org.apache.james.mailbox.cassandra.mail.utils.FlagsUpdateStageResult | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type succeeded : List<UpdatedFlags> to succeeded : ImmutableList<UpdatedFlags> in class org.apache.james.mailbox.cassandra.mail.utils.FlagsUpdateStageResult | From | To | |
| Change Attribute Type failed : List<MessageUid> to failed : ImmutableList<MessageUid> in class org.apache.james.mailbox.cassandra.mail.utils.FlagsUpdateStageResult | From | To | |
| Extract Method | 1 | ||
| Extract Method private retryUpdatesStage(mailboxId CassandraId, flagsUpdateCalculator FlagsUpdateCalculator, failed List<MessageUid>) : FlagsUpdateStageResult extracted from private runUpdate(mailboxId CassandraId, set MessageRange, flagsUpdateCalculator FlagsUpdateCalculator) : List<UpdatedFlags> in class org.apache.james.mailbox.cassandra.mail.CassandraMessageMapper | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter flagsUpdateCalculator : FlagsUpdateCalculator to flagUpdateCalculator : FlagsUpdateCalculator in method private handleUpdatesStagedRetry(mailboxId CassandraId, flagUpdateCalculator FlagsUpdateCalculator, firstResult FlagsUpdateStageResult) : FlagsUpdateStageResult in class org.apache.james.mailbox.cassandra.mail.CassandraMessageMapper | From | To | |
| Rename Parameter set : MessageRange to range : MessageRange in method public updateFlags(mailbox Mailbox, flagUpdateCalculator FlagsUpdateCalculator, range MessageRange) : Iterator<UpdatedFlags> in class org.apache.james.mailbox.cassandra.mail.CassandraMessageMapper | From | To |