f8eb73e8d59dcd0fc328b7a7086980bd22aa31ee
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 5
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Change Parameter Type | 1 | ||
Change Parameter Type composedMessageId : ComposedMessageIdWithMetaData to mailboxId : MailboxId in method private flagsUpdateWithRetry(newState Flags, updateMode MessageManager.FlagsUpdateMode, mailboxId MailboxId, messageId MessageId) : Optional<Pair<MailboxId,UpdatedFlags>> in class org.apache.james.mailbox.cassandra.mail.CassandraMessageIdMapper | From | To | |
Rename Variable | 2 | ||
Rename Variable mailboxId : MailboxId to cassandraId : CassandraId in method private updateFlags(mailboxId MailboxId, messageId MessageId, newState Flags, updateMode MessageManager.FlagsUpdateMode) : Optional<Pair<Flags,ComposedMessageIdWithMetaData>> in class org.apache.james.mailbox.cassandra.mail.CassandraMessageIdMapper | From | To | |
Rename Variable composedMessageId : ComposedMessageIdWithMetaData to storedComposedId : ComposedMessageIdWithMetaData in method private updateFlags(mailboxId MailboxId, messageId MessageId, newState Flags, updateMode MessageManager.FlagsUpdateMode) : Optional<Pair<Flags,ComposedMessageIdWithMetaData>> in class org.apache.james.mailbox.cassandra.mail.CassandraMessageIdMapper | From | To | |
Change Return Type | 3 | ||
Change Return Type Optional<Pair<Flags,Long>> to Optional<Pair<Flags,ComposedMessageIdWithMetaData>> in method private tryFlagsUpdate(newState Flags, updateMode MessageManager.FlagsUpdateMode, mailboxId MailboxId, messageId MessageId) : Optional<Pair<Flags,ComposedMessageIdWithMetaData>> in class org.apache.james.mailbox.cassandra.mail.CassandraMessageIdMapper | From | To | |
Change Return Type Pair<MailboxId,UpdatedFlags> to Optional<Pair<MailboxId,UpdatedFlags>> in method private flagsUpdateWithRetry(newState Flags, updateMode MessageManager.FlagsUpdateMode, mailboxId MailboxId, messageId MessageId) : Optional<Pair<MailboxId,UpdatedFlags>> in class org.apache.james.mailbox.cassandra.mail.CassandraMessageIdMapper | From | To | |
Change Return Type CompletableFuture<Boolean> to CompletableFuture<Void> in method public updateMetadata(composedMessageIdWithMetaData ComposedMessageIdWithMetaData) : CompletableFuture<Void> in class org.apache.james.mailbox.cassandra.mail.CassandraMessageIdDAO | From | To | |
Merge Variable | 1 | ||
Merge Variable [composedMessageId : ComposedMessageIdWithMetaData, newFlagsWithModSeq : Pair<Flags,Long>] to pair : Pair<Flags,ComposedMessageIdWithMetaData> in method private flagsUpdateWithRetry(newState Flags, updateMode MessageManager.FlagsUpdateMode, mailboxId MailboxId, messageId MessageId) : Optional<Pair<MailboxId,UpdatedFlags>> in class org.apache.james.mailbox.cassandra.mail.CassandraMessageIdMapper | From | To | |
Change Variable Type | 1 | ||
Change Variable Type mailboxId : MailboxId to cassandraId : CassandraId in method private updateFlags(mailboxId MailboxId, messageId MessageId, newState Flags, updateMode MessageManager.FlagsUpdateMode) : Optional<Pair<Flags,ComposedMessageIdWithMetaData>> in class org.apache.james.mailbox.cassandra.mail.CassandraMessageIdMapper | From | To | |
Extract Method | 1 | ||
Extract Method private updateFlags(mailboxId MailboxId, messageId MessageId, newState Flags, updateMode MessageManager.FlagsUpdateMode) : Optional<Pair<Flags,ComposedMessageIdWithMetaData>> extracted from private tryFlagsUpdate(newState Flags, updateMode MessageManager.FlagsUpdateMode, composedMessageId ComposedMessageIdWithMetaData, oldModSeq long) : Optional<Pair<Flags,Long>> in class org.apache.james.mailbox.cassandra.mail.CassandraMessageIdMapper | From | To | |
Rename Parameter | 1 | ||
Rename Parameter composedMessageId : ComposedMessageIdWithMetaData to mailboxId : MailboxId in method private flagsUpdateWithRetry(newState Flags, updateMode MessageManager.FlagsUpdateMode, mailboxId MailboxId, messageId MessageId) : Optional<Pair<MailboxId,UpdatedFlags>> in class org.apache.james.mailbox.cassandra.mail.CassandraMessageIdMapper | From | To |