jetty.project 0bd1e0ad7d2563b7f756ea56340903a02d5bca5c

0bd1e0ad7d2563b7f756ea56340903a02d5bca5c

Files Diff

Added: 3
Removed: 1
Renamed: 0
Modified: 24

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	1
Move And Rename Method protected idleCreated(connection Connection) : void from class org.eclipse.jetty.client.DuplexConnectionPool to protected onCreated(connection Connection) : void from class org.eclipse.jetty.client.MultiplexConnectionPool	From	To
Change Parameter Type	2
Change Parameter Type connection : C to connection : Connection in method public process(connection Connection) : void in class org.eclipse.jetty.client.HttpDestination	From	To
Change Parameter Type sslContextFactory : SslContextFactory to transport : Transport in method public HttpClientLoadTest(transport Transport) in class org.eclipse.jetty.http.client.HttpClientLoadTest	From	To
Move Method	4
Move Method public remove(connection Connection) : boolean from class org.eclipse.jetty.client.PoolingHttpDestination to public remove(connection Connection) : boolean from class org.eclipse.jetty.client.MultiplexConnectionPool	From	To
Move Method public dump(out Appendable, indent String) : void from class org.eclipse.jetty.client.PoolingHttpDestination to public dump(out Appendable, indent String) : void from class org.eclipse.jetty.client.MultiplexConnectionPool	From	To
Move Method public toString() : String from class org.eclipse.jetty.client.PoolingHttpDestination to public toString() : String from class org.eclipse.jetty.client.MultiplexConnectionPool.Holder	From	To
Move Method public close() : void from class org.eclipse.jetty.client.PoolingHttpDestination to public close() : void from class org.eclipse.jetty.client.AbstractConnectionPool	From	To
Pull Up Attribute	4
Pull Up Attribute private requester : Callback from class org.eclipse.jetty.client.DuplexConnectionPool to private requester : Callback from class org.eclipse.jetty.client.AbstractConnectionPool	From	To
Pull Up Attribute private connectionCount : AtomicInteger from class org.eclipse.jetty.client.DuplexConnectionPool to private connectionCount : AtomicInteger from class org.eclipse.jetty.client.AbstractConnectionPool	From	To
Pull Up Attribute private maxConnections : int from class org.eclipse.jetty.client.DuplexConnectionPool to private maxConnections : int from class org.eclipse.jetty.client.AbstractConnectionPool	From	To
Pull Up Attribute private destination : Destination from class org.eclipse.jetty.client.DuplexConnectionPool to private destination : Destination from class org.eclipse.jetty.client.AbstractConnectionPool	From	To
Extract Class	2
Extract Class org.eclipse.jetty.client.MultiplexConnectionPool from class org.eclipse.jetty.client.PoolingHttpDestination	From	To
Extract Class org.eclipse.jetty.client.AbstractConnectionPool from class org.eclipse.jetty.client.PoolingHttpDestination	From	To
Move Class	1
Move Class org.eclipse.jetty.client.HttpClientLoadTest moved to org.eclipse.jetty.http.client.HttpClientLoadTest	From	To
Extract Variable	3
Extract Variable connectionPool : DuplexConnectionPool in method public test_SecondAcquire_ConcurrentWithFirstAcquire_WithEmptyQueue_CreatesTwoConnections() : void from class org.eclipse.jetty.client.http.HttpDestinationOverHTTPTest	From	To
Extract Variable connectionPool : DuplexConnectionPool in method public testProxyRequestFailureInTheMiddleOfProxyingSmallContent() : void from class org.eclipse.jetty.proxy.ProxyServletTest	From	To
Extract Variable connectionPool : DuplexConnectionPool in method public testProxyRequestFailureInTheMiddleOfProxyingBigContent() : void from class org.eclipse.jetty.proxy.ProxyServletTest	From	To
Change Variable Type	17
Change Variable Type activeConnections : Queue<Connection> to activeConnections : Collection<Connection> in method public test_IdleConnection_IsClosed_OnRemoteClose() : void in class org.eclipse.jetty.client.HttpConnectionLifecycleTest	From	To
Change Variable Type activeConnections : Queue<Connection> to activeConnections : Collection<Connection> in method public test_BadRequest_WithSlowRequest_RemovesConnection() : void in class org.eclipse.jetty.client.HttpConnectionLifecycleTest	From	To
Change Variable Type activeConnections : Queue<Connection> to activeConnections : Collection<Connection> in method public test_ConnectionFailure_RemovesConnection() : void in class org.eclipse.jetty.client.HttpConnectionLifecycleTest	From	To
Change Variable Type idleConnections : Queue<Connection> to idleConnections : Collection<Connection> in method public test_IdleConnection_IsClosed_OnRemoteClose() : void in class org.eclipse.jetty.client.HttpConnectionLifecycleTest	From	To
Change Variable Type activeConnections : Queue<Connection> to activeConnections : Collection<Connection> in method public testConnectionForHTTP10ResponseIsRemoved() : void in class org.eclipse.jetty.client.HttpConnectionLifecycleTest	From	To
Change Variable Type activeConnections : Queue<Connection> to activeConnections : Collection<Connection> in method public test_SuccessfulRequest_ReturnsConnection() : void in class org.eclipse.jetty.client.HttpConnectionLifecycleTest	From	To
Change Variable Type idleConnections : Queue<Connection> to idleConnections : Collection<Connection> in method public test_ConnectionFailure_RemovesConnection() : void in class org.eclipse.jetty.client.HttpConnectionLifecycleTest	From	To
Change Variable Type idleConnections : Queue<Connection> to idleConnections : Collection<Connection> in method public testConnectionForHTTP10ResponseIsRemoved() : void in class org.eclipse.jetty.client.HttpConnectionLifecycleTest	From	To
Change Variable Type idleConnections : Queue<Connection> to idleConnections : Collection<Connection> in method public test_SuccessfulRequest_ReturnsConnection() : void in class org.eclipse.jetty.client.HttpConnectionLifecycleTest	From	To
Change Variable Type activeConnections : Queue<Connection> to activeConnections : Collection<Connection> in method public test_ResponseWithConnectionCloseHeader_RemovesConnection() : void in class org.eclipse.jetty.client.HttpConnectionLifecycleTest	From	To
Change Variable Type activeConnections : Queue<Connection> to activeConnections : Collection<Connection> in method public test_BadRequest_RemovesConnection() : void in class org.eclipse.jetty.client.HttpConnectionLifecycleTest	From	To
Change Variable Type idleConnections : Queue<Connection> to idleConnections : Collection<Connection> in method public test_BadRequest_WithSlowRequest_RemovesConnection() : void in class org.eclipse.jetty.client.HttpConnectionLifecycleTest	From	To
Change Variable Type idleConnections : Queue<Connection> to idleConnections : Collection<Connection> in method public test_ResponseWithConnectionCloseHeader_RemovesConnection() : void in class org.eclipse.jetty.client.HttpConnectionLifecycleTest	From	To
Change Variable Type activeConnections : Queue<Connection> to activeConnections : Collection<Connection> in method public test_BigRequestContent_ResponseWithConnectionCloseHeader_RemovesConnection() : void in class org.eclipse.jetty.client.HttpConnectionLifecycleTest	From	To
Change Variable Type activeConnections : Queue<Connection> to activeConnections : Collection<Connection> in method public test_FailedRequest_RemovesConnection() : void in class org.eclipse.jetty.client.HttpConnectionLifecycleTest	From	To
Change Variable Type idleConnections : Queue<Connection> to idleConnections : Collection<Connection> in method public test_BigRequestContent_ResponseWithConnectionCloseHeader_RemovesConnection() : void in class org.eclipse.jetty.client.HttpConnectionLifecycleTest	From	To
Change Variable Type idleConnections : Queue<Connection> to idleConnections : Collection<Connection> in method public test_FailedRequest_RemovesConnection() : void in class org.eclipse.jetty.client.HttpConnectionLifecycleTest	From	To
Extract Method	1
Extract Method protected newServerConnector(server Server) : ServerConnector extracted from private startServer(handler Handler) : void in class org.eclipse.jetty.http.client.AbstractTest	From	To
Rename Method	2
Rename Method protected offerIdle(connection Connection) : boolean renamed to protected deactivate(connection Connection) : boolean in class org.eclipse.jetty.client.DuplexConnectionPool	From	To
Rename Method public isIdle(connection Connection) : boolean renamed to protected onCreated(connection Connection) : void in class org.eclipse.jetty.client.DuplexConnectionPool	From	To
Pull Up Method	19
Pull Up Method public acquire() : Connection from class org.eclipse.jetty.client.DuplexConnectionPool to public acquire() : Connection from class org.eclipse.jetty.client.AbstractConnectionPool	From	To
Pull Up Method public isEmpty() : boolean from class org.eclipse.jetty.client.DuplexConnectionPool to public isEmpty() : boolean from class org.eclipse.jetty.client.AbstractConnectionPool	From	To
Pull Up Method protected proceed() : void from class org.eclipse.jetty.client.DuplexConnectionPool to protected proceed() : void from class org.eclipse.jetty.client.AbstractConnectionPool	From	To
Pull Up Method private tryCreate() : Connection from class org.eclipse.jetty.client.DuplexConnectionPool to private tryCreate() : Connection from class org.eclipse.jetty.client.AbstractConnectionPool	From	To
Pull Up Method public dump() : String from class org.eclipse.jetty.client.DuplexConnectionPool to public dump() : String from class org.eclipse.jetty.client.AbstractConnectionPool	From	To
Pull Up Method protected idle(connection Connection, idle boolean) : boolean from class org.eclipse.jetty.client.DuplexConnectionPool to protected idle(connection Connection, close boolean) : boolean from class org.eclipse.jetty.client.AbstractConnectionPool	From	To
Pull Up Method protected doStop() : void from class org.eclipse.jetty.client.PoolingHttpDestination to protected doStop() : void from class org.eclipse.jetty.client.HttpDestination	From	To
Pull Up Method public getConnectionCount() : int from class org.eclipse.jetty.client.DuplexConnectionPool to public getConnectionCount() : int from class org.eclipse.jetty.client.AbstractConnectionPool	From	To
Pull Up Method protected doStart() : void from class org.eclipse.jetty.client.PoolingHttpDestination to protected doStart() : void from class org.eclipse.jetty.client.HttpDestination	From	To
Pull Up Method public failed(x Throwable) : void from class org.eclipse.jetty.client.PoolingHttpDestination to public failed(x Throwable) : void from class org.eclipse.jetty.client.HttpDestination	From	To
Pull Up Method private process() : void from class org.eclipse.jetty.client.PoolingHttpDestination to private process() : void from class org.eclipse.jetty.client.HttpDestination	From	To
Pull Up Method protected acquired(connection Connection) : void from class org.eclipse.jetty.client.DuplexConnectionPool to protected acquired(connection Connection) : void from class org.eclipse.jetty.client.AbstractConnectionPool	From	To
Pull Up Method public send() : void from class org.eclipse.jetty.client.PoolingHttpDestination to public send() : void from class org.eclipse.jetty.client.HttpDestination	From	To
Pull Up Method public close(connection Connection) : void from class org.eclipse.jetty.client.PoolingHttpDestination to public close(connection Connection) : void from class org.eclipse.jetty.client.HttpDestination	From	To
Pull Up Method public release(c Connection) : void from class org.eclipse.jetty.client.PoolingHttpDestination to public release(connection Connection) : void from class org.eclipse.jetty.client.HttpDestination	From	To
Pull Up Method public process(connection C) : void from class org.eclipse.jetty.client.PoolingHttpDestination to public process(connection Connection) : void from class org.eclipse.jetty.client.HttpDestination	From	To
Pull Up Method protected released(connection Connection) : void from class org.eclipse.jetty.client.DuplexConnectionPool to protected released(connection Connection) : void from class org.eclipse.jetty.client.AbstractConnectionPool	From	To
Pull Up Method public failed(x Throwable) : void from class org.eclipse.jetty.client.MultiplexHttpDestination to public failed(x Throwable) : void from class org.eclipse.jetty.client.HttpDestination	From	To
Pull Up Method public succeeded() : void from class org.eclipse.jetty.client.PoolingHttpDestination to public succeeded() : void from class org.eclipse.jetty.client.HttpDestination	From	To
Rename Variable	1
Rename Variable idle : boolean to closed : boolean in method public release(connection Connection) : boolean in class org.eclipse.jetty.client.DuplexConnectionPool	From	To
Change Return Type	3
Change Return Type boolean to void in method protected onCreated(connection Connection) : void in class org.eclipse.jetty.client.DuplexConnectionPool	From	To
Change Return Type Queue<Connection> to Collection<Connection> in method public getActiveConnections() : Collection<Connection> in class org.eclipse.jetty.client.DuplexConnectionPool	From	To
Change Return Type DuplexConnectionPool to ConnectionPool in method protected newConnectionPool(client HttpClient) : ConnectionPool in class org.eclipse.jetty.client.PoolingHttpDestination	From	To
Extract Superclass	1
Extract Superclass org.eclipse.jetty.client.AbstractConnectionPool from classes [org.eclipse.jetty.client.DuplexConnectionPool]	From	To
Rename Attribute	1
Rename Attribute latch : AtomicBoolean to done : AtomicBoolean in class org.eclipse.jetty.client.ValidatingConnectionPool.Holder	From	To
Change Attribute Type	1
Change Attribute Type activeConnections : Queue<Connection> to activeConnections : Set<Connection> in class org.eclipse.jetty.client.DuplexConnectionPool	From	To
Rename Parameter	3
Rename Parameter idle : boolean to close : boolean in method protected idle(connection Connection, close boolean) : boolean in class org.eclipse.jetty.client.AbstractConnectionPool	From	To
Rename Parameter c : Connection to connection : Connection in method public release(connection Connection) : void in class org.eclipse.jetty.client.HttpDestination	From	To
Rename Parameter sslContextFactory : SslContextFactory to transport : Transport in method public HttpClientLoadTest(transport Transport) in class org.eclipse.jetty.http.client.HttpClientLoadTest	From	To

0bd1e0ad7d2563b7f756ea56340903a02d5bca5c

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: