8dba440317f7f8f2313d7a709946f38b9425d98c
Files Diff
- Added: 22
- Removed: 12
- Renamed: 0
- Modified: 62
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method public addListener(listener ConnectionStateListener) : void from class org.eclipse.jetty.websocket.common.io.IOState to public addSessionListener(listener WebSocketSessionListener) : void from class org.eclipse.jetty.websocket.common.test.BlockheadClient | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type listener : WebSocketSession.Listener to listener : WebSocketSessionListener in method public removeSessionListener(listener WebSocketSessionListener) : void in class org.eclipse.jetty.websocket.server.WebSocketServerFactory | From | To | |
| Change Parameter Type listener : ConnectionStateListener to listener : WebSocketSessionListener in method public addSessionListener(listener WebSocketSessionListener) : void in class org.eclipse.jetty.websocket.common.test.BlockheadClient | From | To | |
| Change Parameter Type consumer : Consumer<WebSocketSession.Listener> to consumer : Consumer<WebSocketSessionListener> in method private notifySessionListeners(scope WebSocketContainerScope, consumer Consumer<WebSocketSessionListener>) : void in class org.eclipse.jetty.websocket.common.WebSocketSession | From | To | |
| Change Parameter Type listener : WebSocketSession.Listener to listener : WebSocketSessionListener in method public addSessionListener(listener WebSocketSessionListener) : void in class org.eclipse.jetty.websocket.server.WebSocketServerFactory | From | To | |
| Move Method | 1 | ||
| Move Method private notifySessionListeners(consumer Consumer<WebSocketSession.Listener>) : void from class org.eclipse.jetty.websocket.server.WebSocketServerFactory to private notifySessionListeners(scope WebSocketContainerScope, consumer Consumer<WebSocketSessionListener>) : void from class org.eclipse.jetty.websocket.common.WebSocketSession | From | To | |
| Pull Up Attribute | 1 | ||
| Pull Up Attribute private LOG : Logger from class org.eclipse.jetty.websocket.server.ManyConnectionsCleanupTest.ContainerSocket to public LOG : Logger from class org.eclipse.jetty.websocket.tests.server.AbstractCloseEndpoint | From | To | |
| Extract Class | 1 | ||
| Extract Class org.eclipse.jetty.websocket.common.io.ConnectionState from class org.eclipse.jetty.websocket.common.io.LocalWebSocketConnection | From | To | |
| Rename Class | 1 | ||
| Rename Class org.eclipse.jetty.websocket.common.io.FrameFlusherTest.SaneFrameOrderingEndPoint renamed to org.eclipse.jetty.websocket.common.io.FrameFlusherTest.CapturingEndPoint | From | To | |
| Move And Rename Class | 7 | ||
| Move And Rename Class org.eclipse.jetty.websocket.common.WebSocketSession.OnCloseLocalCallback moved and renamed to org.eclipse.jetty.websocket.common.io.LocalWebSocketConnection.CallbackBridge | From | To | |
| Move And Rename Class org.eclipse.jetty.websocket.common.WebSocketSession.Listener moved and renamed to org.eclipse.jetty.websocket.common.WebSocketSessionListener | From | To | |
| Move And Rename Class org.eclipse.jetty.websocket.client.SessionTest moved and renamed to org.eclipse.jetty.websocket.tests.client.ClientSessionsTest | From | To | |
| Move And Rename Class org.eclipse.jetty.websocket.server.ManyConnectionsCleanupTest moved and renamed to org.eclipse.jetty.websocket.tests.server.ServerCloseTest | From | To | |
| Move And Rename Class org.eclipse.jetty.websocket.server.ManyConnectionsCleanupTest.ContainerSocket moved and renamed to org.eclipse.jetty.websocket.tests.server.ContainerEndpoint | From | To | |
| Move And Rename Class org.eclipse.jetty.websocket.common.ConnectionState moved and renamed to org.eclipse.jetty.websocket.common.io.ConnectionState.State | From | To | |
| Move And Rename Class org.eclipse.jetty.websocket.client.ClientCloseTest.CloseTrackingSocket moved and renamed to org.eclipse.jetty.websocket.tests.CloseTrackingEndpoint | From | To | |
| Move Class | 6 | ||
| Move Class org.eclipse.jetty.websocket.client.SlowServerTest moved to org.eclipse.jetty.websocket.tests.server.SlowServerTest | From | To | |
| Move Class org.eclipse.jetty.websocket.common.WebSocketSession.DisconnectCallback moved to org.eclipse.jetty.websocket.common.io.LocalWebSocketConnection.DisconnectCallback | From | To | |
| Move Class org.eclipse.jetty.websocket.client.ClientWriteThread moved to org.eclipse.jetty.websocket.tests.client.ClientWriteThread | From | To | |
| Move Class org.eclipse.jetty.websocket.client.BadNetworkTest moved to org.eclipse.jetty.websocket.tests.client.BadNetworkTest | From | To | |
| Move Class org.eclipse.jetty.websocket.client.SlowClientTest moved to org.eclipse.jetty.websocket.tests.client.SlowClientTest | From | To | |
| Move Class org.eclipse.jetty.websocket.client.ClientCloseTest moved to org.eclipse.jetty.websocket.tests.client.ClientCloseTest | From | To | |
| Extract Variable | 1 | ||
| Extract Variable port : int in method public testWebSocketProtocolResponse() : void from class org.eclipse.jetty.websocket.server.WebSocketProtocolTest | From | To | |
| Change Variable Type | 10 | ||
| Change Variable Type clientSocket : JettyTrackingSocket to clientEndpoint : CloseTrackingEndpoint in method public testServerSlowToSend() : void in class org.eclipse.jetty.websocket.tests.server.SlowServerTest | From | To | |
| Change Variable Type cliSock : JettyTrackingSocket to cliSock : CloseTrackingEndpoint in method public testBasicEcho_FromClient() : void in class org.eclipse.jetty.websocket.tests.client.ClientSessionsTest | From | To | |
| Change Variable Type clientSocket : CloseTrackingSocket to clientSocket : CloseTrackingEndpoint in method public testWriteException() : void in class org.eclipse.jetty.websocket.tests.client.ClientCloseTest | From | To | |
| Change Variable Type tsocket : JettyTrackingSocket to clientEndpoint : CloseTrackingEndpoint in method public testClientSlowToSend() : void in class org.eclipse.jetty.websocket.tests.client.SlowClientTest | From | To | |
| Change Variable Type clientSockets : List<CloseTrackingSocket> to clientSockets : List<CloseTrackingEndpoint> in method public testStopLifecycle() : void in class org.eclipse.jetty.websocket.tests.client.ClientCloseTest | From | To | |
| Change Variable Type wsocket : JettyTrackingSocket to wsocket : CloseTrackingEndpoint in method public testAbruptServerClose() : void in class org.eclipse.jetty.websocket.tests.client.BadNetworkTest | From | To | |
| Change Variable Type clientSocket : CloseTrackingSocket to clientSocket : CloseTrackingEndpoint in method public testServerNoCloseHandshake() : void in class org.eclipse.jetty.websocket.tests.client.ClientCloseTest | From | To | |
| Change Variable Type clientSocket : CloseTrackingSocket to clientSocket : CloseTrackingEndpoint in method public testHalfClose() : void in class org.eclipse.jetty.websocket.tests.client.ClientCloseTest | From | To | |
| Change Variable Type endPoint : SaneFrameOrderingEndPoint to endPoint : CapturingEndPoint in method public testLargeSmallText() : void in class org.eclipse.jetty.websocket.common.io.FrameFlusherTest | From | To | |
| Change Variable Type wsocket : JettyTrackingSocket to wsocket : CloseTrackingEndpoint in method public testAbruptClientClose() : void in class org.eclipse.jetty.websocket.tests.client.BadNetworkTest | From | To | |
| Inline Variable | 1 | ||
| Inline Variable closed : Throwable in method public onCompleteFailure(failure Throwable) : void from class org.eclipse.jetty.websocket.common.io.FrameFlusher | From | To | |
| Rename Variable | 7 | ||
| Rename Variable clientConnectFuture : Future<Session> to future : Future<Session> in method public testServerSlowToSend() : void in class org.eclipse.jetty.websocket.tests.server.SlowServerTest | From | To | |
| Rename Variable clientCount : int to sessionCount : int in method public testStopLifecycle() : void in class org.eclipse.jetty.websocket.tests.client.ClientCloseTest | From | To | |
| Rename Variable resp : String to msg : String in method public testOpenSessionCleanup() : void in class org.eclipse.jetty.websocket.tests.server.ServerCloseTest | From | To | |
| Rename Variable closed : Throwable to dead : Throwable in method public enqueue(frame Frame, callback WriteCallback, batchMode BatchMode) : boolean in class org.eclipse.jetty.websocket.common.io.FrameFlusher | From | To | |
| Rename Variable clientSocket : JettyTrackingSocket to clientEndpoint : CloseTrackingEndpoint in method public testServerSlowToSend() : void in class org.eclipse.jetty.websocket.tests.server.SlowServerTest | From | To | |
| Rename Variable tsocket : JettyTrackingSocket to clientEndpoint : CloseTrackingEndpoint in method public testClientSlowToSend() : void in class org.eclipse.jetty.websocket.tests.client.SlowClientTest | From | To | |
| Rename Variable timeout : int to clientTimeout : int in method public testServerNoCloseHandshake() : void in class org.eclipse.jetty.websocket.tests.client.ClientCloseTest | From | To | |
| Change Return Type | 1 | ||
| Change Return Type void to boolean in method public enqueue(frame Frame, callback WriteCallback, batchMode BatchMode) : boolean in class org.eclipse.jetty.websocket.common.io.FrameFlusher | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.eclipse.jetty.websocket.tests.server.AbstractCloseEndpoint from classes [org.eclipse.jetty.websocket.tests.server.ContainerEndpoint] | From | To | |
| Extract Interface | 1 | ||
| Extract Interface org.eclipse.jetty.websocket.common.WebSocketSessionListener from classes [org.eclipse.jetty.websocket.jsr356.ClientContainer, org.eclipse.jetty.websocket.client.WebSocketClient, org.eclipse.jetty.websocket.server.WebSocketServerFactory] | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type server : BrowserDebugTool to server : Server in class org.eclipse.jetty.websocket.server.WebSocketProtocolTest | From | To | |
| Change Attribute Type server : BlockheadServer to server : Server in class org.eclipse.jetty.websocket.tests.server.SlowServerTest | From | To | |
| Change Attribute Type listeners : List<WebSocketSession.Listener> to listeners : List<WebSocketSessionListener> in class org.eclipse.jetty.websocket.server.WebSocketServerFactory | From | To | |
| Change Attribute Type incomingFrames : int to incomingFrames : LinkedBlockingQueue<Frame> in class org.eclipse.jetty.websocket.common.io.FrameFlusherTest.CapturingEndPoint | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public close(cause Throwable) : void extracted from public open() : void in class org.eclipse.jetty.websocket.common.WebSocketSession & moved to class org.eclipse.jetty.websocket.common.test.DummyConnection | From | To |