kaa 9f340f8282cfc72dace0947aeeb522c213e87065

9f340f8282cfc72dace0947aeeb522c213e87065

Files Diff

Added: 14
Removed: 12
Renamed: 0
Modified: 54

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	5
Change Parameter Type version : int to version : Integer in method public getEventClassesByFamilyIdVersionAndType(eventClassFamilyId String, version Integer, type EventClassType) : List<EventClassDto> in class org.kaaproject.kaa.server.admin.shared.services.KaaAdminService	From	To
Change Parameter Type version : int to version : Integer in method public getEventClassesByFamilyIdVersionAndType(eventClassFamilyId String, version Integer, type EventClassType) : List<EventClassDto> in class org.kaaproject.kaa.server.admin.services.KaaAdminServiceImpl	From	To
Change Parameter Type place : EcfSchemaPlace to place : EcfVersionPlace in method public getToken(place EcfVersionPlace) : String in class org.kaaproject.kaa.server.admin.client.mvp.place.EcfVersionPlace.Tokenizer	From	To
Change Parameter Type place : EcfSchemaPlace to place : EcfVersionPlace in method public EcfVersionActivity(place EcfVersionPlace, clientFactory ClientFactory) in class org.kaaproject.kaa.server.admin.client.mvp.activity.EcfVersionActivity	From	To
Change Parameter Type place : EventClassPlace to place : P in method public getToken(place P) : String in class org.kaaproject.kaa.server.admin.client.mvp.place.AbstractSchemaPlaceEvent.Tokenizer	From	To
Move Method	2
Move Method public getEcfId() : String from class org.kaaproject.kaa.server.admin.client.mvp.place.EcfSchemaPlace to public getEcfId() : String from class org.kaaproject.kaa.server.admin.client.mvp.place.CtlSchemaPlace	From	To
Move Method public getPlace(token String) : EventClassPlace from class org.kaaproject.kaa.server.admin.client.mvp.place.EventClassPlace.Tokenizer to public getPlace(token String) : P from class org.kaaproject.kaa.server.admin.client.mvp.place.SchemasPlaceEvent.Tokenizer	From	To
Pull Up Attribute	1
Pull Up Attribute private ecfId : String from class org.kaaproject.kaa.server.admin.client.mvp.place.EventClassPlace to protected ecfId : String from class org.kaaproject.kaa.server.admin.client.mvp.place.SchemasPlaceEvent	From	To
Push Down Attribute	1
Push Down Attribute protected applicationId : String from class org.kaaproject.kaa.server.admin.client.mvp.activity.AbstractBaseCtlSchemaActivity to protected applicationId : String from class org.kaaproject.kaa.server.admin.client.mvp.activity.AbstractBaseCtlSchemaActivityApplication	From	To
Move Attribute	2
Move Attribute private ecfId : String from class org.kaaproject.kaa.server.admin.client.mvp.place.EcfSchemaPlace to private ecfId : String from class org.kaaproject.kaa.server.admin.client.mvp.place.CtlSchemaPlace	From	To
Move Attribute private ecfId : String from class org.kaaproject.kaa.server.admin.client.mvp.place.EventClassPlace to private ecfId : String from class org.kaaproject.kaa.server.admin.client.mvp.place.CtlSchemaPlace	From	To
Extract Class	1
Extract Class org.kaaproject.kaa.server.admin.client.mvp.place.SchemasPlaceEvent.Tokenizer from class org.kaaproject.kaa.server.admin.client.mvp.place.EventClassPlace.Tokenizer	From	To
Rename Class	8
Rename Class org.kaaproject.kaa.server.admin.client.mvp.view.event.EventClassesGrid renamed to org.kaaproject.kaa.server.admin.client.mvp.view.event.EcfVersionGrid	From	To
Rename Class org.kaaproject.kaa.server.admin.client.mvp.activity.EcfSchemaActivity renamed to org.kaaproject.kaa.server.admin.client.mvp.activity.EcfVersionActivity	From	To
Rename Class org.kaaproject.kaa.server.admin.client.mvp.place.SchemasPlace renamed to org.kaaproject.kaa.server.admin.client.mvp.place.SchemasPlaceApplication	From	To
Rename Class org.kaaproject.kaa.server.admin.client.mvp.data.EventClassesDataProvider renamed to org.kaaproject.kaa.server.admin.client.mvp.data.EcfVersionDataProvider	From	To
Rename Class org.kaaproject.kaa.server.admin.client.mvp.view.event.EcfSchemasGrid renamed to org.kaaproject.kaa.server.admin.client.mvp.view.event.EcfVersionsGrid	From	To
Rename Class org.kaaproject.kaa.server.admin.client.mvp.data.EcfSchemasDataProvider renamed to org.kaaproject.kaa.server.admin.client.mvp.data.EcfVersionsDataProvider	From	To
Rename Class org.kaaproject.kaa.server.admin.client.mvp.place.AbstractSchemaPlace renamed to org.kaaproject.kaa.server.admin.client.mvp.place.AbstractSchemaPlaceApplication	From	To
Rename Class org.kaaproject.kaa.server.admin.client.mvp.place.EcfSchemaPlace renamed to org.kaaproject.kaa.server.admin.client.mvp.place.EcfVersionPlace	From	To
Move Class	1
Move Class org.kaaproject.kaa.server.admin.client.mvp.place.EcfSchemaPlace.Tokenizer moved to org.kaaproject.kaa.server.admin.client.mvp.place.EcfVersionPlace.Tokenizer	From	To
Move And Rename Attribute	3
Move And Rename Attribute public filterPanel : HorizontalPanel renamed to public supportPanel : HorizontalPanel and moved from class org.kaaproject.kaa.server.admin.client.mvp.view.endpoint.EndpointProfilesViewImpl to class org.kaaproject.kaa.server.admin.client.mvp.view.base.BaseListViewImpl	From	To
Move And Rename Attribute private version : int renamed to private ecfVersion : int and moved from class org.kaaproject.kaa.server.admin.client.mvp.place.EcfSchemaPlace to class org.kaaproject.kaa.server.admin.client.mvp.place.CtlSchemaPlace	From	To
Move And Rename Attribute private version : int renamed to private eventClassDtoList : List<EventClassViewDto> and moved from class org.kaaproject.kaa.server.admin.client.mvp.place.EventClassPlace to class org.kaaproject.kaa.server.admin.client.mvp.place.CtlSchemaPlace	From	To
Change Variable Type	3
Change Variable Type other : EcfSchemaPlace to other : EcfVersionPlace in method public equals(obj Object) : boolean in class org.kaaproject.kaa.server.admin.client.mvp.place.EcfVersionPlace	From	To
Change Variable Type ecfSchemaPlace : EcfSchemaPlace to ecfVersionPlace : EcfVersionPlace in method private addEcfVersion() : void in class org.kaaproject.kaa.server.admin.client.mvp.activity.EcfActivity	From	To
Change Variable Type other : SchemasPlace to other : SchemasPlaceApplication in method public equals(obj Object) : boolean in class org.kaaproject.kaa.server.admin.client.mvp.place.SchemasPlaceApplication	From	To
Rename Method	19
Rename Method public setEcfId(ecfId String) : void renamed to public setEcfvId(ecfvId String) : void in class org.kaaproject.kaa.common.dto.event.EventClassDto	From	To
Rename Method public deleteEventClassById(eventClassId String) : void renamed to public getEventClassById(eventClassId String) : EventClassDto in class org.kaaproject.kaa.server.control.service.DefaultControlService	From	To
Rename Method public deleteEventClassById(eventClassId String) : void renamed to public getEventClass(eventClassId String) : EventClassDto in class org.kaaproject.kaa.server.admin.services.KaaAdminServiceImpl	From	To
Rename Method public deleteEventClassById(ecfId String) : void renamed to public removeByEcfId(ecfId String) : void in class org.kaaproject.kaa.server.common.dao.impl.EventClassDao	From	To
Rename Method public getEcfSchemasGrid() : AbstractGrid<EventClassFamilyVersionDto,Integer> renamed to public getEcfVersionsGrid() : AbstractGrid<EventClassFamilyVersionDto,Integer> in class org.kaaproject.kaa.server.admin.client.mvp.view.event.EcfViewImpl	From	To
Rename Method private addEcfSchema() : void renamed to private addEcfVersion() : void in class org.kaaproject.kaa.server.admin.client.mvp.activity.EcfActivity	From	To
Rename Method public getEcfSchemasGrid() : AbstractGrid<EventClassFamilyVersionDto,Integer> renamed to public getEcfVersionsGrid() : AbstractGrid<EventClassFamilyVersionDto,Integer> in class org.kaaproject.kaa.server.admin.client.mvp.view.EcfView	From	To
Rename Method public addEcfSchema(ecfId String, schemaForm RecordField, callback AsyncCallback<Void>) : void renamed to public addEcfVersion(ecfId String, schemaForm RecordField, callback AsyncCallback<Void>) : void in class org.kaaproject.kaa.server.admin.client.mvp.data.DataSource	From	To
Rename Method public getCreateEcfSchemaView() : BaseListView<EventClassDto> renamed to public getCreateEcfVersionView() : EcfVersionView in class org.kaaproject.kaa.server.admin.client.mvp.ClientFactoryImpl	From	To
Rename Method public getAddEcfSchemaButton() : HasClickHandlers renamed to public getAddEcfVersionButton() : HasClickHandlers in class org.kaaproject.kaa.server.admin.client.mvp.view.event.EcfViewImpl	From	To
Rename Method public deleteEventClassById(ecfId String) : void renamed to public removeByEcfId(ecfId String) : void in class org.kaaproject.kaa.server.common.dao.impl.sql.HibernateEventClassDao	From	To
Rename Method public getAddEcfSchemaButton() : HasClickHandlers renamed to public getAddEcfVersionButton() : HasClickHandlers in class org.kaaproject.kaa.server.admin.client.mvp.view.EcfView	From	To
Rename Method public getEcfId() : String renamed to public getEcfvId() : String in class org.kaaproject.kaa.common.dto.event.EventClassDto	From	To
Rename Method public deleteEventClassById(eventClassId String) : void renamed to public getEventClass(eventClassId String) : EventClassDto in class org.kaaproject.kaa.server.admin.shared.services.KaaAdminService	From	To
Rename Method public getCreateEcfSchemaView() : BaseListView<EventClassDto> renamed to public getCreateEcfVersionView() : EcfVersionView in class org.kaaproject.kaa.server.admin.client.mvp.ClientFactory	From	To
Rename Method public getEcfId() : String renamed to public getCtlSchemaId() : String in class org.kaaproject.kaa.server.admin.client.mvp.place.EventClassPlace	From	To
Rename Method public deleteEventClassById(eventClassId String) : void renamed to public getEventClassById(eventClassId String) : EventClassDto in class org.kaaproject.kaa.server.control.service.ControlService	From	To
Rename Method public getVersion() : int renamed to public getEcfVersion() : int in class org.kaaproject.kaa.server.admin.client.mvp.place.EcfVersionPlace	From	To
Rename Method public generateEcfSchemaForm(fileItemName String, callback AsyncCallback<RecordField>) : void renamed to public generateEcfVersionForm(fileItemName String, callback AsyncCallback<RecordField>) : void in class org.kaaproject.kaa.server.admin.client.mvp.data.DataSource	From	To
Push Down Method	5
Push Down Method protected doSave(eventBus EventBus) : void from class org.kaaproject.kaa.server.admin.client.mvp.activity.AbstractBaseCtlSchemaActivity to protected doSave(eventBus EventBus) : void from class org.kaaproject.kaa.server.admin.client.mvp.activity.EventClassActivity	From	To
Push Down Method protected getEntityId(place P) : String from class org.kaaproject.kaa.server.admin.client.mvp.activity.AbstractBaseCtlSchemaActivity to protected getEntityId(place P) : String from class org.kaaproject.kaa.server.admin.client.mvp.activity.AbstractBaseCtlSchemaActivityEvent	From	To
Push Down Method protected getEntityId(place P) : String from class org.kaaproject.kaa.server.admin.client.mvp.activity.AbstractBaseCtlSchemaActivity to protected getEntityId(place P) : String from class org.kaaproject.kaa.server.admin.client.mvp.activity.AbstractBaseCtlSchemaActivityApplication	From	To
Push Down Method protected onEntityRetrieved() : void from class org.kaaproject.kaa.server.admin.client.mvp.activity.AbstractBaseCtlSchemaActivity to protected onEntityRetrieved() : void from class org.kaaproject.kaa.server.admin.client.mvp.activity.AbstractBaseCtlSchemaActivityApplication	From	To
Push Down Method protected newEntity() : T from class org.kaaproject.kaa.server.admin.client.mvp.activity.AbstractBaseCtlSchemaActivity to protected newEntity() : T from class org.kaaproject.kaa.server.admin.client.mvp.activity.AbstractBaseCtlSchemaActivityApplication	From	To
Pull Up Method	4
Pull Up Method public getPlace(token String) : EventClassPlace from class org.kaaproject.kaa.server.admin.client.mvp.place.EventClassPlace.Tokenizer to public getPlace(token String) : P from class org.kaaproject.kaa.server.admin.client.mvp.place.AbstractSchemaPlaceEvent.Tokenizer	From	To
Pull Up Method public getToken(place EventClassPlace) : String from class org.kaaproject.kaa.server.admin.client.mvp.place.EventClassPlace.Tokenizer to public getToken(place P) : String from class org.kaaproject.kaa.server.admin.client.mvp.place.AbstractSchemaPlaceEvent.Tokenizer	From	To
Pull Up Method protected existingSchemaPlace(ec String, schemaId String) : EventClassPlace from class org.kaaproject.kaa.server.admin.client.mvp.activity.EventClassActivity to protected existingSchemaPlace(applicationId String, schemaId String) : P from class org.kaaproject.kaa.server.admin.client.mvp.activity.AbstractBaseCtlSchemaActivity	From	To
Pull Up Method public isLeaf() : boolean from class org.kaaproject.kaa.server.admin.client.mvp.place.EventClassPlace to public isLeaf() : boolean from class org.kaaproject.kaa.server.admin.client.mvp.place.AbstractSchemaPlaceEvent	From	To
Rename Variable	4
Rename Variable ecfSchemasGrid : AbstractGrid<EventClassFamilyVersionDto,Integer> to ecfVersionsGrid : AbstractGrid<EventClassFamilyVersionDto,Integer> in method public start(containerWidget AcceptsOneWidget, eventBus EventBus) : void in class org.kaaproject.kaa.server.admin.client.mvp.activity.EcfActivity	From	To
Rename Variable ecfSchemaPlace : EcfSchemaPlace to ecfVersionPlace : EcfVersionPlace in method private addEcfVersion() : void in class org.kaaproject.kaa.server.admin.client.mvp.activity.EcfActivity	From	To
Rename Variable ecfSchemasLabel : Label to ecfVersionsLabel : Label in method protected initDetailsTable() : void in class org.kaaproject.kaa.server.admin.client.mvp.view.event.EcfViewImpl	From	To
Rename Variable data : List<EventClassDto> to eventClassDtoList : List<EventClassDto> in method protected loadData(callback LoadCallback) : void in class org.kaaproject.kaa.server.admin.client.mvp.data.EcfVersionDataProvider	From	To
Change Return Type	16
Change Return Type BaseCtlSchemaView to EventClassView in method public getEventClassView() : EventClassView in class org.kaaproject.kaa.server.admin.client.mvp.ClientFactoryImpl	From	To
Change Return Type void to EventClassDto in method public getEventClassById(eventClassId String) : EventClassDto in class org.kaaproject.kaa.server.control.service.DefaultControlService	From	To
Change Return Type void to EventClassDto in method public getEventClass(eventClassId String) : EventClassDto in class org.kaaproject.kaa.server.admin.shared.services.KaaAdminService	From	To
Change Return Type BaseListView<EventClassDto> to EcfVersionView in method public getCreateEcfVersionView() : EcfVersionView in class org.kaaproject.kaa.server.admin.client.mvp.ClientFactoryImpl	From	To
Change Return Type EventClassPlace to P in method public getPlace(token String) : P in class org.kaaproject.kaa.server.admin.client.mvp.place.SchemasPlaceEvent.Tokenizer	From	To
Change Return Type CtlSchemaPlace.SchemaType to SchemaType in method protected getPlaceSchemaType() : SchemaType in class org.kaaproject.kaa.server.admin.client.mvp.activity.EventClassActivity	From	To
Change Return Type BaseCtlSchemaView to EventClassView in method public getCreateEventClassView() : EventClassView in class org.kaaproject.kaa.server.admin.client.mvp.ClientFactory	From	To
Change Return Type BaseListView<EventClassDto> to EcfVersionView in method public getCreateEcfVersionView() : EcfVersionView in class org.kaaproject.kaa.server.admin.client.mvp.ClientFactory	From	To
Change Return Type void to EventClassDto in method public getEventClassById(eventClassId String) : EventClassDto in class org.kaaproject.kaa.server.control.service.ControlService	From	To
Change Return Type EventClassPlace to P in method public getPlace(token String) : P in class org.kaaproject.kaa.server.admin.client.mvp.place.AbstractSchemaPlaceEvent.Tokenizer	From	To
Change Return Type BaseCtlSchemaView to EventClassView in method public getCreateEventClassView() : EventClassView in class org.kaaproject.kaa.server.admin.client.mvp.ClientFactoryImpl	From	To
Change Return Type void to EventClassDto in method public getEventClass(eventClassId String) : EventClassDto in class org.kaaproject.kaa.server.admin.services.KaaAdminServiceImpl	From	To
Change Return Type EcfSchemaPlace to EcfVersionPlace in method public getPlace(token String) : EcfVersionPlace in class org.kaaproject.kaa.server.admin.client.mvp.place.EcfVersionPlace.Tokenizer	From	To
Change Return Type EventClassPlace to P in method protected existingSchemaPlace(applicationId String, schemaId String) : P in class org.kaaproject.kaa.server.admin.client.mvp.activity.AbstractBaseCtlSchemaActivity	From	To
Change Return Type BaseCtlSchemaView to EventClassView in method protected getView(create boolean) : EventClassView in class org.kaaproject.kaa.server.admin.client.mvp.activity.EventClassActivity	From	To
Change Return Type BaseCtlSchemaView to EventClassView in method public getEventClassView() : EventClassView in class org.kaaproject.kaa.server.admin.client.mvp.ClientFactory	From	To
Extract Superclass	3
Extract Superclass org.kaaproject.kaa.server.admin.client.mvp.activity.AbstractBaseCtlSchemaActivityEvent from classes [org.kaaproject.kaa.server.admin.client.mvp.activity.EventClassActivity]	From	To
Extract Superclass org.kaaproject.kaa.server.admin.client.mvp.place.AbstractSchemaPlaceEvent from classes [org.kaaproject.kaa.server.admin.client.mvp.place.EventClassPlace]	From	To
Extract Superclass org.kaaproject.kaa.server.admin.client.mvp.activity.AbstractBaseCtlSchemaActivityApplication from classes [org.kaaproject.kaa.server.admin.client.mvp.activity.ConfigurationSchemaActivity, org.kaaproject.kaa.server.admin.client.mvp.activity.LogSchemaActivity, org.kaaproject.kaa.server.admin.client.mvp.activity.NotificationSchemaActivity, org.kaaproject.kaa.server.admin.client.mvp.activity.ProfileSchemaActivity, org.kaaproject.kaa.server.admin.client.mvp.activity.ServerProfileSchemaActivity]	From	To
Rename Attribute	6
Rename Attribute version : int to ecfVersion : int in class org.kaaproject.kaa.server.admin.client.mvp.activity.EcfVersionActivity	From	To
Rename Attribute ecfSchemasDataProvider : EcfSchemasDataProvider to ecfVersionsDataProvider : EcfVersionsDataProvider in class org.kaaproject.kaa.server.admin.client.mvp.activity.EcfActivity	From	To
Rename Attribute ecfId : String to eventClassFamilyId : String in class org.kaaproject.kaa.server.admin.client.mvp.data.EcfVersionDataProvider	From	To
Rename Attribute ecfSchemasGrid : EcfSchemasGrid to ecfVersionsGrid : EcfVersionsGrid in class org.kaaproject.kaa.server.admin.client.mvp.view.event.EcfViewImpl	From	To
Rename Attribute addEcfSchemaButton : Button to addEcfVersionButton : Button in class org.kaaproject.kaa.server.admin.client.mvp.view.event.EcfViewImpl	From	To
Rename Attribute ecfId : String to ecfvId : String in class org.kaaproject.kaa.common.dto.event.EventClassDto	From	To
Change Attribute Type	4
Change Attribute Type ecfSchemasGrid : EcfSchemasGrid to ecfVersionsGrid : EcfVersionsGrid in class org.kaaproject.kaa.server.admin.client.mvp.view.event.EcfViewImpl	From	To
Change Attribute Type eventClassView : BaseCtlSchemaView to eventClassView : EventClassView in class org.kaaproject.kaa.server.admin.client.mvp.ClientFactoryImpl	From	To
Change Attribute Type createEventClassView : BaseCtlSchemaView to createEventClassView : EventClassView in class org.kaaproject.kaa.server.admin.client.mvp.ClientFactoryImpl	From	To
Change Attribute Type ecfSchemasDataProvider : EcfSchemasDataProvider to ecfVersionsDataProvider : EcfVersionsDataProvider in class org.kaaproject.kaa.server.admin.client.mvp.activity.EcfActivity	From	To
Extract And Move Method	1
Extract And Move Method public getEcfVersionId() : String extracted from public hashCode() : int in class org.kaaproject.kaa.server.admin.client.mvp.place.EventClassPlace & moved to class org.kaaproject.kaa.server.admin.client.mvp.place.CtlSchemaPlace	From	To
Rename Parameter	7
Rename Parameter ecfId : String to ecfvId : String in method public setEcfvId(ecfvId String) : void in class org.kaaproject.kaa.common.dto.event.EventClassDto	From	To
Rename Parameter id : String to eventClassId : String in method protected getEntity(eventClassId String, callback AsyncCallback<EventClassViewDto>) : void in class org.kaaproject.kaa.server.admin.client.mvp.activity.EventClassActivity	From	To
Rename Parameter entity : EventClassViewDto to eventClassViewDto : EventClassViewDto in method protected editEntity(eventClassViewDto EventClassViewDto, callback AsyncCallback<EventClassViewDto>) : void in class org.kaaproject.kaa.server.admin.client.mvp.activity.EventClassActivity	From	To
Rename Parameter ecfId : String to eventClassFamilyId : String in method public getEventClassesByFamilyIdVersionAndType(eventClassFamilyId String, version int, type EventClassType, callback AsyncCallback<List<EventClassDto>>) : void in class org.kaaproject.kaa.server.admin.client.mvp.data.DataSource	From	To
Rename Parameter ec : String to applicationId : String in method protected existingSchemaPlace(applicationId String, schemaId String) : P in class org.kaaproject.kaa.server.admin.client.mvp.activity.AbstractBaseCtlSchemaActivity	From	To
Rename Parameter version : int to ecfVersion : int in method public EventClassPlace(ecfId String, ecfVersionId String, ecfVersion int, schemaId String, ctlSchemaId String, eventClassDtoList List<EventClassViewDto>) in class org.kaaproject.kaa.server.admin.client.mvp.place.EventClassPlace	From	To
Rename Parameter ecfId : String to eventClassFamilyId : String in method public EcfVersionDataProvider(dataGrid AbstractGrid<EventClassDto,String>, hasErrorMessage HasErrorMessage, eventClassFamilyId String, version int, eventClassViewDtoList List<EventClassViewDto>) in class org.kaaproject.kaa.server.admin.client.mvp.data.EcfVersionDataProvider	From	To

9f340f8282cfc72dace0947aeeb522c213e87065

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: