18e0c0277fc5595288e8eb04b2440a87f91fd58a
Files Diff
- Added: 29
- Removed: 1
- Renamed: 0
- Modified: 56
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public getClientRegistrationTrustedHost() : ClientRegistrationTrustedHostResource renamed to public getClientRegistrationPolicy() : ClientRegistrationPolicyResource in class org.keycloak.services.resources.admin.RealmAdminResource | From | To | |
| Rename Method private createToken(session KeycloakSession, realm RealmModel, uri UriInfo, id String, type String, expiration int) : String renamed to private setupToken(jwt JsonWebToken, session KeycloakSession, realm RealmModel, uri UriInfo, id String, type String, expiration int) : String in class org.keycloak.services.clientregistration.ClientRegistrationTokenUtils | From | To | |
| Rename Method public requireUpdate(client ClientModel) : void renamed to private requireUpdateAuth(client ClientModel) : RegistrationAuth in class org.keycloak.services.clientregistration.ClientRegistrationAuth | From | To | |
| Push Down Method | 1 | ||
| Push Down Method public getClient() : ClientRepresentation from class org.keycloak.services.clientregistration.ClientRegistrationContext to public getClient() : ClientRepresentation from class org.keycloak.services.clientregistration.AbstractClientRegistrationContext | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type clientRedirectUris : Set<String> to clientRedirectUris : Collection<String> in method public resolveValidRedirectUris(clientRootUrl String, clientRedirectUris Collection<String>) : Set<String> in class org.keycloak.protocol.oidc.utils.PairwiseSubMapperUtils | From | To | |
| Move Method | 3 | ||
| Move Method protected validateClient(context ClientRegistrationContext, validationMessages ValidationMessages) : boolean from class org.keycloak.services.clientregistration.oidc.OIDCClientRegistrationProvider to public validateClient(validationMessages ValidationMessages) : boolean from class org.keycloak.services.clientregistration.oidc.OIDCClientRegistrationContext | From | To | |
| Move Method protected validateClient(context ClientRegistrationContext, validationMessages ValidationMessages) : boolean from class org.keycloak.services.clientregistration.AbstractClientRegistrationProvider to public validateClient(validationMessages ValidationMessages) : boolean from class org.keycloak.services.clientregistration.AbstractClientRegistrationContext | From | To | |
| Move Method protected validateClient(context ClientRegistrationContext, validationMessages ValidationMessages) : boolean from class org.keycloak.services.clientregistration.DefaultClientRegistrationProvider to public validateClient(validationMessages ValidationMessages) : boolean from class org.keycloak.services.clientregistration.DefaultClientRegistrationContext | From | To | |
| Change Return Type | 3 | ||
| Change Return Type void to RegistrationAuth in method private requireUpdateAuth(client ClientModel) : RegistrationAuth in class org.keycloak.services.clientregistration.ClientRegistrationAuth | From | To | |
| Change Return Type ClientRegistrationTrustedHostResource to ClientRegistrationPolicyResource in method public getClientRegistrationPolicy() : ClientRegistrationPolicyResource in class org.keycloak.services.resources.admin.RealmAdminResource | From | To | |
| Change Return Type void to Response in method public updateComponent(id String, rep ComponentRepresentation) : Response in class org.keycloak.services.resources.admin.ComponentResource | From | To | |
| Push Down Attribute | 1 | ||
| Push Down Attribute private client : ClientRepresentation from class org.keycloak.services.clientregistration.ClientRegistrationContext to protected client : ClientRepresentation from class org.keycloak.services.clientregistration.AbstractClientRegistrationContext | From | To | |
| Extract Attribute | 1 | ||
| Extract Attribute public KEYCLOAK_EMBEDDED : String in class org.keycloak.services.resources.KeycloakApplication | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.keycloak.services.clientregistration.AbstractClientRegistrationContext from classes [org.keycloak.services.clientregistration.oidc.OIDCClientRegistrationContext] | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type resource : ClientRegistrationTrustedHostResource to resource : ClientRegistrationPolicyResource in method public getClientRegistrationPolicy() : ClientRegistrationPolicyResource in class org.keycloak.services.resources.admin.RealmAdminResource | From | To | |
| Extract Method | 4 | ||
| Extract Method private forbidden(errorDescription String) : Failure extracted from private forbidden() : Failure in class org.keycloak.services.clientregistration.ClientRegistrationAuth | From | To | |
| Extract Method private updateComponentEntity(entity ComponentEntity, model ComponentModel) : void extracted from public updateComponent(model ComponentModel) : void in class org.keycloak.models.mongo.keycloak.adapters.RealmAdapter | From | To | |
| Extract Method private updateComponentEntity(entity ComponentEntity, model ComponentModel) : void extracted from public addComponentModel(model ComponentModel) : ComponentModel in class org.keycloak.models.mongo.keycloak.adapters.RealmAdapter | From | To | |
| Extract Method public toRepresentation(prop ProviderConfigProperty) : ConfigPropertyRepresentation extracted from public toRepresentation(configProperties List<ProviderConfigProperty>) : List<ConfigPropertyRepresentation> in class org.keycloak.models.utils.ModelToRepresentation | From | To | |
| Extract And Move Method | 4 | ||
| Extract And Move Method public toRepresentation(prop ProviderConfigProperty) : ConfigPropertyRepresentation extracted from public getMapperTypes() : Map<String,IdentityProviderMapperTypeRepresentation> in class org.keycloak.services.resources.admin.IdentityProviderResource & moved to class org.keycloak.models.utils.ModelToRepresentation | From | To | |
| Extract And Move Method public toRepresentation(prop ProviderConfigProperty) : ConfigPropertyRepresentation extracted from private toConfigPropertyRepresentation(prop ProviderConfigProperty) : ConfigPropertyRepresentation in class org.keycloak.services.resources.admin.UserFederationProvidersResource & moved to class org.keycloak.models.utils.ModelToRepresentation | From | To | |
| Extract And Move Method public toRepresentation(prop ProviderConfigProperty) : ConfigPropertyRepresentation extracted from private getConfigPropertyRep(prop ProviderConfigProperty) : ConfigPropertyRepresentation in class org.keycloak.services.resources.admin.AuthenticationManagementResource & moved to class org.keycloak.models.utils.ModelToRepresentation | From | To | |
| Extract And Move Method public toRepresentation(prop ProviderConfigProperty) : ConfigPropertyRepresentation extracted from public getMapperTypes() : Map<String,UserFederationMapperTypeRepresentation> in class org.keycloak.services.resources.admin.UserFederationProviderResource & moved to class org.keycloak.models.utils.ModelToRepresentation | From | To |