65f51b7b83271bc42de923b3625cac8a69e8e9a2
Files Diff
- Added: 28
- Removed: 4
- Renamed: 0
- Modified: 87
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Move And Rename Method | 2 | ||
Move And Rename Method public getInputValue(input WebElement) : String from class org.keycloak.testsuite.page.Form to public getTextInputValue(input WebElement) : String from class org.keycloak.testsuite.util.UIUtils | From | To | |
Move And Rename Method public getErrorMessage() : String from class org.keycloak.testsuite.auth.page.login.VerifyEmail to public getOtpPeriod() : String from class org.keycloak.testsuite.auth.page.login.OTPSetup | From | To | |
Pull Up Attribute | 1 | ||
Pull Up Attribute private keycloakThemeCssName : String from class org.keycloak.testsuite.auth.page.login.Login to protected keycloakThemeCssName : String from class org.keycloak.testsuite.auth.page.login.LoginBase | From | To | |
Rename Class | 1 | ||
Rename Class org.keycloak.testsuite.console.page.fragment.Dropdown renamed to org.keycloak.testsuite.console.page.fragment.LocaleDropdown | From | To | |
Move Class | 2 | ||
Move Class org.keycloak.testsuite.auth.page.account.AccountFields moved to org.keycloak.testsuite.auth.page.AccountFields | From | To | |
Move Class org.keycloak.testsuite.auth.page.account.PasswordFields moved to org.keycloak.testsuite.auth.page.PasswordFields | From | To | |
Extract Variable | 1 | ||
Extract Variable contextRoot : URL in method private updateWithAuthServerInfo(authServerInfo ContainerInfo, clusterPortOffset int) : ContainerInfo from class org.keycloak.testsuite.arquillian.AuthServerTestEnricher | From | To | |
Extract Method | 1 | ||
Extract Method public createTestUserWithAdminClient(setRealmRoles boolean) : void extracted from public createTestUserWithAdminClient() : void in class org.keycloak.testsuite.AbstractAuthTest | From | To | |
Rename Method | 3 | ||
Rename Method public currentUrlStartWith(url String) : boolean renamed to public currentUrlMatches(regex String) : boolean in class org.keycloak.testsuite.util.URLUtils | From | To | |
Rename Method public currentUrlEqual(url String) : boolean renamed to public currentUrlEquals(url String) : boolean in class org.keycloak.testsuite.util.URLUtils | From | To | |
Rename Method public waitForUsernameInputPresent() : void renamed to public isUsernamePresent() : boolean in class org.keycloak.testsuite.auth.page.login.Registration | From | To | |
Push Down Method | 1 | ||
Push Down Method public getFeedbackText() : String from class org.keycloak.testsuite.auth.page.login.LoginActions to public getOtpType() : String from class org.keycloak.testsuite.auth.page.login.OTPSetup | From | To | |
Pull Up Method | 6 | ||
Pull Up Method public setKeycloakThemeCssName(name String) : void from class org.keycloak.testsuite.auth.page.login.Login to public setKeycloakThemeCssName(name String) : void from class org.keycloak.testsuite.auth.page.login.LoginBase | From | To | |
Pull Up Method public isCurrent() : boolean from class org.keycloak.testsuite.auth.page.login.TermsAndConditions to public isCurrent() : boolean from class org.keycloak.testsuite.auth.page.login.RequiredActions | From | To | |
Pull Up Method public waitForKeycloakThemePresent() : void from class org.keycloak.testsuite.auth.page.login.Login to public waitForKeycloakThemePresent() : void from class org.keycloak.testsuite.auth.page.login.LoginBase | From | To | |
Pull Up Method public waitForKeycloakThemeNotPresent() : void from class org.keycloak.testsuite.auth.page.login.Login to public waitForKeycloakThemeNotPresent() : void from class org.keycloak.testsuite.auth.page.login.LoginBase | From | To | |
Pull Up Method public isCurrent() : boolean from class org.keycloak.testsuite.auth.page.login.OAuthGrant to public isCurrent() : boolean from class org.keycloak.testsuite.auth.page.login.RequiredActions | From | To | |
Pull Up Method protected getKeycloakThemeLocator() : By from class org.keycloak.testsuite.auth.page.login.Login to protected getKeycloakThemeLocator() : By from class org.keycloak.testsuite.auth.page.login.LoginBase | From | To | |
Inline Method | 2 | ||
Inline Method public navigateTo(waitForMatch boolean) : void inlined to public navigateTo() : void in class org.keycloak.testsuite.page.AbstractPage | From | To | |
Inline Method private navigateToUri(uri String, waitForMatch boolean, enableIEWorkaround boolean) : void inlined to private navigateToUri(uri String, enableIEWorkaround boolean) : void in class org.keycloak.testsuite.util.URLUtils | From | To | |
Change Return Type | 1 | ||
Change Return Type void to boolean in method public isUsernamePresent() : boolean in class org.keycloak.testsuite.auth.page.login.Registration | From | To | |
Extract Superclass | 3 | ||
Extract Superclass org.keycloak.testsuite.auth.page.FieldsBase from classes [org.keycloak.testsuite.auth.page.AccountFields, org.keycloak.testsuite.auth.page.PasswordFields] | From | To | |
Extract Superclass org.keycloak.testsuite.auth.page.login.RequiredActions from classes [org.keycloak.testsuite.auth.page.login.OAuthGrant, org.keycloak.testsuite.auth.page.login.TermsAndConditions, org.keycloak.testsuite.auth.page.login.UpdateAccount, org.keycloak.testsuite.auth.page.login.UpdatePassword, org.keycloak.testsuite.auth.page.login.VerifyEmail] | From | To | |
Extract Superclass org.keycloak.testsuite.auth.page.login.LoginBase from classes [org.keycloak.testsuite.auth.page.login.Login, org.keycloak.testsuite.auth.page.login.LoginActions] | From | To | |
Rename Attribute | 1 | ||
Rename Attribute localeLink : WebElement to root : WebElement in class org.keycloak.testsuite.console.page.fragment.LocaleDropdown | From | To | |
Change Attribute Type | 1 | ||
Change Attribute Type localeDropdown : Dropdown to localeDropdown : LocaleDropdown in class org.keycloak.testsuite.console.realm.InternationalizationTest | From | To | |
Extract And Move Method | 9 | ||
Extract And Move Method public navigateToUri(uri String) : void extracted from public navigateToAdminAlbum(shouldBeDenied boolean) : void in class org.keycloak.testsuite.adapter.page.PhotozClientAuthzTestApp & moved to class org.keycloak.testsuite.util.URLUtils | From | To | |
Extract And Move Method public navigateToUri(uri String) : void extracted from public testOIDCParamsForwarding() : void in class org.keycloak.testsuite.adapter.servlet.DemoServletsAdapterTest & moved to class org.keycloak.testsuite.util.URLUtils | From | To | |
Extract And Move Method public navigateToUri(uri String) : void extracted from public navigateToLink(element WebElement) : void in class org.keycloak.testsuite.util.UIUtils & moved to class org.keycloak.testsuite.util.URLUtils | From | To | |
Extract And Move Method public navigateToUri(uri String) : void extracted from public login(username String, password String, scopes String...) : void in class org.keycloak.testsuite.adapter.page.PhotozClientAuthzTestApp & moved to class org.keycloak.testsuite.util.URLUtils | From | To | |
Extract And Move Method public navigateToUri(uri String) : void extracted from public logout() : void in class org.keycloak.testsuite.pages.social.GitHubLoginPage & moved to class org.keycloak.testsuite.util.URLUtils | From | To | |
Extract And Move Method public navigateToUri(uri String) : void extracted from public testCookiesPath() : void in class org.keycloak.testsuite.cookies.CookiesPathTest & moved to class org.keycloak.testsuite.util.URLUtils | From | To | |
Extract And Move Method public navigateToUri(uri String) : void extracted from protected deleteAllCookiesForRealm(realmName String) : void in class org.keycloak.testsuite.AbstractKeycloakTest & moved to class org.keycloak.testsuite.util.URLUtils | From | To | |
Extract And Move Method public navigateToUri(uri String) : void extracted from public testOIDCUiLocalesParamForwarding() : void in class org.keycloak.testsuite.adapter.servlet.DemoServletsAdapterTest & moved to class org.keycloak.testsuite.util.URLUtils | From | To | |
Extract And Move Method public navigateToUri(uri String) : void extracted from public navigateToConsole() : void in class org.keycloak.testsuite.pages.AppServerWelcomePage & moved to class org.keycloak.testsuite.util.URLUtils | From | To | |
Rename Parameter | 3 | ||
Rename Parameter url : String to regex : String in method public currentUrlMatches(regex String) : boolean in class org.keycloak.testsuite.util.URLUtils | From | To | |
Rename Parameter waitForMatch : boolean to enableIEWorkaround : boolean in method private navigateToUri(uri String, enableIEWorkaround boolean) : void in class org.keycloak.testsuite.util.URLUtils | From | To | |
Rename Parameter value : String to usernameOrEmail : String in method public resetCredentials(usernameOrEmail String) : void in class org.keycloak.testsuite.auth.page.login.ResetCredentials | From | To |