8e64bc3e4dc3d5b6ab449ffff42e425bc76f253f
Files Diff
- Added: 5
- Removed: 2
- Renamed: 0
- Modified: 11
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method protected doCreate(payload String) : Object renamed to protected doCreateRepresentation(payload String) : AbstractPolicyRepresentation in class org.keycloak.authorization.admin.PolicyService | From | To | |
| Pull Up Method | 2 | ||
| Pull Up Method protected doCreatePolicyTypeResource(type String) : Object from class org.keycloak.authorization.admin.PermissionService to private getPolicyProviderFactory(policyType String) : PolicyProviderFactory from class org.keycloak.authorization.admin.PolicyService | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method private toRepresentation(type String, payload String, provider PolicyProviderAdminService) : AbstractPolicyRepresentation from class org.keycloak.authorization.admin.PermissionTypeService to protected doCreateRepresentation(payload String) : AbstractPolicyRepresentation from class org.keycloak.authorization.admin.PolicyTypeService | From | To | |
| Move And Inline Method | 2 | ||
| Move And Inline Method public setType(type String) : void moved from class org.keycloak.representations.idm.authorization.PolicyRepresentation to class org.keycloak.testsuite.authz.ConflictingScopePermissionTest & inlined to private createScopePermission(name String, resourceName String, scopes List<String>, policies List<String>, client ClientResource) : void | From | To | |
| Move And Inline Method public getId() : String moved from class org.keycloak.representations.idm.authorization.PolicyRepresentation to class org.keycloak.authorization.admin.PolicyService & inlined to public create(representation PolicyRepresentation) : Policy | From | To | |
| Move Method | 1 | ||
| Move Method protected doCreatePolicyResource(policy Policy) : Object from class org.keycloak.authorization.admin.PermissionTypeService to protected doCreatePolicyResource(policy Policy) : Object from class org.keycloak.authorization.admin.PolicyTypeService | From | To | |
| Inline Method | 1 | ||
| Inline Method protected doCreatePolicyTypeResource(type String) : Object inlined to public getResource(type String) : Object in class org.keycloak.authorization.admin.PolicyService | From | To | |
| Change Return Type | 3 | ||
| Change Return Type void to Policy in method public create(representation PolicyRepresentation) : Policy in class org.keycloak.authorization.admin.PolicyService | From | To | |
| Change Return Type Object to PolicyProviderFactory in method private getPolicyProviderFactory(policyType String) : PolicyProviderFactory in class org.keycloak.authorization.admin.PolicyService | From | To | |
| Change Return Type Object to AbstractPolicyRepresentation in method protected doCreateRepresentation(payload String) : AbstractPolicyRepresentation in class org.keycloak.authorization.admin.PolicyService | From | To | |
| Rename Class | 1 | ||
| Rename Class org.keycloak.authorization.admin.PermissionResourceService renamed to org.keycloak.authorization.admin.PolicyTypeResourceService | From | To | |
| Extract Variable | 2 | ||
| Extract Variable authorization : AuthorizationResource in method private createScopePermission(name String, resourceName String, scopes List<String>, policies List<String>, client ClientResource) : void from class org.keycloak.testsuite.authz.ConflictingScopePermissionTest | From | To | |
| Extract Variable authorization : AuthorizationResource in method private createResourcePermission(name String, resourceName String, policies List<String>, client ClientResource) : void from class org.keycloak.testsuite.authz.ConflictingScopePermissionTest | From | To | |
| Extract Method | 6 | ||
| Extract Method private getPolicyIds(policies List<String>, authorization AuthorizationResource) : List<String> extracted from private createResourcePermission(name String, resourceName String, policies List<String>, client ClientResource) : void in class org.keycloak.testsuite.authz.ConflictingScopePermissionTest | From | To | |
| Extract Method private getPolicyIds(policies List<String>, authorization AuthorizationResource) : List<String> extracted from private createScopePermission(name String, resourceName String, scopes List<String>, policies List<String>, client ClientResource) : void in class org.keycloak.testsuite.authz.ConflictingScopePermissionTest | From | To | |
| Extract Method private getPolicyProviderFactory(policyType String) : PolicyProviderFactory extracted from protected getPolicyProviderAdminResource(policyType String) : PolicyProviderAdminService in class org.keycloak.authorization.admin.PolicyService | From | To | |
| Extract Method private getResourceId(resourceName String, authorization AuthorizationResource) : String extracted from private createScopePermission(name String, resourceName String, scopes List<String>, policies List<String>, client ClientResource) : void in class org.keycloak.testsuite.authz.ConflictingScopePermissionTest | From | To | |
| Extract Method private getResourceId(resourceName String, authorization AuthorizationResource) : String extracted from private createResourcePermission(name String, resourceName String, policies List<String>, client ClientResource) : void in class org.keycloak.testsuite.authz.ConflictingScopePermissionTest | From | To | |
| Extract Method private getPolicyProviderFactory(policyType String) : PolicyProviderFactory extracted from public getResource(type String) : Object in class org.keycloak.authorization.admin.PolicyService | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter type : String to policyType : String in method private getPolicyProviderFactory(policyType String) : PolicyProviderFactory in class org.keycloak.authorization.admin.PolicyService | From | To |