a27be0cee7aac8977357dc56e6f1750a5e2b6960
Files Diff
- Added: 33
- Removed: 7
- Renamed: 0
- Modified: 36
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 6 | ||
Rename Method public run(event ClusterEvent) : void renamed to public eventReceived(event ClusterEvent) : void in class org.keycloak.services.managers.UsersSyncManager.UserFederationClusterListener | From | To | |
Rename Method public run(event ClusterEvent) : void renamed to public eventReceived(event ClusterEvent) : void in class org.keycloak.services.managers.UserStorageSyncManager.UserStorageClusterListener | From | To | |
Rename Method public run(event ClusterEvent) : void renamed to public eventReceived(event ClusterEvent) : void in class org.keycloak.cluster.ClusterListener | From | To | |
Rename Method private invalidateRealm(id String) : void renamed to public registerRealmInvalidation(id String, name String) : void in class org.keycloak.models.cache.infinispan.RealmCacheSession | From | To | |
Rename Method private roleInvalidations(roleId String) : void renamed to private roleRemovalInvalidations(roleId String, roleName String, roleContainerId String) : void in class org.keycloak.models.cache.infinispan.RealmCacheSession | From | To | |
Rename Method public clientAdded(realmId String, id String, invalidations Set<String>) : void renamed to public realmRemoval(id String, name String, invalidations Set<String>) : void in class org.keycloak.models.cache.infinispan.RealmCacheManager | From | To | |
Change Parameter Type | 3 | ||
Change Parameter Type event : CacheEntryModifiedEvent<String,Object> to event : CacheEntryModifiedEvent<String,Serializable> in method public cacheEntryModified(event CacheEntryModifiedEvent<String,Serializable>) : void in class org.keycloak.cluster.infinispan.InfinispanNotificationsManager.CacheEntryListener | From | To | |
Change Parameter Type event : CacheEntryCreatedEvent<String,Object> to event : CacheEntryCreatedEvent<String,Serializable> in method public cacheEntryCreated(event CacheEntryCreatedEvent<String,Serializable>) : void in class org.keycloak.cluster.infinispan.InfinispanNotificationsManager.CacheEntryListener | From | To | |
Change Parameter Type session : KeycloakSession to myAddress : String in method public InfinispanClusterProvider(clusterStartupTime int, myAddress String, crossDCAwareCacheFactory CrossDCAwareCacheFactory, notificationsManager InfinispanNotificationsManager) in class org.keycloak.cluster.infinispan.InfinispanClusterProvider | From | To | |
Inline Method | 3 | ||
Inline Method protected invalidateClient(realm RealmModel, client ClientModel) : void inlined to private addedClient(realm RealmModel, client ClientModel) : ClientModel in class org.keycloak.models.cache.infinispan.RealmCacheSession | From | To | |
Inline Method protected invalidateClient(realm RealmModel, client ClientModel) : void inlined to public removeClient(id String, realm RealmModel) : boolean in class org.keycloak.models.cache.infinispan.RealmCacheSession | From | To | |
Inline Method public registerRoleInvalidation(id String) : void inlined to public removeRole(realm RealmModel, role RoleModel) : boolean in class org.keycloak.models.cache.infinispan.RealmCacheSession | From | To | |
Rename Variable | 3 | ||
Rename Variable invalidationCacheConfiguration : Configuration to modelCacheConfiguration : Configuration in method protected initEmbedded() : void in class org.keycloak.connections.infinispan.DefaultInfinispanConnectionProviderFactory | From | To | |
Rename Variable replicationCacheConfiguration : Configuration to replicationEvictionCacheConfiguration : Configuration in method protected initEmbedded() : void in class org.keycloak.connections.infinispan.DefaultInfinispanConnectionProviderFactory | From | To | |
Rename Variable invalidationConfigBuilder : ConfigurationBuilder to modelCacheConfigBuilder : ConfigurationBuilder in method protected initEmbedded() : void in class org.keycloak.connections.infinispan.DefaultInfinispanConnectionProviderFactory | From | To | |
Move Class | 2 | ||
Move Class org.keycloak.cluster.infinispan.InfinispanClusterProviderFactory.CacheEntryListener moved to org.keycloak.cluster.infinispan.InfinispanNotificationsManager.CacheEntryListener | From | To | |
Move Class org.keycloak.models.cache.infinispan.GroupListQuery moved to org.keycloak.models.cache.infinispan.entities.GroupListQuery | From | To | |
Rename Attribute | 1 | ||
Rename Attribute cache : Cache<String,Serializable> to clusterStartupTime : int in class org.keycloak.cluster.infinispan.InfinispanClusterProvider | From | To | |
Extract Variable | 1 | ||
Extract Variable ispnConnections : InfinispanConnectionProvider in method private lazyInit(session KeycloakSession) : void from class org.keycloak.cluster.infinispan.InfinispanClusterProviderFactory | From | To | |
Extract Method | 14 | ||
Extract Method package getUserByFederatedIdentityCacheKey(realmId String, identityProvider String, socialUserId String) : String extracted from public getUserByFederatedIdentityCacheKey(realmId String, socialLink FederatedIdentityModel) : String in class org.keycloak.models.cache.infinispan.UserCacheSession | From | To | |
Extract Method private addRealmInvalidation(realmId String) : void extracted from public preRemove(realm RealmModel, role RoleModel) : void in class org.keycloak.models.cache.infinispan.UserCacheSession | From | To | |
Extract Method private addRealmInvalidation(realmId String) : void extracted from public grantToAllUsers(realm RealmModel, role RoleModel) : void in class org.keycloak.models.cache.infinispan.UserCacheSession | From | To | |
Extract Method private addRealmInvalidation(realmId String) : void extracted from public preRemove(realm RealmModel, component ComponentModel) : void in class org.keycloak.models.cache.infinispan.UserCacheSession | From | To | |
Extract Method private getStateFromCache() : InitializerState extracted from private isFinished() : boolean in class org.keycloak.models.sessions.infinispan.initializer.InfinispanUserSessionInitializer | From | To | |
Extract Method private getStateFromCache() : InitializerState extracted from private getOrCreateInitializerState() : InitializerState in class org.keycloak.models.sessions.infinispan.initializer.InfinispanUserSessionInitializer | From | To | |
Extract Method private addRealmInvalidation(realmId String) : void extracted from public preRemove(realm RealmModel) : void in class org.keycloak.models.cache.infinispan.UserCacheSession | From | To | |
Extract Method private getInRealmPredicate(realmId String) : InRealmPredicate extracted from public invalidateRealmUsers(realm String, invalidations Set<String>) : void in class org.keycloak.models.cache.infinispan.UserCacheManager | From | To | |
Extract Method private addRealmInvalidation(realmId String) : void extracted from public preRemove(realm RealmModel, link UserFederationProviderModel) : void in class org.keycloak.models.cache.infinispan.UserCacheSession | From | To | |
Extract Method private addRealmInvalidation(realmId String) : void extracted from public preRemove(realm RealmModel, client ClientModel) : void in class org.keycloak.models.cache.infinispan.UserCacheSession | From | To | |
Extract Method private addedRole(roleId String, roleContainerId String) : void extracted from public addClientRole(realm RealmModel, client ClientModel, id String, name String) : RoleModel in class org.keycloak.models.cache.infinispan.RealmCacheSession | From | To | |
Extract Method private invalidateGroup(id String, realmId String, invalidateQueries boolean) : void extracted from public registerGroupInvalidation(id String) : void in class org.keycloak.models.cache.infinispan.RealmCacheSession | From | To | |
Extract Method private addRealmInvalidation(realmId String) : void extracted from public preRemove(realm RealmModel, group GroupModel) : void in class org.keycloak.models.cache.infinispan.UserCacheSession | From | To | |
Extract Method private addedRole(roleId String, roleContainerId String) : void extracted from public addRealmRole(realm RealmModel, id String, name String) : RoleModel in class org.keycloak.models.cache.infinispan.RealmCacheSession | From | To | |
Split Attribute | 1 | ||
Split Attribute workCache : Cache<String,Serializable> to [notificationsManager : InfinispanNotificationsManager, myAddress : String] in class org.keycloak.cluster.infinispan.InfinispanClusterProviderFactory | From | To | |
Change Attribute Type | 1 | ||
Change Attribute Type cache : Cache<String,Serializable> to clusterStartupTime : int in class org.keycloak.cluster.infinispan.InfinispanClusterProvider | From | To | |
Extract And Move Method | 6 | ||
Extract And Move Method public groupQueriesInvalidations(realmId String, invalidations Set<String>) : void extracted from public groupAdded(realm RealmModel, group GroupModel) : GroupModel in class org.keycloak.models.cache.infinispan.RealmCacheSession & moved to class org.keycloak.models.cache.infinispan.RealmCacheManager | From | To | |
Extract And Move Method public realmUpdated(id String, name String, invalidations Set<String>) : void extracted from private invalidateRealm(id String) : void in class org.keycloak.models.cache.infinispan.RealmCacheSession & moved to class org.keycloak.models.cache.infinispan.RealmCacheManager | From | To | |
Extract And Move Method public groupQueriesInvalidations(realmId String, invalidations Set<String>) : void extracted from public removeGroup(realm RealmModel, group GroupModel) : boolean in class org.keycloak.models.cache.infinispan.RealmCacheSession & moved to class org.keycloak.models.cache.infinispan.RealmCacheManager | From | To | |
Extract And Move Method public federatedIdentityLinkRemovedInvalidation(userId String, realmId String, identityProviderId String, socialUserId String, invalidations Set<String>) : void extracted from public removeFederatedIdentity(realm RealmModel, user UserModel, socialProvider String) : boolean in class org.keycloak.models.cache.infinispan.UserCacheSession & moved to class org.keycloak.models.cache.infinispan.UserCacheManager | From | To | |
Extract And Move Method public userUpdatedInvalidations(userId String, username String, email String, realmId String, invalidations Set<String>) : void extracted from public registerUserInvalidation(realm RealmModel, user CachedUser) : void in class org.keycloak.models.cache.infinispan.UserCacheSession & moved to class org.keycloak.models.cache.infinispan.UserCacheManager | From | To | |
Extract And Move Method public userUpdatedInvalidations(userId String, username String, email String, realmId String, invalidations Set<String>) : void extracted from public evict(realm RealmModel, user UserModel) : void in class org.keycloak.models.cache.infinispan.UserCacheSession & moved to class org.keycloak.models.cache.infinispan.UserCacheManager | From | To | |
Rename Parameter | 2 | ||
Rename Parameter realmId : String to name : String in method public realmRemoval(id String, name String, invalidations Set<String>) : void in class org.keycloak.models.cache.infinispan.RealmCacheManager | From | To | |
Rename Parameter session : KeycloakSession to myAddress : String in method public InfinispanClusterProvider(clusterStartupTime int, myAddress String, crossDCAwareCacheFactory CrossDCAwareCacheFactory, notificationsManager InfinispanNotificationsManager) in class org.keycloak.cluster.infinispan.InfinispanClusterProvider | From | To |