bcc2c893ef0845e299e436910e12aafbebff0ea1
Files Diff
- Added: 13
- Removed: 1
- Renamed: 0
- Modified: 23
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Attribute | 1 | ||
| Pull Up Attribute public EXECUTION : String from class org.keycloak.authentication.authenticators.browser.AbstractFormAuthenticator to public EXECUTION : String from class org.keycloak.authentication.AbstractFormAuthenticator | From | To | |
| Rename Class | 1 | ||
| Rename Class org.keycloak.authentication.authenticators.browser.AbstractFormAuthenticator renamed to org.keycloak.authentication.authenticators.browser.AbstractUsernameFormAuthenticator | From | To | |
| Move Class | 1 | ||
| Move Class org.keycloak.authentication.AuthenticationProcessor.Status moved to org.keycloak.authentication.RequiredActionContext.Status | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type status : AuthenticationProcessor.Status to status : FlowStatus in method public processResult(result AuthenticationProcessor.Result) : Response in class org.keycloak.authentication.DefaultAuthenticationFlow | From | To | |
| Change Variable Type context : RequiredActionContext to result : RequiredActionContextResult in method public evaluateRequiredActionTriggers(session KeycloakSession, userSession UserSessionModel, clientSession ClientSessionModel, clientConnection ClientConnection, request HttpRequest, uriInfo UriInfo, event EventBuilder, realm RealmModel, user UserModel) : void in class org.keycloak.services.managers.AuthenticationManager | From | To | |
| Extract Method | 1 | ||
| Extract Method public validateHashedCredential(realm RealmModel, user UserModel, unhashedCredValue String, credential UserCredentialValueModel) : boolean extracted from public validPassword(realm RealmModel, user UserModel, password String) : boolean in class org.keycloak.models.utils.CredentialValidation | From | To | |
| Rename Method | 1 | ||
| Rename Method public requiredAction(code String, action String) : Object renamed to public processRequireAction(code String, action String) : Response in class org.keycloak.services.resources.LoginActionsService | From | To | |
| Pull Up Method | 5 | ||
| Pull Up Method public close() : void from class org.keycloak.authentication.authenticators.browser.AbstractFormAuthenticator to public close() : void from class org.keycloak.authentication.AbstractFormAuthenticator | From | To | |
| Pull Up Method public close() : void from class org.keycloak.authentication.requiredactions.TermsAndConditions to public close() : void from class org.keycloak.authentication.AbstractFormRequiredAction | From | To | |
| Pull Up Method public jaxrsService(context RequiredActionContext) : Object from class org.keycloak.authentication.requiredactions.TermsAndConditions to public getActionUrl(context RequiredActionContext) : URI from class org.keycloak.authentication.AbstractFormRequiredAction | From | To | |
| Pull Up Method protected loginForm(context AuthenticationFlowContext) : LoginFormsProvider from class org.keycloak.authentication.authenticators.browser.AbstractFormAuthenticator to protected loginForm(context AuthenticationFlowContext) : LoginFormsProvider from class org.keycloak.authentication.AbstractFormAuthenticator | From | To | |
| Pull Up Method public getActionUrl(context AuthenticationFlowContext, code String) : URI from class org.keycloak.authentication.authenticators.browser.AbstractFormAuthenticator to public getActionUrl(context AuthenticationFlowContext, code String) : URI from class org.keycloak.authentication.AbstractFormAuthenticator | From | To | |
| Rename Variable | 1 | ||
| Rename Variable context : RequiredActionContext to result : RequiredActionContextResult in method public evaluateRequiredActionTriggers(session KeycloakSession, userSession UserSessionModel, clientSession ClientSessionModel, clientConnection ClientConnection, request HttpRequest, uriInfo UriInfo, event EventBuilder, realm RealmModel, user UserModel) : void in class org.keycloak.services.managers.AuthenticationManager | From | To | |
| Change Return Type | 10 | ||
| Change Return Type Response to void in method public requiredActionChallenge(context RequiredActionContext) : void in class org.keycloak.authentication.requiredactions.TermsAndConditions | From | To | |
| Change Return Type Response to void in method public requiredActionChallenge(context RequiredActionContext) : void in class org.keycloak.authentication.requiredactions.VerifyEmail | From | To | |
| Change Return Type Response to void in method public requiredActionChallenge(context RequiredActionContext) : void in class org.keycloak.authentication.RequiredActionProvider | From | To | |
| Change Return Type Response to void in method public requiredActionChallenge(context RequiredActionContext) : void in class org.keycloak.authentication.requiredactions.UpdateProfile | From | To | |
| Change Return Type Object to Response in method public processRequireAction(code String, action String) : Response in class org.keycloak.services.resources.LoginActionsService | From | To | |
| Change Return Type RequiredActionContext to void in method public evaluateRequiredActionTriggers(session KeycloakSession, userSession UserSessionModel, clientSession ClientSessionModel, clientConnection ClientConnection, request HttpRequest, uriInfo UriInfo, event EventBuilder, realm RealmModel, user UserModel) : void in class org.keycloak.services.managers.AuthenticationManager | From | To | |
| Change Return Type Object to URI in method public getActionUrl(context RequiredActionContext) : URI in class org.keycloak.authentication.AbstractFormRequiredAction | From | To | |
| Change Return Type Response to void in method public requiredActionChallenge(context RequiredActionContext) : void in class org.keycloak.authentication.requiredactions.UpdatePassword | From | To | |
| Change Return Type Response to void in method public requiredActionChallenge(context RequiredActionContext) : void in class org.keycloak.authentication.requiredactions.UpdateTotp | From | To | |
| Change Return Type Status to FlowStatus in method public getStatus() : FlowStatus in class org.keycloak.authentication.AuthenticationProcessor.Result | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable passwordCred : UserCredentialValueModel to credential : UserCredentialValueModel in method public validateHashedCredential(realm RealmModel, user UserModel, unhashedCredValue String, credential UserCredentialValueModel) : boolean in class org.keycloak.models.utils.CredentialValidation | From | To | |
| Extract Superclass | 2 | ||
| Extract Superclass org.keycloak.authentication.AbstractFormRequiredAction from classes [org.keycloak.authentication.requiredactions.TermsAndConditions] | From | To | |
| Extract Superclass org.keycloak.authentication.AbstractFormAuthenticator from classes [org.keycloak.authentication.authenticators.browser.AbstractUsernameFormAuthenticator] | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type status : Status to status : FlowStatus in class org.keycloak.authentication.AuthenticationProcessor.Result | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter password : String to unhashedCredValue : String in method public validateHashedCredential(realm RealmModel, user UserModel, unhashedCredValue String, credential UserCredentialValueModel) : boolean in class org.keycloak.models.utils.CredentialValidation | From | To |