keycloak c9c9f05e29b8bc7b64763ae1d4db743b96c6db6d

c9c9f05e29b8bc7b64763ae1d4db743b96c6db6d

Files Diff

Added: 0
Removed: 0
Renamed: 0
Modified: 85

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	4
Rename Method public findByType(type String) : List<Policy> renamed to public findDependentPolicies(id String, resourceServerId String) : List<Policy> in class org.keycloak.models.authorization.infinispan.CachedPolicyStore	From	To
Rename Method public allPermits(evaluation List<Result>, authorizationProvider AuthorizationProvider) : List<Permission> renamed to public permits(evaluation List<Result>, authorizationProvider AuthorizationProvider, resourceServer String) : List<Permission> in class org.keycloak.authorization.util.Permissions	From	To
Rename Method public findByType(type String) : List<Policy> renamed to public findDependentPolicies(id String, resourceServerId String) : List<Policy> in class org.keycloak.authorization.store.PolicyStore	From	To
Rename Method private getResourceOwnerCacheKey(ownerId String) : String renamed to private getCacheKeyForResourceName(name String, resourceServerId String) : String in class org.keycloak.models.authorization.infinispan.CachedResourceStore	From	To
Move And Inline Method	12
Move And Inline Method public setType(type String) : void moved from class org.keycloak.authorization.admin.representation.PolicyEvaluationRequest.Resource to class org.keycloak.models.utils.RepresentationToModel & inlined to public toModel(resource ResourceRepresentation, resourceServer ResourceServer, authorization AuthorizationProvider) : Resource	From	To
Move And Inline Method public setId(id String) : void moved from class org.keycloak.authorization.admin.representation.PolicyEvaluationRequest.Resource to class org.keycloak.models.utils.RepresentationToModel & inlined to public toModel(scope ScopeRepresentation, resourceServer ResourceServer, authorization AuthorizationProvider) : Scope	From	To
Move And Inline Method public setName(name String) : void moved from class org.keycloak.authorization.admin.representation.PolicyEvaluationRequest.Resource to class org.keycloak.models.utils.RepresentationToModel & inlined to public toModel(resource ResourceRepresentation, resourceServer ResourceServer, authorization AuthorizationProvider) : Resource	From	To
Move And Inline Method public setName(name String) : void moved from class org.keycloak.authorization.admin.representation.PolicyEvaluationRequest.Resource to class org.keycloak.testsuite.admin.client.authorization.GenericPolicyManagementTest & inlined to public testUpdate() : void	From	To
Move And Inline Method public create(policy Policy, authorization AuthorizationProvider) : PolicyProvider moved from class org.keycloak.authorization.policy.provider.aggregated.AggregatePolicyProviderFactory to class org.keycloak.authorization.policy.provider.aggregated.AggregatePolicyProvider & inlined to public evaluate(evaluation Evaluation) : void	From	To
Move And Inline Method public create(policy Policy, authorization AuthorizationProvider) : PolicyProvider moved from class org.keycloak.authorization.policy.provider.client.ClientPolicyProviderFactory to class org.keycloak.authorization.policy.provider.aggregated.AggregatePolicyProvider & inlined to public evaluate(evaluation Evaluation) : void	From	To
Move And Inline Method public setName(name String) : void moved from class org.keycloak.authorization.admin.representation.PolicyEvaluationRequest.Resource to class org.keycloak.models.utils.RepresentationToModel & inlined to public toModel(policy PolicyRepresentation, resourceServer ResourceServer, authorization AuthorizationProvider) : Policy	From	To
Move And Inline Method public create(policy Policy, authorization AuthorizationProvider) : PolicyProvider moved from class org.keycloak.authorization.policy.provider.role.RolePolicyProviderFactory to class org.keycloak.authorization.policy.provider.aggregated.AggregatePolicyProvider & inlined to public evaluate(evaluation Evaluation) : void	From	To
Move And Inline Method public create(policy Policy, authorization AuthorizationProvider) : PolicyProvider moved from class org.keycloak.authorization.policy.provider.aggregated.AggregatePolicyProviderFactory to class org.keycloak.authorization.policy.evaluation.DefaultPolicyEvaluator & inlined to private createDecisionConsumer(permission ResourcePermission, executionContext EvaluationContext, decision Decision, verified AtomicBoolean) : Consumer<Policy>	From	To
Move And Inline Method public setName(name String) : void moved from class org.keycloak.authorization.admin.representation.PolicyEvaluationRequest.Resource to class org.keycloak.models.utils.RepresentationToModel & inlined to public toModel(scope ScopeRepresentation, resourceServer ResourceServer, authorization AuthorizationProvider) : Scope	From	To
Move And Inline Method public setId(id String) : void moved from class org.keycloak.authorization.admin.representation.PolicyEvaluationRequest.Resource to class org.keycloak.models.utils.RepresentationToModel & inlined to public toModel(resource ResourceRepresentation, resourceServer ResourceServer, authorization AuthorizationProvider) : Resource	From	To
Move And Inline Method public setId(id String) : void moved from class org.keycloak.authorization.admin.representation.PolicyEvaluationRequest.Resource to class org.keycloak.models.utils.RepresentationToModel & inlined to public toModel(policy PolicyRepresentation, resourceServer ResourceServer, authorization AuthorizationProvider) : Policy	From	To
Change Parameter Type	8
Change Parameter Type policy : Policy to engineProvider : Supplier<ScriptEngine> in method public JSPolicyProvider(engineProvider Supplier<ScriptEngine>) in class org.keycloak.authorization.policy.provider.js.JSPolicyProvider	From	To
Change Parameter Type policy : DroolsPolicy to policyProvider : Function<Policy,DroolsPolicy> in method public DroolsPolicyProvider(policyProvider Function<Policy,DroolsPolicy>) in class org.keycloak.authorization.policy.provider.drools.DroolsPolicyProvider	From	To
Change Parameter Type id : String... to id : List<String> in method public findByScope(id List<String>, resourceServerId String) : List<Resource> in class org.keycloak.authorization.jpa.store.JPAResourceStore	From	To
Change Parameter Type storeFactory : StoreFactory to storeFactory : Supplier<StoreFactory> in method public AuthorizationProvider(session KeycloakSession, realm RealmModel, storeFactory Supplier<StoreFactory>, policyProviderFactories Map<String,PolicyProviderFactory>, scheduller Executor) in class org.keycloak.authorization.AuthorizationProvider	From	To
Change Parameter Type id : String... to id : List<String> in method public findByScope(id List<String>, resourceServerId String) : List<Resource> in class org.keycloak.models.authorization.infinispan.CachedResourceStore	From	To
Change Parameter Type id : String... to id : List<String> in method public findByScope(id List<String>, resourceServerId String) : List<Resource> in class org.keycloak.authorization.mongo.store.MongoResourceStore	From	To
Change Parameter Type id : String... to id : List<String> in method public findByScope(id List<String>, resourceServerId String) : List<Resource> in class org.keycloak.authorization.store.ResourceStore	From	To
Change Parameter Type policiesCount : AtomicInteger to verified : AtomicBoolean in method private createDecisionConsumer(permission ResourcePermission, executionContext EvaluationContext, decision Decision, verified AtomicBoolean) : Consumer<Policy> in class org.keycloak.authorization.policy.evaluation.DefaultPolicyEvaluator	From	To
Inline Method	2
Inline Method public findById(id String) : Scope inlined to public delete(id String) : void in class org.keycloak.authorization.jpa.store.JPAScopeStore	From	To
Inline Method public findById(id String) : Resource inlined to public delete(id String) : void in class org.keycloak.authorization.jpa.store.JPAResourceStore	From	To
Rename Variable	4
Rename Variable resourcePolicies : List<? extends Policy> to policies : List<Policy> in method private evaluatePolicies(supplier Supplier<List<Policy>>, consumer Consumer<Policy>) : void in class org.keycloak.authorization.policy.evaluation.DefaultPolicyEvaluator	From	To
Rename Variable cache : List<Policy> to policies : List<Policy> in method public findByScopeIds(scopeIds List<String>, resourceServerId String) : List<Policy> in class org.keycloak.models.authorization.infinispan.CachedPolicyStore	From	To
Rename Variable policiesCount : AtomicInteger to verified : AtomicBoolean in method public evaluate(permission ResourcePermission, executionContext EvaluationContext, decision Decision) : void in class org.keycloak.authorization.policy.evaluation.DefaultPolicyEvaluator	From	To
Rename Variable resource : PolicyRepresentation to policy : PolicyRepresentation in method public testUpdate() : void in class org.keycloak.testsuite.admin.client.authorization.GenericPolicyManagementTest	From	To
Change Return Type	1
Change Return Type List<PolicyProviderFactory> to Collection<PolicyProviderFactory> in method public getProviderFactories() : Collection<PolicyProviderFactory> in class org.keycloak.authorization.AuthorizationProvider	From	To
Rename Attribute	1
Rename Attribute policy : Policy to engineProvider : Supplier<ScriptEngine> in class org.keycloak.authorization.policy.provider.js.JSPolicyProvider	From	To
Change Variable Type	3
Change Variable Type cache : List<Policy> to cache : List<CachedPolicy> in method private updatePolicyCache(policy Policy) : CachedPolicy in class org.keycloak.models.authorization.infinispan.CachedPolicyStore	From	To
Change Variable Type resourcePolicies : List<? extends Policy> to policies : List<Policy> in method private evaluatePolicies(supplier Supplier<List<Policy>>, consumer Consumer<Policy>) : void in class org.keycloak.authorization.policy.evaluation.DefaultPolicyEvaluator	From	To
Change Variable Type policiesCount : AtomicInteger to verified : AtomicBoolean in method public evaluate(permission ResourcePermission, executionContext EvaluationContext, decision Decision) : void in class org.keycloak.authorization.policy.evaluation.DefaultPolicyEvaluator	From	To
Extract Variable	5
Extract Variable parentPolicy : Policy in method public onDecision(evaluation DefaultEvaluation) : void from class org.keycloak.authorization.policy.evaluation.DecisionResultCollector	From	To
Extract Variable storeFactory : StoreFactory in method public postInit(factory KeycloakSessionFactory) : void from class org.keycloak.authorization.policy.provider.user.UserPolicyProviderFactory	From	To
Extract Variable storeFactory : StoreFactory in method public postInit(factory KeycloakSessionFactory) : void from class org.keycloak.authorization.policy.provider.client.ClientPolicyProviderFactory	From	To
Extract Variable scopes : List<Scope> in method public evaluate(permission ResourcePermission, executionContext EvaluationContext, decision Decision) : void from class org.keycloak.authorization.policy.evaluation.DefaultPolicyEvaluator	From	To
Extract Variable enforcementMode : PolicyEnforcementMode in method public evaluate(permission ResourcePermission, executionContext EvaluationContext, decision Decision) : void from class org.keycloak.authorization.policy.evaluation.DefaultPolicyEvaluator	From	To
Extract Method	6
Extract Method public toRepresentation(model Scope, authorizationProvider AuthorizationProvider, deep boolean) : ScopeRepresentation extracted from public toRepresentation(model Scope, authorizationProvider AuthorizationProvider) : ScopeRepresentation in class org.keycloak.models.utils.ModelToRepresentation	From	To
Extract Method private updateResourceServer(clientModel ClientModel, removedRole RoleModel, resourceServerStore ResourceServerStore, policyStore PolicyStore) : void extracted from public postInit(factory KeycloakSessionFactory) : void in class org.keycloak.authorization.policy.provider.role.RolePolicyProviderFactory	From	To
Extract Method private evaluatePolicies(supplier Supplier<List<Policy>>, consumer Consumer<Policy>) : void extracted from public evaluate(permission ResourcePermission, executionContext EvaluationContext, decision Decision) : void in class org.keycloak.authorization.policy.evaluation.DefaultPolicyEvaluator	From	To
Extract Method private grantPermission(authorizationProvider AuthorizationProvider, permissions Map<String,Permission>, permission ResourcePermission, resourceServer String) : void extracted from public allPermits(evaluation List<Result>, authorizationProvider AuthorizationProvider) : List<Permission> in class org.keycloak.authorization.util.Permissions	From	To
Change Attribute Type	6
Change Attribute Type policyProviderFactories : List<PolicyProviderFactory> to policyProviderFactories : Map<String,PolicyProviderFactory> in class org.keycloak.authorization.AuthorizationProvider	From	To
Change Attribute Type cache : Cache<String,List> to cache : Cache<String,List<CachedPolicy>> in class org.keycloak.models.authorization.infinispan.CachedPolicyStore	From	To
Change Attribute Type policy : Policy to engineProvider : Supplier<ScriptEngine> in class org.keycloak.authorization.policy.provider.js.JSPolicyProvider	From	To
Change Attribute Type policy : DroolsPolicy to policy : Function<Policy,DroolsPolicy> in class org.keycloak.authorization.policy.provider.drools.DroolsPolicyProvider	From	To
Change Attribute Type cache : Cache<String,List> to cache : Cache<String,List<CachedResource>> in class org.keycloak.models.authorization.infinispan.CachedResourceStore	From	To
Change Attribute Type storeFactory : StoreFactory to storeFactory : Supplier<StoreFactory> in class org.keycloak.authorization.AuthorizationProvider	From	To
Rename Parameter	6
Rename Parameter policiesCount : AtomicInteger to verified : AtomicBoolean in method private createDecisionConsumer(permission ResourcePermission, executionContext EvaluationContext, decision Decision, verified AtomicBoolean) : Consumer<Policy> in class org.keycloak.authorization.policy.evaluation.DefaultPolicyEvaluator	From	To
Rename Parameter type : String to id : String in method public findDependentPolicies(id String, resourceServerId String) : List<Policy> in class org.keycloak.authorization.store.PolicyStore	From	To
Rename Parameter policy : Policy to engineProvider : Supplier<ScriptEngine> in method public JSPolicyProvider(engineProvider Supplier<ScriptEngine>) in class org.keycloak.authorization.policy.provider.js.JSPolicyProvider	From	To
Rename Parameter policy : DroolsPolicy to policyProvider : Function<Policy,DroolsPolicy> in method public DroolsPolicyProvider(policyProvider Function<Policy,DroolsPolicy>) in class org.keycloak.authorization.policy.provider.drools.DroolsPolicyProvider	From	To
Rename Parameter type : String to id : String in method public findDependentPolicies(id String, resourceServerId String) : List<Policy> in class org.keycloak.models.authorization.infinispan.CachedPolicyStore	From	To
Rename Parameter evaluationt : Evaluation to evaluation : Evaluation in method public evaluate(evaluation Evaluation) : void in class org.keycloak.authorization.policy.provider.drools.DroolsPolicyProvider	From	To

c9c9f05e29b8bc7b64763ae1d4db743b96c6db6d

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: