d2cae0f8c368b24d243abda08603bdb9671f617d
Files Diff
- Added: 40
- Removed: 3
- Renamed: 0
- Modified: 119
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method private printKey(key Object) : String from class org.keycloak.test.RealmKeyGenerator to private encode(obj Object) : String from class org.keycloak.common.util.PemUtils | From | To | |
| Move And Inline Method | 1 | ||
| Move And Inline Method public getPublicKey(input JWSInput, deployment KeycloakDeployment) : PublicKey moved from class org.keycloak.adapters.rotation.JWKPublicKeyLocator to class org.keycloak.adapters.PreAuthActionsHandler & inlined to protected verifyAdminRequest() : JWSInput | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type input : JWSInput to kid : String in method public getPublicKey(kid String, deployment KeycloakDeployment) : PublicKey in class org.keycloak.adapters.rotation.AdapterRSATokenVerifier | From | To | |
| Change Parameter Type input : JWSInput to kid : String in method public getPublicKey(kid String, deployment KeycloakDeployment) : PublicKey in class org.keycloak.adapters.rotation.PublicKeyLocator | From | To | |
| Change Parameter Type input : JWSInput to kid : String in method public getPublicKey(kid String, deployment KeycloakDeployment) : PublicKey in class org.keycloak.adapters.rotation.HardcodedPublicKeyLocator | From | To | |
| Move Method | 15 | ||
| Move Method public getPrivateKey() : PrivateKey from class org.keycloak.models.cache.infinispan.RealmAdapter to public getPrivateKey() : PrivateKey from class org.keycloak.models.KeyManager.ActiveKey | From | To | |
| Move Method public getPrivateKey() : PrivateKey from class org.keycloak.models.mongo.keycloak.adapters.RealmAdapter to public getPrivateKey() : PrivateKey from class org.keycloak.models.KeyManager.ActiveKey | From | To | |
| Move Method public setPublicKey(publicKey PublicKey) : void from class org.keycloak.models.jpa.RealmAdapter to public setPublicKey(publicKey PublicKey) : void from class org.keycloak.keys.KeyMetadata | From | To | |
| Move Method public getCertificate() : X509Certificate from class org.keycloak.models.cache.infinispan.RealmAdapter to public getCertificate() : X509Certificate from class org.keycloak.models.KeyManager.ActiveKey | From | To | |
| Move Method public setPublicKey(publicKey PublicKey) : void from class org.keycloak.models.mongo.keycloak.adapters.RealmAdapter to public setPublicKey(publicKey PublicKey) : void from class org.keycloak.keys.KeyMetadata | From | To | |
| Move Method public getPublicKey() : PublicKey from class org.keycloak.models.cache.infinispan.RealmAdapter to public getPublicKey() : PublicKey from class org.keycloak.keys.KeyMetadata | From | To | |
| Move Method public getPublicKey() : PublicKey from class org.keycloak.models.jpa.RealmAdapter to public getPublicKey() : PublicKey from class org.keycloak.keys.KeyMetadata | From | To | |
| Move Method public getCertificate() : X509Certificate from class org.keycloak.models.jpa.RealmAdapter to public getCertificate() : X509Certificate from class org.keycloak.models.KeyManager.ActiveKey | From | To | |
| Move Method public getPublicKey() : PublicKey from class org.keycloak.models.cache.infinispan.entities.CachedRealm to public getPublicKey() : PublicKey from class org.keycloak.keys.KeyMetadata | From | To | |
| Move Method public getCertificate() : X509Certificate from class org.keycloak.models.cache.infinispan.entities.CachedRealm to public getCertificate() : X509Certificate from class org.keycloak.models.KeyManager.ActiveKey | From | To | |
| Move Method public getPublicKey() : PublicKey from class org.keycloak.models.mongo.keycloak.adapters.RealmAdapter to public getPublicKey() : PublicKey from class org.keycloak.keys.KeyMetadata | From | To | |
| Move Method public getCertificate() : X509Certificate from class org.keycloak.models.mongo.keycloak.adapters.RealmAdapter to public getCertificate() : X509Certificate from class org.keycloak.models.KeyManager.ActiveKey | From | To | |
| Move Method public getPrivateKey() : PrivateKey from class org.keycloak.models.jpa.RealmAdapter to public getPrivateKey() : PrivateKey from class org.keycloak.models.KeyManager.ActiveKey | From | To | |
| Move Method public setPublicKey(publicKey PublicKey) : void from class org.keycloak.models.cache.infinispan.RealmAdapter to public setPublicKey(publicKey PublicKey) : void from class org.keycloak.keys.KeyMetadata | From | To | |
| Move Method public getPrivateKey() : PrivateKey from class org.keycloak.models.cache.infinispan.entities.CachedRealm to public getPrivateKey() : PrivateKey from class org.keycloak.models.KeyManager.ActiveKey | From | To | |
| Move Attribute | 12 | ||
| Move Attribute protected privateKey : PrivateKey from class org.keycloak.models.cache.infinispan.RealmAdapter to private privateKey : PrivateKey from class org.keycloak.models.KeyManager.ActiveKey | From | To | |
| Move Attribute protected publicKey : PublicKey from class org.keycloak.models.cache.infinispan.entities.CachedRealm to private publicKey : PublicKey from class org.keycloak.keys.KeyMetadata | From | To | |
| Move Attribute protected certificate : X509Certificate from class org.keycloak.models.cache.infinispan.RealmAdapter to private certificate : X509Certificate from class org.keycloak.models.KeyManager.ActiveKey | From | To | |
| Move Attribute protected privateKey : PrivateKey from class org.keycloak.models.mongo.keycloak.adapters.RealmAdapter to private privateKey : PrivateKey from class org.keycloak.models.KeyManager.ActiveKey | From | To | |
| Move Attribute protected publicKey : PublicKey from class org.keycloak.models.mongo.keycloak.adapters.RealmAdapter to private publicKey : PublicKey from class org.keycloak.keys.KeyMetadata | From | To | |
| Move Attribute protected certificate : X509Certificate from class org.keycloak.models.cache.infinispan.entities.CachedRealm to private certificate : X509Certificate from class org.keycloak.models.KeyManager.ActiveKey | From | To | |
| Move Attribute protected privateKey : PrivateKey from class org.keycloak.models.jpa.RealmAdapter to private privateKey : PrivateKey from class org.keycloak.models.KeyManager.ActiveKey | From | To | |
| Move Attribute protected certificate : X509Certificate from class org.keycloak.models.mongo.keycloak.adapters.RealmAdapter to private certificate : X509Certificate from class org.keycloak.models.KeyManager.ActiveKey | From | To | |
| Move Attribute protected publicKey : PublicKey from class org.keycloak.models.jpa.RealmAdapter to private publicKey : PublicKey from class org.keycloak.keys.KeyMetadata | From | To | |
| Move Attribute protected certificate : X509Certificate from class org.keycloak.models.jpa.RealmAdapter to private certificate : X509Certificate from class org.keycloak.models.KeyManager.ActiveKey | From | To | |
| Move Attribute protected privateKey : PrivateKey from class org.keycloak.models.cache.infinispan.entities.CachedRealm to private privateKey : PrivateKey from class org.keycloak.models.KeyManager.ActiveKey | From | To | |
| Move Attribute protected publicKey : PublicKey from class org.keycloak.models.cache.infinispan.RealmAdapter to private publicKey : PublicKey from class org.keycloak.keys.KeyMetadata | From | To | |
| Extract Class | 18 | ||
| Extract Class org.keycloak.keys.KeyMetadata from class org.keycloak.models.mongo.keycloak.entities.RealmEntity | From | To | |
| Extract Class org.keycloak.representations.idm.KeysMetadataRepresentation.KeyMetadataRepresentation from class org.keycloak.models.cache.infinispan.entities.CachedRealm | From | To | |
| Extract Class org.keycloak.models.KeyManager.ActiveKey from class org.keycloak.models.mongo.keycloak.adapters.RealmAdapter | From | To | |
| Extract Class org.keycloak.models.KeyManager.ActiveKey from class org.keycloak.models.cache.infinispan.RealmAdapter | From | To | |
| Extract Class org.keycloak.keys.KeyMetadata from class org.keycloak.models.jpa.entities.RealmEntity | From | To | |
| Extract Class org.keycloak.models.KeyManager.ActiveKey from class org.keycloak.models.jpa.entities.RealmEntity | From | To | |
| Extract Class org.keycloak.keys.KeyMetadata from class org.keycloak.models.cache.infinispan.entities.CachedRealm | From | To | |
| Extract Class org.keycloak.keys.KeyMetadata from class org.keycloak.models.jpa.RealmAdapter | From | To | |
| Extract Class org.keycloak.models.KeyManager.ActiveKey from class org.keycloak.models.jpa.RealmAdapter | From | To | |
| Extract Class org.keycloak.representations.idm.KeysMetadataRepresentation.KeyMetadataRepresentation from class org.keycloak.models.cache.infinispan.RealmAdapter | From | To | |
| Extract Class org.keycloak.keys.KeyMetadata from class org.keycloak.models.cache.infinispan.RealmAdapter | From | To | |
| Extract Class org.keycloak.representations.idm.KeysMetadataRepresentation.KeyMetadataRepresentation from class org.keycloak.models.mongo.keycloak.adapters.RealmAdapter | From | To | |
| Extract Class org.keycloak.keys.KeyMetadata from class org.keycloak.models.mongo.keycloak.adapters.RealmAdapter | From | To | |
| Extract Class org.keycloak.representations.idm.KeysMetadataRepresentation.KeyMetadataRepresentation from class org.keycloak.models.mongo.keycloak.entities.RealmEntity | From | To | |
| Extract Class org.keycloak.representations.idm.KeysMetadataRepresentation.KeyMetadataRepresentation from class org.keycloak.models.jpa.entities.RealmEntity | From | To | |
| Extract Class org.keycloak.representations.idm.KeysMetadataRepresentation.KeyMetadataRepresentation from class org.keycloak.models.jpa.RealmAdapter | From | To | |
| Extract Class org.keycloak.models.KeyManager.ActiveKey from class org.keycloak.models.cache.infinispan.entities.CachedRealm | From | To | |
| Extract Class org.keycloak.models.KeyManager.ActiveKey from class org.keycloak.models.mongo.keycloak.entities.RealmEntity | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type realm : RealmRepresentation to key : KeysMetadataRepresentation.KeyMetadataRepresentation in method public testSignatureVerificationHardcodedPublicKey() : void in class org.keycloak.testsuite.broker.OIDCKeycloakServerBrokerWithSignatureTest | From | To | |
| Change Variable Type accessCode : ClientSessionCode to parseResult : ClientSessionCode.ParseResult in method public buildAuthorizationCodeAccessTokenResponse() : Response in class org.keycloak.protocol.oidc.endpoints.TokenEndpoint | From | To | |
| Inline Variable | 4 | ||
| Inline Variable publicKey : PublicKey in method public performLogin(request AuthenticationRequest) : Response from class org.keycloak.broker.saml.SAMLIdentityProvider | From | To | |
| Inline Variable privateKey : PrivateKey in method public performLogin(request AuthenticationRequest) : Response from class org.keycloak.broker.saml.SAMLIdentityProvider | From | To | |
| Inline Variable clientSession : ClientSessionModel in method public buildAuthorizationCodeAccessTokenResponse() : Response from class org.keycloak.protocol.oidc.endpoints.TokenEndpoint | From | To | |
| Inline Variable publicKeyPem : String in method public getRealmPublicKey(realm String) : PublicKey from class org.keycloak.testsuite.util.OAuthClient | From | To | |
| Extract Method | 2 | ||
| Extract Method public generateV1SelfSignedCertificate(caKeyPair KeyPair, subject String, serialNumber BigInteger) : X509Certificate extracted from public generateV1SelfSignedCertificate(caKeyPair KeyPair, subject String) : X509Certificate in class org.keycloak.common.util.CertificateUtils | From | To | |
| Extract Method private afterFirstBrokerLogin(clientSessionCode ClientSessionCode) : Response extracted from public afterFirstBrokerLogin(code String) : Response in class org.keycloak.services.resources.IdentityBrokerService | From | To | |
| Rename Variable | 3 | ||
| Rename Variable active : boolean to valid : boolean in method public introspect(token String) : Response in class org.keycloak.protocol.oidc.AccessTokenIntrospectionProvider | From | To | |
| Rename Variable realm : RealmRepresentation to key : KeysMetadataRepresentation.KeyMetadataRepresentation in method public testSignatureVerificationHardcodedPublicKey() : void in class org.keycloak.testsuite.broker.OIDCKeycloakServerBrokerWithSignatureTest | From | To | |
| Rename Variable accessCode : ClientSessionCode to parseResult : ClientSessionCode.ParseResult in method public buildAuthorizationCodeAccessTokenResponse() : Response in class org.keycloak.protocol.oidc.endpoints.TokenEndpoint | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type logger : ServicesLogger to logger : Logger in class org.keycloak.protocol.oidc.TokenManager | From | To | |
| Change Attribute Type logger : ServicesLogger to logger : Logger in class org.keycloak.services.managers.AuthenticationManager | From | To | |
| Extract And Move Method | 3 | ||
| Extract And Move Method public realmUrl(realmUrl String) : RSATokenVerifier extracted from private issueUserInfo(tokenString String) : Response in class org.keycloak.protocol.oidc.endpoints.UserInfoEndpoint & moved to class org.keycloak.RSATokenVerifier | From | To | |
| Extract And Move Method public publicKey(publicKey PublicKey) : RSATokenVerifier extracted from private issueUserInfo(tokenString String) : Response in class org.keycloak.protocol.oidc.endpoints.UserInfoEndpoint & moved to class org.keycloak.RSATokenVerifier | From | To | |
| Extract And Move Method public create(tokenString String) : RSATokenVerifier extracted from public verifyToken(tokenString String, deployment KeycloakDeployment, checkActive boolean, checkTokenType boolean) : AccessToken in class org.keycloak.adapters.rotation.AdapterRSATokenVerifier & moved to class org.keycloak.RSATokenVerifier | From | To | |
| Rename Parameter | 7 | ||
| Rename Parameter realmKey : PublicKey to publicKey : PublicKey in method public verifyToken(tokenString String, publicKey PublicKey, realmUrl String, checkActive boolean, checkTokenType boolean) : AccessToken in class org.keycloak.RSATokenVerifier | From | To | |
| Rename Parameter input : JWSInput to kid : String in method public getPublicKey(kid String, deployment KeycloakDeployment) : PublicKey in class org.keycloak.adapters.rotation.AdapterRSATokenVerifier | From | To | |
| Rename Parameter realmKey : PublicKey to publicKey : PublicKey in method public verifyToken(tokenString String, publicKey PublicKey, realmUrl String) : AccessToken in class org.keycloak.RSATokenVerifier | From | To | |
| Rename Parameter input : JWSInput to kid : String in method public getPublicKey(kid String, deployment KeycloakDeployment) : PublicKey in class org.keycloak.adapters.rotation.PublicKeyLocator | From | To | |
| Rename Parameter config : ComponentModel to model : ComponentModel in method public validateConfiguration(session KeycloakSession, model ComponentModel) : void in class org.keycloak.component.ComponentFactory | From | To | |
| Rename Parameter key : Object to obj : Object in method private encode(obj Object) : String in class org.keycloak.common.util.PemUtils | From | To | |
| Rename Parameter input : JWSInput to kid : String in method public getPublicKey(kid String, deployment KeycloakDeployment) : PublicKey in class org.keycloak.adapters.rotation.HardcodedPublicKeyLocator | From | To |