f9a0abcfc47f2c4a5569b9de1a70642a1c856086
Files Diff
- Added: 15
- Removed: 1
- Renamed: 0
- Modified: 73
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method public createClientWithJWKS() : void from class org.keycloak.testsuite.client.OIDCClientRegistrationTest to public createClientWithJWKS_generatedKid() : void from class org.keycloak.testsuite.client.OIDCJwksClientRegistrationTest | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type privateKey : PrivateKey to keyPair : KeyPair in method private getClientSignedJWT(keyPair KeyPair, clientId String) : String in class org.keycloak.testsuite.oauth.ClientAuthSignedJWTTest | From | To | |
| Move Method | 5 | ||
| Move Method private sendRequest(requestUrl String, parameters List<NameValuePair>) : HttpResponse from class org.keycloak.testsuite.client.OIDCClientRegistrationTest to private sendRequest(requestUrl String, parameters List<NameValuePair>) : HttpResponse from class org.keycloak.testsuite.client.OIDCJwksClientRegistrationTest | From | To | |
| Move Method public createClientWithJWKSURI() : void from class org.keycloak.testsuite.client.OIDCClientRegistrationTest to public createClientWithJWKSURI() : void from class org.keycloak.testsuite.client.OIDCJwksClientRegistrationTest | From | To | |
| Move Method private doClientCredentialsGrantRequest(signedJwt String) : OAuthClient.AccessTokenResponse from class org.keycloak.testsuite.client.OIDCClientRegistrationTest to private doClientCredentialsGrantRequest(signedJwt String) : OAuthClient.AccessTokenResponse from class org.keycloak.testsuite.client.OIDCJwksClientRegistrationTest | From | To | |
| Move Method private getClientSignedJWT(clientId String, privateKeyPem String) : String from class org.keycloak.testsuite.client.OIDCClientRegistrationTest to private getClientSignedJWT(clientId String, keyPair KeyPair, kid String) : String from class org.keycloak.testsuite.client.OIDCJwksClientRegistrationTest | From | To | |
| Move Method public getSignatureValidationKey(client ClientModel, attributePrefix String) : PublicKey from class org.keycloak.services.util.CertificateInfoHelper to private getSignatureValidationKey(certInfo CertificateRepresentation) : PublicKey from class org.keycloak.keys.loader.ClientPublicKeyLoader | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private JWT : String from class org.keycloak.protocol.oidc.TokenManager to public JWT : String from class org.keycloak.OAuth2Constants | From | To | |
| Extract Class | 1 | ||
| Extract Class org.keycloak.testsuite.client.OIDCJwksClientRegistrationTest from class org.keycloak.testsuite.client.OIDCClientRegistrationTest | From | To | |
| Rename Class | 1 | ||
| Rename Class org.keycloak.protocol.oidc.utils.JWKSUtils renamed to org.keycloak.protocol.oidc.utils.JWKSHttpUtils | From | To | |
| Extract Variable | 2 | ||
| Extract Variable kid : String in method public rs256(key PublicKey) : JWK from class org.keycloak.jose.jwk.JWKBuilder | From | To | |
| Extract Variable x509Cert : X509Certificate in method private testClientWithGeneratedKeys(format String) : void from class org.keycloak.testsuite.oauth.ClientAuthSignedJWTTest | From | To | |
| Extract Method | 2 | ||
| Extract Method private assertAuthenticateClientSuccess(generatedKeys Map<String,String>, response OIDCClientRepresentation, kid String) : void extracted from public createClientWithJWKSURI() : void in class org.keycloak.testsuite.client.OIDCJwksClientRegistrationTest | From | To | |
| Extract Method private setPublicKey(clientOIDC OIDCClientRepresentation, clientRep ClientRepresentation) : boolean extracted from public toInternal(session KeycloakSession, clientOIDC OIDCClientRepresentation) : ClientRepresentation in class org.keycloak.services.clientregistration.oidc.DescriptionConverter | From | To | |
| Rename Method | 3 | ||
| Rename Method private getClient1PrivateKey() : PrivateKey renamed to private getClient1KeyPair() : KeyPair in class org.keycloak.testsuite.oauth.ClientAuthSignedJWTTest | From | To | |
| Rename Method public loadPrivateKeyFromKeystore(keystoreFile String, storePassword String, keyPassword String, keyAlias String, format KeystoreFormat) : PrivateKey renamed to public loadKeyPairFromKeystore(keystoreFile String, storePassword String, keyPassword String, keyAlias String, format KeystoreFormat) : KeyPair in class org.keycloak.common.util.KeystoreUtil | From | To | |
| Rename Method private getClient2PrivateKey() : PrivateKey renamed to private getClient2KeyPair() : KeyPair in class org.keycloak.testsuite.oauth.ClientAuthSignedJWTTest | From | To | |
| Inline Method | 1 | ||
| Inline Method protected sendJwksRequest(session KeycloakSession, rep OIDCConfigurationRepresentation, config OIDCIdentityProviderConfig) : void inlined to protected parseOIDCConfig(session KeycloakSession, inputStream InputStream) : Map<String,String> in class org.keycloak.broker.oidc.OIDCIdentityProviderFactory | From | To | |
| Rename Variable | 1 | ||
| Rename Variable key : PrivateKey to privateKey : PrivateKey in method public loadKeyPairFromKeystore(keystoreFile String, storePassword String, keyPassword String, keyAlias String, format KeystoreFormat) : KeyPair in class org.keycloak.common.util.KeystoreUtil | From | To | |
| Change Return Type | 3 | ||
| Change Return Type PrivateKey to KeyPair in method private getClient1KeyPair() : KeyPair in class org.keycloak.testsuite.oauth.ClientAuthSignedJWTTest | From | To | |
| Change Return Type PrivateKey to KeyPair in method public loadKeyPairFromKeystore(keystoreFile String, storePassword String, keyPassword String, keyAlias String, format KeystoreFormat) : KeyPair in class org.keycloak.common.util.KeystoreUtil | From | To | |
| Change Return Type PrivateKey to KeyPair in method private getClient2KeyPair() : KeyPair in class org.keycloak.testsuite.oauth.ClientAuthSignedJWTTest | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable client : ClientRepresentation to clientRep : ClientRepresentation in method private setPublicKey(clientOIDC OIDCClientRepresentation, clientRep ClientRepresentation) : boolean in class org.keycloak.services.clientregistration.oidc.DescriptionConverter | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter privateKeyPem : String to kid : String in method private getClientSignedJWT(clientId String, keyPair KeyPair, kid String) : String in class org.keycloak.testsuite.client.OIDCJwksClientRegistrationTest | From | To | |
| Rename Parameter privateKey : PrivateKey to keyPair : KeyPair in method private getClientSignedJWT(keyPair KeyPair, clientId String) : String in class org.keycloak.testsuite.oauth.ClientAuthSignedJWTTest | From | To |