0627670a8c0f2ccea6ef71d006fc3a7bd0f83789
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 17
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method private getFixedPrice(nextPhase PlanPhase, currency Currency) : BigDecimal renamed to private computeFixedPrice() : BigDecimal in class org.killbill.billing.junction.plumbing.billing.DefaultBillingEvent | From | To | |
| Rename Method private getRecurringPrice(nextPhase PlanPhase, currency Currency) : BigDecimal renamed to private computeRecurringPrice() : BigDecimal in class org.killbill.billing.junction.plumbing.billing.DefaultBillingEvent | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type transition : SubscriptionInternalEvent to transition : SubscriptionBillingEvent in method public DefaultBillingEvent(transition SubscriptionBillingEvent, subscription SubscriptionBase, billCycleDayLocal int, billingAlignment BillingAlignment, currency Currency, catalog Catalog) in class org.killbill.billing.junction.plumbing.billing.DefaultBillingEvent | From | To | |
| Rename Variable | 1 | ||
| Rename Variable subscription : SubscriptionBase to recurringPrice : BigDecimal in method protected createNewReenableEvent(odEventTime DateTime, previousEvent BillingEvent, catalog Catalog, context InternalTenantContext) : BillingEvent in class org.killbill.billing.junction.plumbing.billing.BlockingCalculator | From | To | |
| Change Return Type | 1 | ||
| Change Return Type List<SubscriptionBaseTransition> to List<SubscriptionBillingEvent> in method public getBillingTransitions() : List<SubscriptionBillingEvent> in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBase | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type subscription : SubscriptionBase to recurringPrice : BigDecimal in method protected createNewReenableEvent(odEventTime DateTime, previousEvent BillingEvent, catalog Catalog, context InternalTenantContext) : BillingEvent in class org.killbill.billing.junction.plumbing.billing.BlockingCalculator | From | To | |
| Change Variable Type result : List<SubscriptionBaseTransition> to result : List<SubscriptionBillingEvent> in method public getBillingTransitions() : List<SubscriptionBillingEvent> in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBase | From | To | |
| Change Variable Type transition : EffectiveSubscriptionInternalEvent to transition : SubscriptionBillingEvent in method private addBillingEventsForSubscription(account ImmutableAccountData, subscriptions List<SubscriptionBase>, baseSubscription SubscriptionBase, currentAccountBCD int, context InternalCallContext, result DefaultBillingEventSet, skipSubscriptionsSet Set<UUID>, catalog Catalog) : void in class org.killbill.billing.junction.plumbing.billing.DefaultInternalBillingApi | From | To | |
| Change Variable Type billingTransitions : List<EffectiveSubscriptionInternalEvent> to billingTransitions : List<SubscriptionBillingEvent> in method private addBillingEventsForSubscription(account ImmutableAccountData, subscriptions List<SubscriptionBase>, baseSubscription SubscriptionBase, currentAccountBCD int, context InternalCallContext, result DefaultBillingEventSet, skipSubscriptionsSet Set<UUID>, catalog Catalog) : void in class org.killbill.billing.junction.plumbing.billing.DefaultInternalBillingApi | From | To | |
| Extract Method | 1 | ||
| Extract Method protected createRealEvent(subscription SubscriptionBase, effectiveDate DateTime, type SubscriptionBaseTransitionType) : BillingEvent extracted from protected createRealEvent(effectiveDate DateTime, subscription SubscriptionBase) : BillingEvent in class org.killbill.billing.junction.plumbing.billing.TestBlockingCalculator | From | To | |
| Inline Variable | 1 | ||
| Inline Variable prevPlan : Plan in method public DefaultBillingEvent(transition SubscriptionInternalEvent, subscription SubscriptionBase, billCycleDayLocal int, billingAlignment BillingAlignment, currency Currency, catalog Catalog) from class org.killbill.billing.junction.plumbing.billing.DefaultBillingEvent | From | To |