178364cfcbb0f2c72aa1351ac41f0f074171a4b0
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 4
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 2 | ||
Rename Method public buildForExistingItems(output List<Item>) : void renamed to private build(output Collection<Item>, targetInvoiceId UUID, mergeMode boolean) : void in class org.killbill.billing.invoice.tree.ItemsNodeInterval | From | To | |
Rename Method private pruneTree() : void renamed to private pruneAndValidateTree() : void in class org.killbill.billing.invoice.tree.ItemsNodeInterval | From | To | |
Change Parameter Type | 1 | ||
Change Parameter Type output : List<Item> to output : Collection<Item> in method private build(output Collection<Item>, targetInvoiceId UUID, mergeMode boolean) : void in class org.killbill.billing.invoice.tree.ItemsNodeInterval | From | To | |
Rename Variable | 1 | ||
Rename Variable result : boolean to merged : boolean in method public mergeProposedItem(invoiceItem InvoiceItem) : void in class org.killbill.billing.invoice.tree.SubscriptionItemTree | From | To | |
Change Return Type | 1 | ||
Change Return Type boolean to void in method public addExistingItem(newNode ItemsNodeInterval) : void in class org.killbill.billing.invoice.tree.ItemsNodeInterval | From | To | |
Change Variable Type | 1 | ||
Change Variable Type insertionNodeItems : ItemsInterval to insertionNodeItems : List<Item> in method public shouldInsertNode(insertionNode NodeInterval) : boolean in class org.killbill.billing.invoice.tree.ItemsNodeInterval.addProposedItem.addNode | From | To | |
Extract Method | 2 | ||
Extract Method private findItems(itemAction ItemAction) : Collection<Item> extracted from public get_ADD_items() : Iterable<Item> in class org.killbill.billing.invoice.tree.ItemsInterval | From | To | |
Extract Method private findItems(itemAction ItemAction) : Collection<Item> extracted from public get_CANCEL_items() : Iterable<Item> in class org.killbill.billing.invoice.tree.ItemsInterval | From | To |