killbill 31fb02aea856bfb196519e8bcc8cf3513ee20153

31fb02aea856bfb196519e8bcc8cf3513ee20153

Files Diff

Added: 0
Removed: 0
Renamed: 0
Modified: 4

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Variable	2
Rename Variable invoice : InvoiceModelDao to invoiceItemToBeAdjusted : InvoiceItemModelDao in method private validateInvoiceItemToBeAdjusted(invoiceItemSqlDao InvoiceItemSqlDao, invoiceItemModelDao InvoiceItemModelDao, context InternalCallContext) : void in class org.killbill.billing.invoice.dao.DefaultInvoiceDao	From	To
Rename Variable cbaItem : InvoiceItemModelDao to invoiceItemToBeAdjusted : InvoiceItemModelDao in method private validateInvoiceItemToBeAdjusted(invoiceItemSqlDao InvoiceItemSqlDao, invoiceItemModelDao InvoiceItemModelDao, context InternalCallContext) : void in class org.killbill.billing.invoice.dao.DefaultInvoiceDao	From	To
Parameterize Variable	10
Parameterize Variable item : InvoiceItem to invoiceItem : InvoiceItem in method private validateInvoiceItemFromPlugin(invoiceItem InvoiceItem, invoicePlugin InvoicePluginApi) : void in class org.killbill.billing.invoice.InvoicePluginDispatcher	From	To
Parameterize Variable nextCBAAdjItem : InvoiceItemModelDao to invoiceItemModelDao : InvoiceItemModelDao in method private createInvoiceItemFromTransaction(invoiceItemSqlDao InvoiceItemSqlDao, invoiceItemModelDao InvoiceItemModelDao, context InternalCallContext) : void in class org.killbill.billing.invoice.dao.DefaultInvoiceDao	From	To
Parameterize Variable item : InvoiceItemModelDao to invoiceItemModelDao : InvoiceItemModelDao in method private createInvoiceItemFromTransaction(invoiceItemSqlDao InvoiceItemSqlDao, invoiceItemModelDao InvoiceItemModelDao, context InternalCallContext) : void in class org.killbill.billing.invoice.dao.DefaultInvoiceDao	From	To
Parameterize Variable transInvoiceDao : InvoiceSqlDao to invoiceItemSqlDao : InvoiceItemSqlDao in method private validateInvoiceItemToBeAdjusted(invoiceItemSqlDao InvoiceItemSqlDao, invoiceItemModelDao InvoiceItemModelDao, context InternalCallContext) : void in class org.killbill.billing.invoice.dao.DefaultInvoiceDao	From	To
Parameterize Variable cbaAdjItem : InvoiceItemModelDao to invoiceItemModelDao : InvoiceItemModelDao in method private createInvoiceItemFromTransaction(invoiceItemSqlDao InvoiceItemSqlDao, invoiceItemModelDao InvoiceItemModelDao, context InternalCallContext) : void in class org.killbill.billing.invoice.dao.DefaultInvoiceDao	From	To
Parameterize Variable transInvoiceItemSqlDao : InvoiceItemSqlDao to invoiceItemSqlDao : InvoiceItemSqlDao in method private createInvoiceItemFromTransaction(invoiceItemSqlDao InvoiceItemSqlDao, invoiceItemModelDao InvoiceItemModelDao, context InternalCallContext) : void in class org.killbill.billing.invoice.dao.DefaultInvoiceDao	From	To
Parameterize Variable adjItem : InvoiceItemModelDao to invoiceItemModelDao : InvoiceItemModelDao in method private createInvoiceItemFromTransaction(invoiceItemSqlDao InvoiceItemSqlDao, invoiceItemModelDao InvoiceItemModelDao, context InternalCallContext) : void in class org.killbill.billing.invoice.dao.DefaultInvoiceDao	From	To
Parameterize Variable transInvoiceItemDao : InvoiceItemSqlDao to invoiceItemSqlDao : InvoiceItemSqlDao in method private createInvoiceItemFromTransaction(invoiceItemSqlDao InvoiceItemSqlDao, invoiceItemModelDao InvoiceItemModelDao, context InternalCallContext) : void in class org.killbill.billing.invoice.dao.DefaultInvoiceDao	From	To
Change Variable Type	3
Change Variable Type invoice : InvoiceModelDao to invoiceItemToBeAdjusted : InvoiceItemModelDao in method private validateInvoiceItemToBeAdjusted(invoiceItemSqlDao InvoiceItemSqlDao, invoiceItemModelDao InvoiceItemModelDao, context InternalCallContext) : void in class org.killbill.billing.invoice.dao.DefaultInvoiceDao	From	To
Change Variable Type transInvoiceDao : InvoiceSqlDao to invoiceItemSqlDao : InvoiceItemSqlDao in method private validateInvoiceItemToBeAdjusted(invoiceItemSqlDao InvoiceItemSqlDao, invoiceItemModelDao InvoiceItemModelDao, context InternalCallContext) : void in class org.killbill.billing.invoice.dao.DefaultInvoiceDao	From	To
Extract Method	11
Extract Method private createInvoiceItemFromTransaction(invoiceItemSqlDao InvoiceItemSqlDao, invoiceItemModelDao InvoiceItemModelDao, context InternalCallContext) : void extracted from public createInvoice(invoice InvoiceModelDao, invoiceItems List<InvoiceItemModelDao>, isRealInvoice boolean, callbackDateTimePerSubscriptions Map<UUID,List<DateTime>>, context InternalCallContext) : void in class org.killbill.billing.invoice.dao.DefaultInvoiceDao	From	To
Extract Method private createInvoiceItemFromTransaction(invoiceItemSqlDao InvoiceItemSqlDao, invoiceItemModelDao InvoiceItemModelDao, context InternalCallContext) : void extracted from public createRefund(paymentId UUID, requestedRefundAmount BigDecimal, isInvoiceAdjusted boolean, invoiceItemIdsWithNullAmounts Map<UUID,BigDecimal>, transactionExternalKey String, context InternalCallContext) : InvoicePaymentModelDao in class org.killbill.billing.invoice.dao.DefaultInvoiceDao	From	To
Extract Method private validateInvoiceItemFromPlugin(invoiceItem InvoiceItem, invoicePlugin InvoicePluginApi) : void extracted from public getAdditionalInvoiceItems(originalInvoice Invoice, callContext CallContext) : List<InvoiceItem> in class org.killbill.billing.invoice.InvoicePluginDispatcher	From	To
Extract Method private createInvoiceItemFromTransaction(invoiceItemSqlDao InvoiceItemSqlDao, invoiceItemModelDao InvoiceItemModelDao, context InternalCallContext) : void extracted from public deleteCBA(accountId UUID, invoiceId UUID, invoiceItemId UUID, context InternalCallContext) : void in class org.killbill.billing.invoice.dao.DefaultInvoiceDao	From	To
Extract Method private validateInvoiceItemToBeAdjusted(invoiceItemSqlDao InvoiceItemSqlDao, invoiceItemModelDao InvoiceItemModelDao, context InternalCallContext) : void extracted from public createRefund(paymentId UUID, requestedRefundAmount BigDecimal, isInvoiceAdjusted boolean, invoiceItemIdsWithNullAmounts Map<UUID,BigDecimal>, transactionExternalKey String, context InternalCallContext) : InvoicePaymentModelDao in class org.killbill.billing.invoice.dao.DefaultInvoiceDao	From	To
Extract Method private createInvoiceItemFromTransaction(invoiceItemSqlDao InvoiceItemSqlDao, invoiceItemModelDao InvoiceItemModelDao, context InternalCallContext) : void extracted from public createInvoices(invoices List<InvoiceModelDao>, context InternalCallContext) : List<InvoiceItemModelDao> in class org.killbill.billing.invoice.dao.DefaultInvoiceDao	From	To
Extract Method private validateInvoiceItemToBeAdjusted(invoiceItemSqlDao InvoiceItemSqlDao, invoiceItemModelDao InvoiceItemModelDao, context InternalCallContext) : void extracted from public deleteCBA(accountId UUID, invoiceId UUID, invoiceItemId UUID, context InternalCallContext) : void in class org.killbill.billing.invoice.dao.DefaultInvoiceDao	From	To

31fb02aea856bfb196519e8bcc8cf3513ee20153

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: