33a975e0716209044c74440c6e87bdade394742e
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 13
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Variable | 2 | ||
| Rename Variable maxAdjAmount : BigDecimal to maxAdjLeftAmount : BigDecimal in method private computeItemAdjustmentsForTargetInvoiceItem(targetInvoiceItem InvoiceItemModelDao, adjustedOrRepairedItems List<InvoiceItemModelDao>, inputAdjInvoiceItem Map<UUID,BigDecimal>, outputAdjInvoiceItem Map<UUID,BigDecimal>) : void in class org.killbill.billing.invoice.dao.InvoiceDaoHelper | From | To | |
| Rename Variable positiveRepairedAmount : BigDecimal to positiveAdjustedOrRepairedAmount : BigDecimal in method private computeItemAdjustmentAmount(requestedPositiveAmountToAdjust BigDecimal, adjustedOrRepairedItems List<InvoiceItemModelDao>) : BigDecimal in class org.killbill.billing.invoice.dao.InvoiceDaoHelper | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable repairedItems : Collection<InvoiceItemModelDao> to adjustedOrRepairedItems : List<InvoiceItemModelDao> in method private computeItemAdjustmentAmount(requestedPositiveAmountToAdjust BigDecimal, adjustedOrRepairedItems List<InvoiceItemModelDao>) : BigDecimal in class org.killbill.billing.invoice.dao.InvoiceDaoHelper | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type repairedItems : Collection<InvoiceItemModelDao> to adjustedOrRepairedItems : List<InvoiceItemModelDao> in method private computeItemAdjustmentAmount(requestedPositiveAmountToAdjust BigDecimal, adjustedOrRepairedItems List<InvoiceItemModelDao>) : BigDecimal in class org.killbill.billing.invoice.dao.InvoiceDaoHelper | From | To | |
| Extract Method | 1 | ||
| Extract Method private computeItemAdjustmentsForTargetInvoiceItem(targetInvoiceItem InvoiceItemModelDao, adjustedOrRepairedItems List<InvoiceItemModelDao>, inputAdjInvoiceItem Map<UUID,BigDecimal>, outputAdjInvoiceItem Map<UUID,BigDecimal>) : void extracted from public computeItemAdjustments(invoiceId String, entitySqlDaoWrapperFactory EntitySqlDaoWrapperFactory, invoiceItemIdsWithNullAmounts Map<UUID,BigDecimal>, context InternalTenantContext) : Map<UUID,BigDecimal> in class org.killbill.billing.invoice.dao.InvoiceDaoHelper | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter invoiceItemIdsWithNullAmounts : Map<UUID,BigDecimal> to inputAdjInvoiceItem : Map<UUID,BigDecimal> in method private computeItemAdjustmentsForTargetInvoiceItem(targetInvoiceItem InvoiceItemModelDao, adjustedOrRepairedItems List<InvoiceItemModelDao>, inputAdjInvoiceItem Map<UUID,BigDecimal>, outputAdjInvoiceItem Map<UUID,BigDecimal>) : void in class org.killbill.billing.invoice.dao.InvoiceDaoHelper | From | To |