3c64441602efa294ebf5b419067e630315e8b557
Files Diff
- Added: 1
- Removed: 1
- Renamed: 0
- Modified: 14
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public getUsageOverrides() : List<UsageOverrideJson> renamed to public getUsagePriceOverrides() : List<UsagePriceOverrideJson> in class org.killbill.billing.jaxrs.json.PhasePriceOverrideJson | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type parentUsageName : String to currency : Currency in method private getOrCreateOverrideUsageDefinitionFromTransaction(parentUsage Usage, currency Currency, catalogEffectiveDate DateTime, override UsagePriceOverride, inTransactionHandle Handle, context InternalCallContext) : CatalogOverrideUsageDefinitionModelDao in class org.killbill.billing.catalog.dao.DefaultCatalogOverrideDao | From | To | |
| Change Parameter Type usageOverrides : List<UsageOverrideJson> to usagePriceOverrides : List<UsagePriceOverrideJson> in method public PhasePriceOverrideJson(phaseName String, phaseType String, fixedPrice BigDecimal, recurringPrice BigDecimal, usagePriceOverrides List<UsagePriceOverrideJson>) in class org.killbill.billing.jaxrs.json.PhasePriceOverrideJson | From | To | |
| Rename Variable | 2 | ||
| Rename Variable usageOverrideJson : UsageOverrideJson to usagePriceOverrideJson : UsagePriceOverrideJson in method public PhasePriceOverrideJson(phaseName String, phaseType String, fixedPrice BigDecimal, recurringPrice BigDecimal, usagePriceOverrides Usage[], currency Currency) in class org.killbill.billing.jaxrs.json.PhasePriceOverrideJson | From | To | |
| Rename Variable results : List<CatalogOverridePhaseDefinitionModelDao> to resultPhases : List<CatalogOverridePhaseDefinitionModelDao> in method private getOrCreatePhaseDefinitionFromTransactionWithoutUsageOverrides(parentPhaseName String, catalogEffectiveDate DateTime, override PlanPhasePriceOverride, inTransactionHandle Handle, context InternalCallContext) : CatalogOverridePhaseDefinitionModelDao in class org.killbill.billing.catalog.dao.DefaultCatalogOverrideDao | From | To | |
| Change Return Type | 1 | ||
| Change Return Type List<UsageOverrideJson> to List<UsagePriceOverrideJson> in method public getUsagePriceOverrides() : List<UsagePriceOverrideJson> in class org.killbill.billing.jaxrs.json.PhasePriceOverrideJson | From | To | |
| Rename Class | 1 | ||
| Rename Class org.killbill.billing.jaxrs.json.UsageOverrideJson renamed to org.killbill.billing.jaxrs.json.UsagePriceOverrideJson | From | To | |
| Parameterize Variable | 4 | ||
| Parameterize Variable i : int to index : int in method private getConcatenatedKey(index int, recordId Long) : StringBuffer in class org.killbill.billing.catalog.dao.DefaultCatalogOverrideDao | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute usageOverrides : List<UsageOverrideJson> to usagePriceOverrides : List<UsagePriceOverrideJson> in class org.killbill.billing.jaxrs.json.PhasePriceOverrideJson | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type usageOverrideJson : UsageOverrideJson to usagePriceOverrideJson : UsagePriceOverrideJson in method public PhasePriceOverrideJson(phaseName String, phaseType String, fixedPrice BigDecimal, recurringPrice BigDecimal, usagePriceOverrides Usage[], currency Currency) in class org.killbill.billing.jaxrs.json.PhasePriceOverrideJson | From | To | |
| Change Variable Type usageOverrideJson : UsageOverrideJson to usageOverrideJson : UsagePriceOverrideJson in method public toPlanPhasePriceOverrides(priceOverrides List<PhasePriceOverrideJson>, spec PlanSpecifier, currency Currency) : List<PlanPhasePriceOverride> in class org.killbill.billing.jaxrs.json.PhasePriceOverrideJson | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type usageOverrides : List<UsageOverrideJson> to usagePriceOverrides : List<UsagePriceOverrideJson> in class org.killbill.billing.jaxrs.json.PhasePriceOverrideJson | From | To | |
| Extract Method | 5 | ||
| Extract Method private getConcatenatedKey(index int, recordId Long) : StringBuffer extracted from private getOverrideUsageDefinitionFromTransaction(overrideTierDefinitionModelDaos CatalogOverrideTierDefinitionModelDao[], inTransactionHandle Handle, context InternalCallContext) : Long in class org.killbill.billing.catalog.dao.DefaultCatalogOverrideDao | From | To | |
| Extract Method private getConcatenatedKey(index int, recordId Long) : StringBuffer extracted from private getOverrideTierDefinitionFromTransaction(overrideBlockDefinitionModelDaos CatalogOverrideBlockDefinitionModelDao[], inTransactionHandle Handle, context InternalCallContext) : Long in class org.killbill.billing.catalog.dao.DefaultCatalogOverrideDao | From | To | |
| Extract Method private getOrCreatePhaseDefinitionFromTransactionWithoutUsageOverrides(parentPhaseName String, catalogEffectiveDate DateTime, override PlanPhasePriceOverride, inTransactionHandle Handle, context InternalCallContext) : CatalogOverridePhaseDefinitionModelDao extracted from private getOrCreateOverridePhaseDefinitionFromTransaction(parentPlanPhase PlanPhase, parentPhaseName String, catalogEffectiveDate DateTime, override PlanPhasePriceOverride, inTransactionHandle Handle, context InternalCallContext) : CatalogOverridePhaseDefinitionModelDao in class org.killbill.billing.catalog.dao.DefaultCatalogOverrideDao | From | To | |
| Extract Method private getConcatenatedKey(index int, recordId Long) : StringBuffer extracted from private getOverridePlanDefinitionFromTransaction(overridePhaseDefinitionModelDaos CatalogOverridePhaseDefinitionModelDao[], inTransactionHandle Handle, context InternalCallContext) : Long in class org.killbill.billing.catalog.dao.DefaultCatalogOverrideDao | From | To | |
| Extract Method private getConcatenatedKey(index int, recordId Long) : StringBuffer extracted from private getOverridePhaseDefinitionFromTransaction(overrideUsageDefinitionModelDaos CatalogOverrideUsageDefinitionModelDao[], inTransactionHandle Handle, context InternalCallContext) : List<Long> in class org.killbill.billing.catalog.dao.DefaultCatalogOverrideDao | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter usageOverrides : Usage[] to usagePriceOverrides : Usage[] in method public PhasePriceOverrideJson(phaseName String, phaseType String, fixedPrice BigDecimal, recurringPrice BigDecimal, usagePriceOverrides Usage[], currency Currency) in class org.killbill.billing.jaxrs.json.PhasePriceOverrideJson | From | To | |
| Rename Parameter usageOverrides : List<UsageOverrideJson> to usagePriceOverrides : List<UsagePriceOverrideJson> in method public PhasePriceOverrideJson(phaseName String, phaseType String, fixedPrice BigDecimal, recurringPrice BigDecimal, usagePriceOverrides List<UsagePriceOverrideJson>) in class org.killbill.billing.jaxrs.json.PhasePriceOverrideJson | From | To | |
| Rename Parameter parentUsageName : String to currency : Currency in method private getOrCreateOverrideUsageDefinitionFromTransaction(parentUsage Usage, currency Currency, catalogEffectiveDate DateTime, override UsagePriceOverride, inTransactionHandle Handle, context InternalCallContext) : CatalogOverrideUsageDefinitionModelDao in class org.killbill.billing.catalog.dao.DefaultCatalogOverrideDao | From | To |