killbill 69aee775b22fcc9b61c7f472a4d8f6394e23f7bc

69aee775b22fcc9b61c7f472a4d8f6394e23f7bc

Files Diff

Added: 3
Removed: 0
Renamed: 0
Modified: 18

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Pull Up Method	4
Pull Up Method private toPaymentControlPluginNames(paymentOptions PaymentOptions) : List<String> from class org.killbill.billing.payment.api.DefaultPaymentApi to protected toPaymentControlPluginNames(paymentOptions PaymentOptions) : List<String> from class org.killbill.billing.payment.api.DefaultApiBase	From	To
Pull Up Method private logAPICall(transactionType String, account Account, paymentMethodId UUID, paymentId UUID, transactionId UUID, amount BigDecimal, currency Currency, paymentExternalKey String, paymentTransactionExternalKey String) : void from class org.killbill.billing.payment.api.DefaultPaymentApi to protected logAPICall(transactionType String, account Account, paymentMethodId UUID, paymentId UUID, transactionId UUID, amount BigDecimal, currency Currency, paymentExternalKey String, paymentTransactionExternalKey String) : void from class org.killbill.billing.payment.api.DefaultApiBase	From	To
Pull Up Method private checkPositiveAmount(amount BigDecimal) : void from class org.killbill.billing.payment.api.DefaultPaymentApi to protected checkPositiveAmount(amount BigDecimal) : void from class org.killbill.billing.payment.api.DefaultApiBase	From	To
Pull Up Method private checkNotNullParameter(parameter Object, parameterName String) : void from class org.killbill.billing.payment.api.DefaultPaymentApi to protected checkNotNullParameter(parameter Object, parameterName String) : void from class org.killbill.billing.payment.api.DefaultApiBase	From	To
Change Parameter Type	10
Change Parameter Type retryPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in method public CompletionControlOperation(locker GlobalLocker, paymentPluginDispatcher PluginDispatcher<OperationResult>, paymentStateContext PaymentStateControlContext, paymentProcessor PaymentProcessor, controlPluginRunner ControlPluginRunner) in class org.killbill.billing.payment.core.sm.control.CompletionControlOperation	From	To
Change Parameter Type paymentControlPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in method public VoidControlOperation(locker GlobalLocker, paymentPluginDispatcher PluginDispatcher<OperationResult>, paymentStateContext PaymentStateControlContext, paymentProcessor PaymentProcessor, controlPluginRunner ControlPluginRunner) in class org.killbill.billing.payment.core.sm.control.VoidControlOperation	From	To
Change Parameter Type paymentControlPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in method public AuthorizeControlOperation(locker GlobalLocker, paymentPluginDispatcher PluginDispatcher<OperationResult>, paymentStateContext PaymentStateControlContext, paymentProcessor PaymentProcessor, controlPluginRunner ControlPluginRunner) in class org.killbill.billing.payment.core.sm.control.AuthorizeControlOperation	From	To
Change Parameter Type paymentControlPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in method public RefundControlOperation(locker GlobalLocker, paymentPluginDispatcher PluginDispatcher<OperationResult>, paymentStateContext PaymentStateControlContext, paymentProcessor PaymentProcessor, controlPluginRunner ControlPluginRunner) in class org.killbill.billing.payment.core.sm.control.RefundControlOperation	From	To
Change Parameter Type paymentControlPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in method public CaptureControlOperation(locker GlobalLocker, paymentPluginDispatcher PluginDispatcher<OperationResult>, paymentStateContext PaymentStateControlContext, paymentProcessor PaymentProcessor, controlPluginRunner ControlPluginRunner) in class org.killbill.billing.payment.core.sm.control.CaptureControlOperation	From	To
Change Parameter Type retryPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in method public MockRetryAuthorizeOperationCallback(locker GlobalLocker, paymentPluginDispatcher PluginDispatcher<OperationResult>, paymentStateContext PaymentStateControlContext, paymentProcessor PaymentProcessor, controlPluginRunner ControlPluginRunner, paymentDao PaymentDao, clock Clock) in class org.killbill.billing.payment.core.sm.MockRetryAuthorizeOperationCallback	From	To
Change Parameter Type paymentControlPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in method public CreditControlOperation(locker GlobalLocker, paymentPluginDispatcher PluginDispatcher<OperationResult>, paymentStateContext PaymentStateControlContext, paymentProcessor PaymentProcessor, controlPluginRunner ControlPluginRunner) in class org.killbill.billing.payment.core.sm.control.CreditControlOperation	From	To
Change Parameter Type retryPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in method protected OperationControlCallback(locker GlobalLocker, paymentPluginDispatcher PluginDispatcher<OperationResult>, paymentStateContext PaymentStateControlContext, paymentProcessor PaymentProcessor, controlPluginRunner ControlPluginRunner) in class org.killbill.billing.payment.core.sm.control.OperationControlCallback	From	To
Change Parameter Type retryPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in method public PurchaseControlOperation(locker GlobalLocker, paymentPluginDispatcher PluginDispatcher<OperationResult>, paymentStateContext PaymentStateControlContext, paymentProcessor PaymentProcessor, controlPluginRunner ControlPluginRunner) in class org.killbill.billing.payment.core.sm.control.PurchaseControlOperation	From	To
Change Parameter Type paymentControlPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in method public ChargebackControlOperation(locker GlobalLocker, paymentPluginDispatcher PluginDispatcher<OperationResult>, paymentStateContext PaymentStateControlContext, paymentProcessor PaymentProcessor, controlPluginRunner ControlPluginRunner) in class org.killbill.billing.payment.core.sm.control.ChargebackControlOperation	From	To
Rename Variable	1
Rename Variable prevResult : PriorPaymentControlResult to result : PriorPaymentControlResult in method private executePluginPriorCalls(paymentControlPluginNames List<String>, paymentControlContextArg PaymentControlContext) : PriorPaymentControlResult in class org.killbill.billing.payment.core.sm.control.OperationControlCallback	From	To
Pull Up Attribute	1
Pull Up Attribute private paymentConfig : PaymentConfig from class org.killbill.billing.payment.api.DefaultPaymentApi to private paymentConfig : PaymentConfig from class org.killbill.billing.payment.api.DefaultApiBase	From	To
Move Attribute	1
Move Attribute private paymentControlPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> from class org.killbill.billing.payment.core.sm.control.OperationControlCallback to private paymentControlPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> from class org.killbill.billing.payment.core.sm.control.ControlPluginRunner	From	To
Extract Class	1
Extract Class org.killbill.billing.payment.core.sm.control.ControlPluginRunner from class org.killbill.billing.payment.core.sm.control.OperationControlCallback	From	To
Move Class	1
Move Class org.killbill.billing.payment.core.sm.control.OperationControlCallback.DefaultPaymentControlContext moved to org.killbill.billing.payment.core.sm.control.ControlPluginRunner.DefaultPaymentControlContext	From	To
Extract Superclass	1
Extract Superclass org.killbill.billing.payment.api.DefaultApiBase from classes [org.killbill.billing.payment.api.DefaultPaymentApi, org.killbill.billing.payment.api.DefaultPaymentGatewayApi]	From	To
Rename Attribute	1
Rename Attribute paymentControlPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in class org.killbill.billing.payment.core.sm.control.OperationControlCallback	From	To
Change Attribute Type	1
Change Attribute Type paymentControlPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in class org.killbill.billing.payment.core.sm.control.OperationControlCallback	From	To
Inline Variable	2
Inline Variable inputPluginProperties : Iterable<PluginProperty> in method protected executePluginOnSuccessCalls(paymentControlPluginNames List<String>, paymentControlContext PaymentControlContext) : void from class org.killbill.billing.payment.core.sm.control.OperationControlCallback	From	To
Inline Variable inputPluginProperties : Iterable<PluginProperty> in method private executePluginOnFailureCalls(paymentControlPluginNames List<String>, paymentControlContext PaymentControlContext) : DateTime from class org.killbill.billing.payment.core.sm.control.OperationControlCallback	From	To
Rename Parameter	12
Rename Parameter retryPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in method public MockRetryAuthorizeOperationCallback(locker GlobalLocker, paymentPluginDispatcher PluginDispatcher<OperationResult>, paymentStateContext PaymentStateControlContext, paymentProcessor PaymentProcessor, controlPluginRunner ControlPluginRunner, paymentDao PaymentDao, clock Clock) in class org.killbill.billing.payment.core.sm.MockRetryAuthorizeOperationCallback	From	To
Rename Parameter paymentControlPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in method public CreditControlOperation(locker GlobalLocker, paymentPluginDispatcher PluginDispatcher<OperationResult>, paymentStateContext PaymentStateControlContext, paymentProcessor PaymentProcessor, controlPluginRunner ControlPluginRunner) in class org.killbill.billing.payment.core.sm.control.CreditControlOperation	From	To
Rename Parameter retryPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in method protected OperationControlCallback(locker GlobalLocker, paymentPluginDispatcher PluginDispatcher<OperationResult>, paymentStateContext PaymentStateControlContext, paymentProcessor PaymentProcessor, controlPluginRunner ControlPluginRunner) in class org.killbill.billing.payment.core.sm.control.OperationControlCallback	From	To
Rename Parameter iterable : Iterable<PluginProperty> to properties : Iterable<PluginProperty> in method public processNotificationWithPaymentControl(notification String, pluginName String, properties Iterable<PluginProperty>, paymentOptions PaymentOptions, callContext CallContext) : GatewayNotification in class org.killbill.billing.payment.api.DefaultPaymentGatewayApi	From	To
Rename Parameter paymentControlPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in method public ChargebackControlOperation(locker GlobalLocker, paymentPluginDispatcher PluginDispatcher<OperationResult>, paymentStateContext PaymentStateControlContext, paymentProcessor PaymentProcessor, controlPluginRunner ControlPluginRunner) in class org.killbill.billing.payment.core.sm.control.ChargebackControlOperation	From	To
Rename Parameter paymentControlPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in method public RefundControlOperation(locker GlobalLocker, paymentPluginDispatcher PluginDispatcher<OperationResult>, paymentStateContext PaymentStateControlContext, paymentProcessor PaymentProcessor, controlPluginRunner ControlPluginRunner) in class org.killbill.billing.payment.core.sm.control.RefundControlOperation	From	To
Rename Parameter retryPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in method public PurchaseControlOperation(locker GlobalLocker, paymentPluginDispatcher PluginDispatcher<OperationResult>, paymentStateContext PaymentStateControlContext, paymentProcessor PaymentProcessor, controlPluginRunner ControlPluginRunner) in class org.killbill.billing.payment.core.sm.control.PurchaseControlOperation	From	To
Rename Parameter uuid : UUID to paymentMethodId : UUID in method public buildFormDescriptorWithPaymentControl(account Account, paymentMethodId UUID, customFields Iterable<PluginProperty>, properties Iterable<PluginProperty>, paymentOptions PaymentOptions, callContext CallContext) : HostedPaymentPageFormDescriptor in class org.killbill.billing.payment.api.DefaultPaymentGatewayApi	From	To
Rename Parameter retryPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in method public CompletionControlOperation(locker GlobalLocker, paymentPluginDispatcher PluginDispatcher<OperationResult>, paymentStateContext PaymentStateControlContext, paymentProcessor PaymentProcessor, controlPluginRunner ControlPluginRunner) in class org.killbill.billing.payment.core.sm.control.CompletionControlOperation	From	To
Rename Parameter paymentControlPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in method public VoidControlOperation(locker GlobalLocker, paymentPluginDispatcher PluginDispatcher<OperationResult>, paymentStateContext PaymentStateControlContext, paymentProcessor PaymentProcessor, controlPluginRunner ControlPluginRunner) in class org.killbill.billing.payment.core.sm.control.VoidControlOperation	From	To
Rename Parameter paymentControlPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in method public AuthorizeControlOperation(locker GlobalLocker, paymentPluginDispatcher PluginDispatcher<OperationResult>, paymentStateContext PaymentStateControlContext, paymentProcessor PaymentProcessor, controlPluginRunner ControlPluginRunner) in class org.killbill.billing.payment.core.sm.control.AuthorizeControlOperation	From	To
Rename Parameter paymentControlPluginRegistry : OSGIServiceRegistration<PaymentControlPluginApi> to controlPluginRunner : ControlPluginRunner in method public CaptureControlOperation(locker GlobalLocker, paymentPluginDispatcher PluginDispatcher<OperationResult>, paymentStateContext PaymentStateControlContext, paymentProcessor PaymentProcessor, controlPluginRunner ControlPluginRunner) in class org.killbill.billing.payment.core.sm.control.CaptureControlOperation	From	To

69aee775b22fcc9b61c7f472a4d8f6394e23f7bc

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: