7365574f63933c3124d0b0cf3e9e45657f3996ad
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 8
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 3 | ||
| Pull Up Method private populateDryRunEvents(bundleId UUID, dryRunArguments DryRunArguments, outputDryRunEvents Collection<SubscriptionBaseEvent>, outputSubscriptions Collection<SubscriptionBase>, catalog Catalog, context InternalTenantContext) : void from class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionInternalApi to private populateDryRunEvents(bundleId UUID, dryRunArguments DryRunArguments, outputDryRunEvents Collection<SubscriptionBaseEvent>, outputSubscriptions Collection<SubscriptionBase>, catalog Catalog, addonUtils AddonUtils, tenantContext TenantContext, context InternalTenantContext) : void from class org.killbill.billing.subscription.api.SubscriptionApiBase | From | To | |
| Pull Up Method private getDryRunEffectiveDate(inputDate LocalDate, subscription DefaultSubscriptionBase, context InternalTenantContext) : DateTime from class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionInternalApi to private getDryRunEffectiveDate(inputDate LocalDate, subscription SubscriptionBase, context InternalTenantContext) : DateTime from class org.killbill.billing.subscription.api.SubscriptionApiBase | From | To | |
| Pull Up Method private getBundleStartDateWithSanity(bundleId UUID, baseSubscription SubscriptionBase, plan Plan, effectiveDate DateTime, catalog Catalog, context InternalTenantContext) : DateTime from class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionInternalApi to protected getBundleStartDateWithSanity(bundleId UUID, baseSubscription SubscriptionBase, plan Plan, effectiveDate DateTime, catalog Catalog, addonUtils AddonUtils, context InternalTenantContext) : DateTime from class org.killbill.billing.subscription.api.SubscriptionApiBase | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method private sanityAndReorderBPOrStandaloneSpecFirst(catalog Catalog, subscriptionBaseWithAddOnsSpecifier SubscriptionBaseWithAddOnsSpecifier, effectiveDate DateTime, outputEntitlementSpecifier Collection<EntitlementSpecifier>) : boolean from class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionInternalApi to private createPlansIfNeededAndReorderBPOrStandaloneSpecFirstWithSanity(subscriptionBaseWithAddOnsSpecifier SubscriptionBaseWithAddOnsSpecifier, catalog Catalog, effectiveDate DateTime, outputEntitlementSpecifier Collection<EntitlementSpecifier>, outputEntitlementPlans Collection<Plan>, callContext CallContext) : boolean from class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionBaseCreateApi | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type callContext : CallContext to callContext : TenantContext in method private verifyAndBuildSubscriptionSpecifiers(bundle SubscriptionBaseBundle, hasBaseOrStandalonePlanSpecifier boolean, entitlements List<EntitlementSpecifier>, entitlementsPlans List<Plan>, isMigrated boolean, effectiveDate DateTime, catalog Catalog, addonUtils AddonUtils, callContext TenantContext, context InternalCallContext) : List<SubscriptionSpecifier> in class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionBaseCreateApi | From | To | |
| Change Parameter Type internalSubscriptions : List<SubscriptionBase> to internalSubscriptions : Collection<SubscriptionBase> in method protected createSubscriptionsForApiUse(internalSubscriptions Collection<SubscriptionBase>) : List<SubscriptionBase> in class org.killbill.billing.subscription.api.SubscriptionApiBase | From | To | |
| Change Parameter Type subscription : DefaultSubscriptionBase to subscription : SubscriptionBase in method private getDryRunEffectiveDate(inputDate LocalDate, subscription SubscriptionBase, context InternalTenantContext) : DateTime in class org.killbill.billing.subscription.api.SubscriptionApiBase | From | To | |
| Change Parameter Type entitlements : Iterable<EntitlementSpecifier> to entitlements : List<EntitlementSpecifier> in method private verifyAndBuildSubscriptionSpecifiers(bundle SubscriptionBaseBundle, hasBaseOrStandalonePlanSpecifier boolean, entitlements List<EntitlementSpecifier>, entitlementsPlans List<Plan>, isMigrated boolean, effectiveDate DateTime, catalog Catalog, addonUtils AddonUtils, callContext TenantContext, context InternalCallContext) : List<SubscriptionSpecifier> in class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionBaseCreateApi | From | To | |
| Move Method | 1 | ||
| Move Method private verifyAndBuildSubscriptionSpecifiers(bundle SubscriptionBaseBundle, hasBaseOrStandalonePlanSpecifier boolean, entitlements Iterable<EntitlementSpecifier>, isMigrated boolean, context InternalCallContext, now DateTime, effectiveDate DateTime, catalog Catalog, callContext CallContext) : List<SubscriptionSpecifier> from class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionInternalApi to private verifyAndBuildSubscriptionSpecifiers(bundle SubscriptionBaseBundle, hasBaseOrStandalonePlanSpecifier boolean, entitlements List<EntitlementSpecifier>, entitlementsPlans List<Plan>, isMigrated boolean, effectiveDate DateTime, catalog Catalog, addonUtils AddonUtils, callContext TenantContext, context InternalCallContext) : List<SubscriptionSpecifier> from class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionBaseCreateApi | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.killbill.billing.subscription.api.svcs.DefaultSubscriptionBaseCreateApi from classes [org.killbill.billing.subscription.api.svcs.DefaultSubscriptionInternalApi] | From | To | |
| Extract And Move Method | 4 | ||
| Extract And Move Method protected getBaseSubscription(bundleId UUID, catalog Catalog, context InternalTenantContext) : SubscriptionBase extracted from public getBaseSubscription(bundleId UUID, context InternalTenantContext) : SubscriptionBase in class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionInternalApi & moved to class org.killbill.billing.subscription.api.SubscriptionApiBase | From | To | |
| Extract And Move Method protected createBundleForAccount(accountId UUID, bundleKey String, renameCancelledBundleIfExist boolean, catalog Catalog, accountIdCacheController CacheController<UUID,UUID>, context InternalCallContext) : SubscriptionBaseBundle extracted from public createBundleForAccount(accountId UUID, bundleKey String, renameCancelledBundleIfExist boolean, context InternalCallContext) : SubscriptionBaseBundle in class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionInternalApi & moved to class org.killbill.billing.subscription.api.SubscriptionApiBase | From | To | |
| Extract And Move Method protected getActiveBundleForKey(bundleKey String, catalog Catalog, context InternalTenantContext) : SubscriptionBaseBundle extracted from public getActiveBundleForKey(bundleKey String, catalog Catalog, context InternalTenantContext) : SubscriptionBaseBundle in class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionInternalApi & moved to class org.killbill.billing.subscription.api.SubscriptionApiBase | From | To | |
| Extract And Move Method protected getSubscriptionsForBundle(bundleId UUID, dryRunArguments DryRunArguments, catalog Catalog, addonUtils AddonUtils, tenantContext TenantContext, context InternalTenantContext) : List<SubscriptionBase> extracted from public getSubscriptionsForBundle(bundleId UUID, dryRunArguments DryRunArguments, context InternalTenantContext) : List<SubscriptionBase> in class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionInternalApi & moved to class org.killbill.billing.subscription.api.SubscriptionApiBase | From | To |