9b32f451f28826f5fdb93f5d32fe5b33fefbff9b
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 4
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Inline Method | 1 | ||
| Inline Method public cancelSubscription(subscription DefaultSubscriptionBase, cancelEvent SubscriptionBaseEvent, context InternalCallContext, seqId int) : void inlined to public cancelSubscriptions(subscriptions List<DefaultSubscriptionBase>, cancelEvents List<SubscriptionBaseEvent>, context InternalCallContext) : void in class org.killbill.billing.subscription.engine.dao.MockSubscriptionDaoMemory | From | To | |
| Extract Variable | 1 | ||
| Extract Variable fullCatalog : Catalog in method private doChangePlan(subscription DefaultSubscriptionBase, newProductName String, newBillingPeriod BillingPeriod, newPriceList String, overrides List<PlanPhasePriceOverride>, now DateTime, effectiveDate DateTime, context CallContext) : DateTime from class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Extract Method | 3 | ||
| Extract Method private computeAddOnsToCancel(cancelEvents List<SubscriptionBaseEvent>, baseProduct Product, bundleId UUID, effectiveDate DateTime, internalCallContext InternalCallContext) : List<DefaultSubscriptionBase> extracted from public cancelAddOnsIfRequired(baseProduct Product, bundleId UUID, effectiveDate DateTime, context CallContext) : int in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Extract Method private getEventsOnChangePlan(subscription DefaultSubscriptionBase, newPlan Plan, newPriceList String, effectiveDate DateTime, addCancellationAddOnForEventsIfRequired boolean, addOnSubscriptionsToBeCancelled Collection<DefaultSubscriptionBase>, addOnCancelEvents List<SubscriptionBaseEvent>, internalTenantContext InternalTenantContext) : List<SubscriptionBaseEvent> extracted from public getEventsOnChangePlan(subscription DefaultSubscriptionBase, newPlan Plan, newPriceList String, effectiveDate DateTime, processedDate DateTime, addCancellationAddOnForEventsIfRequired boolean, internalTenantContext InternalTenantContext) : List<SubscriptionBaseEvent> in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Extract Method private cancelSubscriptionsFromTransaction(entitySqlDaoWrapperFactory EntitySqlDaoWrapperFactory, subscriptions List<DefaultSubscriptionBase>, cancelEvents List<SubscriptionBaseEvent>, context InternalCallContext) : void extracted from public cancelSubscriptions(subscriptions List<DefaultSubscriptionBase>, cancelEvents List<SubscriptionBaseEvent>, context InternalCallContext) : void in class org.killbill.billing.subscription.engine.dao.DefaultSubscriptionDao | From | To |