a361ac72632349eadfc2cf7af9131210f5ee0298
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 15
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public cancelWithPolicyNoValidation(subscriptions Iterable<DefaultSubscriptionBase>, policy BillingActionPolicy, accountBillCycleDayLocal int, context InternalCallContext) : boolean renamed to public cancelWithPolicyNoValidationAndCatalog(subscriptions Iterable<DefaultSubscriptionBase>, policy BillingActionPolicy, accountBillCycleDayLocal int, catalog Catalog, context InternalCallContext) : boolean in class org.killbill.billing.subscription.api.SubscriptionBaseApiService | From | To | |
| Rename Method public cancelWithPolicyNoValidation(subscriptions Iterable<DefaultSubscriptionBase>, policy BillingActionPolicy, accountBillCycleDayLocal int, context InternalCallContext) : boolean renamed to public cancelWithPolicyNoValidationAndCatalog(subscriptions Iterable<DefaultSubscriptionBase>, policy BillingActionPolicy, accountBillCycleDayLocal int, catalog Catalog, context InternalCallContext) : boolean in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type processedDate : DateTime to fullCatalog : Catalog in method public createPlan(builder SubscriptionBuilder, plan Plan, initialPhase PhaseType, realPriceList String, effectiveDate DateTime, fullCatalog Catalog, context CallContext) : DefaultSubscriptionBase in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Change Parameter Type now : DateTime to fullCatalog : Catalog in method private doCancelPlan(subscriptions Map<DefaultSubscriptionBase,DateTime>, fullCatalog Catalog, internalCallContext InternalCallContext) : boolean in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Move Attribute | 4 | ||
| Move Attribute private catalogInternalApi : CatalogInternalApi from class org.killbill.billing.subscription.engine.dao.DefaultSubscriptionDao to private catalogInternalApi : CatalogInternalApi from class org.killbill.billing.subscription.engine.core.DefaultSubscriptionBaseService | From | To | |
| Move Attribute private catalogInternalApi : CatalogInternalApi from class org.killbill.billing.subscription.engine.dao.DefaultSubscriptionDao to private catalogInternalApi : CatalogInternalApi from class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionInternalApi | From | To | |
| Move Attribute private catalogInternalApi : CatalogInternalApi from class org.killbill.billing.subscription.engine.addon.AddonUtils to private catalogInternalApi : CatalogInternalApi from class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionInternalApi | From | To | |
| Move Attribute private catalogInternalApi : CatalogInternalApi from class org.killbill.billing.subscription.alignment.PlanAligner to private catalogInternalApi : CatalogInternalApi from class org.killbill.billing.subscription.engine.core.DefaultSubscriptionBaseService | From | To | |
| Push Down Attribute | 1 | ||
| Push Down Attribute protected catalogInternalApi : CatalogInternalApi from class org.killbill.billing.subscription.api.SubscriptionApiBase to private catalogInternalApi : CatalogInternalApi from class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionInternalApi | From | To | |
| Parameterize Variable | 2 | ||
| Parameterize Variable fullCatalog : Catalog to catalog : Catalog in method private createSubscriptionForInternalUse(shellSubscription SubscriptionBase, events List<SubscriptionBaseEvent>, catalog Catalog, context InternalTenantContext) : SubscriptionBase in class org.killbill.billing.subscription.engine.dao.DefaultSubscriptionDao | From | To | |
| Parameterize Variable now : DateTime to catalog : Catalog in method public cancelWithPolicyNoValidationAndCatalog(subscriptions Iterable<DefaultSubscriptionBase>, policy BillingActionPolicy, accountBillCycleDayLocal int, catalog Catalog, context InternalCallContext) : boolean in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type now : DateTime to catalog : Catalog in method public cancelWithPolicyNoValidationAndCatalog(subscriptions Iterable<DefaultSubscriptionBase>, policy BillingActionPolicy, accountBillCycleDayLocal int, catalog Catalog, context InternalCallContext) : boolean in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Extract Variable | 1 | ||
| Extract Variable fullCatalog : Catalog in method public cancel(subscription DefaultSubscriptionBase, context CallContext) : boolean from class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter processedDate : DateTime to fullCatalog : Catalog in method public createPlan(builder SubscriptionBuilder, plan Plan, initialPhase PhaseType, realPriceList String, effectiveDate DateTime, fullCatalog Catalog, context CallContext) : DefaultSubscriptionBase in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Rename Parameter now : DateTime to fullCatalog : Catalog in method private doCancelPlan(subscriptions Map<DefaultSubscriptionBase,DateTime>, fullCatalog Catalog, internalCallContext InternalCallContext) : boolean in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To |