a4f6150141a9e30f7fc7ba6f3eb5a0ad1dd54e2d
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 3
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Variable | 2 | ||
| Rename Variable subscription : SubscriptionBundle to subscriptionBundle : SubscriptionBundle in method private filterBundles(subscriptionBundlesForAccountId List<SubscriptionBundle>, bundlesFilter List<String>) : List<SubscriptionBundle> in class org.killbill.billing.jaxrs.resources.AccountResource | From | To | |
| Rename Variable entitlementSpecifierList : List<EntitlementSpecifier> to baseEntitlementWithAddOnsSpecifierList : List<BaseEntitlementWithAddOnsSpecifier> in method public doOperation(ctx CallContext) : List<Entitlement> in class org.killbill.billing.jaxrs.resources.SubscriptionResource.createEntitlementWithAddOns.callback | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type callCompletionCreation : EntitlementCallCompletion<Entitlement> to callCompletionCreation : EntitlementCallCompletion<List<Entitlement>> in method public createEntitlementWithAddOns(entitlements List<SubscriptionJson>, requestedDate String, entitlementDate String, billingDate String, isMigrated Boolean, callCompletion Boolean, timeoutSec long, pluginPropertiesString List<String>, createdBy String, reason String, comment String, request HttpServletRequest, uriInfo UriInfo) : Response in class org.killbill.billing.jaxrs.resources.SubscriptionResource | From | To | |
| Change Variable Type callback : EntitlementCallCompletionCallback<Entitlement> to callback : EntitlementCallCompletionCallback<List<Entitlement>> in method public createEntitlementWithAddOns(entitlements List<SubscriptionJson>, requestedDate String, entitlementDate String, billingDate String, isMigrated Boolean, callCompletion Boolean, timeoutSec long, pluginPropertiesString List<String>, createdBy String, reason String, comment String, request HttpServletRequest, uriInfo UriInfo) : Response in class org.killbill.billing.jaxrs.resources.SubscriptionResource | From | To | |
| Change Variable Type specifier : EntitlementSpecifier to baseEntitlementSpecifierWithAddOns : BaseEntitlementWithAddOnsSpecifier in method public doOperation(ctx CallContext) : List<Entitlement> in class org.killbill.billing.jaxrs.resources.SubscriptionResource.createEntitlementWithAddOns.callback | From | To | |
| Change Variable Type entitlementSpecifierList : List<EntitlementSpecifier> to baseEntitlementWithAddOnsSpecifierList : List<BaseEntitlementWithAddOnsSpecifier> in method public doOperation(ctx CallContext) : List<Entitlement> in class org.killbill.billing.jaxrs.resources.SubscriptionResource.createEntitlementWithAddOns.callback | From | To | |
| Extract Method | 4 | ||
| Extract Method private buildEntitlementSpecifierList(entitlements List<SubscriptionJson>, currency Currency) : List<EntitlementSpecifier> extracted from public createEntitlementWithAddOns(entitlements List<SubscriptionJson>, requestedDate String, entitlementDate String, billingDate String, isMigrated Boolean, callCompletion Boolean, timeoutSec long, pluginPropertiesString List<String>, createdBy String, reason String, comment String, request HttpServletRequest, uriInfo UriInfo) : Response in class org.killbill.billing.jaxrs.resources.SubscriptionResource | From | To | |
| Extract Method private buildBaseEntitlementWithAddOnsSpecifier(entitlementSpecifierList List<EntitlementSpecifier>, resolvedEntitlementDate LocalDate, resolvedBillingDate LocalDate, bundleId UUID, baseEntitlement SubscriptionJson, isMigrated Boolean) : BaseEntitlementWithAddOnsSpecifier extracted from public createEntitlementsWithAddOns(entitlementsWithAddOns List<BulkBaseSubscriptionAndAddOnsJson>, requestedDate String, entitlementDate String, billingDate String, isMigrated Boolean, callCompletion Boolean, timeoutSec long, pluginPropertiesString List<String>, createdBy String, reason String, comment String, request HttpServletRequest, uriInfo UriInfo) : Response in class org.killbill.billing.jaxrs.resources.SubscriptionResource | From | To | |
| Extract Method private buildEntitlementSpecifierList(entitlements List<SubscriptionJson>, currency Currency) : List<EntitlementSpecifier> extracted from public createEntitlementsWithAddOns(entitlementsWithAddOns List<BulkBaseSubscriptionAndAddOnsJson>, requestedDate String, entitlementDate String, billingDate String, isMigrated Boolean, callCompletion Boolean, timeoutSec long, pluginPropertiesString List<String>, createdBy String, reason String, comment String, request HttpServletRequest, uriInfo UriInfo) : Response in class org.killbill.billing.jaxrs.resources.SubscriptionResource | From | To | |
| Extract Method private buildBaseEntitlementWithAddOnsSpecifier(entitlementSpecifierList List<EntitlementSpecifier>, resolvedEntitlementDate LocalDate, resolvedBillingDate LocalDate, bundleId UUID, baseEntitlement SubscriptionJson, isMigrated Boolean) : BaseEntitlementWithAddOnsSpecifier extracted from public createEntitlementWithAddOns(entitlements List<SubscriptionJson>, requestedDate String, entitlementDate String, billingDate String, isMigrated Boolean, callCompletion Boolean, timeoutSec long, pluginPropertiesString List<String>, createdBy String, reason String, comment String, request HttpServletRequest, uriInfo UriInfo) : Response in class org.killbill.billing.jaxrs.resources.SubscriptionResource | From | To |