a7b8104632757e9e752cfd9b033dc7585b00ec88
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 7
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public createSubscriptionWithAddOns(subscriptions List<DefaultSubscriptionBase>, initialEventsMap Map<UUID,List<SubscriptionBaseEvent>>, context InternalCallContext) : void renamed to public createSubscriptionsWithAddOns(subscriptions List<DefaultSubscriptionBase>, initialEventsMap Map<UUID,List<SubscriptionBaseEvent>>, context InternalCallContext) : void in class org.killbill.billing.subscription.engine.dao.SubscriptionDao | From | To | |
| Rename Method public createSubscriptionWithAddOns(subscriptions List<DefaultSubscriptionBase>, initialEventsMap Map<UUID,List<SubscriptionBaseEvent>>, context InternalCallContext) : void renamed to public createSubscriptionsWithAddOns(subscriptions List<DefaultSubscriptionBase>, initialEventsMap Map<UUID,List<SubscriptionBaseEvent>>, context InternalCallContext) : void in class org.killbill.billing.subscription.engine.dao.MockSubscriptionDaoMemory | From | To | |
| Rename Variable | 2 | ||
| Rename Variable subscriptionWithAddOns : List<SubscriptionBase> to subscriptionsForBundle : List<SubscriptionBase> in method private verifyAndBuildSubscriptionSpecifiers(bundleId UUID, entitlements Iterable<EntitlementSpecifier>, isMigrated boolean, context InternalCallContext, now DateTime, effectiveDate DateTime, catalog Catalog, callContext CallContext) : List<SubscriptionSpecifier> in class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionInternalApi | From | To | |
| Rename Variable subscriptionBase : List<DefaultSubscriptionBase> to subscriptions : List<DefaultSubscriptionBase> in method public createPlansWithAddOns(accountId UUID, subscriptionsAndAddOns Iterable<SubscriptionAndAddOnsSpecifier>, context CallContext) : List<DefaultSubscriptionBase> in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Change Return Type | 2 | ||
| Change Return Type List<List<DefaultSubscriptionBase>> to List<DefaultSubscriptionBase> in method public createPlansWithAddOns(accountId UUID, subscriptionsAndAddOns Iterable<SubscriptionAndAddOnsSpecifier>, context CallContext) : List<DefaultSubscriptionBase> in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Change Return Type List<List<DefaultSubscriptionBase>> to List<DefaultSubscriptionBase> in method public createPlansWithAddOns(accountId UUID, subscriptionsAndAddOns Iterable<SubscriptionAndAddOnsSpecifier>, context CallContext) : List<DefaultSubscriptionBase> in class org.killbill.billing.subscription.api.SubscriptionBaseApiService | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable subscriptionBase : List<DefaultSubscriptionBase> to subscriptions : List<DefaultSubscriptionBase> in method private rebuildTransitions(internalCallContext InternalCallContext, subscriptions List<DefaultSubscriptionBase>, baseSubscription DefaultSubscriptionBase) : void in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type result : List<List<DefaultSubscriptionBase>> to result : List<DefaultSubscriptionBase> in method public createBaseSubscriptionsWithAddOns(accountId UUID, baseEntitlementWithAddOnsSpecifier Iterable<BaseEntitlementWithAddOnsSpecifier>, context InternalCallContext) : List<SubscriptionBase> in class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionInternalApi | From | To | |
| Extract Method | 6 | ||
| Extract Method private createEvents(subscriptions Iterable<SubscriptionSpecifier>, context CallContext, eventsMap Map<UUID,List<SubscriptionBaseEvent>>, subscriptionBaseList List<DefaultSubscriptionBase>) : void extracted from public createPlansWithAddOns(accountId UUID, subscriptionsAndAddOns Iterable<SubscriptionAndAddOnsSpecifier>, context CallContext) : List<List<DefaultSubscriptionBase>> in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Extract Method private rebuildTransitions(internalCallContext InternalCallContext, subscriptions List<DefaultSubscriptionBase>, baseSubscription DefaultSubscriptionBase) : void extracted from public createPlansWithAddOns(accountId UUID, subscriptionsAndAddOns Iterable<SubscriptionAndAddOnsSpecifier>, context CallContext) : List<List<DefaultSubscriptionBase>> in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Extract Method private createEvents(subscriptions Iterable<SubscriptionSpecifier>, context CallContext, eventsMap Map<UUID,List<SubscriptionBaseEvent>>, subscriptionBaseList List<DefaultSubscriptionBase>) : void extracted from public createPlans(subscriptions Iterable<SubscriptionSpecifier>, context CallContext) : List<DefaultSubscriptionBase> in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Extract Method private rebuildTransitions(internalCallContext InternalCallContext, subscriptions List<DefaultSubscriptionBase>, baseSubscription DefaultSubscriptionBase) : void extracted from public createPlans(subscriptions Iterable<SubscriptionSpecifier>, context CallContext) : List<DefaultSubscriptionBase> in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Extract Method private verifyAndBuildSubscriptionSpecifiers(bundleId UUID, entitlements Iterable<EntitlementSpecifier>, isMigrated boolean, context InternalCallContext, now DateTime, effectiveDate DateTime, catalog Catalog, callContext CallContext) : List<SubscriptionSpecifier> extracted from public createBaseSubscriptionsWithAddOns(accountId UUID, baseEntitlementWithAddOnsSpecifier Iterable<BaseEntitlementWithAddOnsSpecifier>, context InternalCallContext) : List<SubscriptionBase> in class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionInternalApi | From | To | |
| Extract Method private verifyAndBuildSubscriptionSpecifiers(bundleId UUID, entitlements Iterable<EntitlementSpecifier>, isMigrated boolean, context InternalCallContext, now DateTime, effectiveDate DateTime, catalog Catalog, callContext CallContext) : List<SubscriptionSpecifier> extracted from public createBaseSubscriptionWithAddOns(bundleId UUID, entitlements Iterable<EntitlementSpecifier>, requestedDateWithMs DateTime, isMigrated boolean, context InternalCallContext) : List<SubscriptionBase> in class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionInternalApi | From | To |