ac39dfd87aa1f974bc00de0278645440d0995c68
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 4
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Inline Method | 1 | ||
| Move And Inline Method protected verifyNumberOfElements(actual int, expected int, errorMessage String) : void moved from class org.killbill.billing.jaxrs.resources.JaxRsResourceBase to class org.killbill.billing.jaxrs.resources.SubscriptionResource & inlined to private createEntitlementsWithAddOnsInternal(entitlementsWithAddOns List<BulkSubscriptionsBundleJson>, requestedDate String, entitlementDate String, billingDate String, isMigrated Boolean, renameKeyIfExistsAndUnused Boolean, callCompletion Boolean, timeoutSec long, pluginPropertiesString List<String>, createdBy String, reason String, comment String, request HttpServletRequest, uriInfo UriInfo, responseObject ObjectType) : Response | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type entitlementSpecifierList : List<EntitlementSpecifier> to entitlementSpecifierList : Iterable<EntitlementSpecifier> in method private buildBaseEntitlementWithAddOnsSpecifier(entitlementSpecifierList Iterable<EntitlementSpecifier>, resolvedEntitlementDate LocalDate, resolvedBillingDate LocalDate, bundleExternalKey String, isMigrated Boolean) : BaseEntitlementWithAddOnsSpecifier in class org.killbill.billing.jaxrs.resources.SubscriptionResource | From | To | |
| Rename Variable | 2 | ||
| Rename Variable baseOrStandalonePlanSpecifier : EntitlementSpecifier to baseOrFirstStandalonePlanSpecifier : EntitlementSpecifier in method public createBaseSubscriptionsWithAddOns(subscriptionWithAddOnsSpecifiers Iterable<SubscriptionBaseWithAddOnsSpecifier>, renameCancelledBundleIfExist boolean, context InternalCallContext) : List<SubscriptionBaseWithAddOns> in class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionInternalApi | From | To | |
| Rename Variable baseOrStandalonePlanSpecifier : EntitlementSpecifier to basePlanSpecifier : EntitlementSpecifier in method private sanityAndReorderBPOrStandaloneSpecFirst(catalog Catalog, subscriptionBaseWithAddOnsSpecifier SubscriptionBaseWithAddOnsSpecifier, effectiveDate DateTime, outputEntitlementSpecifier Collection<EntitlementSpecifier>) : EntitlementSpecifier in class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionInternalApi | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type baseEntitlementWithAddOnsSpecifierList : List<BaseEntitlementWithAddOnsSpecifier> to baseEntitlementWithAddOnsSpecifierList : Collection<BaseEntitlementWithAddOnsSpecifier> in method private createEntitlementsWithAddOnsInternal(entitlementsWithAddOns List<BulkSubscriptionsBundleJson>, requestedDate String, entitlementDate String, billingDate String, isMigrated Boolean, renameKeyIfExistsAndUnused Boolean, callCompletion Boolean, timeoutSec long, pluginPropertiesString List<String>, createdBy String, reason String, comment String, request HttpServletRequest, uriInfo UriInfo, responseObject ObjectType) : Response in class org.killbill.billing.jaxrs.resources.SubscriptionResource | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter baseOrStandalonePlanSpecifier : EntitlementSpecifier to baseOrFirstStandalonePlanSpecifier : EntitlementSpecifier in method private verifyAndBuildSubscriptionSpecifiers(bundle SubscriptionBaseBundle, baseOrFirstStandalonePlanSpecifier EntitlementSpecifier, entitlements Iterable<EntitlementSpecifier>, isMigrated boolean, context InternalCallContext, now DateTime, effectiveDate DateTime, catalog Catalog, callContext CallContext) : List<SubscriptionSpecifier> in class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionInternalApi | From | To |