b18573ac8d010574f26239af23806e4345714532
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 1
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Variable | 2 | ||
| Rename Variable charge : InvoiceItem to inputItem : InvoiceItem in method public prepareInvoices() : Iterable<DefaultInvoice> in class org.killbill.billing.invoice.api.user.DefaultInvoiceUserApi.insertItems.withAccountLock | From | To | |
| Rename Variable creditInvoiceItems : Collection<InvoiceItem> to accountData : ImmutableAccountData in method private insertItems(accountId UUID, effectiveDate LocalDate, itemType InvoiceItemType, inputItems Iterable<InvoiceItem>, autoCommit boolean, context CallContext) : List<InvoiceItem> in class org.killbill.billing.invoice.api.user.DefaultInvoiceUserApi | From | To | |
| Merge Variable | 1 | ||
| Merge Variable [amount : BigDecimal, description : String, itemDetails : String] to inputItem : InvoiceItem in method public prepareInvoices() : Iterable<DefaultInvoice> in class org.killbill.billing.invoice.api.user.DefaultInvoiceUserApi.insertItems.withAccountLock | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type creditInvoiceItems : Collection<InvoiceItem> to accountData : ImmutableAccountData in method private insertItems(accountId UUID, effectiveDate LocalDate, itemType InvoiceItemType, inputItems Iterable<InvoiceItem>, autoCommit boolean, context CallContext) : List<InvoiceItem> in class org.killbill.billing.invoice.api.user.DefaultInvoiceUserApi | From | To | |
| Extract Variable | 1 | ||
| Extract Variable accountCurrency : Currency in method public prepareInvoices() : Iterable<DefaultInvoice> from class org.killbill.billing.invoice.api.user.DefaultInvoiceUserApi.insertItems.withAccountLock | From | To | |
| Extract Method | 2 | ||
| Extract Method private insertItems(accountId UUID, effectiveDate LocalDate, itemType InvoiceItemType, inputItems Iterable<InvoiceItem>, autoCommit boolean, context CallContext) : List<InvoiceItem> extracted from private insertCreditForInvoice(accountId UUID, invoiceId UUID, amount BigDecimal, effectiveDate LocalDate, currency Currency, autoCommit boolean, description String, itemDetails String, context CallContext) : InvoiceItem in class org.killbill.billing.invoice.api.user.DefaultInvoiceUserApi | From | To | |
| Extract Method private insertItems(accountId UUID, effectiveDate LocalDate, itemType InvoiceItemType, inputItems Iterable<InvoiceItem>, autoCommit boolean, context CallContext) : List<InvoiceItem> extracted from public insertExternalCharges(accountId UUID, effectiveDate LocalDate, charges Iterable<InvoiceItem>, autoCommit boolean, context CallContext) : List<InvoiceItem> in class org.killbill.billing.invoice.api.user.DefaultInvoiceUserApi | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter charges : Iterable<InvoiceItem> to inputItems : Iterable<InvoiceItem> in method private insertItems(accountId UUID, effectiveDate LocalDate, itemType InvoiceItemType, inputItems Iterable<InvoiceItem>, autoCommit boolean, context CallContext) : List<InvoiceItem> in class org.killbill.billing.invoice.api.user.DefaultInvoiceUserApi | From | To |