bd4d80e937f6c1405be8762408da15c45814766d
Files Diff
- Added: 26
- Removed: 0
- Renamed: 0
- Modified: 19
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private getOrCreateOverridePhaseDefinitionFromTransaction(parentPhaseName String, catalogEffectiveDate DateTime, override PlanPhasePriceOverride, inTransactionHandle Handle, context InternalCallContext) : CatalogOverridePhaseDefinitionModelDao renamed to private getOrCreateOverriddenBlockDefinitionFromTransaction(tieredBlockPriceOverride TieredBlockPriceOverride, catalogEffectiveDate DateTime, currency String, inTransactionHandle Handle, context InternalCallContext) : CatalogOverrideBlockDefinitionModelDao in class org.killbill.billing.catalog.dao.DefaultCatalogOverrideDao | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type parentPlanName : String to parentPlan : Plan in method public getOrCreateOverridePlanDefinition(parentPlan Plan, catalogEffectiveDate DateTime, resolvedOverride PlanPhasePriceOverride[], context InternalCallContext) : CatalogOverridePlanDefinitionModelDao in class org.killbill.billing.catalog.dao.DefaultCatalogOverrideDao | From | To | |
| Change Parameter Type parentPlanName : String to parentPlan : Plan in method public getOrCreateOverridePlanDefinition(parentPlan Plan, catalogEffectiveDate DateTime, resolvedOverride PlanPhasePriceOverride[], context InternalCallContext) : CatalogOverridePlanDefinitionModelDao in class org.killbill.billing.catalog.dao.CatalogOverrideDao | From | To | |
| Rename Variable | 1 | ||
| Rename Variable phaseDef : CatalogOverridePhaseDefinitionModelDao to blockDef : CatalogOverrideBlockDefinitionModelDao in method private getOrCreateOverriddenBlockDefinitionFromTransaction(tieredBlockPriceOverride TieredBlockPriceOverride, catalogEffectiveDate DateTime, currency String, inTransactionHandle Handle, context InternalCallContext) : CatalogOverrideBlockDefinitionModelDao in class org.killbill.billing.catalog.dao.DefaultCatalogOverrideDao | From | To | |
| Change Return Type | 2 | ||
| Change Return Type CatalogOverridePhaseDefinitionModelDao to List<CatalogOverridePhaseDefinitionModelDao> in method public getByAttributes(parentPhaseName String, currency String, fixedPrice BigDecimal, recurringPrice BigDecimal, context InternalTenantContext) : List<CatalogOverridePhaseDefinitionModelDao> in class org.killbill.billing.catalog.dao.CatalogOverridePhaseDefinitionSqlDao | From | To | |
| Change Return Type CatalogOverridePhaseDefinitionModelDao to CatalogOverrideBlockDefinitionModelDao in method private getOrCreateOverriddenBlockDefinitionFromTransaction(tieredBlockPriceOverride TieredBlockPriceOverride, catalogEffectiveDate DateTime, currency String, inTransactionHandle Handle, context InternalCallContext) : CatalogOverrideBlockDefinitionModelDao in class org.killbill.billing.catalog.dao.DefaultCatalogOverrideDao | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type sqlDao : CatalogOverridePhaseDefinitionSqlDao to sqlDao : CatalogOverrideBlockDefinitionSqlDao in method private getOrCreateOverriddenBlockDefinitionFromTransaction(tieredBlockPriceOverride TieredBlockPriceOverride, catalogEffectiveDate DateTime, currency String, inTransactionHandle Handle, context InternalCallContext) : CatalogOverrideBlockDefinitionModelDao in class org.killbill.billing.catalog.dao.DefaultCatalogOverrideDao | From | To | |
| Change Variable Type result : CatalogOverridePhaseDefinitionModelDao to result : CatalogOverrideBlockDefinitionModelDao in method private getOrCreateOverriddenBlockDefinitionFromTransaction(tieredBlockPriceOverride TieredBlockPriceOverride, catalogEffectiveDate DateTime, currency String, inTransactionHandle Handle, context InternalCallContext) : CatalogOverrideBlockDefinitionModelDao in class org.killbill.billing.catalog.dao.DefaultCatalogOverrideDao | From | To | |
| Change Variable Type phaseDef : CatalogOverridePhaseDefinitionModelDao to blockDef : CatalogOverrideBlockDefinitionModelDao in method private getOrCreateOverriddenBlockDefinitionFromTransaction(tieredBlockPriceOverride TieredBlockPriceOverride, catalogEffectiveDate DateTime, currency String, inTransactionHandle Handle, context InternalCallContext) : CatalogOverrideBlockDefinitionModelDao in class org.killbill.billing.catalog.dao.DefaultCatalogOverrideDao | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter parentPlanName : String to parentPlan : Plan in method public getOrCreateOverridePlanDefinition(parentPlan Plan, catalogEffectiveDate DateTime, resolvedOverride PlanPhasePriceOverride[], context InternalCallContext) : CatalogOverridePlanDefinitionModelDao in class org.killbill.billing.catalog.dao.DefaultCatalogOverrideDao | From | To | |
| Rename Parameter parentPhaseName : String to currency : String in method private getOrCreateOverriddenBlockDefinitionFromTransaction(tieredBlockPriceOverride TieredBlockPriceOverride, catalogEffectiveDate DateTime, currency String, inTransactionHandle Handle, context InternalCallContext) : CatalogOverrideBlockDefinitionModelDao in class org.killbill.billing.catalog.dao.DefaultCatalogOverrideDao | From | To | |
| Rename Parameter parentPlanName : String to parentPlan : Plan in method public getOrCreateOverridePlanDefinition(parentPlan Plan, catalogEffectiveDate DateTime, resolvedOverride PlanPhasePriceOverride[], context InternalCallContext) : CatalogOverridePlanDefinitionModelDao in class org.killbill.billing.catalog.dao.CatalogOverrideDao | From | To |