ccc6808731e8bc8c1b5334d96b82f9aafb371933
Files Diff
- Added: 1
- Removed: 1
- Renamed: 0
- Modified: 42
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method public getPlanPhaseSpecifier() : PlanPhaseSpecifier renamed to public getEntitlementSpecifier() : EntitlementSpecifier in class org.killbill.billing.jaxrs.resources.InvoiceResource.DefaultDryRunArguments | From | To | |
| Rename Method public getPlanPhaseSpecifier() : PlanPhaseSpecifier renamed to public getEntitlementSpecifier() : EntitlementSpecifier in class org.killbill.billing.beatrix.integration.TestIntegrationBase.TestDryRunArguments | From | To | |
| Rename Method public getPlanPhaseSpecifier() : PlanPhaseSpecifier renamed to public getEntitlementSpecifier() : EntitlementSpecifier in class org.killbill.billing.invoice.InvoiceDispatcher.TargetDateDryRunArguments | From | To | |
| Rename Method public getPlanPhaseSpecifier() : PlanPhaseSpecifier renamed to public getEntitlementSpecifier() : EntitlementSpecifier in class org.killbill.billing.invoice.TestInvoiceHelper.DryRunFutureDateArguments | From | To | |
| Change Parameter Type | 24 | ||
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public changePlan(spec EntitlementSpecifier, context CallContext) : DateTime in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBase | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public dryRunChangePlan(subscription DefaultSubscriptionBase, spec EntitlementSpecifier, requestedDateWithMs DateTime, requestedPolicy BillingActionPolicy, context TenantContext) : DateTime in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method private doChangePlan(subscription DefaultSubscriptionBase, spec EntitlementSpecifier, effectiveDate DateTime, context CallContext) : void in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public changePlan(spec EntitlementSpecifier, properties Iterable<PluginProperty>, callContext CallContext) : Entitlement in class org.killbill.billing.entitlement.api.DefaultEntitlement | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public changePlanOverrideBillingPolicy(spec EntitlementSpecifier, unused LocalDate, actionPolicy BillingActionPolicy, properties Iterable<PluginProperty>, callContext CallContext) : Entitlement in class org.killbill.billing.entitlement.api.DefaultEntitlement | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public dryRunChangePlan(subscription DefaultSubscriptionBase, spec EntitlementSpecifier, requestedDate DateTime, policy BillingActionPolicy, context TenantContext) : DateTime in class org.killbill.billing.subscription.api.SubscriptionBaseApiService | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public changePlanWithPolicy(subscription DefaultSubscriptionBase, spec EntitlementSpecifier, policy BillingActionPolicy, context CallContext) : DateTime in class org.killbill.billing.subscription.api.SubscriptionBaseApiService | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public getDryRunChangePlanEffectiveDate(subscription SubscriptionBase, spec EntitlementSpecifier, requestedDateWithMs DateTime, requestedPolicy BillingActionPolicy, context InternalCallContext) : DateTime in class org.killbill.billing.subscription.api.svcs.DefaultSubscriptionInternalApi | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public changePlan(subscription DefaultSubscriptionBase, spec EntitlementSpecifier, context CallContext) : DateTime in class org.killbill.billing.subscription.api.SubscriptionBaseApiService | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public changePlanWithRequestedDate(subscription DefaultSubscriptionBase, spec EntitlementSpecifier, requestedDateWithMs DateTime, context CallContext) : DateTime in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public changePlanWithPolicy(subscription DefaultSubscriptionBase, spec EntitlementSpecifier, policy BillingActionPolicy, context CallContext) : DateTime in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public createDryRunArguments(subscriptionId UUID, bundleId UUID, spec EntitlementSpecifier, requestedDate LocalDate, type SubscriptionEventType, billingActionPolicy BillingActionPolicy) : DryRunArguments in class org.killbill.billing.subscription.api.user.TestSubscriptionHelper | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public changePlanWithPolicy(spec EntitlementSpecifier, policy BillingActionPolicy, context CallContext) : DateTime in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBase | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public getDryRunChangePlanEffectiveDate(subscription SubscriptionBase, spec EntitlementSpecifier, requestedDate DateTime, policy BillingActionPolicy, context InternalCallContext) : DateTime in class org.killbill.billing.subscription.api.SubscriptionBaseInternalApi | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public changePlan(spec EntitlementSpecifier, context CallContext) : DateTime in class org.killbill.billing.mock.MockSubscription | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public changePlanWithDate(spec EntitlementSpecifier, effectiveDate LocalDate, properties Iterable<PluginProperty>, callContext CallContext) : Entitlement in class org.killbill.billing.entitlement.api.DefaultEntitlement | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public changePlanWithPolicy(spec EntitlementSpecifier, policy BillingActionPolicy, context CallContext) : DateTime in class org.killbill.billing.subscription.api.SubscriptionBase | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public changePlan(subscription DefaultSubscriptionBase, spec EntitlementSpecifier, context CallContext) : DateTime in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public changePlanWithDate(spec EntitlementSpecifier, requestedDate DateTime, context CallContext) : DateTime in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBase | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public changePlanWithPolicy(spec EntitlementSpecifier, policy BillingActionPolicy, context CallContext) : DateTime in class org.killbill.billing.mock.MockSubscription | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public changePlanWithRequestedDate(subscription DefaultSubscriptionBase, spec EntitlementSpecifier, requestedDate DateTime, context CallContext) : DateTime in class org.killbill.billing.subscription.api.SubscriptionBaseApiService | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public changePlanWithDate(spec EntitlementSpecifier, requestedDate DateTime, context CallContext) : DateTime in class org.killbill.billing.subscription.api.SubscriptionBase | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public changePlan(spec EntitlementSpecifier, context CallContext) : DateTime in class org.killbill.billing.subscription.api.SubscriptionBase | From | To | |
| Change Parameter Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in method public changePlanWithDate(spec EntitlementSpecifier, requestedDate DateTime, context CallContext) : DateTime in class org.killbill.billing.mock.MockSubscription | From | To | |
| Rename Variable | 2 | ||
| Rename Variable spec : PlanPhaseSpecifier to planPhaseSpecifier : PlanPhaseSpecifier in method private doChangePlan(subscription DefaultSubscriptionBase, spec EntitlementSpecifier, effectiveDate DateTime, context CallContext) : void in class org.killbill.billing.subscription.api.user.DefaultSubscriptionBaseApiService | From | To | |
| Rename Variable spec : PlanPhaseSpecifier to planPhaseSpecifier : PlanPhaseSpecifier in method public testCancelWithEntitlementDate() : void in class org.killbill.billing.entitlement.api.TestDefaultEntitlement | From | To | |
| Move Source Folder | 1 | ||
| Move Source Folder entitlement to api | From | To | |
| Change Return Type | 4 | ||
| Change Return Type PlanPhaseSpecifier to EntitlementSpecifier in method public getEntitlementSpecifier() : EntitlementSpecifier in class org.killbill.billing.jaxrs.resources.InvoiceResource.DefaultDryRunArguments | From | To | |
| Change Return Type PlanPhaseSpecifier to EntitlementSpecifier in method public getEntitlementSpecifier() : EntitlementSpecifier in class org.killbill.billing.beatrix.integration.TestIntegrationBase.TestDryRunArguments | From | To | |
| Change Return Type PlanPhaseSpecifier to EntitlementSpecifier in method public getEntitlementSpecifier() : EntitlementSpecifier in class org.killbill.billing.invoice.InvoiceDispatcher.TargetDateDryRunArguments | From | To | |
| Change Return Type PlanPhaseSpecifier to EntitlementSpecifier in method public getEntitlementSpecifier() : EntitlementSpecifier in class org.killbill.billing.invoice.TestInvoiceHelper.DryRunFutureDateArguments | From | To | |
| Merge Parameter | 1 | ||
| Merge Parameter [spec : PlanSpecifier, overrides : List<PlanPhasePriceOverride>] to entitlementSpecifier : EntitlementSpecifier in method public logChangePlan(log Logger, entitlement Entitlement, entitlementSpecifier EntitlementSpecifier, entitlementEffectiveDate LocalDate, actionPolicy BillingActionPolicy) : void in class org.killbill.billing.entitlement.logging.EntitlementLoggingHelper | From | To | |
| Extract Variable | 35 | ||
| Extract Variable spec1 : PlanPhaseSpecifier in method public testBlockedEntitlementChange() : void from class org.killbill.billing.entitlement.api.TestDefaultSubscriptionApi | From | To | |
| Extract Variable spec2 : PlanPhaseSpecifier in method public testInvoiceNotificationWithFutureSubscriptionEvents() : void from class org.killbill.billing.beatrix.integration.TestInvoiceNotifications | From | To | |
| Extract Variable planPhaseSpecifier : PlanPhaseSpecifier in method public testChangePlanOnCreate() : void from class org.killbill.billing.subscription.api.user.TestUserApiChangePlan | From | To | |
| Extract Variable planPhaseSpecifier : PlanPhaseSpecifier in method public testChangeSubscriptionNonActive() : void from class org.killbill.billing.subscription.api.user.TestUserApiError | From | To | |
| Extract Variable planPhaseSpecifier : PlanPhaseSpecifier in method private tChangePlanBundleAlignIMM(fromProd String, fromTerm BillingPeriod, fromPlanSet String, toProd String, toTerm BillingPeriod, toPlanSet String) : void from class org.killbill.billing.subscription.api.user.TestUserApiChangePlan | From | To | |
| Extract Variable spec : PlanPhaseSpecifier in method public testChangePlanEOTWith2AddOns() : void from class org.killbill.billing.entitlement.engine.core.TestEntitlementUtils | From | To | |
| Extract Variable planPhaseSpecifier : PlanPhaseSpecifier in method public testCorrectPhaseAlignmentOnChange() : void from class org.killbill.billing.subscription.api.user.TestUserApiChangePlan | From | To | |
| Extract Variable planPhaseSpecifier : PlanPhaseSpecifier in method private tChangePlanChangePlanAlignEOTWithChargeThroughDate(fromProd String, fromTerm BillingPeriod, fromPlanSet String, toProd String, toTerm BillingPeriod, toPlanSet String) : void from class org.killbill.billing.subscription.api.user.TestUserApiChangePlan | From | To | |
| Extract Variable spec : PlanPhaseSpecifier in method public testChangePlanEOT() : void from class org.killbill.billing.entitlement.engine.core.TestEntitlementUtils | From | To | |
| Extract Variable spec : PlanPhaseSpecifier in method private checkChangePlanWithOverdueState(entitlement Entitlement, shouldFail boolean, expectedPayment boolean) : void from class org.killbill.billing.beatrix.integration.overdue.TestOverdueIntegration | From | To | |
| Extract Variable planPhaseSpecifier1 : PlanPhaseSpecifier in method public testTransferBPNoTrialWithCTD() : void from class org.killbill.billing.subscription.api.transfer.TestTransfer | From | To | |
| Extract Variable spec : PlanPhaseSpecifier in method public testChangePlanWithRecurringPriceOverride() : void from class org.killbill.billing.beatrix.integration.TestWithPriceOverride | From | To | |
| Extract Variable planPhaseSpecifier : PlanPhaseSpecifier in method public testCancelWithEntitlementPolicyEOTNoCTDAndImmediateChange() : void from class org.killbill.billing.entitlement.api.TestDefaultEntitlement | From | To | |
| Extract Variable planPhaseSpecifier : PlanPhaseSpecifier in method public testTransferBPNoTrialWithCTD() : void from class org.killbill.billing.subscription.api.transfer.TestTransfer | From | To | |
| Extract Variable planPhaseSpecifier : PlanPhaseSpecifier in method public testChangePlanRightAfterCreate() : void from class org.killbill.billing.subscription.api.user.TestUserApiChangePlan | From | To | |
| Extract Variable planPhaseSpecifier : PlanPhaseSpecifier in method public testChangeBPWithAddonNonAvailable() : void from class org.killbill.billing.subscription.api.user.TestUserApiAddOn | From | To | |
| Extract Variable planPhaseSpecifier : PlanPhaseSpecifier in method private tChangePlanBundleAlignEOTWithNoChargeThroughDate(fromProd String, fromTerm BillingPeriod, fromPlanSet String, toProd String, toTerm BillingPeriod, toPlanSet String) : void from class org.killbill.billing.subscription.api.user.TestUserApiChangePlan | From | To | |
| Extract Variable planPhaseSpecifier1 : PlanPhaseSpecifier in method public testMultipleChangeLastIMM() : void from class org.killbill.billing.subscription.api.user.TestUserApiChangePlan | From | To | |
| Extract Variable planPhaseSpecifier : PlanPhaseSpecifier in method private testChangePlanBundleAlignEOTWithChargeThroughDate(fromProd String, fromTerm BillingPeriod, fromPlanSet String, toProd String, toTerm BillingPeriod, toPlanSet String) : void from class org.killbill.billing.subscription.api.user.TestUserApiChangePlan | From | To | |
| Extract Variable spec : PlanPhaseSpecifier in method public testParentInvoiceGenerationMultipleActionsSameDay() : void from class org.killbill.billing.beatrix.integration.TestIntegrationParentInvoice | From | To | |
| Extract Variable planPhaseSpecifier : PlanPhaseSpecifier in method public testUndoChangePlan() : void from class org.killbill.billing.subscription.api.user.TestUserApiChangePlan | From | To | |
| Extract Variable spec : PlanPhaseSpecifier in method public apply(dontcare Void) : Entitlement from class org.killbill.billing.beatrix.integration.TestIntegrationBase.changeEntitlementAndCheckForCompletion.doCallAndCheckForCompletion | From | To | |
| Extract Variable spec : PlanPhaseSpecifier in method public testChangePlanWithRecurringPriceOverrideAndSamePlan() : void from class org.killbill.billing.beatrix.integration.TestWithPriceOverride | From | To | |
| Extract Variable planPhaseSpecifier : PlanPhaseSpecifier in method public testMultipleChangeLastIMM() : void from class org.killbill.billing.subscription.api.user.TestUserApiChangePlan | From | To | |
| Extract Variable planPhaseSpecifier : PlanPhaseSpecifier in method public testUndoChangePlanOnPendingSubscription() : void from class org.killbill.billing.subscription.api.user.TestUserApiChangePlan | From | To | |
| Extract Variable planPhaseSpecifier : PlanPhaseSpecifier in method public testChangeSubscriptionFutureCancelled() : void from class org.killbill.billing.subscription.api.user.TestUserApiError | From | To | |
| Extract Variable spec2 : PlanPhaseSpecifier in method public testBlockedEntitlementChange() : void from class org.killbill.billing.entitlement.api.TestDefaultSubscriptionApi | From | To | |
| Extract Variable spec : PlanPhaseSpecifier in method public testBasic() : void from class org.killbill.billing.beatrix.integration.TestIntegrationWithCatalogUpdate | From | To | |
| Extract Variable planPhaseSpecifier1 : PlanPhaseSpecifier in method public testMultipleChangeLastEOT() : void from class org.killbill.billing.subscription.api.user.TestUserApiChangePlan | From | To | |
| Extract Variable planPhaseSpecifier : PlanPhaseSpecifier in method public testChangeBPWithAddonIncluded() : void from class org.killbill.billing.subscription.api.user.TestUserApiAddOn | From | To | |
| Extract Variable spec : PlanPhaseSpecifier in method public testChangePlanIMM() : void from class org.killbill.billing.entitlement.engine.core.TestEntitlementUtils | From | To | |
| Extract Variable planPhaseSpecifier : PlanPhaseSpecifier in method public testChangeSubscriptionWithPolicy() : void from class org.killbill.billing.subscription.api.user.TestUserApiError | From | To | |
| Extract Variable planPhaseSpecifier : PlanPhaseSpecifier in method public testInvalidChangesAcrossProductTypes() : void from class org.killbill.billing.subscription.api.user.TestUserApiChangePlan | From | To | |
| Extract Variable planPhaseSpecifier : PlanPhaseSpecifier in method public testMultipleChangeLastEOT() : void from class org.killbill.billing.subscription.api.user.TestUserApiChangePlan | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type spec : PlanPhaseSpecifier to spec : EntitlementSpecifier in class org.killbill.billing.beatrix.integration.TestIntegrationBase.TestDryRunArguments | From | To | |
| Change Attribute Type specifier : PlanPhaseSpecifier to specifier : EntitlementSpecifier in class org.killbill.billing.jaxrs.resources.InvoiceResource.DefaultDryRunArguments | From | To |