daccdf6ed88d9bc9feea0d3ae088db5416fb31b1
Files Diff
- Added: 2
- Removed: 1
- Renamed: 0
- Modified: 11
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 3 | ||
| Change Parameter Type amounts : List<BigDecimal> to amounts : Iterable<BigDecimal> in method public createAndPersistInvoice(testInvoiceHelper TestInvoiceHelper, invoiceDao InvoiceDao, clock Clock, amounts Iterable<BigDecimal>, currency Currency, internalCallContext InternalCallContext) : Invoice in class org.killbill.billing.invoice.tests.InvoiceTestUtils | From | To | |
| Change Parameter Type entitySqlDaoWrapperFactory : EntitySqlDaoWrapperFactory<EntitySqlDao> to entitySqlDaoWrapperFactory : EntitySqlDaoWrapperFactory in method public createAdjustmentItem(entitySqlDaoWrapperFactory EntitySqlDaoWrapperFactory, invoiceId UUID, invoiceItemId UUID, positiveAdjAmount BigDecimal, currency Currency, effectiveDate LocalDate, context InternalCallContext) : InvoiceItemModelDao in class org.killbill.billing.invoice.dao.InvoiceDaoHelper | From | To | |
| Change Parameter Type subscriptionBaseApi : SubscriptionBaseInternalApi to invoiceApiHelper : InvoiceApiHelper in method public DefaultInvoiceInternalApi(dao InvoiceDao, invoiceApiHelper InvoiceApiHelper, internalCallContextFactory InternalCallContextFactory) in class org.killbill.billing.invoice.api.svcs.DefaultInvoiceInternalApi | From | To | |
| Move Method | 3 | ||
| Move Method private toInvoiceItemModelDao(invoiceItems Collection<InvoiceItem>) : List<InvoiceItemModelDao> from class org.killbill.billing.invoice.api.user.DefaultInvoiceUserApi to private toInvoiceItemModelDao(invoiceItems Collection<InvoiceItem>) : List<InvoiceItemModelDao> from class org.killbill.billing.invoice.api.InvoiceApiHelper | From | To | |
| Move Method private fromInvoiceItemModelDao(invoiceItemModelDaos Collection<InvoiceItemModelDao>) : List<InvoiceItem> from class org.killbill.billing.invoice.api.user.DefaultInvoiceUserApi to private fromInvoiceItemModelDao(invoiceItemModelDaos Collection<InvoiceItemModelDao>) : List<InvoiceItem> from class org.killbill.billing.invoice.api.InvoiceApiHelper | From | To | |
| Move Method private dispatchToInvoicePluginsAndInsertItems(accountId UUID, withAccountLock WithAccountLock, context CallContext) : List<InvoiceItem> from class org.killbill.billing.invoice.api.user.DefaultInvoiceUserApi to public dispatchToInvoicePluginsAndInsertItems(accountId UUID, withAccountLock WithAccountLock, context CallContext) : List<InvoiceItem> from class org.killbill.billing.invoice.api.InvoiceApiHelper | From | To | |
| Rename Variable | 1 | ||
| Rename Variable invoiceForCredit : Invoice to invoice : Invoice in method private getInvoiceAndCheckCurrency(invoiceId UUID, currency Currency, context TenantContext) : Invoice in class org.killbill.billing.invoice.api.user.DefaultInvoiceUserApi | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private NB_LOCK_TRY : int from class org.killbill.billing.invoice.api.user.DefaultInvoiceUserApi to private NB_LOCK_TRY : int from class org.killbill.billing.invoice.api.InvoiceApiHelper | From | To | |
| Move Attribute private locker : GlobalLocker from class org.killbill.billing.invoice.api.user.DefaultInvoiceUserApi to private locker : GlobalLocker from class org.killbill.billing.invoice.api.InvoiceApiHelper | From | To | |
| Move Attribute private invoicePluginDispatcher : InvoicePluginDispatcher from class org.killbill.billing.invoice.api.user.DefaultInvoiceUserApi to private invoicePluginDispatcher : InvoicePluginDispatcher from class org.killbill.billing.invoice.api.InvoiceApiHelper | From | To | |
| Extract Class | 1 | ||
| Extract Class org.killbill.billing.invoice.api.InvoiceApiHelper from class org.killbill.billing.invoice.api.user.DefaultInvoiceUserApi | From | To | |
| Move Class | 1 | ||
| Move Class org.killbill.billing.invoice.api.user.DefaultInvoiceUserApi.WithAccountLock moved to org.killbill.billing.invoice.api.WithAccountLock | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute subscriptionBaseApi : SubscriptionBaseInternalApi to invoiceApiHelper : InvoiceApiHelper in class org.killbill.billing.invoice.api.svcs.DefaultInvoiceInternalApi | From | To | |
| Rename Attribute nextBillingDatePoster : NextBillingDatePoster to internalCallContextFactory : InternalCallContextFactory in class org.killbill.billing.invoice.api.svcs.DefaultInvoiceInternalApi | From | To | |
| Extract Variable | 1 | ||
| Extract Variable refund : InvoicePaymentModelDao in method public createRefund(paymentId UUID, amount BigDecimal, isInvoiceAdjusted boolean, invoiceItemIdsWithAmounts Map<UUID,BigDecimal>, transactionExternalKey String, context InternalCallContext) : InvoicePayment from class org.killbill.billing.invoice.api.svcs.DefaultInvoiceInternalApi | From | To | |
| Extract Method | 1 | ||
| Extract Method private getInvoiceAndCheckCurrency(invoiceId UUID, currency Currency, context TenantContext) : Invoice extracted from public insertCreditForInvoice(accountId UUID, invoiceId UUID, amount BigDecimal, effectiveDate LocalDate, currency Currency, context CallContext) : InvoiceItem in class org.killbill.billing.invoice.api.user.DefaultInvoiceUserApi | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type nextBillingDatePoster : NextBillingDatePoster to internalCallContextFactory : InternalCallContextFactory in class org.killbill.billing.invoice.api.svcs.DefaultInvoiceInternalApi | From | To | |
| Change Attribute Type subscriptionBaseApi : SubscriptionBaseInternalApi to invoiceApiHelper : InvoiceApiHelper in class org.killbill.billing.invoice.api.svcs.DefaultInvoiceInternalApi | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter subscriptionBaseApi : SubscriptionBaseInternalApi to invoiceApiHelper : InvoiceApiHelper in method public DefaultInvoiceInternalApi(dao InvoiceDao, invoiceApiHelper InvoiceApiHelper, internalCallContextFactory InternalCallContextFactory) in class org.killbill.billing.invoice.api.svcs.DefaultInvoiceInternalApi | From | To |