daf32c1eac2ce6ce92ef2aa871afde50eaf4f0b1
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 5
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 3 | ||
| Pull Up Method public getAllEntitlementsForAccountId(accountId UUID, tenantContext TenantContext) : AccountEntitlements from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementInternalApi to public getAllEntitlementsForAccountId(accountId UUID, tenantContext InternalTenantContext) : AccountEntitlements from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementApiBase | From | To | |
| Pull Up Method public DefaultEntitlementInternalApi(entitlementApi EntitlementApi, pluginExecution EntitlementPluginExecution, internalCallContextFactory InternalCallContextFactory, subscriptionInternalApi SubscriptionBaseInternalApi, accountApi AccountInternalApi, blockingStateDao BlockingStateDao, clock Clock, checker BlockingChecker, notificationQueueService NotificationQueueService, eventsStreamBuilder EventsStreamBuilder, entitlementUtils EntitlementUtils, securityApi SecurityApi) from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementInternalApi to protected DefaultEntitlementApiBase(eventBus PersistentBus, entitlementApi EntitlementApi, pluginExecution EntitlementPluginExecution, internalCallContextFactory InternalCallContextFactory, subscriptionInternalApi SubscriptionBaseInternalApi, accountApi AccountInternalApi, blockingStateDao BlockingStateDao, clock Clock, checker BlockingChecker, notificationQueueService NotificationQueueService, eventsStreamBuilder EventsStreamBuilder, entitlementUtils EntitlementUtils, securityApi SecurityApi) from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementApiBase | From | To | |
| Pull Up Method private recordPauseResumeNotificationEntry(entitlementId UUID, bundleId UUID, effectiveDate DateTime, isPause boolean, contextWithValidAccountRecordId InternalCallContext) : void from class org.killbill.billing.entitlement.api.DefaultEntitlementApi to protected recordPauseResumeNotificationEntry(entitlementId UUID, bundleId UUID, effectiveDate DateTime, isPause boolean, contextWithValidAccountRecordId InternalCallContext) : void from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementApiBase | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type entitlementApi : EntitlementApi to entitlementInternalApi : EntitlementInternalApi in method public DefaultEntitlementService(entitlementInternalApi EntitlementInternalApi, blockingStateDao BlockingStateDao, eventBus PersistentBus, notificationQueueService NotificationQueueService, internalCallContextFactory InternalCallContextFactory) in class org.killbill.billing.entitlement.DefaultEntitlementService | From | To | |
| Change Parameter Type tenantContext : TenantContext to tenantContext : InternalTenantContext in method public getAllEntitlementsForAccountId(accountId UUID, tenantContext InternalTenantContext) : AccountEntitlements in class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementApiBase | From | To | |
| Pull Up Attribute | 12 | ||
| Pull Up Attribute private dateHelper : EntitlementDateHelper from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementInternalApi to protected dateHelper : EntitlementDateHelper from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementApiBase | From | To | |
| Pull Up Attribute private checker : BlockingChecker from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementInternalApi to protected checker : BlockingChecker from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementApiBase | From | To | |
| Pull Up Attribute private eventsStreamBuilder : EventsStreamBuilder from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementInternalApi to protected eventsStreamBuilder : EventsStreamBuilder from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementApiBase | From | To | |
| Pull Up Attribute private entitlementApi : EntitlementApi from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementInternalApi to protected entitlementApi : EntitlementApi from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementApiBase | From | To | |
| Pull Up Attribute private blockingStateDao : BlockingStateDao from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementInternalApi to protected blockingStateDao : BlockingStateDao from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementApiBase | From | To | |
| Pull Up Attribute private internalCallContextFactory : InternalCallContextFactory from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementInternalApi to protected internalCallContextFactory : InternalCallContextFactory from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementApiBase | From | To | |
| Pull Up Attribute private entitlementUtils : EntitlementUtils from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementInternalApi to protected entitlementUtils : EntitlementUtils from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementApiBase | From | To | |
| Pull Up Attribute private notificationQueueService : NotificationQueueService from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementInternalApi to protected notificationQueueService : NotificationQueueService from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementApiBase | From | To | |
| Pull Up Attribute private clock : Clock from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementInternalApi to protected clock : Clock from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementApiBase | From | To | |
| Pull Up Attribute private pluginExecution : EntitlementPluginExecution from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementInternalApi to protected pluginExecution : EntitlementPluginExecution from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementApiBase | From | To | |
| Pull Up Attribute private subscriptionInternalApi : SubscriptionBaseInternalApi from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementInternalApi to protected subscriptionInternalApi : SubscriptionBaseInternalApi from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementApiBase | From | To | |
| Pull Up Attribute private securityApi : SecurityApi from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementInternalApi to protected securityApi : SecurityApi from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementApiBase | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private entitlementApi : EntitlementApi from class org.killbill.billing.entitlement.DefaultEntitlementService to protected entitlementApi : EntitlementApi from class org.killbill.billing.entitlement.api.svcs.DefaultEntitlementApiBase | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.killbill.billing.entitlement.api.svcs.DefaultEntitlementApiBase from classes [org.killbill.billing.entitlement.api.DefaultEntitlementApi, org.killbill.billing.entitlement.api.svcs.DefaultEntitlementInternalApi] | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute entitlementApi : EntitlementApi to entitlementInternalApi : EntitlementInternalApi in class org.killbill.billing.entitlement.DefaultEntitlementService | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type entitlementApi : EntitlementApi to entitlementInternalApi : EntitlementInternalApi in class org.killbill.billing.entitlement.DefaultEntitlementService | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter context : TenantContext to tenantContext : TenantContext in method public getSubscriptionBundle(bundleId UUID, tenantContext TenantContext) : SubscriptionBundle in class org.killbill.billing.entitlement.api.DefaultSubscriptionApi | From | To | |
| Rename Parameter context : TenantContext to tenantContext : TenantContext in method public getSubscriptionForEntitlementId(entitlementId UUID, tenantContext TenantContext) : Subscription in class org.killbill.billing.entitlement.api.DefaultSubscriptionApi | From | To | |
| Rename Parameter entitlementApi : EntitlementApi to entitlementInternalApi : EntitlementInternalApi in method public DefaultEntitlementService(entitlementInternalApi EntitlementInternalApi, blockingStateDao BlockingStateDao, eventBus PersistentBus, notificationQueueService NotificationQueueService, internalCallContextFactory InternalCallContextFactory) in class org.killbill.billing.entitlement.DefaultEntitlementService | From | To | |
| Rename Parameter uuid : UUID to entitlementId : UUID in method public getEntitlementForId(entitlementId UUID, tenantContext TenantContext) : Entitlement in class org.killbill.billing.entitlement.api.DefaultEntitlementApi | From | To |