ea74c1761d512d809828af41c5a744214fb96788
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 6
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public addCBAComplexityFromTransaction(entitySqlDaoWrapperFactory EntitySqlDaoWrapperFactory, context InternalCallContext) : void renamed to private useExistingCBAFromTransaction(accountCBA BigDecimal, entitySqlDaoWrapperFactory EntitySqlDaoWrapperFactory, context InternalCallContext) : void in class org.killbill.billing.invoice.dao.CBADao | From | To | |
| Rename Method public addCBAComplexityFromTransaction(invoiceId UUID, entitySqlDaoWrapperFactory EntitySqlDaoWrapperFactory, context InternalCallContext) : void renamed to public doCBAComplexityFromTransaction(invoiceId UUID, entitySqlDaoWrapperFactory EntitySqlDaoWrapperFactory, context InternalCallContext) : void in class org.killbill.billing.invoice.dao.CBADao | From | To | |
| Rename Variable | 1 | ||
| Rename Variable cur : InvoiceModelDao to unpaidInvoice : InvoiceModelDao in method private useExistingCBAFromTransaction(accountCBA BigDecimal, entitySqlDaoWrapperFactory EntitySqlDaoWrapperFactory, context InternalCallContext) : void in class org.killbill.billing.invoice.dao.CBADao | From | To | |
| Inline Method | 1 | ||
| Inline Method private useExistingCBAFromTransaction(invoices List<InvoiceModelDao>, entitySqlDaoWrapperFactory EntitySqlDaoWrapperFactory, context InternalCallContext) : void inlined to private useExistingCBAFromTransaction(accountCBA BigDecimal, entitySqlDaoWrapperFactory EntitySqlDaoWrapperFactory, context InternalCallContext) : void in class org.killbill.billing.invoice.dao.CBADao | From | To | |
| Change Return Type | 2 | ||
| Change Return Type void to InvoiceItemModelDao in method private createCredit(accountId UUID, effectiveDate LocalDate, creditAmount BigDecimal, draft boolean) : InvoiceItemModelDao in class org.killbill.billing.invoice.dao.TestInvoiceDao | From | To | |
| Change Return Type void to InvoiceItemModelDao in method private createCredit(accountId UUID, invoiceId UUID, effectiveDate LocalDate, creditAmount BigDecimal, draft boolean) : InvoiceItemModelDao in class org.killbill.billing.invoice.dao.TestInvoiceDao | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable balance : BigDecimal to amount : BigDecimal in method private buildCBAItem(invoice InvoiceModelDao, amount BigDecimal, context InternalCallContext) : InvoiceItemModelDao in class org.killbill.billing.invoice.dao.CBADao | From | To | |
| Extract Variable | 4 | ||
| Extract Variable parentCreditItem : InvoiceItemModelDao in method public inTransaction(entitySqlDaoWrapperFactory EntitySqlDaoWrapperFactory) : Void from class org.killbill.billing.invoice.dao.DefaultInvoiceDao.transferChildCreditToParent.execute | From | To | |
| Extract Variable childExternalChargeItem : InvoiceItemModelDao in method public transferChildCreditToParent(childAccount Account, childAccountContext InternalCallContext) : void from class org.killbill.billing.invoice.dao.DefaultInvoiceDao | From | To | |
| Extract Variable childExternalChargeItem : InvoiceItemModelDao in method public inTransaction(entitySqlDaoWrapperFactory EntitySqlDaoWrapperFactory) : Void from class org.killbill.billing.invoice.dao.DefaultInvoiceDao.transferChildCreditToParent.execute | From | To | |
| Extract Variable parentCreditItem : InvoiceItemModelDao in method public transferChildCreditToParent(childAccount Account, childAccountContext InternalCallContext) : void from class org.killbill.billing.invoice.dao.DefaultInvoiceDao | From | To | |
| Extract Method | 1 | ||
| Extract Method private buildCBAItem(invoice InvoiceModelDao, amount BigDecimal, context InternalCallContext) : InvoiceItemModelDao extracted from public computeCBAComplexity(invoice InvoiceModelDao, entitySqlDaoWrapperFactory EntitySqlDaoWrapperFactory, context InternalCallContext) : InvoiceItemModelDao in class org.killbill.billing.invoice.dao.CBADao | From | To |