27df79bd2edeae135f534632f44ee32ffe65dfdc
Files Diff
- Added: 7
- Removed: 5
- Renamed: 0
- Modified: 37
Link to commit
Third party dependencies:
| Dependency Action | |
|---|---|
| Added | |
| org.mapstruct:mapstruct-jdk8:1.1.0.Final |
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public vaildCheckCode() : boolean renamed to public validCheckCode() : boolean in class com.mpush.api.protocol.Packet | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method public encodeFrame(packet Packet, out ByteBuf) : void from class com.mpush.netty.codec.PacketEncoder to public encodePacket(packet Packet, out ByteBuf) : void from class com.mpush.api.protocol.Packet | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type cmd : byte to cmd : Command in method public JsonPacket(cmd Command, sessionId int) in class com.mpush.api.protocol.JsonPacket | From | To | |
| Rename Variable | 1 | ||
| Rename Variable request : String to text : String in method protected channelRead0(ctx ChannelHandlerContext, frame WebSocketFrame) : void in class com.mpush.core.server.WebSocketChannelHandler | From | To | |
| Inline Method | 3 | ||
| Inline Method private readPacket(packet Packet, in ByteBuf, bodyLength int) : Packet inlined to private decodeFrame(in ByteBuf) : Packet in class com.mpush.netty.codec.PacketDecoder | From | To | |
| Inline Method protected decode0(packet Packet, connection Connection) : T inlined to public handle(packet Packet, connection Connection) : void in class com.mpush.common.handler.BaseMessageHandler | From | To | |
| Change Return Type | 1 | ||
| Change Return Type String to int in method public getBodyLength() : int in class com.mpush.api.protocol.JsonPacket | From | To | |
| Rename Class | 1 | ||
| Rename Class com.mpush.api.protocol.TextPacket renamed to com.mpush.api.protocol.JsonPacket | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type channelHandler : ServerChannelHandler to channelHandler : ChannelHandler in class com.mpush.core.server.WebSocketServer | From | To | |
| Change Attribute Type body : String to body : Map<String,Object> in class com.mpush.api.protocol.JsonPacket | From | To | |
| Extract Method | 3 | ||
| Extract Method private encodeBinaryBody0() : void extracted from protected encodeBody() : void in class com.mpush.common.message.BaseMessage | From | To | |
| Extract Method private decodeBinaryBody0() : void extracted from protected decodeBody() : void in class com.mpush.common.message.BaseMessage | From | To | |
| Extract Method private encodeBodyRaw() : void extracted from public sendRaw(listener ChannelFutureListener) : void in class com.mpush.common.message.BaseMessage | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public toFrame(channel Channel) : Object extracted from public send(packet Packet, listener ChannelFutureListener) : ChannelFuture in class com.mpush.netty.connection.NettyConnection & moved to class com.mpush.api.protocol.Packet | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter datagram : DatagramPacket to frame : DatagramPacket in method public decodeFrame(frame DatagramPacket) : Packet in class com.mpush.netty.codec.PacketDecoder | From | To |