cc40ff92ad494ec2e043066980ed36297adf501c
Files Diff
- Added: 14
- Removed: 3
- Renamed: 0
- Modified: 27
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 5 | ||
| Rename Method public main(args String[]) : void renamed to public testConnClient() : void in class com.mpush.test.client.ConnClientTestMain | From | To | |
| Rename Method public getAllConnections() : Collection<Connection> renamed to public getAllNode() : Collection<Connection> in class com.mpush.client.gateway.GatewayTCPConnectionFactory | From | To | |
| Rename Method public main(args String[]) : void renamed to public testServer() : void in class com.mpush.test.sever.ServerTestMain | From | To | |
| Rename Method public main(args String[]) : void renamed to public testPush() : void in class com.mpush.test.push.PushClientTestMain | From | To | |
| Rename Method public start(listener Listener) : void renamed to private createNioClient(listener Listener) : void in class com.mpush.netty.client.NettyTCPClient | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type client : PushClient to factory : GatewayConnectionFactory in method public build(factory GatewayConnectionFactory, ctx PushContext) : PushRequest in class com.mpush.client.push.PushRequest | From | To | |
| Change Parameter Type client : PushClient to factory : GatewayConnectionFactory in method public PushRequest(factory GatewayConnectionFactory) in class com.mpush.client.push.PushRequest | From | To | |
| Rename Variable | 1 | ||
| Rename Variable bootstrap : Bootstrap to b : Bootstrap in method private createClient(listener Listener, workerGroup EventLoopGroup, clazz Class<? extends SocketChannel>) : void in class com.mpush.netty.client.NettyTCPClient | From | To | |
| Pull Up Attribute | 1 | ||
| Pull Up Attribute private logger : Logger from class com.mpush.client.gateway.GatewayClientFactory to package logger : Logger from class com.mpush.client.gateway.GatewayConnectionFactory | From | To | |
| Rename Class | 3 | ||
| Rename Class com.mpush.client.gateway.GatewayClientFactory renamed to com.mpush.client.gateway.GatewayTCPConnectionFactory | From | To | |
| Rename Class com.mpush.netty.client.NettyClient renamed to com.mpush.netty.client.NettyTCPClient | From | To | |
| Rename Class com.mpush.netty.server.NettyServer renamed to com.mpush.netty.server.NettyTCPServer | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass com.mpush.client.gateway.GatewayConnectionFactory from classes [com.mpush.client.gateway.GatewayTCPConnectionFactory] | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute client : PushClient to connectionFactory : GatewayConnectionFactory in class com.mpush.client.push.PushRequest | From | To | |
| Extract Variable | 1 | ||
| Extract Variable msg : Object in method public send(packet Packet, listener ChannelFutureListener) : ChannelFuture from class com.mpush.netty.connection.NettyConnection | From | To | |
| Extract Method | 2 | ||
| Extract Method private createClient(listener Listener, workerGroup EventLoopGroup, clazz Class<? extends SocketChannel>) : void extracted from public start(listener Listener) : void in class com.mpush.netty.client.NettyTCPClient | From | To | |
| Extract Method public encodeFrame(packet Packet, out ByteBuf) : void extracted from protected encode(ctx ChannelHandlerContext, packet Packet, out ByteBuf) : void in class com.mpush.netty.codec.PacketEncoder | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type factory : GatewayClientFactory to factory : GatewayConnectionFactory in class com.mpush.client.push.PushClient | From | To | |
| Change Attribute Type client : PushClient to connectionFactory : GatewayConnectionFactory in class com.mpush.client.push.PushRequest | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public setContent(content byte[]) : GatewayPushMessage extracted from public broadcast() : FutureTask<Boolean> in class com.mpush.client.push.PushRequest & moved to class com.mpush.common.message.gateway.GatewayPushMessage | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter client : PushClient to factory : GatewayConnectionFactory in method public build(factory GatewayConnectionFactory, ctx PushContext) : PushRequest in class com.mpush.client.push.PushRequest | From | To | |
| Rename Parameter client : PushClient to factory : GatewayConnectionFactory in method public PushRequest(factory GatewayConnectionFactory) in class com.mpush.client.push.PushRequest | From | To |