02a5a30e401ee55ae2f6a43f2eb669116e36c7fc
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 13
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 8 | ||
| Rename Method package grabFreePage(faultEvent PageFaultEvent) : MuninnPage renamed to package grabFreeAndExclusivelyLockedPage(faultEvent PageFaultEvent) : MuninnPage in class org.neo4j.io.pagecache.impl.muninn.MuninnPageCache | From | To | |
| Rename Method public writeLock() : void renamed to public tryWriteLock() : boolean in class org.neo4j.io.pagecache.impl.muninn.OptiLock | From | To | |
| Rename Method protected lockPage(page MuninnPage) : void renamed to protected tryLockPage(page MuninnPage) : boolean in class org.neo4j.io.pagecache.impl.muninn.MuninnReadPageCursor | From | To | |
| Rename Method protected lockPage(page MuninnPage) : void renamed to protected tryLockPage(page MuninnPage) : boolean in class org.neo4j.io.pagecache.impl.muninn.MuninnWritePageCursor | From | To | |
| Rename Method public writeLockedPageMustBlockFileUnmapping() : void renamed to public writeLockedPageMustNotBlockFileUnmapping() : void in class org.neo4j.io.pagecache.PageCacheTest | From | To | |
| Rename Method public pessimisticReadLockedPageMustNotBlockFileUnmapping() : void renamed to public optimisticReadLockedPageMustNotBlockFileUnmapping() : void in class org.neo4j.io.pagecache.PageCacheTest | From | To | |
| Rename Method package grabFreePage(faultEvent PageFaultEvent) : MuninnPage renamed to package grabFreeAndExclusivelyLockedPage(faultEvent PageFaultEvent) : MuninnPage in class org.neo4j.io.pagecache.impl.muninn.MuninnPagedFile | From | To | |
| Rename Method protected abstract lockPage(page MuninnPage) : void renamed to protected abstract tryLockPage(page MuninnPage) : boolean in class org.neo4j.io.pagecache.impl.muninn.MuninnPageCursor | From | To | |
| Rename Variable | 1 | ||
| Rename Variable pageCount : int to filePageCount : int in method public readsAndWritesMustBeMutuallyConsistent() : void in class org.neo4j.io.pagecache.PageCacheTest | From | To | |
| Change Return Type | 4 | ||
| Change Return Type void to boolean in method protected tryLockPage(page MuninnPage) : boolean in class org.neo4j.io.pagecache.impl.muninn.MuninnReadPageCursor | From | To | |
| Change Return Type void to boolean in method protected abstract tryLockPage(page MuninnPage) : boolean in class org.neo4j.io.pagecache.impl.muninn.MuninnPageCursor | From | To | |
| Change Return Type void to boolean in method public tryWriteLock() : boolean in class org.neo4j.io.pagecache.impl.muninn.OptiLock | From | To | |
| Change Return Type void to boolean in method protected tryLockPage(page MuninnPage) : boolean in class org.neo4j.io.pagecache.impl.muninn.MuninnWritePageCursor | From | To | |
| Extract Variable | 1 | ||
| Extract Variable fileByte : byte in method public write(record Record, cursor PageCursor) : void from class org.neo4j.io.pagecache.randomharness.StandardRecordFormat | From | To | |
| Inline Variable | 2 | ||
| Inline Variable recordSize : int in method private readRecord() : Action from class org.neo4j.io.pagecache.randomharness.CommandPrimer | From | To | |
| Inline Variable unmapper : Thread in method public writeLockedPageMustBlockFileUnmapping() : void from class org.neo4j.io.pagecache.PageCacheTest | From | To | |
| Extract Method | 5 | ||
| Extract Method private getUsageCounter() : byte extracted from public incrementUsage() : void in class org.neo4j.io.pagecache.impl.muninn.MuninnPage | From | To | |
| Extract Method private getUsageCounter() : byte extracted from public decrementUsage() : boolean in class org.neo4j.io.pagecache.impl.muninn.MuninnPage | From | To | |
| Extract Method private abortPageFault(throwable Throwable, chunk Object[], chunkOffset long, latch BinaryLatch, faultEvent PageFaultEvent) : void extracted from private pageFault(filePageId long, swapper PageSwapper, chunkOffset long, chunk Object[], latch BinaryLatch) : MuninnPage in class org.neo4j.io.pagecache.impl.muninn.MuninnPageCursor | From | To | |
| Extract Method private initiateExclusiveLockRelease() : long extracted from public unlockExclusive() : long in class org.neo4j.io.pagecache.impl.muninn.OptiLock | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter exclusive : boolean to writeLock : boolean in method protected pin(filePageId long, writeLock boolean) : void in class org.neo4j.io.pagecache.impl.muninn.MuninnPageCursor | From | To |