neo4j 05200ceed501120f86fdfea2f31b1121d2a7e28f

05200ceed501120f86fdfea2f31b1121d2a7e28f

Files Diff

Added: 2
Removed: 0
Renamed: 0
Modified: 12

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	1
Move And Rename Method public compact() : void from class org.neo4j.coreedge.raft.state.CoreState to package prune() : void from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Change Parameter Type	4
Change Parameter Type raftInstance : RaftInstance to handler : MessageHandler<RaftMessages.StoreIdAwareMessage> in method public BatchingMessageHandler(handler MessageHandler<RaftMessages.StoreIdAwareMessage>, queueSize int, maxBatch int, logProvider LogProvider) in class org.neo4j.coreedge.raft.BatchingMessageHandler	From	To
Change Parameter Type listener : BatchingMessageHandler.MismatchedStoreListener to listener : MismatchedStoreListener in method public addMismatchedStoreListener(listener MismatchedStoreListener) : void in class org.neo4j.coreedge.raft.state.CoreState	From	To
Change Parameter Type ex : BatchingMessageHandler.MismatchedStoreIdException to ex : MismatchedStoreIdService.MismatchedStoreIdException in method public onMismatchedStore(ex MismatchedStoreIdService.MismatchedStoreIdException) : void in class org.neo4j.coreedge.raft.membership.MembershipWaiter.Evaluator	From	To
Change Parameter Type batch : List<RaftMessage> to batch : List<RaftMessages.StoreIdAwareMessage> in method private drain(messageQueue BlockingQueue<RaftMessages.StoreIdAwareMessage>, batch List<RaftMessages.StoreIdAwareMessage>, maxElements int) : void in class org.neo4j.coreedge.raft.BatchingMessageHandler	From	To
Move Method	23
Move Method public shouldApplyToLogFromCache() : void from class org.neo4j.coreedge.raft.state.CoreStateTest to public shouldApplyToLogFromCache() : void from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Method public addMismatchedStoreListener(listener BatchingMessageHandler.MismatchedStoreListener) : void from class org.neo4j.coreedge.raft.BatchingMessageHandler to public addMismatchedStoreListener(listener MismatchedStoreListener) : void from class org.neo4j.coreedge.raft.state.CoreState	From	To
Move Method public shouldIncreaseLastAppliedForOtherCommands() : void from class org.neo4j.coreedge.raft.state.CoreStateTest to public shouldIncreaseLastAppliedForOtherCommands() : void from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Method public shouldPeriodicallyFlushState() : void from class org.neo4j.coreedge.raft.state.CoreStateTest to public shouldPeriodicallyFlushState() : void from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Method public shouldFallbackToLogCursorOnCacheMiss() : void from class org.neo4j.coreedge.raft.state.CoreStateTest to public shouldFallbackToLogCursorOnCacheMiss() : void from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Method private operation(tx CoreReplicatedContent) : ReplicatedContent from class org.neo4j.coreedge.raft.state.CoreStateTest to private operation(tx CoreReplicatedContent) : ReplicatedContent from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Method private tx(dataValue byte) : ReplicatedTransaction from class org.neo4j.coreedge.raft.state.CoreStateTest to private tx(dataValue byte) : ReplicatedTransaction from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Method public shouldApplyCommittedCommand() : void from class org.neo4j.coreedge.raft.state.CoreStateTest to public shouldApplyCommittedCommand() : void from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Method public shouldFailWhenCacheAndLogMiss() : void from class org.neo4j.coreedge.raft.state.CoreStateTest to public shouldFailWhenCacheAndLogMiss() : void from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Method public entriesThatAreNotStateMachineCommandsShouldStillIncreaseCommandIndex() : void from class org.neo4j.coreedge.raft.state.CoreStateTest to public entriesThatAreNotStateMachineCommandsShouldStillIncreaseCommandIndex() : void from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Method public shouldPanicIfUnableToApply() : void from class org.neo4j.coreedge.raft.state.CoreStateTest to public shouldPanicIfUnableToApply() : void from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Method private submitApplyJob(lastToApply long) : void from class org.neo4j.coreedge.raft.state.CoreState to private submitApplyJob(lastToApply long) : void from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Method private maybeFlush() : void from class org.neo4j.coreedge.raft.state.CoreState to private maybeFlush() : void from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Method private flush() : void from class org.neo4j.coreedge.raft.state.CoreState to private flush() : void from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Method public outOfOrderDuplicatesShouldBeIgnoredButStillIncreaseCommandIndex() : void from class org.neo4j.coreedge.raft.state.CoreStateTest to public outOfOrderDuplicatesShouldBeIgnoredButStillIncreaseCommandIndex() : void from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Method private anyCallback() : Consumer<Result> from class org.neo4j.coreedge.raft.state.CoreStateTest to private anyCallback() : Consumer<Result> from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Method public shouldIncreaseLastAppliedForStateMachineCommands() : void from class org.neo4j.coreedge.raft.state.CoreStateTest to public shouldIncreaseLastAppliedForStateMachineCommands() : void from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Method public shouldLogOnStoreIdMismatchAndNonEmptyStore() : void from class org.neo4j.coreedge.raft.BatchingMessageHandlerTest to public shouldLogOnStoreIdMismatchAndNonEmptyStore() : void from class org.neo4j.coreedge.raft.state.CoreStateTest	From	To
Move Method public cacheEntryShouldBePurgedWhenApplied() : void from class org.neo4j.coreedge.raft.state.CoreStateTest to public cacheEntryShouldBePurgedWhenApplied() : void from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Method public duplicatesShouldBeIgnoredButStillIncreaseCommandIndex() : void from class org.neo4j.coreedge.raft.state.CoreStateTest to public duplicatesShouldBeIgnoredButStillIncreaseCommandIndex() : void from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Method private handleOperations(commandIndex long, operations List<DistributedOperation>) : void from class org.neo4j.coreedge.raft.state.CoreState to private handleOperations(commandIndex long, operations List<DistributedOperation>) : void from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Method public lastApplied() : long from class org.neo4j.coreedge.raft.state.CoreState to public lastApplied() : long from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Method public shouldNotApplyUncommittedCommands() : void from class org.neo4j.coreedge.raft.state.CoreStateTest to public shouldNotApplyUncommittedCommands() : void from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Attribute	31
Move Attribute private raftInstance : RaftInstance from class org.neo4j.coreedge.raft.BatchingMessageHandler to private raftInstance : RaftInstance from class org.neo4j.coreedge.raft.state.CoreState	From	To
Move Attribute private flushEvery : int from class org.neo4j.coreedge.raft.state.CoreStateTest to private flushEvery : int from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Attribute private progressTracker : ProgressTracker from class org.neo4j.coreedge.raft.state.CoreState to private progressTracker : ProgressTracker from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Attribute private lastSeenCommitIndex : long from class org.neo4j.coreedge.raft.state.CoreState to private lastSeenCommitIndex : long from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Attribute private globalSession : GlobalSession from class org.neo4j.coreedge.raft.state.CoreStateTest to private globalSession : GlobalSession from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Attribute private raftLog : InMemoryRaftLog from class org.neo4j.coreedge.raft.state.CoreStateTest to private raftLog : InMemoryRaftLog from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Attribute private raftLog : RaftLog from class org.neo4j.coreedge.raft.state.CoreState to private raftLog : RaftLog from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Attribute private monitors : Monitors from class org.neo4j.coreedge.raft.state.CoreStateTest to private monitors : Monitors from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Attribute private batchSize : int from class org.neo4j.coreedge.raft.state.CoreStateTest to private batchSize : int from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Attribute private sessionTracker : SessionTracker from class org.neo4j.coreedge.raft.state.CoreState to private sessionTracker : SessionTracker from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Attribute private commandDispatcher : CommandDispatcher from class org.neo4j.coreedge.raft.state.CoreStateTest to private commandDispatcher : CommandDispatcher from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Attribute private nullTx : ReplicatedTransaction from class org.neo4j.coreedge.raft.state.CoreStateTest to private nullTx : ReplicatedTransaction from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Attribute private applier : CoreStateApplier from class org.neo4j.coreedge.raft.state.CoreStateTest to private applier : CoreStateApplier from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Attribute private sessionStorage : SessionTracker from class org.neo4j.coreedge.raft.state.CoreStateTest to private sessionStorage : SessionTracker from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Attribute private coreStateMachines : CoreStateMachines from class org.neo4j.coreedge.raft.state.CoreStateTest to private coreStateMachines : CoreStateMachines from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Attribute private lastFlushedStorage : StateStorage<Long> from class org.neo4j.coreedge.raft.state.CoreState to private lastFlushedStorage : StateStorage<Long> from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Attribute private applier : CoreStateApplier from class org.neo4j.coreedge.raft.state.CoreState to private applier : CoreStateApplier from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Attribute private lastFlushedStorage : InMemoryStateStorage<Long> from class org.neo4j.coreedge.raft.state.CoreStateTest to private lastFlushedStorage : InMemoryStateStorage<Long> from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Attribute private localDatabase : LocalDatabase from class org.neo4j.coreedge.raft.BatchingMessageHandler to private localDatabase : LocalDatabase from class org.neo4j.coreedge.raft.state.CoreState	From	To
Move Attribute private batcher : OperationBatcher from class org.neo4j.coreedge.raft.state.CoreState to private batcher : OperationBatcher from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Attribute private flushEvery : int from class org.neo4j.coreedge.raft.state.CoreState to private flushEvery : int from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Attribute private dbHealth : Supplier<DatabaseHealth> from class org.neo4j.coreedge.raft.state.CoreState to private dbHealth : Supplier<DatabaseHealth> from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Attribute private commitIndexMonitor : RaftLogCommitIndexMonitor from class org.neo4j.coreedge.raft.state.CoreState to private commitIndexMonitor : RaftLogCommitIndexMonitor from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Attribute private inFlightMap : InFlightMap<Long,RaftLogEntry> from class org.neo4j.coreedge.raft.state.CoreState to private inFlightMap : InFlightMap<Long,RaftLogEntry> from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Attribute private inFlightMap : InFlightMap<Long,RaftLogEntry> from class org.neo4j.coreedge.raft.state.CoreStateTest to private inFlightMap : InFlightMap<Long,RaftLogEntry> from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Attribute private lastApplied : long from class org.neo4j.coreedge.raft.state.CoreState to private lastApplied : long from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Attribute private lastFlushed : long from class org.neo4j.coreedge.raft.state.CoreState to private lastFlushed : long from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Attribute private NOTHING : long from class org.neo4j.coreedge.raft.state.CoreState to private NOTHING : long from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Move Attribute private dbHealth : DatabaseHealth from class org.neo4j.coreedge.raft.state.CoreStateTest to private dbHealth : DatabaseHealth from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Attribute private sequenceNumber : int from class org.neo4j.coreedge.raft.state.CoreStateTest to private sequenceNumber : int from class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest	From	To
Move Attribute private coreStateMachines : CoreStateMachines from class org.neo4j.coreedge.raft.state.CoreState to private coreStateMachines : CoreStateMachines from class org.neo4j.coreedge.raft.state.CommandApplicationProcess	From	To
Extract Class	3
Extract Class org.neo4j.coreedge.raft.state.CommandApplicationProcess from class org.neo4j.coreedge.raft.state.CoreStateTest	From	To
Extract Class org.neo4j.coreedge.raft.state.CommandApplicationProcessTest from class org.neo4j.coreedge.raft.state.CoreStateTest	From	To
Extract Class org.neo4j.coreedge.raft.state.CommandApplicationProcess from class org.neo4j.coreedge.raft.state.CoreState	From	To
Move Class	1
Move Class org.neo4j.coreedge.raft.state.CoreState.OperationBatcher moved to org.neo4j.coreedge.raft.state.CommandApplicationProcess.OperationBatcher	From	To
Rename Attribute	1
Rename Attribute raftInstance : RaftInstance to handler : MessageHandler<RaftMessages.StoreIdAwareMessage> in class org.neo4j.coreedge.raft.BatchingMessageHandler	From	To
Change Attribute Type	3
Change Attribute Type raftInstance : RaftInstance to handler : MessageHandler<RaftMessages.StoreIdAwareMessage> in class org.neo4j.coreedge.raft.BatchingMessageHandler	From	To
Change Attribute Type raftStateMachine : RaftStateMachine to raftStateMachine : MessageHandler<RaftMessages.StoreIdAwareMessage> in class org.neo4j.coreedge.raft.BatchingMessageHandlerTest	From	To
Change Attribute Type batch : List<RaftMessages.RaftMessage> to batch : List<RaftMessages.StoreIdAwareMessage> in class org.neo4j.coreedge.raft.BatchingMessageHandler	From	To
Extract And Move Method	1
Extract And Move Method public handle(storeIdAwareMessage RaftMessages.StoreIdAwareMessage) : void extracted from public run() : void in class org.neo4j.coreedge.raft.BatchingMessageHandler & moved to class org.neo4j.coreedge.raft.state.CoreState	From	To
Rename Parameter	1
Rename Parameter raftInstance : RaftInstance to handler : MessageHandler<RaftMessages.StoreIdAwareMessage> in method public BatchingMessageHandler(handler MessageHandler<RaftMessages.StoreIdAwareMessage>, queueSize int, maxBatch int, logProvider LogProvider) in class org.neo4j.coreedge.raft.BatchingMessageHandler	From	To

05200ceed501120f86fdfea2f31b1121d2a7e28f

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: