05884321c0df16e4a9971bd98babda8247c2dc5c
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 16
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method protected createTransactionCounters() : TransactionCounters renamed to protected createTransactionStats() : TransactionStats in class org.neo4j.kernel.impl.factory.PlatformModule | From | To | |
| Push Down Method | 7 | ||
| Push Down Method public getNumberOfRolledbackTransactions() : long from class org.neo4j.kernel.impl.transaction.TransactionCounters to public getNumberOfRolledBackReadTransactions() : long from class org.neo4j.kernel.impl.transaction.TransactionStats | From | To | |
| Push Down Method public getNumberOfCommittedTransactions() : long from class org.neo4j.kernel.impl.transaction.TransactionCounters to public getNumberOfCommittedTransactions() : long from class org.neo4j.kernel.impl.transaction.TransactionStats | From | To | |
| Push Down Method public getPeakConcurrentNumberOfTransactions() : long from class org.neo4j.kernel.impl.transaction.TransactionCounters to public getPeakConcurrentNumberOfTransactions() : long from class org.neo4j.kernel.impl.transaction.TransactionStats | From | To | |
| Push Down Method public getNumberOfActiveTransactions() : long from class org.neo4j.kernel.impl.transaction.TransactionCounters to public getNumberOfActiveTransactions() : long from class org.neo4j.kernel.impl.transaction.TransactionStats | From | To | |
| Push Down Method public transactionStarted() : void from class org.neo4j.kernel.impl.transaction.TransactionCounters to public transactionStarted() : void from class org.neo4j.kernel.impl.transaction.TransactionStats | From | To | |
| Push Down Method public getNumberOfStartedTransactions() : long from class org.neo4j.kernel.impl.transaction.TransactionCounters to public getNumberOfStartedTransactions() : long from class org.neo4j.kernel.impl.transaction.TransactionStats | From | To | |
| Push Down Method public getNumberOfTerminatedTransactions() : long from class org.neo4j.kernel.impl.transaction.TransactionCounters to public getNumberOfTerminatedTransactions() : long from class org.neo4j.kernel.impl.transaction.TransactionStats | From | To | |
| Extract Subclass | 1 | ||
| Extract Subclass org.neo4j.kernel.impl.transaction.TransactionStats from class org.neo4j.kernel.impl.transaction.TransactionCounters | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type transactionCounters : TransactionCounters to transactionCounters : TransactionStats in method package SwitchToSlave(storeDir File, logService LogService, config Config, resolver DependencyResolver, idGeneratorFactory HaIdGeneratorFactory, masterDelegateHandler DelegateInvocationHandler<Master>, clusterMemberAvailability ClusterMemberAvailability, requestContextFactory RequestContextFactory, pullerFactory PullerFactory, masterClientResolver MasterClientResolver, monitor Monitor, storeCopyClient StoreCopyClient, neoDataSourceSupplier Supplier<NeoStoreDataSource>, transactionIdStoreSupplier Supplier<TransactionIdStore>, slaveServerFactory Function<Slave,SlaveServer>, updatePuller UpdatePuller, pageCache PageCache, monitors Monitors, transactionCounters TransactionStats) in class org.neo4j.kernel.ha.cluster.SwitchToSlave | From | To | |
| Change Parameter Type transactionMonitor : TransactionCounters to transactionMonitor : TransactionStats in method public DatabaseAvailability(availabilityGuard AvailabilityGuard, transactionMonitor TransactionStats) in class org.neo4j.kernel.DatabaseAvailability | From | To | |
| Change Parameter Type transactionMonitor : TransactionCounters to transactionMonitor : TransactionStats in method public DatabaseAvailability(availabilityGuard AvailabilityGuard, transactionMonitor TransactionStats, awaitActiveTransactionDeadlineMillis long) in class org.neo4j.kernel.DatabaseAvailability | From | To | |
| Change Parameter Type transactionCounters : TransactionCounters to transactionCounters : TransactionStats in method public SwitchToSlave(storeDir File, logService LogService, fileSystemAbstraction FileSystemAbstraction, config Config, resolver DependencyResolver, idGeneratorFactory HaIdGeneratorFactory, masterDelegateHandler DelegateInvocationHandler<Master>, clusterMemberAvailability ClusterMemberAvailability, requestContextFactory RequestContextFactory, pullerFactory PullerFactory, kernelExtensions Iterable<KernelExtensionFactory<?>>, masterClientResolver MasterClientResolver, monitor Monitor, storeCopyMonitor StoreCopyClient.Monitor, neoDataSourceSupplier Supplier<NeoStoreDataSource>, transactionIdStoreSupplier Supplier<TransactionIdStore>, slaveServerFactory Function<Slave,SlaveServer>, updatePuller UpdatePuller, pageCache PageCache, monitors Monitors, transactionCounters TransactionStats) in class org.neo4j.kernel.ha.cluster.SwitchToSlave | From | To | |
| Rename Variable | 1 | ||
| Rename Variable monitor : TransactionCounters to counts : TransactionCounters in method public shouldCountCommittedTransactions() : void in class org.neo4j.kernel.impl.transaction.TransactionMonitorTest | From | To | |
| Change Return Type | 1 | ||
| Change Return Type TransactionCounters to TransactionStats in method protected createTransactionStats() : TransactionStats in class org.neo4j.kernel.impl.factory.PlatformModule | From | To | |
| Push Down Attribute | 2 | ||
| Push Down Attribute private startedTransactionCount : AtomicLong from class org.neo4j.kernel.impl.transaction.TransactionCounters to private startedTransactionCount : AtomicLong from class org.neo4j.kernel.impl.transaction.TransactionStats | From | To | |
| Push Down Attribute private peakTransactionCount : long from class org.neo4j.kernel.impl.transaction.TransactionCounters to private peakTransactionCount : long from class org.neo4j.kernel.impl.transaction.TransactionStats | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type transactionCounters : TransactionCounters to transactionCounters : TransactionStats in method public whenHAModeSwitcherSwitchesToSlaveTheOtherModeSwitcherDoNotGetTheOldMasterClient() : void in class org.neo4j.kernel.ha.cluster.HighAvailabilityMemberStateMachineTest | From | To | |
| Change Variable Type transactionCounters : TransactionCounters to transactionCounters : TransactionStats in method private newSwitchToSlaveSpy(pageCacheMock PageCache, storeCopyClient StoreCopyClient) : SwitchToSlave in class org.neo4j.kernel.ha.cluster.SwitchToSlaveTest | From | To | |
| Change Variable Type txMonitor : TransactionCounters to txMonitor : TransactionStats in method public executing_single_statement_in_new_transaction_and_failing_to_read_the_output_should_interrupt() : void in class org.neo4j.server.rest.transactional.integration.TransactionIT | From | To | |
| Extract Variable | 1 | ||
| Extract Variable caching : IndexReaderFactory.Caching in method public acquireStatement() : KernelStatement from class org.neo4j.kernel.impl.api.KernelTransactionImplementation | From | To | |
| Extract Method | 14 | ||
| Extract Method private verifyExtraInteractionWithTheMonitor(transactionMonitor TransactionMonitor, isWriteTx boolean) : void extracted from public shouldCommitSuccessfulTransaction() : void in class org.neo4j.kernel.api.KernelTransactionImplementationTest | From | To | |
| Extract Method private verifyExtraInteractionWithTheMonitor(transactionMonitor TransactionMonitor, isWriteTx boolean) : void extracted from public shouldNotDowngradeFailureState() : void in class org.neo4j.kernel.api.KernelTransactionImplementationTest | From | To | |
| Extract Method private verifyExtraInteractionWithTheMonitor(transactionMonitor TransactionMonitor, isWriteTx boolean) : void extracted from public shouldRollbackAndThrowOnFailedAndSuccess() : void in class org.neo4j.kernel.api.KernelTransactionImplementationTest | From | To | |
| Extract Method private verifyExtraInteractionWithTheMonitor(transactionMonitor TransactionMonitor, isWriteTx boolean) : void extracted from public shouldRollbackOnClosingTerminatedTransaction() : void in class org.neo4j.kernel.api.KernelTransactionImplementationTest | From | To | |
| Extract Method private verifyExtraInteractionWithTheMonitor(transactionMonitor TransactionMonitor, isWriteTx boolean) : void extracted from public shouldAllowTerminatingFromADifferentThread() : void in class org.neo4j.kernel.api.KernelTransactionImplementationTest | From | To | |
| Extract Method private verifyExtraInteractionWithTheMonitor(transactionMonitor TransactionMonitor, isWriteTx boolean) : void extracted from public shouldRollbackUnsuccessfulTransaction() : void in class org.neo4j.kernel.api.KernelTransactionImplementationTest | From | To | |
| Extract Method private verifyExtraInteractionWithTheMonitor(transactionMonitor TransactionMonitor, isWriteTx boolean) : void extracted from public shouldRollbackOnClosingSuccessfulButTerminatedTransaction() : void in class org.neo4j.kernel.api.KernelTransactionImplementationTest | From | To | |
| Extract Method public getNumberOfTerminatedReadTransactions() : long extracted from public getNumberOfTerminatedTransactions() : long in class org.neo4j.kernel.impl.transaction.TransactionStats | From | To | |
| Extract Method private verifyExtraInteractionWithTheMonitor(transactionMonitor TransactionMonitor, isWriteTx boolean) : void extracted from public shouldIgnoreTerminateAfterCommit() : void in class org.neo4j.kernel.api.KernelTransactionImplementationTest | From | To | |
| Extract Method private verifyExtraInteractionWithTheMonitor(transactionMonitor TransactionMonitor, isWriteTx boolean) : void extracted from public shouldIgnoreTerminationDuringRollback() : void in class org.neo4j.kernel.api.KernelTransactionImplementationTest | From | To | |
| Extract Method public getNumberOfActiveReadTransactions() : long extracted from public getNumberOfActiveTransactions() : long in class org.neo4j.kernel.impl.transaction.TransactionStats | From | To | |
| Extract Method private verifyExtraInteractionWithTheMonitor(transactionMonitor TransactionMonitor, isWriteTx boolean) : void extracted from public shouldRollbackOnClosingTerminatedButSuccessfulTransaction() : void in class org.neo4j.kernel.api.KernelTransactionImplementationTest | From | To | |
| Extract Method private verifyExtraInteractionWithTheMonitor(transactionMonitor TransactionMonitor, isWriteTx boolean) : void extracted from public shouldRollbackFailedTransaction() : void in class org.neo4j.kernel.api.KernelTransactionImplementationTest | From | To | |
| Extract Method private verifyExtraInteractionWithTheMonitor(transactionMonitor TransactionMonitor, isWriteTx boolean) : void extracted from public shouldIgnoreTerminateAfterRollback() : void in class org.neo4j.kernel.api.KernelTransactionImplementationTest | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type transactionCounters : TransactionCounters to transactionCounters : TransactionStats in class org.neo4j.kernel.ha.cluster.SwitchToSlave | From | To | |
| Change Attribute Type transactionMonitor : TransactionCounters to transactionMonitor : TransactionStats in class org.neo4j.kernel.impl.factory.PlatformModule | From | To | |
| Change Attribute Type txMonitor : TransactionCounters to txMonitor : TransactionStats in class org.neo4j.management.impl.TransactionManagerBean.TransactionManagerImpl | From | To | |
| Change Attribute Type transactionMonitor : TransactionCounters to transactionMonitor : TransactionStats in class org.neo4j.kernel.DatabaseAvailability | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter element : RelationshipPropertyExistenceConstraint to rpec : RelationshipPropertyExistenceConstraint in method public visitRemovedRelationshipPropertyExistenceConstraint(rpec RelationshipPropertyExistenceConstraint) : void in class org.neo4j.kernel.impl.api.KernelTransactionImplementation.TransactionToRecordStateVisitor | From | To |