07fcae2ece1900cf302666e76c4ec96d0671edb0
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 22
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method package add(update IndexEntryUpdate) : void renamed to public batch(update IndexEntryUpdate<?>) : boolean in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.IndexPopulation | From | To | |
| Move And Inline Method | 2 | ||
| Move And Inline Method public add(update IndexEntryUpdate<?>) : void moved from class org.neo4j.kernel.impl.index.schema.fusion.FusionIndexPopulator to class org.neo4j.unsafe.batchinsert.internal.BatchInserterImpl.IndexPopulatorWithSchema & inlined to public add(update IndexEntryUpdate<?>) : void | From | To | |
| Move And Inline Method public add(update IndexEntryUpdate<?>) : void moved from class org.neo4j.kernel.impl.index.schema.fusion.FusionIndexPopulator to class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.IndexPopulation & inlined to private onUpdate(update IndexEntryUpdate) : void | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type update : IndexEntryUpdate to update : IndexEntryUpdate<?> in method public batch(update IndexEntryUpdate<?>) : boolean in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.IndexPopulation | From | To | |
| Change Parameter Type batch : List<IndexEntryUpdate<?>> to batch : Collection<IndexEntryUpdate<?>> in method private flush(population IndexPopulation, batch Collection<IndexEntryUpdate<?>>) : void in class org.neo4j.kernel.impl.api.index.BatchingMultipleIndexPopulator | From | To | |
| Rename Variable | 3 | ||
| Rename Variable executor : ExecutorService to result : ExecutorService in method private immediateExecutor() : ExecutorService in class org.neo4j.kernel.impl.api.index.BatchingMultipleIndexPopulatorTest | From | To | |
| Inline Method | 1 | ||
| Inline Method public add(update IndexEntryUpdate<?>) : void inlined to public add(updates Collection<? extends IndexEntryUpdate<?>>) : void in class org.neo4j.kernel.impl.index.schema.fusion.FusionIndexPopulator | From | To | |
| Pull Up Attribute | 1 | ||
| Pull Up Attribute private BATCH_SIZE : int from class org.neo4j.kernel.impl.api.index.BatchingMultipleIndexPopulator to private BATCH_SIZE : int from class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator | From | To | |
| Change Return Type | 1 | ||
| Change Return Type void to boolean in method public batch(update IndexEntryUpdate<?>) : boolean in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.IndexPopulation | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type update : IndexEntryUpdate to update : IndexEntryUpdate<?> in method private addUpdate(populator UniqueLuceneIndexPopulator, nodeId long, value Object) : void in class org.neo4j.kernel.api.impl.schema.populator.UniqueDatabaseIndexPopulatorTest | From | To | |
| Change Variable Type update : IndexEntryUpdate<LabelSchemaDescriptor> to update : Collection<IndexEntryUpdate<LabelSchemaDescriptor>> in method private verifyAddWithCorrectPopulator(correctPopulator IndexPopulator, wrongPopulator IndexPopulator, numberValues Value...) : void in class org.neo4j.kernel.impl.index.schema.fusion.FusionIndexPopulatorTest | From | To | |
| Extract Variable | 1 | ||
| Extract Variable currentPageId : long in method private cursorIsAtExpectedLocation(cursor PageCursor) : boolean from class org.neo4j.index.internal.gbptree.InternalTreeLogic | From | To | |
| Extract Method | 5 | ||
| Extract Method private immediateExecutor() : ExecutorService extracted from private sameThreadExecutor() : ExecutorService in class org.neo4j.kernel.impl.api.index.BatchingMultipleIndexPopulatorTest | From | To | |
| Extract Method private immediateExecutor() : ExecutorService extracted from public executorShutdownAfterStoreScanCompletes() : void in class org.neo4j.kernel.impl.api.index.BatchingMultipleIndexPopulatorTest | From | To | |
| Extract Method package processUpdate(treeKey KEY, treeValue VALUE, update IndexEntryUpdate, writer Writer<KEY,VALUE>, conflictDetectingValueMerger ConflictDetectingValueMerger<KEY,VALUE>) : void extracted from public process(update IndexEntryUpdate) : void in class org.neo4j.kernel.impl.index.schema.NativeSchemaNumberIndexUpdater | From | To | |
| Extract Method private immediateExecutor() : ExecutorService extracted from public executorForcefullyShutdownIfStoreScanFails() : void in class org.neo4j.kernel.impl.api.index.BatchingMultipleIndexPopulatorTest | From | To | |
| Extract Method package itemsMatches(expected Iterable<T>, actual Iterable<T>) : boolean extracted from protected matchesSafely(objects Iterable<T>) : boolean in class org.neo4j.test.mockito.matcher.IterableMatcher | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter objects : Iterable<T> to actual : Iterable<T> in method package itemsMatches(expected Iterable<T>, actual Iterable<T>) : boolean in class org.neo4j.test.mockito.matcher.IterableMatcher | From | To |