neo4j 0c4fd5b0a6e36705ed80d5d462a1d58757f7d1b3

0c4fd5b0a6e36705ed80d5d462a1d58757f7d1b3

Files Diff

Added: 7
Removed: 1
Renamed: 0
Modified: 78

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	6
Change Parameter Type role : Role to role : RoleInfo in method package ReadWriteEndPoint(clientConnectorAddresses ClientConnectorAddresses, role RoleInfo, memberId UUID, groups List<String>, dbName String) in class org.neo4j.causalclustering.discovery.procedures.ClusterOverviewProcedure.ReadWriteEndPoint	From	To
Change Parameter Type unexpectedRole : Role to unexpectedRole : RoleInfo in method private doesNotContainRole(unexpectedRole RoleInfo) : Matcher<List<MemberInfo>> in class org.neo4j.causalclustering.scenarios.ClusterOverviewIT	From	To
Change Parameter Type role : Role to role : RoleInfo in method package MemberInfo(addresses String[], role RoleInfo) in class org.neo4j.causalclustering.scenarios.ClusterOverviewIT.MemberInfo	From	To
Change Parameter Type factory : DiscoveryServiceFactory to discoveryType : DiscoveryServiceType in method public withDiscoveryServiceType(discoveryType DiscoveryServiceType) : ClusterRule in class org.neo4j.test.causalclustering.ClusterRule	From	To
Change Parameter Type role : Role to role : RoleInfo in method package IsRecord(memberId UUID, boltPort int, role RoleInfo, groups Set<String>, dbName String) in class org.neo4j.causalclustering.discovery.procedures.ClusterOverviewProcedureTest.IsRecord	From	To
Change Parameter Type expectedRole : Role to expectedRole : RoleInfo in method private containsRole(expectedRole RoleInfo, expectedCount long) : Matcher<List<MemberInfo>> in class org.neo4j.causalclustering.scenarios.ClusterOverviewIT	From	To
Move Method	2
Move Method public topologyService(config Config, logProvider LogProvider, jobScheduler JobScheduler, myself MemberId, hostnameResolver HostnameResolver, topologyServiceRetryStrategy TopologyServiceRetryStrategy) : TopologyService from class org.neo4j.causalclustering.discovery.SharedDiscoveryService to public topologyService(config Config, logProvider LogProvider, jobScheduler JobScheduler, myself MemberId, hostnameResolver HostnameResolver, topologyServiceRetryStrategy TopologyServiceRetryStrategy) : TopologyService from class org.neo4j.causalclustering.discovery.SharedDiscoveryServiceFactory	From	To
Move Method public coreTopologyService(config Config, myself MemberId, jobScheduler JobScheduler, logProvider LogProvider, userLogProvider LogProvider, hostnameResolver HostnameResolver, topologyServiceRetryStrategy TopologyServiceRetryStrategy) : CoreTopologyService from class org.neo4j.causalclustering.discovery.SharedDiscoveryService to public coreTopologyService(config Config, myself MemberId, jobScheduler JobScheduler, logProvider LogProvider, userLogProvider LogProvider, hostnameResolver HostnameResolver, topologyServiceRetryStrategy TopologyServiceRetryStrategy) : CoreTopologyService from class org.neo4j.causalclustering.discovery.SharedDiscoveryServiceFactory	From	To
Extract Class	1
Extract Class org.neo4j.causalclustering.discovery.SharedDiscoveryServiceFactory from class org.neo4j.causalclustering.discovery.SharedDiscoveryService	From	To
Move And Rename Class	1
Move And Rename Class org.neo4j.causalclustering.discovery.procedures.Role moved and renamed to org.neo4j.causalclustering.discovery.RoleInfo	From	To
Move Class	1
Move Class org.neo4j.harness.CausalClusterInProcessRunner.CausalCluster moved to org.neo4j.harness.CausalClusterInProcessBuilder.CausalCluster	From	To
Merge Parameter	1
Merge Parameter [nCores : int, nReplicas : int, clusterPath : Path, portPickingStrategy : PortPickingStrategy] to bldr : CausalClusterInProcessBuilder.Builder in method private CausalCluster(bldr CausalClusterInProcessBuilder.Builder) in class org.neo4j.harness.CausalClusterInProcessBuilder.CausalCluster	From	To
Extract Variable	1
Extract Variable numMembers : int in method public shouldCollectMembersAsAMap() : void from class org.neo4j.causalclustering.discovery.HazelcastClusterTopologyTest	From	To
Change Variable Type	2
Change Variable Type portPickingStrategy : CausalClusterInProcessRunner.PortPickingStrategy to portPickingStrategy : CausalClusterInProcessBuilder.PortPickingStrategy in method public shouldBootAndShutdownCluster() : void in class org.neo4j.harness.CausalClusterInProcessRunnerIT	From	To
Change Variable Type leader : MemberId to roleMap : Map<MemberId,RoleInfo> in method public apply(ctx Context, input Object[], resourceTracker ResourceTracker) : RawIterator<Object[],ProcedureException> in class org.neo4j.causalclustering.discovery.procedures.ClusterOverviewProcedure	From	To
Extract Method	10
Extract Method private hzClient(jobScheduler OnDemandJobScheduler, cluster Cluster, config Config) : HazelcastClient extracted from public shouldReturnTopologyUsingHazelcastMembers() : void in class org.neo4j.causalclustering.discovery.HazelcastClientTest	From	To
Extract Method private clusterBinder(clusterIdStorage SimpleStorage<ClusterId>, topologyService CoreTopologyService) : ClusterBinder extracted from public shouldBindToClusterIdPublishedByAnotherMember() : void in class org.neo4j.causalclustering.identity.ClusterBinderTest	From	To
Extract Method private makeMember(id int, databaseName String) : Member extracted from private makeMember(id int) : Member in class org.neo4j.causalclustering.discovery.HazelcastClientTest	From	To
Extract Method private startedClientWithMembers(members Set<Member>, config Config) : HazelcastClient extracted from public shouldReturnTopologyUsingHazelcastMembers() : void in class org.neo4j.causalclustering.discovery.HazelcastClientTest	From	To
Extract Method private clusterBinder(clusterIdStorage SimpleStorage<ClusterId>, topologyService CoreTopologyService) : ClusterBinder extracted from public shouldFailToPublishMismatchingStoredClusterId() : void in class org.neo4j.causalclustering.identity.ClusterBinderTest	From	To
Extract Method public getStoreIds(coreStoreDirs List<File>, fs FileSystemAbstraction) : Set<StoreId> extracted from public assertAllStoresHaveTheSameStoreId(coreStoreDirs List<File>, fs FileSystemAbstraction) : void in class org.neo4j.causalclustering.TestStoreId	From	To
Extract Method public getDbWithAnyRole(dbName String, roles Role...) : CoreClusterMember extracted from public getDbWithAnyRole(roles Role...) : CoreClusterMember in class org.neo4j.causalclustering.discovery.Cluster	From	To
Extract Method private clusterBinder(clusterIdStorage SimpleStorage<ClusterId>, topologyService CoreTopologyService) : ClusterBinder extracted from public shouldPublishStoredClusterIdIfPreviouslyBound() : void in class org.neo4j.causalclustering.identity.ClusterBinderTest	From	To
Extract Method private clusterBinder(clusterIdStorage SimpleStorage<ClusterId>, topologyService CoreTopologyService) : ClusterBinder extracted from public shouldBootstrapWhenBootstrappable() : void in class org.neo4j.causalclustering.identity.ClusterBinderTest	From	To
Extract Method private clusterBinder(clusterIdStorage SimpleStorage<ClusterId>, topologyService CoreTopologyService) : ClusterBinder extracted from public shouldTimeoutWhenNotBootrappableAndNobodyElsePublishesClusterId() : void in class org.neo4j.causalclustering.identity.ClusterBinderTest	From	To
Rename Method	10
Rename Method public readReplicas() : ReadReplicaTopology renamed to public allReadReplicas() : ReadReplicaTopology in class org.neo4j.causalclustering.discovery.HazelcastCoreTopologyService	From	To
Rename Method public readReplicas() : ReadReplicaTopology renamed to public allReadReplicas() : ReadReplicaTopology in class org.neo4j.causalclustering.discovery.SharedDiscoveryCoreClient	From	To
Rename Method public withDiscoveryServiceFactory(factory DiscoveryServiceFactory) : ClusterRule renamed to public withDiscoveryServiceType(discoveryType DiscoveryServiceType) : ClusterRule in class org.neo4j.test.causalclustering.ClusterRule	From	To
Rename Method public coreServers() : CoreTopology renamed to public allCoreServers() : CoreTopology in class org.neo4j.causalclustering.discovery.HazelcastCoreTopologyService	From	To
Rename Method public readReplicas() : ReadReplicaTopology renamed to public allReadReplicas() : ReadReplicaTopology in class org.neo4j.causalclustering.discovery.HazelcastClient	From	To
Rename Method public coreServers() : CoreTopology renamed to public allCoreServers() : CoreTopology in class org.neo4j.causalclustering.discovery.TopologyService	From	To
Rename Method public removeCoreMemberWithMemberId(memberId int) : void renamed to public removeCoreMemberWithServerId(serverId int) : void in class org.neo4j.causalclustering.discovery.Cluster	From	To
Rename Method public coreServers() : CoreTopology renamed to public allCoreServers() : CoreTopology in class org.neo4j.causalclustering.discovery.SharedDiscoveryCoreClient	From	To
Rename Method public readReplicas() : ReadReplicaTopology renamed to public allReadReplicas() : ReadReplicaTopology in class org.neo4j.causalclustering.discovery.TopologyService	From	To
Rename Method public coreServers() : CoreTopology renamed to public allCoreServers() : CoreTopology in class org.neo4j.causalclustering.discovery.HazelcastClient	From	To
Rename Variable	3
Rename Variable memberId : MemberId to mId : MemberId in method public shouldCollectMembersAsAMap() : void in class org.neo4j.causalclustering.discovery.HazelcastClusterTopologyTest	From	To
Rename Variable leader : MemberId to roleMap : Map<MemberId,RoleInfo> in method public apply(ctx Context, input Object[], resourceTracker ResourceTracker) : RawIterator<Object[],ProcedureException> in class org.neo4j.causalclustering.discovery.procedures.ClusterOverviewProcedure	From	To
Rename Variable config : Config to c : Config in method public shouldLogAndExcludeMembersWithMissingAttributes() : void in class org.neo4j.causalclustering.discovery.HazelcastClusterTopologyTest	From	To
Change Return Type	4
Change Return Type Role to RoleInfo in method package abstract role() : RoleInfo in class org.neo4j.causalclustering.discovery.procedures.RoleProcedure	From	To
Change Return Type Role to RoleInfo in method public role() : RoleInfo in class org.neo4j.causalclustering.discovery.procedures.ClusterOverviewProcedure.ReadWriteEndPoint	From	To
Change Return Type Role to RoleInfo in method package role() : RoleInfo in class org.neo4j.causalclustering.discovery.procedures.CoreRoleProcedure	From	To
Change Return Type Role to RoleInfo in method package role() : RoleInfo in class org.neo4j.causalclustering.discovery.procedures.ReadReplicaRoleProcedure	From	To
Extract Superclass	1
Extract Superclass org.neo4j.causalclustering.discovery.AbstractTopologyService from classes [org.neo4j.causalclustering.discovery.HazelcastClient, org.neo4j.causalclustering.discovery.HazelcastCoreTopologyService, org.neo4j.causalclustering.discovery.SharedDiscoveryCoreClient, org.neo4j.causalclustering.discovery.SharedDiscoveryReadReplicaClient]	From	To
Rename Attribute	7
Rename Attribute READ_REPLICA_MEMBER_ID_MAP_NAME : String to READ_REPLICA_MEMBER_ID_MAP : String in class org.neo4j.causalclustering.discovery.HazelcastClusterTopology	From	To
Rename Attribute discoveryServiceFactory : DiscoveryServiceFactory to discoveryServiceType : DiscoveryServiceType in class org.neo4j.test.causalclustering.ClusterRule	From	To
Rename Attribute READ_REPLICA_TRANSACTION_SERVER_ADDRESS_MAP_NAME : String to READ_REPLICA_TRANSACTION_SERVER_ADDRESS_MAP : String in class org.neo4j.causalclustering.discovery.HazelcastClusterTopology	From	To
Rename Attribute READ_REPLICA_BOLT_ADDRESS_MAP_NAME : String to READ_REPLICA_BOLT_ADDRESS_MAP : String in class org.neo4j.causalclustering.discovery.HazelcastClusterTopology	From	To
Rename Attribute SERVER_GROUPS_MULTIMAP_NAME : String to SERVER_GROUPS_MULTIMAP : String in class org.neo4j.causalclustering.discovery.HazelcastClusterTopology	From	To
Rename Attribute logProvider : LogProvider to term : long in class org.neo4j.causalclustering.discovery.HazelcastCoreTopologyService	From	To
Rename Attribute member : MemberId to myself : MemberId in class org.neo4j.causalclustering.discovery.SharedDiscoveryCoreClient	From	To
Change Attribute Type	8
Change Attribute Type discoveryServiceFactory : DiscoveryServiceFactory to discoveryServiceType : DiscoveryServiceType in class org.neo4j.test.causalclustering.ClusterRule	From	To
Change Attribute Type coreMembers : Map<MemberId,CoreServerInfo> to coreMembers : ConcurrentMap<MemberId,CoreServerInfo> in class org.neo4j.causalclustering.discovery.SharedDiscoveryService	From	To
Change Attribute Type enoughMembers : Condition to enoughMembers : CountDownLatch in class org.neo4j.causalclustering.discovery.SharedDiscoveryService	From	To
Change Attribute Type listeners : List<CoreTopologyService.Listener> to listeners : Set<CoreTopologyService.Listener> in class org.neo4j.causalclustering.discovery.CoreTopologyListenerService	From	To
Change Attribute Type role : Role to role : RoleInfo in class org.neo4j.causalclustering.discovery.procedures.ClusterOverviewProcedure.ReadWriteEndPoint	From	To
Change Attribute Type role : Role to role : RoleInfo in class org.neo4j.causalclustering.scenarios.ClusterOverviewIT.MemberInfo	From	To
Change Attribute Type logProvider : LogProvider to term : long in class org.neo4j.causalclustering.discovery.HazelcastCoreTopologyService	From	To
Change Attribute Type role : Role to role : RoleInfo in class org.neo4j.causalclustering.discovery.procedures.ClusterOverviewProcedureTest.IsRecord	From	To
Rename Parameter	2
Rename Parameter memberId : int to serverId : int in method public removeCoreMemberWithServerId(serverId int) : void in class org.neo4j.causalclustering.discovery.Cluster	From	To
Rename Parameter factory : DiscoveryServiceFactory to discoveryType : DiscoveryServiceType in method public withDiscoveryServiceType(discoveryType DiscoveryServiceType) : ClusterRule in class org.neo4j.test.causalclustering.ClusterRule	From	To

0c4fd5b0a6e36705ed80d5d462a1d58757f7d1b3

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: