0e4cac0fe0e3516b3cab04fc3975c0ba12abdc1a
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 98
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 5 | ||
| Rename Method public checkNeoStoreHasCurrentFormatVersion(check StoreVersionCheck, workingDirectory File) : boolean renamed to public checkNeoStoreHasDefaultFormatVersion(check StoreVersionCheck, workingDirectory File) : boolean in class org.neo4j.kernel.impl.storemigration.MigrationTestUtils | From | To | |
| Rename Method public storeCopyClientMustRespectConfiguredRecordFormat() : void renamed to private checkStoreCopyClientWithRecordFormats(recordFormatsName String) : void in class org.neo4j.com.storecopy.StoreCopyClientTest | From | To | |
| Rename Method public select(config Config, defaultFormat RecordFormats, logService LogService) : RecordFormats renamed to public selectForConfig(config Config, logProvider LogProvider) : RecordFormats in class org.neo4j.kernel.impl.store.format.RecordFormatSelector | From | To | |
| Rename Method private bumpMessagesDotLogFile(dbDirectory File, toTimestamp long) : boolean renamed to private bumpDebugDotLogFileVersion(dbDirectory File, toTimestamp long) : boolean in class org.neo4j.backup.BackupService | From | To | |
| Rename Method public autoSelectFormat(config Config, logService LogService) : RecordFormats renamed to private selectSpecificFormat(recordFormat String) : RecordFormats in class org.neo4j.kernel.impl.store.format.RecordFormatSelector | From | To | |
| Move And Rename Method | 7 | ||
| Move And Rename Method private getFormatConfig() : Config from class org.neo4j.backup.TestBackup to private getTuningConfig() : Config from class upgrade.StoreUpgraderTest | From | To | |
| Move And Rename Method private getFormatConfig() : Config from class org.neo4j.backup.IncrementalBackupTests to private getTuningConfig() : Config from class upgrade.StoreUpgraderTest | From | To | |
| Move And Rename Method private getConfig() : Config from class org.neo4j.ha.BackupHaIT to private config(recordFormatName String) : Config from class org.neo4j.kernel.impl.store.format.RecordFormatSelectorTest | From | To | |
| Move And Rename Method private getConfig() : Config from class org.neo4j.backup.BackupEmbeddedIT to private config(recordFormatName String) : Config from class org.neo4j.kernel.impl.store.format.RecordFormatSelectorTest | From | To | |
| Move And Rename Method private getTunnningConfig() : Config from class upgrade.StoreUpgraderTest to private config(recordFormatName String) : Config from class org.neo4j.kernel.impl.store.format.RecordFormatSelectorTest | From | To | |
| Move And Rename Method private getConfig() : Config from class org.neo4j.storeupgrade.StoreUpgradeIntegrationTest to private config(recordFormatName String) : Config from class org.neo4j.kernel.impl.store.format.RecordFormatSelectorTest | From | To | |
| Move And Rename Method private getConfig() : Config from class org.neo4j.backup.BackupServiceIT to private config(recordFormatName String) : Config from class org.neo4j.kernel.impl.store.format.RecordFormatSelectorTest | From | To | |
| Move And Inline Method | 1 | ||
| Move And Inline Method public setIdGeneratorFactory(idGeneratorFactory IdGeneratorFactory) : void moved from class org.neo4j.kernel.impl.store.StoreFactory to class org.neo4j.kernel.impl.storageengine.impl.recordstorage.RecordStorageEngine & inlined to public RecordStorageEngine(storeDir File, config Config, idGeneratorFactory IdGeneratorFactory, pageCache PageCache, fs FileSystemAbstraction, logProvider LogProvider, propertyKeyTokenHolder PropertyKeyTokenHolder, labelTokens LabelTokenHolder, relationshipTypeTokens RelationshipTypeTokenHolder, schemaStateChangeCallback Runnable, constraintSemantics ConstraintSemantics, scheduler JobScheduler, tokenNameLookup TokenNameLookup, lockService LockService, indexProvider SchemaIndexProvider, indexingServiceMonitor IndexingService.Monitor, databaseHealth DatabaseHealth, labelScanStoreProvider LabelScanStoreProvider, legacyIndexProviderLookup LegacyIndexProviderLookup, indexConfigStore IndexConfigStore, legacyIndexTransactionOrdering IdOrderingQueue, transactionsSnapshotSupplier Supplier<KernelTransactionsSnapshot>) | From | To | |
| Rename Variable | 7 | ||
| Rename Variable storeFactory : StoreFactory to factory : StoreFactory in method public shouldBeAbleToResumeMigrationOnMoving() : void in class org.neo4j.kernel.impl.storemigration.participant.StoreMigratorTest | From | To | |
| Rename Variable currentFormats : Iterable<RecordFormats> to loadableFormats : Iterable<RecordFormats> in method private allFormats() : Iterable<RecordFormats> in class org.neo4j.kernel.impl.store.format.RecordFormatSelector | From | To | |
| Rename Variable storeFactory : StoreFactory to factory : StoreFactory in method public RecordStorageEngine(storeDir File, config Config, idGeneratorFactory IdGeneratorFactory, pageCache PageCache, fs FileSystemAbstraction, logProvider LogProvider, propertyKeyTokenHolder PropertyKeyTokenHolder, labelTokens LabelTokenHolder, relationshipTypeTokens RelationshipTypeTokenHolder, schemaStateChangeCallback Runnable, constraintSemantics ConstraintSemantics, scheduler JobScheduler, tokenNameLookup TokenNameLookup, lockService LockService, indexProvider SchemaIndexProvider, indexingServiceMonitor IndexingService.Monitor, databaseHealth DatabaseHealth, labelScanStoreProvider LabelScanStoreProvider, legacyIndexProviderLookup LegacyIndexProviderLookup, indexConfigStore IndexConfigStore, legacyIndexTransactionOrdering IdOrderingQueue, transactionsSnapshotSupplier Supplier<KernelTransactionsSnapshot>) in class org.neo4j.kernel.impl.storageengine.impl.recordstorage.RecordStorageEngine | From | To | |
| Rename Variable storeFactory : StoreFactory to factory : StoreFactory in method public setUpNeoStore() : void in class org.neo4j.unsafe.impl.batchimport.PropertyEncoderStepTest | From | To | |
| Rename Variable storeFactory : StoreFactory to factory : StoreFactory in method public upgradedNeoStoreShouldHaveNewUpgradeTimeAndUpgradeId() : void in class upgrade.StoreUpgraderTest | From | To | |
| Rename Variable storeFactory : StoreFactory to factory : StoreFactory in method public deduplicateProperties() : void in class org.neo4j.kernel.impl.storemigration.legacystore.v21.propertydeduplication.PropertyDeduplicator | From | To | |
| Rename Variable storeFactory : StoreFactory to factory : StoreFactory in method public shouldBeAbleToResumeMigrationOnRebuildingCounts() : void in class org.neo4j.kernel.impl.storemigration.participant.StoreMigratorTest | From | To | |
| Inline Method | 4 | ||
| Inline Method public setStoreDir(storeDir File) : void inlined to public StoreFactory(storeDir File, config Config, idGeneratorFactory IdGeneratorFactory, pageCache PageCache, fileSystemAbstraction FileSystemAbstraction, recordFormats RecordFormats, logProvider LogProvider) in class org.neo4j.kernel.impl.store.StoreFactory | From | To | |
| Inline Method private selectSpecificFormat(recordFormat String, logService LogService) : RecordFormats inlined to private selectSpecificFormat(recordFormat String) : RecordFormats in class org.neo4j.kernel.impl.store.format.RecordFormatSelector | From | To | |
| Inline Method public setLogProvider(logProvider LogProvider) : void inlined to public StoreFactory(storeDir File, config Config, idGeneratorFactory IdGeneratorFactory, pageCache PageCache, fileSystemAbstraction FileSystemAbstraction, recordFormats RecordFormats, logProvider LogProvider) in class org.neo4j.kernel.impl.store.StoreFactory | From | To | |
| Inline Method public assertConsistentStore(dir File, config Config) : void inlined to public assertConsistentStore(dir File) : void in class org.neo4j.consistency.store.StoreAssertions | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable unkownFormat : String to recordFormatsName : String in method private checkStoreCopyClientWithRecordFormats(recordFormatsName String) : void in class org.neo4j.com.storecopy.StoreCopyClientTest | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute select : RecordFormats to format : RecordFormats in class org.neo4j.com.StoreIdTestFactory | From | To | |
| Rename Attribute format : RecordFormats to recordFormat : RecordFormats in class upgrade.StoreMigratorFrom20IT | From | To | |
| Extract Variable | 6 | ||
| Extract Variable internalLogProvider : LogProvider in method public BatchInserterImpl(storeDir File, fileSystem FileSystemAbstraction, stringParams Map<String,String>, kernelExtensions Iterable<KernelExtensionFactory<?>>) from class org.neo4j.unsafe.batchinsert.internal.BatchInserterImpl | From | To | |
| Extract Variable logProvider : LogProvider in method public shouldAbortLoadingGroupChainIfComeTooFar() : void from class org.neo4j.kernel.impl.transaction.state.RelationshipGroupGetterTest | From | To | |
| Extract Variable log : Log in method private getOrCreatePageCache(config Config, fs FileSystemAbstraction) : PageCache from class org.neo4j.test.rule.NeoStoresRule | From | To | |
| Extract Variable logProvider : LogProvider in method public directStoreAccess() : DirectStoreAccess from class org.neo4j.consistency.checking.GraphStoreFixture | From | To | |
| Extract Variable loadableFormatFactories : Iterable<RecordFormats.Factory> in method private allFormats() : Iterable<RecordFormats> from class org.neo4j.kernel.impl.store.format.RecordFormatSelector | From | To | |
| Extract Variable logProvider : LogProvider in method private newMetaDataStore() : MetaDataStore from class org.neo4j.kernel.impl.store.MetaDataStoreTest | From | To | |
| Extract Method | 6 | ||
| Extract Method private newStoreFactory(pageCache PageCache) : StoreFactory extracted from public shouldDetectSabotagedRelationshipWhereEverItIs() : void in class org.neo4j.consistency.checking.full.DetectAllRelationshipInconsistenciesIT | From | To | |
| Extract Method private getOrCreatePageCache(config Config, fs FileSystemAbstraction) : PageCache extracted from public open(format RecordFormats, config String...) : NeoStores in class org.neo4j.test.rule.NeoStoresRule | From | To | |
| Extract Method private defaultStoreVersion() : long extracted from public shouldAddUpgradeFieldsToTheNeoStoreIfNotPresent() : void in class org.neo4j.kernel.impl.store.NeoStoresTest | From | To | |
| Extract Method private defaultStoreVersion() : long extracted from public shouldNotReadNonRecordDataAsRecord() : void in class org.neo4j.kernel.impl.store.NeoStoresTest | From | To | |
| Extract Method private allFormats() : Iterable<RecordFormats> extracted from public selectForVersion(storeVersion String) : RecordFormats in class org.neo4j.kernel.impl.store.format.RecordFormatSelector | From | To |