165b40528535ef90250320b274665a9afb17d448
Files Diff
- Added: 4
- Removed: 1
- Renamed: 0
- Modified: 62
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method private storeCommitIndex(commitIndex long) : void renamed to private storeMetadata() : void in class org.neo4j.coreedge.raft.log.NaiveDurableRaftLog | From | To | |
| Rename Method public getLogEntry() : RaftLogEntry renamed to public logEntry() : RaftLogEntry in class org.neo4j.coreedge.raft.log.RaftLogAppendRecord | From | To | |
| Push Down Method | 4 | ||
| Push Down Method public getLogIndex() : long from class org.neo4j.coreedge.raft.log.RaftLogRecord to public logIndex() : long from class org.neo4j.coreedge.raft.log.RaftLogAppendRecord | From | To | |
| Push Down Method public getLogIndex() : long from class org.neo4j.coreedge.raft.log.RaftLogRecord to public commitIndex() : long from class org.neo4j.coreedge.raft.log.RaftLogCommitRecord | From | To | |
| Push Down Method public getLogIndex() : long from class org.neo4j.coreedge.raft.log.RaftLogRecord to public prevLogIndex() : long from class org.neo4j.coreedge.raft.log.RaftLogContinuationRecord | From | To | |
| Push Down Method public getLogIndex() : long from class org.neo4j.coreedge.raft.log.RaftLogRecord to public prevLogTerm() : long from class org.neo4j.coreedge.raft.log.RaftLogContinuationRecord | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type recordCursor : RaftRecordCursor<?> to recordCursor : IOCursor<RaftLogRecord> in method public PhysicalRaftLogEntryCursor(recordCursor IOCursor<RaftLogRecord>, skipStack Stack<Long>, fromIndex long) in class org.neo4j.coreedge.raft.log.PhysicalRaftLogEntryCursor | From | To | |
| Rename Variable | 4 | ||
| Rename Variable commitFile : File to metaFile : File in method public shouldCallWriteAllWhenStoringEntries() : void in class org.neo4j.coreedge.raft.log.NaiveDurableRaftLogTest | From | To | |
| Rename Variable commitFile : File to metaFile : File in method public shouldForceAndCloseFilesOnShutdownEvenOnFailure() : void in class org.neo4j.coreedge.raft.log.NaiveDurableRaftLogTest | From | To | |
| Rename Variable commitFile : File to metaFile : File in method public shouldForceAndCloseFilesOnShutdown() : void in class org.neo4j.coreedge.raft.log.NaiveDurableRaftLogTest | From | To | |
| Rename Variable fromIndex : long to prevLogIndex : long in method public read(channel ReadableChannel) : RaftLogContinuationRecord in class org.neo4j.coreedge.raft.log.RaftLogContinuationRecord | From | To | |
| Change Return Type | 9 | ||
| Change Return Type IOCursor<RaftLogEntry> to RaftLogCursor in method public getEntryCursor(fromIndex long) : RaftLogCursor in class org.neo4j.coreedge.raft.membership.CatchupGoalTest.StubLog | From | To | |
| Change Return Type IOCursor<RaftLogEntry> to RaftLogCursor in method public getEntryCursor(fromIndex long) : RaftLogCursor in class org.neo4j.coreedge.raft.log.InMemoryRaftLog | From | To | |
| Change Return Type IOCursor<RaftLogEntry> to RaftLogCursor in method public getEntryCursor(fromIndex long) : RaftLogCursor in class org.neo4j.coreedge.raft.log.ReadableRaftLog | From | To | |
| Change Return Type IOCursor<RaftLogEntry> to RaftLogCursor in method public getEntryCursor(fromIndex long) : RaftLogCursor in class org.neo4j.coreedge.raft.log.MonitoredRaftLog | From | To | |
| Change Return Type IOCursor<RaftLogEntry> to RaftLogCursor in method public getEntryCursor(fromIndex long) : RaftLogCursor in class org.neo4j.coreedge.raft.log.PhysicalRaftLog | From | To | |
| Change Return Type IOCursor<RaftLogEntry> to RaftLogCursor in method public getEntryCursor(fromIndex long) : RaftLogCursor in class org.neo4j.coreedge.raft.log.VerifyingRaftLog | From | To | |
| Change Return Type IOCursor<RaftLogEntry> to RaftLogCursor in method public getEntryCursor(fromIndex long) : RaftLogCursor in class org.neo4j.coreedge.raft.membership.CatchupGoalTrackerTest.StubLog | From | To | |
| Change Return Type IOCursor<RaftLogEntry> to RaftLogCursor in method public getEntryCursor(fromIndex long) : RaftLogCursor in class org.neo4j.coreedge.raft.RaftInstanceTest.ExplodingRaftLog | From | To | |
| Change Return Type IOCursor<RaftLogEntry> to RaftLogCursor in method public getEntryCursor(fromIndex long) : RaftLogCursor in class org.neo4j.coreedge.raft.log.NaiveDurableRaftLog | From | To | |
| Extract Attribute | 1 | ||
| Extract Attribute private prevIndex : long in class org.neo4j.coreedge.raft.log.PhysicalRaftLog | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute COMMIT_INDEX_BYTES : int to META_BYTES : int in class org.neo4j.coreedge.raft.log.NaiveDurableRaftLog | From | To | |
| Rename Attribute commitChannel : StoreChannel to metaChannel : StoreChannel in class org.neo4j.coreedge.raft.log.NaiveDurableRaftLog | From | To | |
| Change Variable Type | 10 | ||
| Change Variable Type cursor : IOCursor<RaftLogEntry> to cursor : RaftLogCursor in method public ComparableRaftLog(raftLog ReadableRaftLog) in class org.neo4j.coreedge.raft.state.explorer.ComparableRaftLog | From | To | |
| Change Variable Type cursor : IOCursor<RaftLogEntry> to cursor : RaftLogCursor in method private sendSingle(logIndex long, leaderContext LeaderContext) : void in class org.neo4j.coreedge.raft.replication.shipping.RaftLogShipper | From | To | |
| Change Variable Type cursor : IOCursor<RaftLogEntry> to cursor : RaftLogCursor in method public readLogEntry(raftLog ReadableRaftLog, index long) : RaftLogEntry in class org.neo4j.coreedge.raft.log.RaftLogHelper | From | To | |
| Change Variable Type cursor : IOCursor<RaftLogEntry> to cursor : RaftLogCursor in method public print(out PrintStream) : void in class org.neo4j.coreedge.raft.log.debug.LogPrinter | From | To | |
| Change Variable Type cursor : IOCursor<RaftLogEntry> to cursor : RaftLogCursor in method private findLastMembershipEntry() : Pair<Long,RaftGroup<MEMBER>> in class org.neo4j.coreedge.raft.membership.RaftMembershipManager | From | To | |
| Change Variable Type otherCursor : IOCursor<RaftLogEntry> to otherCursor : RaftLogCursor in method private verifyTraversalUsingCursor(expected RaftLog, other RaftLog) : void in class org.neo4j.coreedge.raft.log.VerifyingRaftLog | From | To | |
| Change Variable Type expectedCursor : IOCursor<RaftLogEntry> to expectedCursor : RaftLogCursor in method private verifyTraversalUsingCursor(expected RaftLog, other RaftLog) : void in class org.neo4j.coreedge.raft.log.VerifyingRaftLog | From | To | |
| Change Variable Type cursor : IOCursor<RaftLogEntry> to cursor : RaftLogCursor in method private applyUpTo(commitIndex long) : void in class org.neo4j.coreedge.raft.state.StateMachineApplier | From | To | |
| Change Variable Type cursor : IOCursor<RaftLogEntry> to cursor : RaftLogCursor in method private sendRange(startIndex long, endIndex long, leaderContext LeaderContext) : void in class org.neo4j.coreedge.raft.replication.shipping.RaftLogShipper | From | To | |
| Change Variable Type entryCursor : IOCursor<RaftLogEntry> to entryCursor : RaftLogCursor in method public processLog(logCommands Collection<LogCommand>) : void in class org.neo4j.coreedge.raft.membership.RaftMembershipManager | From | To | |
| Extract Variable | 2 | ||
| Extract Variable newTerm : long in method public truncate(fromIndex long) : void from class org.neo4j.coreedge.raft.log.PhysicalRaftLog | From | To | |
| Extract Variable logHeaderCache : LogHeaderCache in method public PhysicalRaftLog(fileSystem FileSystemAbstraction, directory File, rotateAtSize long, entryCacheSize int, metaDataCacheSize int, headerCacheSize int, monitor PhysicalLogFile.Monitor, marshal ChannelMarshal<ReplicatedContent>, databaseHealthSupplier Supplier<DatabaseHealth>, logProvider LogProvider) from class org.neo4j.coreedge.raft.log.PhysicalRaftLog | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type recordCursor : RaftRecordCursor<?> to recordCursor : IOCursor<RaftLogRecord> in class org.neo4j.coreedge.raft.log.PhysicalRaftLogEntryCursor | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter fromIndex : long to prevLogIndex : long in method public write(channel WritableChannel, prevLogIndex long, prevLogTerm long) : void in class org.neo4j.coreedge.raft.log.RaftLogContinuationRecord | From | To | |
| Rename Parameter logIndex : long to commitIndex : long in method public RaftLogCommitRecord(commitIndex long) in class org.neo4j.coreedge.raft.log.RaftLogCommitRecord | From | To | |
| Rename Parameter logIndex : long to appendIndex : long in method package RaftLogAppendRecord(appendIndex long, logEntry RaftLogEntry) in class org.neo4j.coreedge.raft.log.RaftLogAppendRecord | From | To |