185ecaa585f82acd069fd9c29f4bf0309ded1994
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 121
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 6 | ||
| Rename Method public shouldWrapIOExceptionsCarefulllyBecauseCriticalInformationIsOftenEncodedInTheirNameButMissingFromTheirMessage() : void renamed to public shouldWrapIOExceptionsCarefullyBecauseCriticalInformationIsOftenEncodedInTheirNameButMissingFromTheirMessage() : void in class org.neo4j.commandline.dbms.LoadCommandTest | From | To | |
| Rename Method private toDatabaseDirectory(databaseName String) : Path renamed to private buildConfig(databaseName String) : Config in class org.neo4j.commandline.dbms.DumpCommand | From | To | |
| Rename Method private toDatabaseDirectory(databaseName String) : Path renamed to private buildConfig(databaseName String) : Config in class org.neo4j.commandline.dbms.LoadCommand | From | To | |
| Rename Method private createPhysicalLogFiles(transactionIdStore TransactionIdStore, fileSystemAbstraction FileSystemAbstraction) : LogFiles renamed to private createLogFiles(transactionIdStore TransactionIdStore, fileSystemAbstraction FileSystemAbstraction) : LogFiles in class org.neo4j.kernel.impl.transaction.log.stresstest.workload.Runner | From | To | |
| Rename Method public moveToDirectoryMustRecursivelyMoveAllFilesInGivenDirectory() : void renamed to public copyToDirectoryCopiesFile() : void in class org.neo4j.io.fs.FileSystemAbstractionTest | From | To | |
| Rename Method public shouldWrapIOExceptionsCarefulllyBecauseCriticalInformationIsOftenEncodedInTheirNameButMissingFromTheirMessage() : void renamed to public shouldWrapIOExceptionsCarefullyBecauseCriticalInformationIsOftenEncodedInTheirNameButMissingFromTheirMessage() : void in class org.neo4j.commandline.dbms.DumpCommandTest | From | To | |
| Rename Variable | 2 | ||
| Rename Variable storeFiles : File[] to indexFiles : File[] in method private gatherNonRecordStores(files Collection<StoreFileMetadata>, includeLogs boolean) : void in class org.neo4j.kernel.impl.transaction.state.NeoStoreFileListing | From | To | |
| Rename Variable existingDbDir : File to storeDir : File in method public createClassicNeo4jStore(base File, fileSystem FileSystemAbstraction, nodesToCreate int, recordFormat String, logicalLogsLocation String) : File in class org.neo4j.causalclustering.backup.RestoreClusterUtils | From | To | |
| Change Return Type | 2 | ||
| Change Return Type Path to Config in method private buildConfig(databaseName String) : Config in class org.neo4j.commandline.dbms.DumpCommand | From | To | |
| Change Return Type Path to Config in method private buildConfig(databaseName String) : Config in class org.neo4j.commandline.dbms.LoadCommand | From | To | |
| Move Attribute | 3 | ||
| Move Attribute public database_path : Setting<File> from class org.neo4j.dbms.DatabaseManagementSystemSettings to public database_path : Setting<File> from class org.neo4j.graphdb.factory.GraphDatabaseSettings | From | To | |
| Move Attribute public active_database : Setting<String> from class org.neo4j.dbms.DatabaseManagementSystemSettings to public active_database : Setting<String> from class org.neo4j.graphdb.factory.GraphDatabaseSettings | From | To | |
| Move Attribute public data_directory : Setting<File> from class org.neo4j.dbms.DatabaseManagementSystemSettings to public data_directory : Setting<File> from class org.neo4j.graphdb.factory.GraphDatabaseSettings | From | To | |
| Rename Attribute | 4 | ||
| Rename Attribute storeDirectory : TestDirectory to testDirectory : TestDirectory in class org.neo4j.consistency.ConsistencyCheckToolTest | From | To | |
| Rename Attribute logDirectory : File to storeDirectory : File in class org.neo4j.kernel.impl.transaction.log.files.TransactionLogFilesTest | From | To | |
| Rename Attribute testDir : TestDirectory to directory : TestDirectory in class org.neo4j.com.storecopy.StoreCopyClientTest | From | To | |
| Rename Attribute directory : File to storeDirectory : File in class org.neo4j.kernel.impl.transaction.log.files.LogFilesBuilderTest | From | To | |
| Extract Variable | 5 | ||
| Extract Variable config : Config in method package loadConfig(additionalConfig Optional<Path>) : Config from class org.neo4j.backup.OnlineBackupCommandConfigLoader | From | To | |
| Extract Variable dependencyResolver : DependencyResolver in method protected run(args Args, out PrintStream) : void from class org.neo4j.tools.applytx.ApplyTransactionsCommand | From | To | |
| Extract Variable path : String in method private doWrite(writer StoreWriter, temporaryBuffer ByteBuffer, file File, recordSize int, fileChannel ReadableByteChannel, fileSize long, storeCopyIdentifier String, isLogFile boolean) : void from class org.neo4j.com.storecopy.StoreCopyServer | From | To | |
| Extract Variable destination : File in method public moveTo(source File, target File, logFiles LogFiles) : void from class org.neo4j.causalclustering.catchup.storecopy.StoreFiles | From | To | |
| Extract Variable logFilesBuilder : LogFilesBuilder in method package TransactionLogCatchUpWriter(storeDir File, fs FileSystemAbstraction, pageCache PageCache, config Config, logProvider LogProvider, fromTxId long, asPartOfStoreCopy boolean, keepTxLogsInStoreDir boolean) from class org.neo4j.causalclustering.catchup.tx.TransactionLogCatchUpWriter | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type fileSystem : EphemeralFileSystemAbstraction to fileSystem : DefaultFileSystemAbstraction in class org.neo4j.kernel.impl.transaction.log.files.LogFilesBuilderTest | From | To | |
| Change Attribute Type fileSystemRule : EphemeralFileSystemRule to fileSystemRule : DefaultFileSystemRule in class org.neo4j.kernel.impl.transaction.log.files.LogFilesBuilderTest | From | To | |
| Extract Method | 12 | ||
| Extract Method private getRecoveryCheckerWithDefaultConfig(fileSystem FileSystemAbstraction, pageCache PageCache) : RecoveryRequiredChecker extracted from public shouldBeAbleToRecoverBrokenStore() : void in class org.neo4j.kernel.impl.recovery.RecoveryRequiredCheckerTest | From | To | |
| Extract Method private bootstrapAndVerify(nodeCount long, fileSystem FileSystemAbstraction, classicNeo4jStore File, pageCache PageCache, config Config, bootstrapper CoreBootstrapper) : void extracted from public shouldSetAllCoreState() : void in class org.neo4j.causalclustering.core.state.CoreBootstrapperIT | From | To | |
| Extract Method private startGraphDatabase(storeDir File, withOnlineBackup boolean, backupPort Integer, logLocation String) : GraphDatabaseService extracted from private startGraphDatabase(storeDir File, withOnlineBackup boolean, backupPort Integer) : GraphDatabaseService in class org.neo4j.backup.BackupIT | From | To | |
| Extract Method private createAndCrashWithDefaultConfig() : FileSystemAbstraction extracted from public shouldWantToRecoverBrokenStore() : void in class org.neo4j.kernel.impl.recovery.RecoveryRequiredCheckerTest | From | To | |
| Extract Method private createTransactionLogWithCheckpoint(config Config, logsInStoreDir boolean) : void extracted from public shouldCreateTransactionLogWithCheckpoint() : void in class org.neo4j.causalclustering.catchup.tx.TransactionLogCatchUpWriterTest | From | To | |
| Extract Method private visitPath(transactionalLogsPath Path, exclude Predicate<Path>, stream ArchiveOutputStream) : void extracted from public dump(root Path, archive Path, exclude Predicate<Path>) : void in class org.neo4j.dbms.archive.Dumper | From | To | |
| Extract Method private getRecoveryCheckerWithDefaultConfig(fileSystem FileSystemAbstraction, pageCache PageCache) : RecoveryRequiredChecker extracted from public shouldWantToRecoverBrokenStore() : void in class org.neo4j.kernel.impl.recovery.RecoveryRequiredCheckerTest | From | To | |
| Extract Method private createTestData(nodesToCreate int, db GraphDatabaseService) : void extracted from private createDbAt(fromPath File, nodesToCreate int) : void in class org.neo4j.restore.RestoreDatabaseCommandIT | From | To | |
| Extract Method public createClassicNeo4jStore(base File, fileSystem FileSystemAbstraction, nodesToCreate int, recordFormat String, logicalLogsLocation String) : File extracted from public createClassicNeo4jStore(base File, fileSystem FileSystemAbstraction, nodesToCreate int, recordFormat String) : File in class org.neo4j.causalclustering.backup.RestoreClusterUtils | From | To | |
| Extract Method private validatePath(path Path) : void extracted from public load(archive Path, destination Path) : void in class org.neo4j.dbms.archive.Loader | From | To | |
| Extract Method private createAndCrashWithDefaultConfig() : FileSystemAbstraction extracted from public shouldBeAbleToRecoverBrokenStore() : void in class org.neo4j.kernel.impl.recovery.RecoveryRequiredCheckerTest | From | To | |
| Extract Method private getRecoveryCheckerWithDefaultConfig(fileSystem FileSystemAbstraction, pageCache PageCache) : RecoveryRequiredChecker extracted from public shouldNotWantToRecoverIntactStore() : void in class org.neo4j.kernel.impl.recovery.RecoveryRequiredCheckerTest | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter storeDirectory : File to logsDirectory : File in method public logFilesBasedOnlyBuilder(logsDirectory File, fileSystem FileSystemAbstraction) : LogFilesBuilder in class org.neo4j.kernel.impl.transaction.log.files.LogFilesBuilder | From | To | |
| Rename Parameter directory : File to logsDirectory : File in method package TransactionLogFiles(logsDirectory File, name String, context TransactionLogFilesContext) in class org.neo4j.kernel.impl.transaction.log.files.TransactionLogFiles | From | To | |
| Rename Parameter destination : Path to databaseDestination : Path in method public load(archive Path, databaseDestination Path, transactionLogsDirectory Path) : void in class org.neo4j.dbms.archive.Loader | From | To | |
| Rename Parameter root : Path to dbPath : Path in method public dump(dbPath Path, transactionalLogsPath Path, archive Path, exclude Predicate<Path>) : void in class org.neo4j.dbms.archive.Dumper | From | To |