neo4j 18d1a50d704a1fa306dd85abe3b8baff19284a03

18d1a50d704a1fa306dd85abe3b8baff19284a03

Files Diff

Added: 1
Removed: 0
Renamed: 0
Modified: 26

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	2
Move And Rename Method private serverConfig() : Server.Configuration from class org.neo4j.kernel.ha.cluster.SwitchToSlave to private masterServerConfig(config Config) : Server.Configuration from class org.neo4j.kernel.ha.factory.EnterpriseEditionModule	From	To
Move And Rename Method private serverConfig() : Server.Configuration from class org.neo4j.kernel.ha.cluster.SwitchToMaster to private slaveServerConfig(config Config) : Server.Configuration from class org.neo4j.kernel.ha.factory.EnterpriseEditionModule	From	To
Change Parameter Type	9
Change Parameter Type resolver : DependencyResolver to dependencies : Dependencies in method public TransactionCommittingResponseUnpacker(dependencies Dependencies, maxBatchSize int) in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpacker	From	To
Change Parameter Type graphdb : GraphDatabaseAPI to neoStoreSupplier : Supplier<NeoStore> in method public OnDiskLastTxIdGetter(neoStoreSupplier Supplier<NeoStore>) in class org.neo4j.kernel.ha.transaction.OnDiskLastTxIdGetter	From	To
Change Parameter Type resolver : DependencyResolver to transactionIdStoreSupplier : Supplier<TransactionIdStore> in method public UpdatePullingTransactionObligationFulfiller(updatePuller UpdatePuller, memberStateMachine HighAvailabilityMemberStateMachine, serverId InstanceId, transactionIdStoreSupplier Supplier<TransactionIdStore>) in class org.neo4j.kernel.ha.UpdatePullingTransactionObligationFulfiller	From	To
Change Parameter Type resolver : DependencyResolver to dependencies : Dependencies in method public TransactionCommittingResponseUnpacker(dependencies Dependencies) in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpacker	From	To
Change Parameter Type resolver : DependencyResolver to supplier : Supplier<TransactionObligationFulfiller> in method private resolveTransactionObligationFulfiller(supplier Supplier<TransactionObligationFulfiller>) : TransactionObligationFulfiller in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpacker	From	To
Change Parameter Type neoDataSource : NeoStoreDataSource to storeId : StoreId in method private checkDataConsistencyWithMaster(availableMasterId URI, master Master, storeId StoreId, transactionIdStore TransactionIdStore) : void in class org.neo4j.kernel.ha.cluster.SwitchToSlave	From	To
Change Parameter Type neoDataSource : NeoStoreDataSource to myStoreId : StoreId in method private checkMyStoreIdAndMastersStoreId(myStoreId StoreId, masterIsOld boolean) : void in class org.neo4j.kernel.ha.cluster.SwitchToSlave	From	To
Change Parameter Type neoDataSource : NeoStoreDataSource to storeId : StoreId in method package checkDataConsistency(masterClient MasterClient, txIdStore TransactionIdStore, storeId StoreId, masterUri URI, masterIsOld boolean) : void in class org.neo4j.kernel.ha.cluster.SwitchToSlave	From	To
Change Parameter Type resolver : DependencyResolver to txIdStoreSupplier : Supplier<TransactionIdStore> in method public RequestContextFactory(serverId int, txIdStoreSupplier Supplier<TransactionIdStore>) in class org.neo4j.kernel.ha.com.RequestContextFactory	From	To
Change Variable Type	8
Change Variable Type logicalTransactionStore : LogicalTransactionStore to applier : TransactionRepresentationStoreApplier in method public shouldApplyQueuedTransactionsIfMany() : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Change Variable Type dependencyResolver : DependencyResolver to deps : TransactionCommittingResponseUnpacker.Dependencies in method public shouldIssueKernelPanicInCaseOfFailureToAppendOrApply() : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Change Variable Type resolver : DependencyResolver to deps : TransactionCommittingResponseUnpacker.Dependencies in method public shouldNotApplyTransactionIfIndexUpdatesValidationFails() : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Change Variable Type dependencyResolver : DependencyResolver to deps : TransactionCommittingResponseUnpacker.Dependencies in method public shouldAwaitTransactionObligationsToBeFulfilled() : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Change Variable Type dependencyResolver : DependencyResolver to deps : TransactionCommittingResponseUnpacker.Dependencies in method public shouldApplyQueuedTransactionsIfMany() : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Change Variable Type dataSource : NeoStoreDataSource to transactionIdStore : TransactionIdStore in method public shouldHandleBranchedStoreWhenMyStoreIdDiffersFromMasterStoreId() : void in class org.neo4j.kernel.ha.cluster.SwitchToSlaveTest	From	To
Change Variable Type dependencyResolver : DependencyResolver to deps : TransactionCommittingResponseUnpacker.Dependencies in method public testStopShouldAllowTransactionsToCompleteCommitAndApply() : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Change Variable Type masterImpl : MasterImpl to master : Master in method public switchToMaster(haCommunicationLife LifeSupport, me URI) : URI in class org.neo4j.kernel.ha.cluster.SwitchToMaster	From	To
Inline Variable	1
Inline Variable resolver : DependencyResolver in method public clientShouldReadAndApplyTransactionLogsOnNewLockSessionRequest() : void from class org.neo4j.ha.upgrade.MasterClientTest	From	To
Split Attribute	1
Split Attribute resolver : DependencyResolver to [fileSystemAbstraction : FileSystemAbstraction, monitors : Monitors, clusterMembers : ClusterMembers] in class org.neo4j.kernel.ha.cluster.SwitchToSlave	From	To
Extract Method	8
Extract Method private buildDependencies(transactionIdStore TransactionIdStore, logFile LogFile, health KernelHealth, logRotation LogRotation, indexUpdatesValidator IndexUpdatesValidator, storeApplier TransactionRepresentationStoreApplier, appender TransactionAppender, obligationFulfiller TransactionObligationFulfiller) : TransactionCommittingResponseUnpacker.Dependencies extracted from public shouldIssueKernelPanicInCaseOfFailureToAppendOrApply() : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Extract Method private buildDependencies(transactionIdStore TransactionIdStore, logFile LogFile, health KernelHealth, logRotation LogRotation, indexUpdatesValidator IndexUpdatesValidator, storeApplier TransactionRepresentationStoreApplier, appender TransactionAppender, obligationFulfiller TransactionObligationFulfiller) : TransactionCommittingResponseUnpacker.Dependencies extracted from public shouldAwaitTransactionObligationsToBeFulfilled() : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Extract Method private masterServerConfig(config Config) : Server.Configuration extracted from public EnterpriseEditionModule(platformModule PlatformModule) in class org.neo4j.kernel.ha.factory.EnterpriseEditionModule	From	To
Extract Method private buildDependencies(transactionIdStore TransactionIdStore, logFile LogFile, health KernelHealth, logRotation LogRotation, indexUpdatesValidator IndexUpdatesValidator, storeApplier TransactionRepresentationStoreApplier, appender TransactionAppender, obligationFulfiller TransactionObligationFulfiller) : TransactionCommittingResponseUnpacker.Dependencies extracted from public shouldApplyQueuedTransactionsIfMany() : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Extract Method private slaveServerConfig(config Config) : Server.Configuration extracted from public EnterpriseEditionModule(platformModule PlatformModule) in class org.neo4j.kernel.ha.factory.EnterpriseEditionModule	From	To
Extract Method private buildDependencies(transactionIdStore TransactionIdStore, logFile LogFile, health KernelHealth, logRotation LogRotation, indexUpdatesValidator IndexUpdatesValidator, storeApplier TransactionRepresentationStoreApplier, appender TransactionAppender, obligationFulfiller TransactionObligationFulfiller) : TransactionCommittingResponseUnpacker.Dependencies extracted from public shouldNotMarkTransactionsAsCommittedIfAppenderClosed() : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Extract Method private buildDependencies(transactionIdStore TransactionIdStore, logFile LogFile, health KernelHealth, logRotation LogRotation, indexUpdatesValidator IndexUpdatesValidator, storeApplier TransactionRepresentationStoreApplier, appender TransactionAppender, obligationFulfiller TransactionObligationFulfiller) : TransactionCommittingResponseUnpacker.Dependencies extracted from public testStopShouldAllowTransactionsToCompleteCommitAndApply() : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Extract Method private buildDependencies(transactionIdStore TransactionIdStore, logFile LogFile, health KernelHealth, logRotation LogRotation, indexUpdatesValidator IndexUpdatesValidator, storeApplier TransactionRepresentationStoreApplier, appender TransactionAppender, obligationFulfiller TransactionObligationFulfiller) : TransactionCommittingResponseUnpacker.Dependencies extracted from public shouldNotApplyTransactionIfIndexUpdatesValidationFails() : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Rename Variable	8
Rename Variable logicalTransactionStore : LogicalTransactionStore to applier : TransactionRepresentationStoreApplier in method public shouldApplyQueuedTransactionsIfMany() : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Rename Variable dependencyResolver : DependencyResolver to deps : TransactionCommittingResponseUnpacker.Dependencies in method public shouldIssueKernelPanicInCaseOfFailureToAppendOrApply() : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Rename Variable resolver : DependencyResolver to deps : TransactionCommittingResponseUnpacker.Dependencies in method public shouldNotApplyTransactionIfIndexUpdatesValidationFails() : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Rename Variable dependencyResolver : DependencyResolver to deps : TransactionCommittingResponseUnpacker.Dependencies in method public shouldApplyQueuedTransactionsIfMany() : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Rename Variable dependencyResolver : DependencyResolver to deps : TransactionCommittingResponseUnpacker.Dependencies in method public shouldAwaitTransactionObligationsToBeFulfilled() : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Rename Variable dataSource : NeoStoreDataSource to transactionIdStore : TransactionIdStore in method public shouldHandleBranchedStoreWhenMyStoreIdDiffersFromMasterStoreId() : void in class org.neo4j.kernel.ha.cluster.SwitchToSlaveTest	From	To
Rename Variable dependencyResolver : DependencyResolver to deps : TransactionCommittingResponseUnpacker.Dependencies in method public testStopShouldAllowTransactionsToCompleteCommitAndApply() : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Rename Variable masterImpl : MasterImpl to master : Master in method public switchToMaster(haCommunicationLife LifeSupport, me URI) : URI in class org.neo4j.kernel.ha.cluster.SwitchToMaster	From	To
Change Return Type	1
Change Return Type void to IndexUpdatesValidator in method private setUpIndexUpdatesValidatorMocking() : IndexUpdatesValidator in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Replace Variable With Attribute	2
Replace Variable With Attribute txCommitProcess : TransactionCommitProcess to transactionCommitProcess : TransactionCommitProcess in method public applyPreparedTransaction(preparedTransaction TransactionRepresentation) : long in class org.neo4j.kernel.ha.cluster.DefaultMasterImplSPI	From	To
Replace Variable With Attribute dataSource : NeoStoreDataSource to neoStoreDataSource : NeoStoreDataSource in method public flushStoresAndStreamStoreFiles(writer StoreWriter) : RequestContext in class org.neo4j.kernel.ha.cluster.DefaultMasterImplSPI	From	To
Parameterize Variable	8
Parameterize Variable myStoreId : StoreId to storeId : StoreId in method private executeConsistencyChecks(myId InstanceId, txIdStore TransactionIdStore, masterUri URI, storeId StoreId, cancellationRequest CancellationRequest) : boolean in class org.neo4j.kernel.ha.cluster.SwitchToSlave	From	To
Parameterize Variable kernelHealth : KernelHealth to health : KernelHealth in method private buildDependencies(transactionIdStore TransactionIdStore, logFile LogFile, health KernelHealth, logRotation LogRotation, indexUpdatesValidator IndexUpdatesValidator, storeApplier TransactionRepresentationStoreApplier, appender TransactionAppender, obligationFulfiller TransactionObligationFulfiller) : TransactionCommittingResponseUnpacker.Dependencies in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Parameterize Variable txIdStore : TransactionIdStore to transactionIdStore : TransactionIdStore in method private buildDependencies(transactionIdStore TransactionIdStore, logFile LogFile, health KernelHealth, logRotation LogRotation, indexUpdatesValidator IndexUpdatesValidator, storeApplier TransactionRepresentationStoreApplier, appender TransactionAppender, obligationFulfiller TransactionObligationFulfiller) : TransactionCommittingResponseUnpacker.Dependencies in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Parameterize Variable validator : IndexUpdatesValidator to indexUpdatesValidator : IndexUpdatesValidator in method private buildDependencies(transactionIdStore TransactionIdStore, logFile LogFile, health KernelHealth, logRotation LogRotation, indexUpdatesValidator IndexUpdatesValidator, storeApplier TransactionRepresentationStoreApplier, appender TransactionAppender, obligationFulfiller TransactionObligationFulfiller) : TransactionCommittingResponseUnpacker.Dependencies in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest	From	To
Rename Attribute	8
Rename Attribute resolver : DependencyResolver to dependencies : Dependencies in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpacker	From	To
Rename Attribute masterRequestMonitor : RequestMonitor to masterServerFactory : Function<Master,MasterServer> in class org.neo4j.kernel.ha.cluster.SwitchToMaster	From	To
Rename Attribute resolver : DependencyResolver to txIdStoreSupplier : Supplier<TransactionIdStore> in class org.neo4j.kernel.ha.com.RequestContextFactory	From	To
Rename Attribute resolver : DependencyResolver to transactionIdStoreSupplier : Supplier<TransactionIdStore> in class org.neo4j.kernel.ha.UpdatePullingTransactionObligationFulfiller	From	To
Rename Attribute dataSourceManager : DataSourceManager to dataSourceSupplier : Supplier<NeoStoreDataSource> in class org.neo4j.kernel.ha.cluster.SwitchToMaster	From	To
Rename Attribute graphdb : GraphDatabaseAPI to neoStoreSupplier : Supplier<NeoStore> in class org.neo4j.kernel.ha.transaction.OnDiskLastTxIdGetter	From	To
Rename Attribute requestMonitor : RequestMonitor to slaveServerFactory : Function<Slave,SlaveServer> in class org.neo4j.kernel.ha.cluster.SwitchToSlave	From	To
Rename Attribute masterImplMonitor : MasterImpl.Monitor to masterFactory : Factory<Master> in class org.neo4j.kernel.ha.cluster.SwitchToMaster	From	To
Change Attribute Type	8
Change Attribute Type resolver : DependencyResolver to dependencies : Dependencies in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpacker	From	To
Change Attribute Type masterRequestMonitor : RequestMonitor to masterServerFactory : Function<Master,MasterServer> in class org.neo4j.kernel.ha.cluster.SwitchToMaster	From	To
Change Attribute Type resolver : DependencyResolver to transactionIdStoreSupplier : Supplier<TransactionIdStore> in class org.neo4j.kernel.ha.UpdatePullingTransactionObligationFulfiller	From	To
Change Attribute Type resolver : DependencyResolver to txIdStoreSupplier : Supplier<TransactionIdStore> in class org.neo4j.kernel.ha.com.RequestContextFactory	From	To
Change Attribute Type dataSourceManager : DataSourceManager to dataSourceSupplier : Supplier<NeoStoreDataSource> in class org.neo4j.kernel.ha.cluster.SwitchToMaster	From	To
Change Attribute Type graphdb : GraphDatabaseAPI to neoStoreSupplier : Supplier<NeoStore> in class org.neo4j.kernel.ha.transaction.OnDiskLastTxIdGetter	From	To
Change Attribute Type requestMonitor : RequestMonitor to slaveServerFactory : Function<Slave,SlaveServer> in class org.neo4j.kernel.ha.cluster.SwitchToSlave	From	To
Change Attribute Type masterImplMonitor : MasterImpl.Monitor to masterFactory : Factory<Master> in class org.neo4j.kernel.ha.cluster.SwitchToMaster	From	To
Rename Parameter	11
Rename Parameter resolver : DependencyResolver to transactionIdStoreSupplier : Supplier<TransactionIdStore> in method public UpdatePullingTransactionObligationFulfiller(updatePuller UpdatePuller, memberStateMachine HighAvailabilityMemberStateMachine, serverId InstanceId, transactionIdStoreSupplier Supplier<TransactionIdStore>) in class org.neo4j.kernel.ha.UpdatePullingTransactionObligationFulfiller	From	To
Rename Parameter fileSystem : FileSystemAbstraction to fs : FileSystemAbstraction in method protected createKernelData(config Config, graphDb GraphDatabaseAPI, members ClusterMembers, fs FileSystemAbstraction, storeDir File, lastUpdateTime LastUpdateTime, neoStoreSupplier Supplier<NeoStore>) : KernelData in class org.neo4j.kernel.ha.factory.EnterpriseEditionModule	From	To
Rename Parameter resolver : DependencyResolver to dependencies : Dependencies in method public TransactionCommittingResponseUnpacker(dependencies Dependencies) in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpacker	From	To
Rename Parameter neoDataSource : NeoStoreDataSource to storeId : StoreId in method private checkDataConsistencyWithMaster(availableMasterId URI, master Master, storeId StoreId, transactionIdStore TransactionIdStore) : void in class org.neo4j.kernel.ha.cluster.SwitchToSlave	From	To
Rename Parameter resolver : DependencyResolver to supplier : Supplier<TransactionObligationFulfiller> in method private resolveTransactionObligationFulfiller(supplier Supplier<TransactionObligationFulfiller>) : TransactionObligationFulfiller in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpacker	From	To
Rename Parameter neoDataSource : NeoStoreDataSource to myStoreId : StoreId in method private checkMyStoreIdAndMastersStoreId(myStoreId StoreId, masterIsOld boolean) : void in class org.neo4j.kernel.ha.cluster.SwitchToSlave	From	To
Rename Parameter neoDataSource : NeoStoreDataSource to storeId : StoreId in method package checkDataConsistency(masterClient MasterClient, txIdStore TransactionIdStore, storeId StoreId, masterUri URI, masterIsOld boolean) : void in class org.neo4j.kernel.ha.cluster.SwitchToSlave	From	To
Rename Parameter resolver : DependencyResolver to txIdStoreSupplier : Supplier<TransactionIdStore> in method public RequestContextFactory(serverId int, txIdStoreSupplier Supplier<TransactionIdStore>) in class org.neo4j.kernel.ha.com.RequestContextFactory	From	To
Rename Parameter resolver : DependencyResolver to dependencies : Dependencies in method public TransactionCommittingResponseUnpacker(dependencies Dependencies, maxBatchSize int) in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpacker	From	To
Rename Parameter fs : FileSystemAbstraction to fileSystemAbstraction : FileSystemAbstraction in method public SwitchToSlave(storeDir File, logService LogService, fileSystemAbstraction FileSystemAbstraction, clusterMembers ClusterMembers, config Config, resolver DependencyResolver, idGeneratorFactory HaIdGeneratorFactory, masterDelegateHandler DelegateInvocationHandler<Master>, clusterMemberAvailability ClusterMemberAvailability, requestContextFactory RequestContextFactory, kernelExtensions Iterable<KernelExtensionFactory<?>>, masterClientResolver MasterClientResolver, monitor Monitor, storeCopyMonitor StoreCopyClient.Monitor, neoDataSourceSupplier Supplier<NeoStoreDataSource>, transactionIdStoreSupplier Supplier<TransactionIdStore>, slaveFactory Factory<Slave>, slaveServerFactory Function<Slave,SlaveServer>, updatePuller UpdatePuller, pageCache PageCache, monitors Monitors) in class org.neo4j.kernel.ha.cluster.SwitchToSlave	From	To
Rename Parameter graphdb : GraphDatabaseAPI to neoStoreSupplier : Supplier<NeoStore> in method public OnDiskLastTxIdGetter(neoStoreSupplier Supplier<NeoStore>) in class org.neo4j.kernel.ha.transaction.OnDiskLastTxIdGetter	From	To

18d1a50d704a1fa306dd85abe3b8baff19284a03

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: