neo4j 1cb430bbc3583a9c03764e0c9d82a5bb24246dff

1cb430bbc3583a9c03764e0c9d82a5bb24246dff

Files Diff

Added: 23
Removed: 22
Renamed: 0
Modified: 26

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	4
Change Parameter Type topologyService : CoreTopologyService to addressProvider : CatchupAddressProvider.PrioritisingUpstreamStrategyBasedAddressProvider in method package createAndStart(platformModule PlatformModule, consensusModule ConsensusModule, identityModule IdentityModule, coreServerModule CoreServerModule, localDatabase LocalDatabase, pipelineBuilderFactory NettyPipelineBuilderFactory, messageLogger MessageLogger<MemberId>, addressProvider CatchupAddressProvider.PrioritisingUpstreamStrategyBasedAddressProvider, supportedApplicationProtocol ApplicationSupportedProtocols, supportedModifierProtocols Collection<ModifierSupportedProtocols>, installedProtocolsHandler ChannelInboundHandler) : void in class org.neo4j.causalclustering.core.RaftServerModule	From	To
Change Parameter Type raftMachine : RaftMachine to leaderLocator : LeaderLocator in method public PrioritisingUpstreamStrategyBasedAddressProvider(leaderLocator LeaderLocator, topologyService TopologyService, strategySelector UpstreamDatabaseStrategySelector) in class org.neo4j.causalclustering.catchup.CatchupAddressProvider.PrioritisingUpstreamStrategyBasedAddressProvider	From	To
Change Parameter Type topologyService : CoreTopologyService to catchupAddressProvider : CatchupAddressProvider.PrioritisingUpstreamStrategyBasedAddressProvider in method private RaftServerModule(platformModule PlatformModule, consensusModule ConsensusModule, identityModule IdentityModule, coreServerModule CoreServerModule, localDatabase LocalDatabase, pipelineBuilderFactory NettyPipelineBuilderFactory, messageLogger MessageLogger<MemberId>, catchupAddressProvider CatchupAddressProvider.PrioritisingUpstreamStrategyBasedAddressProvider, supportedApplicationProtocol ApplicationSupportedProtocols, supportedModifierProtocols Collection<ModifierSupportedProtocols>, installedProtocolsHandler ChannelInboundHandler) in class org.neo4j.causalclustering.core.RaftServerModule	From	To
Change Parameter Type topologyService : TopologyService to catchupAddressProvider : CatchupAddressProvider.PrioritisingUpstreamStrategyBasedAddressProvider in method public RaftMessageApplier(localDatabase LocalDatabase, logProvider LogProvider, raftMachine RaftMachine, downloadService CoreStateDownloaderService, applicationProcess CommandApplicationProcess, catchupAddressProvider CatchupAddressProvider.PrioritisingUpstreamStrategyBasedAddressProvider) in class org.neo4j.causalclustering.core.state.RaftMessageApplier	From	To
Move Attribute	2
Move Attribute private topologyService : TopologyService from class org.neo4j.causalclustering.core.state.RaftMessageApplier to private topologyService : TopologyService from class org.neo4j.causalclustering.catchup.CatchupAddressProvider.UpstreamStrategyAddressSupplier	From	To
Move Attribute private topologyService : TopologyService from class org.neo4j.causalclustering.core.RaftServerModule to private topologyService : TopologyService from class org.neo4j.causalclustering.catchup.CatchupAddressProvider.UpstreamStrategyAddressSupplier	From	To
Extract Attribute	3
Extract Attribute public IDENTITY : String in class org.neo4j.causalclustering.upstream.strategies.ConnectToRandomCoreServerStrategy	From	To
Extract Attribute public IDENTITY : String in class org.neo4j.causalclustering.upstream.strategies.ConnectRandomlyWithinServerGroupStrategy	From	To
Extract Attribute public IDENTITY : String in class org.neo4j.causalclustering.upstream.strategies.UserDefinedConfigurationStrategy	From	To
Rename Class	1
Rename Class org.neo4j.causalclustering.catchup.CatchupAddressProvider.TopologyBasedAddressProvider renamed to org.neo4j.causalclustering.catchup.CatchupAddressProvider.PrioritisingUpstreamStrategyBasedAddressProvider	From	To
Move Class	19
Move Class org.neo4j.causalclustering.readreplica.ConnectRandomlyToServerGroupStrategyTest moved to org.neo4j.causalclustering.upstream.strategies.ConnectRandomlyToServerGroupStrategyTest	From	To
Move Class org.neo4j.causalclustering.readreplica.UserDefinedConfigurationStrategyTest moved to org.neo4j.causalclustering.upstream.strategies.UserDefinedConfigurationStrategyTest	From	To
Move Class org.neo4j.causalclustering.readreplica.TypicallyConnectToRandomReadReplicaStrategy.ModuloCounter moved to org.neo4j.causalclustering.upstream.strategies.TypicallyConnectToRandomReadReplicaStrategy.ModuloCounter	From	To
Move Class org.neo4j.causalclustering.readreplica.ConnectRandomlyWithinServerGroupStrategy moved to org.neo4j.causalclustering.upstream.strategies.ConnectRandomlyWithinServerGroupStrategy	From	To
Move Class org.neo4j.causalclustering.readreplica.UpstreamDatabaseSelectionStrategy moved to org.neo4j.causalclustering.upstream.UpstreamDatabaseSelectionStrategy	From	To
Move Class org.neo4j.causalclustering.readreplica.UserDefinedConfigurationStrategy moved to org.neo4j.causalclustering.upstream.strategies.UserDefinedConfigurationStrategy	From	To
Move Class org.neo4j.causalclustering.readreplica.UpstreamDatabaseStrategiesLoader moved to org.neo4j.causalclustering.upstream.UpstreamDatabaseStrategiesLoader	From	To
Move Class org.neo4j.causalclustering.readreplica.ConnectRandomlyWithinServerGroupStrategyTest moved to org.neo4j.causalclustering.upstream.strategies.ConnectRandomlyWithinServerGroupStrategyTest	From	To
Move Class org.neo4j.causalclustering.readreplica.TypicallyConnectToRandomReadReplicaStrategyTest moved to org.neo4j.causalclustering.upstream.strategies.TypicallyConnectToRandomReadReplicaStrategyTest	From	To
Move Class org.neo4j.causalclustering.readreplica.ConnectToRandomCoreServerStrategy moved to org.neo4j.causalclustering.upstream.strategies.ConnectToRandomCoreServerStrategy	From	To
Move Class org.neo4j.causalclustering.readreplica.UpstreamDatabaseStrategySelector moved to org.neo4j.causalclustering.upstream.UpstreamDatabaseStrategySelector	From	To
Move Class org.neo4j.causalclustering.readreplica.ConnectRandomlyToServerGroupStrategyImplTest moved to org.neo4j.causalclustering.upstream.strategies.ConnectRandomlyToServerGroupStrategyImplTest	From	To
Move Class org.neo4j.causalclustering.readreplica.UpstreamDatabaseSelectionException moved to org.neo4j.causalclustering.upstream.UpstreamDatabaseSelectionException	From	To
Move Class org.neo4j.causalclustering.readreplica.UpstreamDatabaseStrategiesLoaderTest moved to org.neo4j.causalclustering.upstream.UpstreamDatabaseStrategiesLoaderTest	From	To
Move Class org.neo4j.causalclustering.readreplica.ConnectRandomlyToServerGroupStrategy moved to org.neo4j.causalclustering.upstream.strategies.ConnectRandomlyToServerGroupStrategy	From	To
Move Class org.neo4j.causalclustering.readreplica.EnterpriseReadReplicaEditionModule.NoOpUpstreamDatabaseStrategiesLoader moved to org.neo4j.causalclustering.upstream.NoOpUpstreamDatabaseStrategiesLoader	From	To
Move Class org.neo4j.causalclustering.readreplica.ConnectToRandomCoreServerStrategyTest moved to org.neo4j.causalclustering.upstream.strategies.ConnectToRandomCoreServerStrategyTest	From	To
Move Class org.neo4j.causalclustering.readreplica.ConnectRandomlyToServerGroupImpl moved to org.neo4j.causalclustering.upstream.strategies.ConnectRandomlyToServerGroupImpl	From	To
Move Class org.neo4j.causalclustering.readreplica.UpstreamDatabaseStrategySelectorTest moved to org.neo4j.causalclustering.upstream.UpstreamDatabaseStrategySelectorTest	From	To
Rename Attribute	5
Rename Attribute raftMachine : RaftMachine to leaderLocator : LeaderLocator in class org.neo4j.causalclustering.catchup.CatchupAddressProvider.PrioritisingUpstreamStrategyBasedAddressProvider	From	To
Rename Attribute NAME : String to IDENTITY : String in class org.neo4j.causalclustering.upstream.strategies.ConnectRandomlyToServerGroupStrategy	From	To
Rename Attribute lastTransactionId : long to requiredTransactionId : long in class org.neo4j.causalclustering.catchup.storecopy.GetIndexFilesRequest	From	To
Rename Attribute topologyService : TopologyService to catchupAddressProvider : CatchupAddressProvider.PrioritisingUpstreamStrategyBasedAddressProvider in class org.neo4j.causalclustering.core.state.RaftMessageApplier	From	To
Rename Attribute topologyService : TopologyService to catchupAddressProvider : CatchupAddressProvider.PrioritisingUpstreamStrategyBasedAddressProvider in class org.neo4j.causalclustering.core.RaftServerModule	From	To
Change Attribute Type	3
Change Attribute Type raftMachine : RaftMachine to leaderLocator : LeaderLocator in class org.neo4j.causalclustering.catchup.CatchupAddressProvider.PrioritisingUpstreamStrategyBasedAddressProvider	From	To
Change Attribute Type topologyService : TopologyService to catchupAddressProvider : CatchupAddressProvider.PrioritisingUpstreamStrategyBasedAddressProvider in class org.neo4j.causalclustering.core.RaftServerModule	From	To
Change Attribute Type topologyService : TopologyService to catchupAddressProvider : CatchupAddressProvider.PrioritisingUpstreamStrategyBasedAddressProvider in class org.neo4j.causalclustering.core.state.RaftMessageApplier	From	To
Extract Method	3
Extract Method private createUpstreamDatabaseStrategySelector(myself MemberId, config Config, logProvider LogProvider, topologyService TopologyService, defaultStrategy ConnectToRandomCoreServerStrategy) : UpstreamDatabaseStrategySelector extracted from public EnterpriseReadReplicaEditionModule(platformModule PlatformModule, discoveryServiceFactory DiscoveryServiceFactory, myself MemberId) in class org.neo4j.causalclustering.readreplica.EnterpriseReadReplicaEditionModule	From	To
Extract Method private persistentCall(request CatchUpRequest, copyHandler CatchUpResponseAdaptor<StoreCopyFinishedResponse>, addressProvider CatchupAddressProvider, terminationCondition TerminationCondition) : void extracted from private copyFilesIndividually(prepareStoreCopyResponse PrepareStoreCopyResponse, expectedStoreId StoreId, addressProvider CatchupAddressProvider, storeFileStream StoreFileStreamProvider, terminationConditions Supplier<TerminationCondition>) : void in class org.neo4j.causalclustering.catchup.storecopy.StoreCopyClient	From	To
Extract Method private persistentCall(request CatchUpRequest, copyHandler CatchUpResponseAdaptor<StoreCopyFinishedResponse>, addressProvider CatchupAddressProvider, terminationCondition TerminationCondition) : void extracted from private copyIndexSnapshotIndividually(prepareStoreCopyResponse PrepareStoreCopyResponse, expectedStoreId StoreId, addressProvider CatchupAddressProvider, storeFileStream StoreFileStreamProvider, terminationConditions Supplier<TerminationCondition>) : void in class org.neo4j.causalclustering.catchup.storecopy.StoreCopyClient	From	To
Rename Parameter	6
Rename Parameter topologyService : CoreTopologyService to addressProvider : CatchupAddressProvider.PrioritisingUpstreamStrategyBasedAddressProvider in method package createAndStart(platformModule PlatformModule, consensusModule ConsensusModule, identityModule IdentityModule, coreServerModule CoreServerModule, localDatabase LocalDatabase, pipelineBuilderFactory NettyPipelineBuilderFactory, messageLogger MessageLogger<MemberId>, addressProvider CatchupAddressProvider.PrioritisingUpstreamStrategyBasedAddressProvider, supportedApplicationProtocol ApplicationSupportedProtocols, supportedModifierProtocols Collection<ModifierSupportedProtocols>, installedProtocolsHandler ChannelInboundHandler) : void in class org.neo4j.causalclustering.core.RaftServerModule	From	To
Rename Parameter topologyService : CoreTopologyService to catchupAddressProvider : CatchupAddressProvider.PrioritisingUpstreamStrategyBasedAddressProvider in method private RaftServerModule(platformModule PlatformModule, consensusModule ConsensusModule, identityModule IdentityModule, coreServerModule CoreServerModule, localDatabase LocalDatabase, pipelineBuilderFactory NettyPipelineBuilderFactory, messageLogger MessageLogger<MemberId>, catchupAddressProvider CatchupAddressProvider.PrioritisingUpstreamStrategyBasedAddressProvider, supportedApplicationProtocol ApplicationSupportedProtocols, supportedModifierProtocols Collection<ModifierSupportedProtocols>, installedProtocolsHandler ChannelInboundHandler) in class org.neo4j.causalclustering.core.RaftServerModule	From	To
Rename Parameter topologyService : TopologyService to catchupAddressProvider : CatchupAddressProvider.PrioritisingUpstreamStrategyBasedAddressProvider in method public RaftMessageApplier(localDatabase LocalDatabase, logProvider LogProvider, raftMachine RaftMachine, downloadService CoreStateDownloaderService, applicationProcess CommandApplicationProcess, catchupAddressProvider CatchupAddressProvider.PrioritisingUpstreamStrategyBasedAddressProvider) in class org.neo4j.causalclustering.core.state.RaftMessageApplier	From	To
Rename Parameter lastTransactionId : long to requiredTransactionId : long in method public GetIndexFilesRequest(expectedStoreId StoreId, indexId long, requiredTransactionId long) in class org.neo4j.causalclustering.catchup.storecopy.GetIndexFilesRequest	From	To
Rename Parameter raftMachine : RaftMachine to leaderLocator : LeaderLocator in method public PrioritisingUpstreamStrategyBasedAddressProvider(leaderLocator LeaderLocator, topologyService TopologyService, strategySelector UpstreamDatabaseStrategySelector) in class org.neo4j.causalclustering.catchup.CatchupAddressProvider.PrioritisingUpstreamStrategyBasedAddressProvider	From	To
Rename Parameter storeStreamProvider : InMemoryStoreStreamProvider to storeFileStreamsProvider : InMemoryStoreStreamProvider in method private clientFileContents(storeFileStreamsProvider InMemoryStoreStreamProvider, filename String) : String in class org.neo4j.causalclustering.catchup.storecopy.StoreCopyClientIT	From	To

1cb430bbc3583a9c03764e0c9d82a5bb24246dff

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: