1f63993c0dc3ccbb08245c351e2ac29db08f33e4
Files Diff
- Added: 12
- Removed: 13
- Renamed: 0
- Modified: 27
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 4 | ||
| Change Parameter Type stateFetcher : StateFetcher to coreClient : CoreClient in method public CoreStateDownloader(localDatabase LocalDatabase, storeFetcher StoreFetcher, coreClient CoreClient, logProvider LogProvider) in class org.neo4j.coreedge.raft.state.CoreStateDownloader | From | To | |
| Change Parameter Type snapshot : RaftStateSnapshot to snapshot : CoreSnapshot in method public onSnapshotReceived(snapshot CoreSnapshot) : void in class org.neo4j.coreedge.catchup.storecopy.core.CoreSnapshotListener | From | To | |
| Change Parameter Type msg : GetRaftStateRequest to msg : CoreSnapshotRequest in method protected encode(ctx ChannelHandlerContext, msg CoreSnapshotRequest, out List<Object>) : void in class org.neo4j.coreedge.catchup.storecopy.core.CoreSnapshotRequestEncoder | From | To | |
| Change Parameter Type snapshot : RaftStateSnapshot to snapshot : CoreSnapshot in method public onSnapshotReceived(snapshot CoreSnapshot) : void in class org.neo4j.coreedge.catchup.storecopy.CoreClient | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private coreClient : CoreClient from class org.neo4j.coreedge.catchup.storecopy.edge.state.StateFetcher to private coreClient : CoreClient from class org.neo4j.coreedge.raft.state.CoreStateDownloader | From | To | |
| Rename Class | 1 | ||
| Rename Class org.neo4j.coreedge.catchup.storecopy.core.RaftStateType renamed to org.neo4j.coreedge.catchup.storecopy.core.CoreStateType | From | To | |
| Move And Rename Class | 6 | ||
| Move And Rename Class org.neo4j.coreedge.catchup.tx.edge.RaftStateSnapshotListener moved and renamed to org.neo4j.coreedge.catchup.storecopy.core.CoreSnapshotListener | From | To | |
| Move And Rename Class org.neo4j.coreedge.catchup.storecopy.edge.GetRaftStateRequestDecoder moved and renamed to org.neo4j.coreedge.catchup.storecopy.core.CoreSnapshotRequestDecoder | From | To | |
| Move And Rename Class org.neo4j.coreedge.catchup.tx.edge.RaftStateSnapshotDecoder moved and renamed to org.neo4j.coreedge.catchup.storecopy.core.CoreSnapshotDecoder | From | To | |
| Move And Rename Class org.neo4j.coreedge.catchup.storecopy.core.RaftStateSnapshot moved and renamed to org.neo4j.coreedge.raft.state.CoreSnapshot | From | To | |
| Move And Rename Class org.neo4j.coreedge.catchup.storecopy.edge.GetRaftStateRequestEncoder moved and renamed to org.neo4j.coreedge.catchup.storecopy.core.CoreSnapshotRequestEncoder | From | To | |
| Move And Rename Class org.neo4j.coreedge.catchup.storecopy.edge.GetRaftStateRequest moved and renamed to org.neo4j.coreedge.catchup.storecopy.core.CoreSnapshotRequest | From | To | |
| Move Class | 3 | ||
| Move Class org.neo4j.coreedge.catchup.storecopy.edge.CoreClient moved to org.neo4j.coreedge.catchup.storecopy.CoreClient | From | To | |
| Move Class org.neo4j.coreedge.catchup.storecopy.core.RaftStateSnapshot.Marshal moved to org.neo4j.coreedge.raft.state.CoreSnapshot.Marshal | From | To | |
| Move Class org.neo4j.coreedge.server.core.CoreToCoreClient moved to org.neo4j.coreedge.catchup.storecopy.core.CoreToCoreClient | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type getRaftStateRequest : GetRaftStateRequest to coreSnapshotRequest : CoreSnapshotRequest in method public requestCoreSnapshot(serverAddress AdvertisedSocketAddress) : CompletableFuture<CoreSnapshot> in class org.neo4j.coreedge.catchup.storecopy.CoreClient | From | To | |
| Change Variable Type notSureAboutTheName : HashMap<Long,Long> to lastSequenceNumberPerSession : Map<Long,Long> in method public unmarshal(source ReadableChannel) : GlobalSessionTrackerState<MEMBER> in class org.neo4j.coreedge.raft.replication.session.GlobalSessionTrackerState.Marshal | From | To | |
| Extract Variable | 2 | ||
| Extract Variable sequenceNumber : long in method public unmarshal(source ReadableChannel) : GlobalSessionTrackerState<MEMBER> from class org.neo4j.coreedge.raft.replication.session.GlobalSessionTrackerState.Marshal | From | To | |
| Extract Variable localSessionId : long in method public unmarshal(source ReadableChannel) : GlobalSessionTrackerState<MEMBER> from class org.neo4j.coreedge.raft.replication.session.GlobalSessionTrackerState.Marshal | From | To | |
| Rename Method | 2 | ||
| Rename Method public requestRaftState(serverAddress AdvertisedSocketAddress) : void renamed to public requestCoreSnapshot(serverAddress AdvertisedSocketAddress) : CompletableFuture<CoreSnapshot> in class org.neo4j.coreedge.catchup.storecopy.CoreClient | From | To | |
| Rename Method public state() : Object renamed to public prevTerm() : long in class org.neo4j.coreedge.raft.state.CoreSnapshot | From | To | |
| Rename Variable | 3 | ||
| Rename Variable notSureAboutTheName : HashMap<Long,Long> to lastSequenceNumberPerSession : Map<Long,Long> in method public unmarshal(source ReadableChannel) : GlobalSessionTrackerState<MEMBER> in class org.neo4j.coreedge.raft.replication.session.GlobalSessionTrackerState.Marshal | From | To | |
| Rename Variable theMainMap : Map<MEMBER,LocalSessionTracker> to sessionTrackers : Map<MEMBER,LocalSessionTracker> in method public unmarshal(source ReadableChannel) : GlobalSessionTrackerState<MEMBER> in class org.neo4j.coreedge.raft.replication.session.GlobalSessionTrackerState.Marshal | From | To | |
| Rename Variable getRaftStateRequest : GetRaftStateRequest to coreSnapshotRequest : CoreSnapshotRequest in method public requestCoreSnapshot(serverAddress AdvertisedSocketAddress) : CompletableFuture<CoreSnapshot> in class org.neo4j.coreedge.catchup.storecopy.CoreClient | From | To | |
| Change Return Type | 4 | ||
| Change Return Type Object to long in method public prevTerm() : long in class org.neo4j.coreedge.raft.state.CoreSnapshot | From | To | |
| Change Return Type Map<RaftStateType,Object> to CoreSnapshot in method public snapshot() : CoreSnapshot in class org.neo4j.coreedge.raft.state.CoreState | From | To | |
| Change Return Type void to CompletableFuture<CoreSnapshot> in method public requestCoreSnapshot(serverAddress AdvertisedSocketAddress) : CompletableFuture<CoreSnapshot> in class org.neo4j.coreedge.catchup.storecopy.CoreClient | From | To | |
| Change Return Type RaftStateType to Iterable<CoreStateType> in method public types() : Iterable<CoreStateType> in class org.neo4j.coreedge.raft.state.CoreSnapshot | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute idAllocationState : IdAllocationState to state : IdAllocationState in class org.neo4j.coreedge.raft.replication.id.ReplicatedIdAllocationStateMachine | From | To | |
| Rename Attribute stateFetcher : StateFetcher to coreClient : CoreClient in class org.neo4j.coreedge.raft.state.CoreStateDownloader | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type stateFetcher : StateFetcher to coreClient : CoreClient in class org.neo4j.coreedge.raft.state.CoreStateDownloader | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public refresh(localCommit TransactionRepresentationCommitProcess) : void extracted from public EnterpriseCoreEditionModule(platformModule PlatformModule, discoveryServiceFactory DiscoveryServiceFactory) in class org.neo4j.coreedge.server.core.EnterpriseCoreEditionModule & moved to class org.neo4j.coreedge.raft.state.CoreStateMachines | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter receiver : CoreState to coreState : CoreState in method package downloadSnapshot(source AdvertisedSocketAddress, coreState CoreState) : void in class org.neo4j.coreedge.raft.state.CoreStateDownloader | From | To | |
| Rename Parameter stateFetcher : StateFetcher to coreClient : CoreClient in method public CoreStateDownloader(localDatabase LocalDatabase, storeFetcher StoreFetcher, coreClient CoreClient, logProvider LogProvider) in class org.neo4j.coreedge.raft.state.CoreStateDownloader | From | To |