203641ee7feb8ec689d49c31e9b81de3c66782bb
Files Diff
- Added: 2
- Removed: 1
- Renamed: 0
- Modified: 29
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 9 | ||
| Change Parameter Type resource : Object to resource : LockResource in method private getRWLockForAcquiring(resource LockResource, tx Object) : RWLock in class org.neo4j.kernel.impl.locking.community.LockManagerImpl | From | To | |
| Change Parameter Type resource : Object to resource : LockResource in method package RWLock(resource LockResource, ragManager RagManager, clock Clock, lockAcquisitionTimeoutMillis long) in class org.neo4j.kernel.impl.locking.community.RWLock | From | To | |
| Change Parameter Type resource : Object to resource : LockResource in method protected createLock(resource LockResource) : RWLock in class org.neo4j.kernel.impl.locking.community.LockManagerImpl | From | To | |
| Change Parameter Type resource : Object to resource : LockResource in method public tryReadLock(resource LockResource, tx Object) : boolean in class org.neo4j.kernel.impl.locking.community.LockManagerImpl | From | To | |
| Change Parameter Type resource : Object to resource : LockResource in method public getWriteLock(resource LockResource, tx Object) : boolean in class org.neo4j.kernel.impl.locking.community.LockManagerImpl | From | To | |
| Change Parameter Type lockMaps : ConcurrentMap<Long,ForsetiLockManager.Lock>[] to lockMaps : ConcurrentMap<Long,Lock>[] in method public ForsetiClientFlyweightPool(config Config, clock Clock, lockMaps ConcurrentMap<Long,Lock>[], waitStrategies WaitStrategy<AcquireLockTimeoutException>[]) in class org.neo4j.kernel.impl.enterprise.lock.forseti.ForsetiLockManager.ForsetiClientFlyweightPool | From | To | |
| Change Parameter Type resource : Object to resource : LockResource in method public tryWriteLock(resource LockResource, tx Object) : boolean in class org.neo4j.kernel.impl.locking.community.LockManagerImpl | From | To | |
| Change Parameter Type resource : Object to resource : LockResource in method protected createLock(resource LockResource) : RWLock in class org.neo4j.kernel.impl.locking.community.LockManagerImplTest.MockedLockLockManager | From | To | |
| Change Parameter Type resource : Object to resource : LockResource in method public getReadLock(resource LockResource, tx Object) : boolean in class org.neo4j.kernel.impl.locking.community.LockManagerImpl | From | To | |
| Parameterize Variable | 4 | ||
| Parameterize Variable node2 : LockResource to resource : LockResource in method private createRWLock(ragManager RagManager, resource LockResource) : RWLock in class org.neo4j.kernel.impl.locking.community.RWLockTest | From | To | |
| Parameterize Variable node3 : LockResource to resource : LockResource in method private createRWLock(ragManager RagManager, resource LockResource) : RWLock in class org.neo4j.kernel.impl.locking.community.RWLockTest | From | To | |
| Parameterize Variable node1 : LockResource to resource : LockResource in method private createRWLock(ragManager RagManager, resource LockResource) : RWLock in class org.neo4j.kernel.impl.locking.community.RWLockTest | From | To | |
| Extract Method | 16 | ||
| Extract Method private createRWLock(ragManager RagManager, resource LockResource) : RWLock extracted from public assertReadLockDoesNotLeakMemory() : void in class org.neo4j.kernel.impl.locking.community.RWLockTest | From | To | |
| Extract Method private createRWLock(ragManager RagManager, resource LockResource) : RWLock extracted from public testLockRequestsTermination() : void in class org.neo4j.kernel.impl.locking.community.RWLockTest | From | To | |
| Extract Method private assertValid(waitStartMillis long, resourceType ResourceType, resourceId long) : void extracted from public trySharedLock(resourceType ResourceType, resourceId long) : boolean in class org.neo4j.kernel.impl.enterprise.lock.forseti.ForsetiClient | From | To | |
| Extract Method private assertValid(waitStartMillis long, resourceType ResourceType, resourceId long) : void extracted from public acquireExclusive(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.impl.enterprise.lock.forseti.ForsetiClient | From | To | |
| Extract Method private assertValid(waitStartMillis long, resourceType ResourceType, resourceId long) : void extracted from public acquireShared(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.impl.enterprise.lock.forseti.ForsetiClient | From | To | |
| Extract Method private createRWLock(ragManager RagManager, resource LockResource) : RWLock extracted from public assertWriteLockDoesNotLeakMemory() : void in class org.neo4j.kernel.impl.locking.community.RWLockTest | From | To | |
| Extract Method private createRWLock(ragManager RagManager, resource LockResource) : RWLock extracted from public testLockCounters() : void in class org.neo4j.kernel.impl.locking.community.RWLockTest | From | To | |
| Extract Method private createRWLock(ragManager RagManager, resource LockResource) : RWLock extracted from public testDeadlockDetection() : void in class org.neo4j.kernel.impl.locking.community.RWLockTest | From | To | |
| Extract Method private createRWLock(ragManager RagManager, resource LockResource) : RWLock extracted from public testWaitingWriterLock() : void in class org.neo4j.kernel.impl.locking.community.RWLockTest | From | To | |
| Extract Method private createLockManager() : LockManagerImpl extracted from public shouldNotBePossibleReleaseNotExistingLock() : void in class org.neo4j.kernel.impl.locking.community.LockManagerImplTest | From | To | |
| Extract Method private createLockManager() : LockManagerImpl extracted from public shouldAllowGetReadWriteLocks() : void in class org.neo4j.kernel.impl.locking.community.LockManagerImplTest | From | To | |
| Extract Method private createLockManager() : LockManagerImpl extracted from public shouldCleanupNotUsedLocks() : void in class org.neo4j.kernel.impl.locking.community.LockManagerImplTest | From | To | |
| Extract Method private createRWLock(ragManager RagManager, resource LockResource) : RWLock extracted from public testThreadRemovedFromWaitingListOnDeadlock() : void in class org.neo4j.kernel.impl.locking.community.RWLockTest | From | To | |
| Extract Method private createRWLock(ragManager RagManager, resource LockResource) : RWLock extracted from public testWaitingReaderLock() : void in class org.neo4j.kernel.impl.locking.community.RWLockTest | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type resource : Object to resource : LockResource in class org.neo4j.kernel.impl.locking.community.RWLock | From | To |