24428d893c07fa300ed04bf6c4bdc54640b82bcc
Files Diff
- Added: 17
- Removed: 5
- Renamed: 0
- Modified: 25
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method public releaseBuffer() : void from class org.neo4j.causalclustering.messaging.marshalling.v2.CoreReplicatedContentMarshallingTest to public close() : void from class org.neo4j.causalclustering.core.state.machines.tx.ByteBufReplicatedTransaction | From | To | |
| Extract Subclass | 1 | ||
| Extract Subclass org.neo4j.causalclustering.core.state.machines.tx.ByteArrayReplicatedTransaction from class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransaction | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type channel : FlushableChannel to channel : WritableChannel in method public StorageCommandSerializer(channel WritableChannel) in class org.neo4j.kernel.impl.transaction.log.entry.StorageCommandSerializer | From | To | |
| Change Parameter Type channel : FlushableChannel to channel : WritableChannel in method public LogEntryWriter(channel WritableChannel) in class org.neo4j.kernel.impl.transaction.log.entry.LogEntryWriter | From | To | |
| Move Method | 2 | ||
| Move Method public close() : void from class org.neo4j.causalclustering.messaging.marshalling.v2.decoding.ReplicatedContentChunkDecoder to public close() : void from class org.neo4j.causalclustering.messaging.marshalling.v2.decoding.ChunkHandler | From | To | |
| Move Method public marshal(transaction ReplicatedTransaction, channel WritableChannel) : void from class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransactionSerializer to public marshal(channel WritableChannel) : void from class org.neo4j.causalclustering.messaging.marshalling.ByteArrayChunkedEncoder | From | To | |
| Push Down Attribute | 1 | ||
| Push Down Attribute private txBytes : byte[] from class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransaction to private txBytes : byte[] from class org.neo4j.causalclustering.core.state.machines.tx.ByteArrayReplicatedTransaction | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private chunkSize : int from class org.neo4j.causalclustering.messaging.marshalling.ChunkedReplicatedContent to private chunkSize : int from class org.neo4j.causalclustering.messaging.marshalling.ChunkedReplicatedContentTest.ThreeChunks | From | To | |
| Move Attribute private chunkSize : int from class org.neo4j.causalclustering.messaging.marshalling.ChunkedReplicatedContent to private chunkSize : int from class org.neo4j.causalclustering.messaging.marshalling.ByteArrayChunkedEncoder | From | To | |
| Extract Class | 1 | ||
| Extract Class org.neo4j.causalclustering.messaging.marshalling.v2.decoding.ChunkHandler from class org.neo4j.causalclustering.messaging.marshalling.v2.decoding.ReplicatedContentChunkDecoder | From | To | |
| Rename Class | 3 | ||
| Rename Class org.neo4j.causalclustering.messaging.marshalling.v2.encoding.RaftMessageContentSerializer renamed to org.neo4j.causalclustering.messaging.marshalling.v2.encoding.RaftMessageContentEncoder | From | To | |
| Rename Class org.neo4j.causalclustering.messaging.marshalling.ByteArrayByteBufAwareMarshalTest renamed to org.neo4j.causalclustering.messaging.marshalling.ByteArrayChunkedEncoderTest | From | To | |
| Rename Class org.neo4j.causalclustering.messaging.marshalling.ByteBufAwareMarshal renamed to org.neo4j.causalclustering.messaging.marshalling.ChunkedEncoder | From | To | |
| Move Class | 1 | ||
| Move Class org.neo4j.kernel.impl.transaction.log.entry.LogEntryWriter.StorageCommandSerializer moved to org.neo4j.kernel.impl.transaction.log.entry.StorageCommandSerializer | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type buffer : ByteBuf to allData : CompositeByteBuf in method public readChunk(allocator ByteBufAllocator) : ByteBuf in class org.neo4j.causalclustering.messaging.marshalling.ChunkedReplicatedContent | From | To | |
| Rename Method | 1 | ||
| Rename Method public simple(channelConsumer ThrowingConsumer<WritableChannel,IOException>) : ByteBufAwareMarshal renamed to public single(channelConsumer ThrowingConsumer<WritableChannel,IOException>) : ChunkedEncoder in class org.neo4j.causalclustering.messaging.marshalling.ChunkedEncoder | From | To | |
| Push Down Method | 5 | ||
| Push Down Method public hashCode() : int from class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransaction to public hashCode() : int from class org.neo4j.causalclustering.core.state.machines.tx.ByteArrayReplicatedTransaction | From | To | |
| Push Down Method public ReplicatedTransaction(txBytes byte[]) from class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransaction to package ByteArrayReplicatedTransaction(txBytes byte[]) from class org.neo4j.causalclustering.core.state.machines.tx.ByteArrayReplicatedTransaction | From | To | |
| Push Down Method public size() : Optional<Long> from class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransaction to public size() : Optional<Long> from class org.neo4j.causalclustering.core.state.machines.tx.ByteArrayReplicatedTransaction | From | To | |
| Push Down Method public equals(o Object) : boolean from class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransaction to public equals(o Object) : boolean from class org.neo4j.causalclustering.core.state.machines.tx.ByteArrayReplicatedTransaction | From | To | |
| Push Down Method public getTxBytes() : byte[] from class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransaction to package getTxBytes() : byte[] from class org.neo4j.causalclustering.core.state.machines.tx.ByteArrayReplicatedTransaction | From | To | |
| Rename Variable | 3 | ||
| Rename Variable coreReplicatedContentSerializer : ChannelMarshal<ReplicatedContent> to coreReplicatedContentMarshal : ChannelMarshal<ReplicatedContent> in method public shouldSerializeAndDeserialize() : void in class org.neo4j.causalclustering.messaging.marshalling.v2.CoreReplicatedContentMarshallingTest | From | To | |
| Rename Variable consumed : boolean to encoded : boolean in method public single(channelConsumer ThrowingConsumer<WritableChannel,IOException>) : ChunkedEncoder in class org.neo4j.causalclustering.messaging.marshalling.ChunkedEncoder | From | To | |
| Rename Variable buffer : ByteBuf to allData : CompositeByteBuf in method public readChunk(allocator ByteBufAllocator) : ByteBuf in class org.neo4j.causalclustering.messaging.marshalling.ChunkedReplicatedContent | From | To | |
| Change Return Type | 3 | ||
| Change Return Type ByteBufAwareMarshal to ChunkedEncoder in method public single(channelConsumer ThrowingConsumer<WritableChannel,IOException>) : ChunkedEncoder in class org.neo4j.causalclustering.messaging.marshalling.ChunkedEncoder | From | To | |
| Change Return Type ByteBufAwareMarshal to ChunkedEncoder in method public serialize() : ChunkedEncoder in class org.neo4j.causalclustering.core.replication.DistributedOperation | From | To | |
| Change Return Type ByteBufAwareMarshal to ChunkedEncoder in method public serializer() : ChunkedEncoder in class org.neo4j.causalclustering.core.state.machines.dummy.DummyRequest | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute decoder : ReplicatedContentChunkDecoder to chunkHandler : ChunkHandler in class org.neo4j.causalclustering.messaging.marshalling.v2.decoding.DecodingDispatcher | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type decoder : ReplicatedContentChunkDecoder to chunkHandler : ChunkHandler in class org.neo4j.causalclustering.messaging.marshalling.v2.decoding.DecodingDispatcher | From | To | |
| Change Attribute Type channel : FlushableChannel to channel : WritableChannel in class org.neo4j.kernel.impl.transaction.log.entry.StorageCommandSerializer | From | To | |
| Change Attribute Type channel : FlushableChannel to channel : WritableChannel in class org.neo4j.kernel.impl.transaction.log.entry.LogEntryWriter | From | To | |
| Change Attribute Type byteBufAwareMarshal : ByteBufAwareMarshal to byteBufAwareMarshal : ChunkedEncoder in class org.neo4j.causalclustering.messaging.marshalling.ChunkedReplicatedContent | From | To | |
| Extract And Move Method | 3 | ||
| Extract And Move Method public from(bytes byte[]) : ByteArrayReplicatedTransaction extracted from public createImmutableReplicatedTransaction(tx TransactionRepresentation) : ReplicatedTransaction in class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransactionFactory & moved to class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransaction | From | To | |
| Extract And Move Method public from(bytes byte[]) : ByteArrayReplicatedTransaction extracted from private tx(dataValue byte) : ReplicatedTransaction in class org.neo4j.causalclustering.core.state.CommandApplicationProcessTest & moved to class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransaction | From | To | |
| Extract And Move Method public from(bytes byte[]) : ByteArrayReplicatedTransaction extracted from public unmarshal(channel ReadableChannel) : ReplicatedTransaction in class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransactionSerializer & moved to class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransaction | From | To |