25fe58b74f7dc85a32d576bc15b3c62a1547059e
Files Diff
- Added: 20
- Removed: 5
- Renamed: 0
- Modified: 64
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method private assertLogEntries(log ReadableRaftLog, expectedValues int...) : void renamed to private integerValues(log ReadableRaftLog) : List<Integer> in class org.neo4j.coreedge.raft.CatchUpTest | From | To | |
| Rename Method public findLastCommittedIndex() : long renamed to public findLastAppliedIndex() : long in class org.neo4j.coreedge.server.core.RecoverTransactionLogState | From | To | |
| Rename Method public notifyCommitted() : void renamed to public notifyUpdate() : void in class org.neo4j.coreedge.raft.state.StateMachineApplier | From | To | |
| Rename Method public raft() : RaftInstance<CoreMember> renamed to public id() : CoreMember in class org.neo4j.coreedge.server.core.EnterpriseCoreEditionModule | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type consensusListener : ConsensusListener to raftStateMachine : RaftStateMachine in method public RaftInstance(myself MEMBER, termStorage StateStorage<TermState>, voteStorage StateStorage<VoteState<MEMBER>>, entryLog RaftLog, raftStateMachine RaftStateMachine, electionTimeout long, heartbeatInterval long, renewableTimeoutService RenewableTimeoutService, inbound Inbound, outbound Outbound<MEMBER>, leaderWaitTimeout long, logProvider LogProvider, membershipManager RaftMembershipManager<MEMBER>, logShipping RaftLogShippingManager<MEMBER>, databaseHealthSupplier Supplier<DatabaseHealth>, monitors Monitors) in class org.neo4j.coreedge.raft.RaftInstance | From | To | |
| Change Parameter Type connectionStrategy : EdgeToCoreConnectionStrategy to connectionStrategy : CoreServerSelectionStrategy in method public EdgeServerStartupProcess(storeFetcher StoreFetcher, localDatabase LocalDatabase, txPuller TxPollingClient, dataSourceManager DataSourceManager, connectionStrategy CoreServerSelectionStrategy, retryStrategy RetryStrategy, logProvider LogProvider) in class org.neo4j.coreedge.server.edge.EdgeServerStartupProcess | From | To | |
| Change Parameter Type consensusListener : ConsensusListener to raftStateMachine : RaftStateMachine in method private createRaft(life LifeSupport, outbound Outbound<AdvertisedSocketAddress>, discoveryService CoreDiscoveryService, config Config, messageLogger MessageLogger<AdvertisedSocketAddress>, raftLog RaftLog, raftStateMachine RaftStateMachine, fileSystem FileSystemAbstraction, clusterStateDirectory File, myself CoreMember, logProvider LogProvider, raftServer RaftServer<CoreMember>, raftTimeoutService DelayedRenewableTimeoutService, databaseHealthSupplier Supplier<DatabaseHealth>, monitors Monitors) : RaftInstance<CoreMember> in class org.neo4j.coreedge.server.core.EnterpriseCoreEditionModule | From | To | |
| Change Parameter Type connectionStrategy : EdgeToCoreConnectionStrategy to connectionStrategy : CoreServerSelectionStrategy in method public TxPollingClient(jobScheduler JobScheduler, pollingInterval long, transactionIdStoreSupplier Supplier<TransactionIdStore>, coreClient CoreClient, txPullResponseListener TxPullResponseListener, connectionStrategy CoreServerSelectionStrategy, logProvider LogProvider) in class org.neo4j.coreedge.catchup.tx.edge.TxPollingClient | From | To | |
| Rename Variable | 2 | ||
| Rename Variable expected : LinkedList<Integer> to actual : List<Integer> in method private integerValues(log ReadableRaftLog) : List<Integer> in class org.neo4j.coreedge.raft.CatchUpTest | From | To | |
| Rename Variable monitoredRaftLog : MonitoredRaftLog to raftLog : MonitoredRaftLog in method public EnterpriseCoreEditionModule(platformModule PlatformModule, discoveryServiceFactory DiscoveryServiceFactory) in class org.neo4j.coreedge.server.core.EnterpriseCoreEditionModule | From | To | |
| Move Source Folder | 1 | ||
| Move Source Folder enterprise/core-edge/src/test to enterprise/core-edge/src/main | From | To | |
| Change Return Type | 2 | ||
| Change Return Type RaftInstance<CoreMember> to CoreMember in method public id() : CoreMember in class org.neo4j.coreedge.server.core.EnterpriseCoreEditionModule | From | To | |
| Change Return Type void to List<Integer> in method private integerValues(log ReadableRaftLog) : List<Integer> in class org.neo4j.coreedge.raft.CatchUpTest | From | To | |
| Rename Class | 3 | ||
| Rename Class org.neo4j.coreedge.raft.ConsensusListener renamed to org.neo4j.coreedge.raft.RaftStateMachine | From | To | |
| Rename Class org.neo4j.coreedge.server.edge.EdgeToCoreConnectionStrategy renamed to org.neo4j.coreedge.server.edge.CoreServerSelectionStrategy | From | To | |
| Rename Class org.neo4j.coreedge.discovery.EdgeServerConnectionException renamed to org.neo4j.coreedge.discovery.CoreServerSelectionException | From | To | |
| Move Class | 1 | ||
| Move Class org.neo4j.coreedge.catchup.storecopy.edge.StoreCopyFailedException moved to org.neo4j.coreedge.catchup.storecopy.StoreCopyFailedException | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute consensusListener : ConsensusListener to raftStateMachine : RaftStateMachine in class org.neo4j.coreedge.raft.RaftInstanceBuilder | From | To | |
| Rename Attribute raft : RaftInstance<CoreMember> to coreEditionSPI : CoreEditionSPI in class org.neo4j.coreedge.server.core.CoreGraphDatabase | From | To | |
| Rename Attribute consensusListener : ConsensusListener to raftStateMachine : RaftStateMachine in class org.neo4j.coreedge.raft.RaftInstance | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type dependencies : org.neo4j.kernel.impl.util.Dependencies to dependencies : Dependencies in method public EnterpriseCoreEditionModule(platformModule PlatformModule, discoveryServiceFactory DiscoveryServiceFactory) in class org.neo4j.coreedge.server.core.EnterpriseCoreEditionModule | From | To | |
| Change Variable Type expected : LinkedList<Integer> to actual : List<Integer> in method private integerValues(log ReadableRaftLog) : List<Integer> in class org.neo4j.coreedge.raft.CatchUpTest | From | To | |
| Extract Method | 1 | ||
| Extract Method public addCoreServerWithServerId(serverId int, intendedClusterSize int, extraParams Map<String,String>) : void extracted from public addCoreServerWithServerId(serverId int, intendedClusterSize int) : void in class org.neo4j.coreedge.discovery.Cluster | From | To | |
| Change Attribute Type | 5 | ||
| Change Attribute Type consensusListener : ConsensusListener to raftStateMachine : RaftStateMachine in class org.neo4j.coreedge.raft.RaftInstanceBuilder | From | To | |
| Change Attribute Type raft : RaftInstance<CoreMember> to coreEditionSPI : CoreEditionSPI in class org.neo4j.coreedge.server.core.CoreGraphDatabase | From | To | |
| Change Attribute Type consensusListener : ConsensusListener to raftStateMachine : RaftStateMachine in class org.neo4j.coreedge.raft.RaftInstance | From | To | |
| Change Attribute Type connectionStrategy : EdgeToCoreConnectionStrategy to connectionStrategy : CoreServerSelectionStrategy in class org.neo4j.coreedge.server.edge.EdgeServerStartupProcess | From | To | |
| Change Attribute Type connectionStrategy : EdgeToCoreConnectionStrategy to connectionStrategy : CoreServerSelectionStrategy in class org.neo4j.coreedge.catchup.tx.edge.TxPollingClient | From | To | |
| Rename Parameter | 5 | ||
| Rename Parameter from : AdvertisedSocketAddress to serverAddress : AdvertisedSocketAddress in method public requestStore(serverAddress AdvertisedSocketAddress) : void in class org.neo4j.coreedge.catchup.storecopy.edge.CoreClient | From | To | |
| Rename Parameter consensusListener : ConsensusListener to raftStateMachine : RaftStateMachine in method public RaftInstance(myself MEMBER, termStorage StateStorage<TermState>, voteStorage StateStorage<VoteState<MEMBER>>, entryLog RaftLog, raftStateMachine RaftStateMachine, electionTimeout long, heartbeatInterval long, renewableTimeoutService RenewableTimeoutService, inbound Inbound, outbound Outbound<MEMBER>, leaderWaitTimeout long, logProvider LogProvider, membershipManager RaftMembershipManager<MEMBER>, logShipping RaftLogShippingManager<MEMBER>, databaseHealthSupplier Supplier<DatabaseHealth>, monitors Monitors) in class org.neo4j.coreedge.raft.RaftInstance | From | To | |
| Rename Parameter consensusListener : ConsensusListener to raftStateMachine : RaftStateMachine in method private createRaft(life LifeSupport, outbound Outbound<AdvertisedSocketAddress>, discoveryService CoreDiscoveryService, config Config, messageLogger MessageLogger<AdvertisedSocketAddress>, raftLog RaftLog, raftStateMachine RaftStateMachine, fileSystem FileSystemAbstraction, clusterStateDirectory File, myself CoreMember, logProvider LogProvider, raftServer RaftServer<CoreMember>, raftTimeoutService DelayedRenewableTimeoutService, databaseHealthSupplier Supplier<DatabaseHealth>, monitors Monitors) : RaftInstance<CoreMember> in class org.neo4j.coreedge.server.core.EnterpriseCoreEditionModule | From | To | |
| Rename Parameter marshal : ChannelMarshal<MEMBER> to memberMarshal : ChannelMarshal<MEMBER> in method public Marshal(memberMarshal ChannelMarshal<MEMBER>) in class org.neo4j.coreedge.server.core.locks.ReplicatedLockTokenState.Marshal | From | To | |
| Rename Parameter from : AdvertisedSocketAddress to serverAddress : AdvertisedSocketAddress in method public pollForTransactions(serverAddress AdvertisedSocketAddress, lastTransactionId long) : void in class org.neo4j.coreedge.catchup.storecopy.edge.CoreClient | From | To |