2d7cd7984293c8548da5afe24d608af5ff235697
Files Diff
- Added: 3
- Removed: 2
- Renamed: 0
- Modified: 36
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method private containsAnyLabel(labelIdFilter int[], labels long[]) : boolean from class org.neo4j.kernel.impl.transaction.state.storeview.StoreViewNodeStoreScan to package containsAnyEntityToken(entityTokenFilter int[], entityTokens long...) : boolean from class org.neo4j.kernel.impl.transaction.state.storeview.PropertyAwareEntityStoreScan | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type node : NodeRecord to record : RECORD in method package PropertyBlockIterator(record RECORD) in class org.neo4j.kernel.impl.transaction.state.storeview.PropertyAwareEntityStoreScan.PropertyBlockIterator | From | To | |
| Pull Up Attribute | 2 | ||
| Pull Up Attribute private propertyStore : PropertyStore from class org.neo4j.kernel.impl.transaction.state.storeview.StoreViewNodeStoreScan to private propertyStore : PropertyStore from class org.neo4j.kernel.impl.transaction.state.storeview.PropertyAwareEntityStoreScan | From | To | |
| Pull Up Attribute private propertyKeyIdFilter : IntPredicate from class org.neo4j.kernel.impl.transaction.state.storeview.StoreViewNodeStoreScan to private propertyKeyIdFilter : IntPredicate from class org.neo4j.kernel.impl.transaction.state.storeview.PropertyAwareEntityStoreScan | From | To | |
| Move Attribute | 1 | ||
| Move Attribute protected nodeStore : NodeStore from class org.neo4j.kernel.impl.transaction.state.storeview.NodeStoreScan to private nodeStore : NodeStore from class org.neo4j.kernel.impl.transaction.state.storeview.StoreViewNodeStoreScan | From | To | |
| Rename Class | 3 | ||
| Rename Class org.neo4j.kernel.impl.transaction.state.NodeStoreScanTest renamed to org.neo4j.kernel.impl.transaction.state.PropertyAwareEntityStoreScanTest | From | To | |
| Rename Class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.NodePopulationVisitor renamed to org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.EntityPopulationVisitor | From | To | |
| Rename Class org.neo4j.kernel.impl.transaction.state.storeview.NeoStoreIndexStoreViewTest.NodeUpdateCollectingVisitor renamed to org.neo4j.kernel.impl.transaction.state.storeview.NeoStoreIndexStoreViewTest.EntityUpdateCollectingVisitor | From | To | |
| Move Class | 1 | ||
| Move Class org.neo4j.kernel.impl.transaction.state.storeview.StoreViewNodeStoreScan.PropertyBlockIterator moved to org.neo4j.kernel.impl.transaction.state.storeview.PropertyAwareEntityStoreScan.PropertyBlockIterator | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type visitor : NodeUpdateCollectingVisitor to visitor : EntityUpdateCollectingVisitor in method public shouldIgnoreDeletedNodesDuringScan() : void in class org.neo4j.kernel.impl.transaction.state.storeview.NeoStoreIndexStoreViewTest | From | To | |
| Change Variable Type visitor : NodeUpdateCollectingVisitor to visitor : EntityUpdateCollectingVisitor in method public shouldScanExistingNodesForALabel() : void in class org.neo4j.kernel.impl.transaction.state.storeview.NeoStoreIndexStoreViewTest | From | To | |
| Extract Variable | 1 | ||
| Extract Variable indexDescriptor : CapableIndexDescriptor in method private newIndexPopulationJob(failureDelegateFactory FailedIndexProxyFactory, populator IndexPopulator, flipper FlippableIndexProxy, storeView IndexStoreView, logProvider LogProvider, type EntityType, descriptor IndexDescriptor) : IndexPopulationJob from class org.neo4j.kernel.impl.api.index.IndexPopulationJobTest | From | To | |
| Extract Method | 2 | ||
| Extract Method private populate(rebuildingDescriptors MutableLongObjectMap<StoreIndexDescriptor>, indexMap IndexMap, populationJob IndexPopulationJob) : void extracted from public start() : void in class org.neo4j.kernel.impl.api.index.IndexingService | From | To | |
| Rename Method | 15 | ||
| Rename Method private indexAllNodes() : void renamed to private indexAllEntities() : void in class org.neo4j.kernel.impl.api.index.IndexPopulationJob | From | To | |
| Rename Method private label(labels long...) : long[] renamed to private entityTokens(entityTokenIds long...) : long[] in class org.neo4j.kernel.impl.api.index.IndexMapTest | From | To | |
| Rename Method public indexAllNodes() : StoreScan<IndexPopulationFailedKernelException> renamed to public indexAllEntities() : StoreScan<IndexPopulationFailedKernelException> in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator | From | To | |
| Rename Method private countIndexesByLabels(labels long[]) : int renamed to private countIndexesByEntityTokens(entityTokenIds long[], descriptors IntObjectMap<Set<SchemaDescriptor>>, descriptorsForAllEntityTokenIds Set<SchemaDescriptor>) : int in class org.neo4j.kernel.impl.api.index.IndexMap | From | To | |
| Rename Method public getPropertyValue(nodeId long, propertyKeyId int) : Value renamed to public getNodePropertyValue(nodeId long, propertyKeyId int) : Value in class org.neo4j.kernel.api.impl.index.TestPropertyAccessor | From | To | |
| Rename Method public getNodeIdIterator() : PrimitiveLongResourceIterator renamed to public getEntityIdIterator() : PrimitiveLongResourceIterator in class schema.MultiIndexPopulationConcurrentUpdatesIT.LabelScanViewNodeStoreWrapper | From | To | |
| Rename Method public getPropertyValue(nodeId long, propertyKeyId int) : Value renamed to public getNodePropertyValue(nodeId long, propertyKeyId int) : Value in class org.neo4j.kernel.impl.transaction.state.storeview.DynamicIndexStoreView | From | To | |
| Rename Method public getPropertyValue(nodeId long, propertyKeyId int) : Value renamed to public getNodePropertyValue(nodeId long, propertyKeyId int) : Value in class org.neo4j.kernel.api.index.NodePropertyAccessor | From | To | |
| Rename Method public indexAllNodes() : StoreScan<IndexPopulationFailedKernelException> renamed to public indexAllEntities() : StoreScan<IndexPopulationFailedKernelException> in class org.neo4j.kernel.impl.api.index.BatchingMultipleIndexPopulator | From | To | |
| Rename Method public getPropertyValue(nodeId long, propertyKeyId int) : Value renamed to public getNodePropertyValue(nodeId long, propertyKeyId int) : Value in class org.neo4j.kernel.impl.transaction.state.storeview.NeoStoreIndexStoreView | From | To | |
| Rename Method public getPropertyValue(nodeId long, propertyKeyId int) : Value renamed to public getNodePropertyValue(nodeId long, propertyKeyId int) : Value in class org.neo4j.consistency.checking.full.PropertyReader | From | To | |
| Rename Method public getNodeIdIterator() : PrimitiveLongResourceIterator renamed to public getEntityIdIterator() : PrimitiveLongResourceIterator in class org.neo4j.kernel.impl.transaction.state.storeview.LabelScanViewNodeStoreScan | From | To | |
| Rename Method public getPropertyValue(nodeId long, propertyKeyId int) : Value renamed to public getNodePropertyValue(nodeId long, propertyKeyId int) : Value in class org.neo4j.kernel.impl.api.index.IndexStoreView.Adaptor | From | To | |
| Rename Method private extractIndexesByLabels(labels long[]) : Set<SchemaDescriptor> renamed to private extractIndexesByEntityTokens(entityTokenIds long[], descriptors IntObjectMap<Set<SchemaDescriptor>>, descriptorsForAllEntityTokens Set<SchemaDescriptor>) : Set<SchemaDescriptor> in class org.neo4j.kernel.impl.api.index.IndexMap | From | To | |
| Rename Method public getPropertyValue(nodeId long, propertyKeyId int) : Value renamed to public getNodePropertyValue(nodeId long, propertyKeyId int) : Value in class org.neo4j.kernel.api.index.PropertyAccessor | From | To | |
| Pull Up Method | 2 | ||
| Pull Up Method public acceptUpdate(updater MultipleIndexPopulator.MultipleIndexUpdater, update IndexEntryUpdate<?>, currentlyIndexedNodeId long) : void from class org.neo4j.kernel.impl.transaction.state.storeview.StoreViewNodeStoreScan to public acceptUpdate(updater MultipleIndexPopulator.MultipleIndexUpdater, update IndexEntryUpdate<?>, currentlyIndexedNodeId long) : void from class org.neo4j.kernel.impl.transaction.state.storeview.PropertyAwareEntityStoreScan | From | To | |
| Pull Up Method private valueOf(property PropertyBlock) : Value from class org.neo4j.kernel.impl.transaction.state.storeview.StoreViewNodeStoreScan to protected valueOf(property PropertyBlock) : Value from class org.neo4j.kernel.impl.transaction.state.storeview.PropertyAwareEntityStoreScan | From | To | |
| Rename Variable | 3 | ||
| Rename Variable label : long to entityToken : long in method private countIndexesByEntityTokens(entityTokenIds long[], descriptors IntObjectMap<Set<SchemaDescriptor>>, descriptorsForAllEntityTokenIds Set<SchemaDescriptor>) : int in class org.neo4j.kernel.impl.api.index.IndexMap | From | To | |
| Rename Variable forLabel : Set<SchemaDescriptor> to forEntityToken : Set<SchemaDescriptor> in method private countIndexesByEntityTokens(entityTokenIds long[], descriptors IntObjectMap<Set<SchemaDescriptor>>, descriptorsForAllEntityTokenIds Set<SchemaDescriptor>) : int in class org.neo4j.kernel.impl.api.index.IndexMap | From | To | |
| Rename Variable labelIds : int[] to entityTokenIds : int[] in method public indexAllEntities() : StoreScan<IndexPopulationFailedKernelException> in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Iterable<SchemaDescriptor> to Set<SchemaDescriptor> in method public getRelatedIndexes(changedEntityTokens long[], unchangedEntityTokens long[], properties IntSet, entityType EntityType) : Set<SchemaDescriptor> in class org.neo4j.kernel.impl.api.index.IndexMapReference | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.neo4j.kernel.impl.transaction.state.storeview.PropertyAwareEntityStoreScan from classes [org.neo4j.kernel.impl.transaction.state.storeview.StoreViewNodeStoreScan] | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute propertyStore : PropertyStore to nodeStore : NodeStore in class org.neo4j.kernel.impl.transaction.state.storeview.StoreViewNodeStoreScan | From | To | |
| Rename Attribute populationJob : IndexPopulationJob to nodePopulationJob : IndexPopulationJob in class org.neo4j.kernel.impl.api.index.IndexingService.IndexPopulationStarter | From | To | |
| Rename Attribute schema : CapableIndexDescriptor to descriptor : CapableIndexDescriptor in class org.neo4j.kernel.impl.api.index.IndexMapTest.TestIndexProxy | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type propertyStore : PropertyStore to nodeStore : NodeStore in class org.neo4j.kernel.impl.transaction.state.storeview.StoreViewNodeStoreScan | From | To | |
| Rename Parameter | 8 | ||
| Rename Parameter labels : long[] to entityTokenIds : long[] in method private extractIndexesByEntityTokens(entityTokenIds long[], descriptors IntObjectMap<Set<SchemaDescriptor>>, descriptorsForAllEntityTokens Set<SchemaDescriptor>) : Set<SchemaDescriptor> in class org.neo4j.kernel.impl.api.index.IndexMap | From | To | |
| Rename Parameter node : NodeRecord to record : RECORD in method package PropertyBlockIterator(record RECORD) in class org.neo4j.kernel.impl.transaction.state.storeview.PropertyAwareEntityStoreScan.PropertyBlockIterator | From | To | |
| Rename Parameter changedLabels : long[] to changedEntityTokens : long[] in method public getRelatedIndexes(changedEntityTokens long[], unchangedEntityTokens long[], properties IntSet, entityType EntityType) : Set<SchemaDescriptor> in class org.neo4j.kernel.impl.api.index.IndexMapReference | From | To | |
| Rename Parameter labelIdFilter : int[] to entityTokenFilter : int[] in method package containsAnyEntityToken(entityTokenFilter int[], entityTokens long...) : boolean in class org.neo4j.kernel.impl.transaction.state.storeview.PropertyAwareEntityStoreScan | From | To | |
| Rename Parameter labels : long... to entityTokenIds : long... in method private entityTokens(entityTokenIds long...) : long[] in class org.neo4j.kernel.impl.api.index.IndexMapTest | From | To | |
| Rename Parameter labels : long[] to entityTokenIds : long[] in method private countIndexesByEntityTokens(entityTokenIds long[], descriptors IntObjectMap<Set<SchemaDescriptor>>, descriptorsForAllEntityTokenIds Set<SchemaDescriptor>) : int in class org.neo4j.kernel.impl.api.index.IndexMap | From | To | |
| Rename Parameter schema : CapableIndexDescriptor to descriptor : CapableIndexDescriptor in method private TestIndexProxy(descriptor CapableIndexDescriptor) in class org.neo4j.kernel.impl.api.index.IndexMapTest.TestIndexProxy | From | To | |
| Rename Parameter labels : long[] to entityTokens : long... in method package containsAnyEntityToken(entityTokenFilter int[], entityTokens long...) : boolean in class org.neo4j.kernel.impl.transaction.state.storeview.PropertyAwareEntityStoreScan | From | To |