neo4j 346608efb08681a04e477336311bc2fc8c9e3c7e

346608efb08681a04e477336311bc2fc8c9e3c7e

Files Diff

Added: 4
Removed: 3
Renamed: 0
Modified: 39

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	3
Rename Method protected initHttpsKeyStore() : KeyStoreInformation renamed to protected createKeyStore() : KeyStoreInformation in class org.neo4j.server.AbstractNeoServer	From	To
Rename Method protected createConfigurationBuilder(log Log) : ConfigurationBuilder renamed to protected createConfig(log Log, file File, configOverrides Pair<String,String>[]) : Config in class org.neo4j.server.WrappingNeoServerBootstrapper	From	To
Rename Method public getServerConfigurator() : ConfigurationBuilder renamed to public getConfig() : Config in class org.neo4j.desktop.ui.DesktopModel	From	To
Move And Rename Method	1
Move And Rename Method private setProperty(config Config, key String, value String) : void from class org.neo4j.server.advanced.jmx.ServerManagementTest to private applyUserOverrides(config Config, configOverrides Pair<String,String>[]) : void from class org.neo4j.server.configuration.ServerConfigFactory	From	To
Change Parameter Type	19
Change Parameter Type configurator : ConfigurationBuilder to config : Config in method protected createNeoServer(config Config, dependencies GraphDatabaseDependencies, userLogProvider LogProvider) : NeoServer in class org.neo4j.server.WrappingNeoServerBootstrapper	From	To
Change Parameter Type propertyFileConfigurator : ConfigurationBuilder to config : Config in method public TestEnterpriseNeoServer(config Config, configFile File, dependencies GraphDatabaseFacadeFactory.Dependencies, logProvider LogProvider) in class org.neo4j.server.enterprise.helpers.EnterpriseServerBuilder.TestEnterpriseNeoServer	From	To
Change Parameter Type configurator : ConfigurationBuilder to config : Config in method public CommunityNeoServer(config Config, dbFactory Database.Factory, dependencies GraphDatabaseFacadeFactory.Dependencies, logProvider LogProvider) in class org.neo4j.server.CommunityNeoServer	From	To
Change Parameter Type configurator : ConfigurationBuilder to config : Config in method protected createDatabaseActionsObject(database Database, config Config) : DatabaseActions in class org.neo4j.server.helpers.CommunityServerBuilder	From	To
Change Parameter Type configurator : ConfigurationBuilder to config : Config in method protected build(configFile File, config Config, dependencies GraphDatabaseFacadeFactory.Dependencies) : CommunityNeoServer in class org.neo4j.server.enterprise.helpers.EnterpriseServerBuilder	From	To
Change Parameter Type configurator : ConfigurationBuilder to config : Config in method public AdvancedNeoServer(config Config, dbFactory Database.Factory, dependencies CommunityFacadeFactory.Dependencies, logProvider LogProvider) in class org.neo4j.server.advanced.AdvancedNeoServer	From	To
Change Parameter Type configurator : ConfigurationBuilder to config : Config in method protected build(configFile File, config Config, dependencies GraphDatabaseFacadeFactory.Dependencies) : AdvancedNeoServer in class org.neo4j.server.advanced.helpers.AdvancedServerBuilder	From	To
Change Parameter Type configurator : ConfigurationBuilder to config : Config in method public EnterpriseNeoServer(config Config, dependencies Dependencies, logProvider LogProvider) in class org.neo4j.server.enterprise.EnterpriseNeoServer	From	To
Change Parameter Type propertyFileConfigurator : ConfigurationBuilder to config : Config in method public TestAdvancedNeoServer(config Config, configFile File, dependencies GraphDatabaseFacadeFactory.Dependencies, logProvider LogProvider) in class org.neo4j.server.advanced.helpers.AdvancedServerBuilder.TestAdvancedNeoServer	From	To
Change Parameter Type configurator : ConfigurationBuilder to config : Config in method protected createNeoServer(config Config, dependencies GraphDatabaseDependencies, userLogProvider LogProvider) : NeoServer in class org.neo4j.server.advanced.AdvancedBootstrapper	From	To
Change Parameter Type configurator : ConfigurationBuilder to config : Config in method public AbstractNeoServer(config Config, dbFactory Database.Factory, dependencies GraphDatabaseFacadeFactory.Dependencies, logProvider LogProvider) in class org.neo4j.server.AbstractNeoServer	From	To
Change Parameter Type configurator : ConfigurationBuilder to config : Config in method protected build(configFile File, config Config, dependencies GraphDatabaseFacadeFactory.Dependencies) : CommunityNeoServer in class org.neo4j.server.helpers.CommunityServerBuilder	From	To
Change Parameter Type configurator : ConfigurationBuilder to config : Config in method protected abstract createNeoServer(config Config, dependencies GraphDatabaseDependencies, userLogProvider LogProvider) : NeoServer in class org.neo4j.server.Bootstrapper	From	To
Change Parameter Type configurator : ConfigurationBuilder to configurator : Config in method protected createNeoServer(configurator Config, dependencies GraphDatabaseDependencies, userLogProvider LogProvider) : NeoServer in class org.neo4j.server.enterprise.EnterpriseBootstrapper	From	To
Change Parameter Type configurator : ConfigurationBuilder to config : Config in method public CommunityNeoServer(config Config, dependencies GraphDatabaseFacadeFactory.Dependencies, logProvider LogProvider) in class org.neo4j.server.CommunityNeoServer	From	To
Change Parameter Type configurator : ConfigurationBuilder to config : Config in method protected createNeoServer(config Config, dependencies GraphDatabaseDependencies, logProvider LogProvider) : NeoServer in class org.neo4j.server.CommunityBootstrapper	From	To
Change Parameter Type configurator : ConfigurationBuilder to config : Config in method public AdvancedNeoServer(config Config, dependencies CommunityFacadeFactory.Dependencies, logProvider LogProvider) in class org.neo4j.server.advanced.AdvancedNeoServer	From	To
Change Parameter Type builder : ConfigurationBuilder to config : Config in method public ConfigWrappingConfigurator(config Config) in class org.neo4j.server.configuration.ConfigurationBuilder.ConfigWrappingConfigurator	From	To
Change Parameter Type propertyFileConfigurator : ConfigurationBuilder to config : Config in method private TestCommunityNeoServer(config Config, configFile File, dependencies GraphDatabaseFacadeFactory.Dependencies, logProvider LogProvider) in class org.neo4j.server.helpers.CommunityServerBuilder.TestCommunityNeoServer	From	To
Move Method	2
Move Method public shouldBeAbleToOverrideShellConfig() : void from class org.neo4j.server.NeoServerShellConfigIT to public shouldBeAbleToOverrideShellConfig() : void from class org.neo4j.server.integration.ServerConfigIT	From	To
Move Method private findFreeShellPortToUse(startingPort int) : int from class org.neo4j.server.NeoServerShellConfigIT to private findFreeShellPortToUse(startingPort int) : int from class org.neo4j.server.integration.ServerConfigIT	From	To
Rename Variable	3
Rename Variable databaseTuningProperties : Map<String,String> to config : Config in method public shouldSupportProvidingDatabaseTuningParametersSeparately() : void in class org.neo4j.server.configuration.ServerConfigTest	From	To
Rename Variable configurator : ConfigurationBuilder to config : Config in method public build() : CommunityNeoServer in class org.neo4j.server.helpers.CommunityServerBuilder	From	To
Rename Variable configurator : ConfigurationBuilder to config : Config in method public start() : void in class org.neo4j.desktop.runtime.DatabaseActions	From	To
Change Return Type	4
Change Return Type Integer to int in method public start(configFile File, configOverrides Pair<String,String>...) : int in class org.neo4j.server.Bootstrapper	From	To
Change Return Type void to Config in method public applyChanges(newConfiguration Map<String,String>) : Config in class org.neo4j.kernel.configuration.Config	From	To
Change Return Type ConfigurationBuilder to Config in method public getConfig() : Config in class org.neo4j.desktop.ui.DesktopModel	From	To
Change Return Type ConfigurationBuilder to Config in method protected createConfig(log Log, file File, configOverrides Pair<String,String>[]) : Config in class org.neo4j.server.WrappingNeoServerBootstrapper	From	To
Rename Class	3
Rename Class org.neo4j.server.configuration.ConfiguratorTest renamed to org.neo4j.server.configuration.ServerConfigTest	From	To
Rename Class org.neo4j.server.configuration.ConfigurationBuilder.ConfigurationBuilderWrappingConfigurator renamed to org.neo4j.server.configuration.ConfigurationBuilder.ConfigWrappingConfigurator	From	To
Rename Class org.neo4j.server.configuration.PropertyFileConfiguratorTest renamed to org.neo4j.server.configuration.ServerConfigFactoryTest	From	To
Rename Attribute	3
Rename Attribute builder : ConfigurationBuilder to config : Config in class org.neo4j.server.configuration.ConfigurationBuilder.ConfigWrappingConfigurator	From	To
Rename Attribute configurator : ConfigurationBuilder to config : Config in class org.neo4j.server.Bootstrapper	From	To
Rename Attribute configurator : ConfigurationBuilder to config : Config in class org.neo4j.server.AbstractNeoServer	From	To
Change Variable Type	4
Change Variable Type configurator : ConfigurationBuilder to config : Config in method public build() : CommunityNeoServer in class org.neo4j.server.helpers.CommunityServerBuilder	From	To
Change Variable Type configurator : ConfigurationBuilder to config : Config in method public start() : void in class org.neo4j.desktop.runtime.DatabaseActions	From	To
Change Variable Type pathToStoreDir : String to pathToStoreDir : File in method public dbPropertiesShouldContainStoreDirProperty() : void in class org.neo4j.desktop.runtime.DesktopConfiguratorTest	From	To
Change Variable Type databaseTuningProperties : Map<String,String> to config : Config in method public shouldSupportProvidingDatabaseTuningParametersSeparately() : void in class org.neo4j.server.configuration.ServerConfigTest	From	To
Change Attribute Type	6
Change Attribute Type GRAPH_DATABASE_STARTUP_ERROR_CODE : Integer to GRAPH_DATABASE_STARTUP_ERROR_CODE : int in class org.neo4j.server.Bootstrapper	From	To
Change Attribute Type builder : ConfigurationBuilder to config : Config in class org.neo4j.server.configuration.ConfigurationBuilder.ConfigWrappingConfigurator	From	To
Change Attribute Type WEB_SERVER_STARTUP_ERROR_CODE : Integer to WEB_SERVER_STARTUP_ERROR_CODE : int in class org.neo4j.server.Bootstrapper	From	To
Change Attribute Type OK : Integer to OK : int in class org.neo4j.server.Bootstrapper	From	To
Change Attribute Type configurator : ConfigurationBuilder to config : Config in class org.neo4j.server.AbstractNeoServer	From	To
Change Attribute Type configurator : ConfigurationBuilder to config : Config in class org.neo4j.server.Bootstrapper	From	To
Extract Method	1
Extract Method public pair(first T1, other T2) : Pair<T1,T2> extracted from public of(first T1, other T2) : Pair<T1,T2> in class org.neo4j.helpers.Pair	From	To
Rename Parameter	18
Rename Parameter configurator : ConfigurationBuilder to config : Config in method protected abstract createNeoServer(config Config, dependencies GraphDatabaseDependencies, userLogProvider LogProvider) : NeoServer in class org.neo4j.server.Bootstrapper	From	To
Rename Parameter propertyFileConfigurator : ConfigurationBuilder to config : Config in method public TestEnterpriseNeoServer(config Config, configFile File, dependencies GraphDatabaseFacadeFactory.Dependencies, logProvider LogProvider) in class org.neo4j.server.enterprise.helpers.EnterpriseServerBuilder.TestEnterpriseNeoServer	From	To
Rename Parameter configurator : ConfigurationBuilder to config : Config in method protected createDatabaseActionsObject(database Database, config Config) : DatabaseActions in class org.neo4j.server.helpers.CommunityServerBuilder	From	To
Rename Parameter configurator : ConfigurationBuilder to config : Config in method public CommunityNeoServer(config Config, dbFactory Database.Factory, dependencies GraphDatabaseFacadeFactory.Dependencies, logProvider LogProvider) in class org.neo4j.server.CommunityNeoServer	From	To
Rename Parameter configurator : ConfigurationBuilder to config : Config in method protected build(configFile File, config Config, dependencies GraphDatabaseFacadeFactory.Dependencies) : AdvancedNeoServer in class org.neo4j.server.advanced.helpers.AdvancedServerBuilder	From	To
Rename Parameter configurator : ConfigurationBuilder to config : Config in method public EnterpriseNeoServer(config Config, dependencies Dependencies, logProvider LogProvider) in class org.neo4j.server.enterprise.EnterpriseNeoServer	From	To
Rename Parameter configurator : ConfigurationBuilder to config : Config in method protected createNeoServer(config Config, dependencies GraphDatabaseDependencies, logProvider LogProvider) : NeoServer in class org.neo4j.server.CommunityBootstrapper	From	To
Rename Parameter builder : ConfigurationBuilder to config : Config in method public ConfigWrappingConfigurator(config Config) in class org.neo4j.server.configuration.ConfigurationBuilder.ConfigWrappingConfigurator	From	To
Rename Parameter propertyFileConfigurator : ConfigurationBuilder to config : Config in method public TestAdvancedNeoServer(config Config, configFile File, dependencies GraphDatabaseFacadeFactory.Dependencies, logProvider LogProvider) in class org.neo4j.server.advanced.helpers.AdvancedServerBuilder.TestAdvancedNeoServer	From	To
Rename Parameter configurator : ConfigurationBuilder to config : Config in method public AdvancedNeoServer(config Config, dependencies CommunityFacadeFactory.Dependencies, logProvider LogProvider) in class org.neo4j.server.advanced.AdvancedNeoServer	From	To
Rename Parameter propertyFileConfigurator : ConfigurationBuilder to config : Config in method private TestCommunityNeoServer(config Config, configFile File, dependencies GraphDatabaseFacadeFactory.Dependencies, logProvider LogProvider) in class org.neo4j.server.helpers.CommunityServerBuilder.TestCommunityNeoServer	From	To
Rename Parameter configurator : ConfigurationBuilder to config : Config in method public AbstractNeoServer(config Config, dbFactory Database.Factory, dependencies GraphDatabaseFacadeFactory.Dependencies, logProvider LogProvider) in class org.neo4j.server.AbstractNeoServer	From	To
Rename Parameter configurator : ConfigurationBuilder to config : Config in method protected createNeoServer(config Config, dependencies GraphDatabaseDependencies, userLogProvider LogProvider) : NeoServer in class org.neo4j.server.WrappingNeoServerBootstrapper	From	To
Rename Parameter configurator : ConfigurationBuilder to config : Config in method protected build(configFile File, config Config, dependencies GraphDatabaseFacadeFactory.Dependencies) : CommunityNeoServer in class org.neo4j.server.enterprise.helpers.EnterpriseServerBuilder	From	To
Rename Parameter configurator : ConfigurationBuilder to config : Config in method public CommunityNeoServer(config Config, dependencies GraphDatabaseFacadeFactory.Dependencies, logProvider LogProvider) in class org.neo4j.server.CommunityNeoServer	From	To
Rename Parameter configurator : ConfigurationBuilder to config : Config in method public AdvancedNeoServer(config Config, dbFactory Database.Factory, dependencies CommunityFacadeFactory.Dependencies, logProvider LogProvider) in class org.neo4j.server.advanced.AdvancedNeoServer	From	To
Rename Parameter configurator : ConfigurationBuilder to config : Config in method protected createNeoServer(config Config, dependencies GraphDatabaseDependencies, userLogProvider LogProvider) : NeoServer in class org.neo4j.server.advanced.AdvancedBootstrapper	From	To
Rename Parameter configurator : ConfigurationBuilder to config : Config in method protected build(configFile File, config Config, dependencies GraphDatabaseFacadeFactory.Dependencies) : CommunityNeoServer in class org.neo4j.server.helpers.CommunityServerBuilder	From	To

346608efb08681a04e477336311bc2fc8c9e3c7e

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: