353c4cc2e817eb568f4d45292112372cb09aff13
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 4
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private getReadLockOnMaster(resourceType Locks.ResourceType, resourceId long) : boolean renamed to private acquireSharedOnMaster(resourceType Locks.ResourceType, resourceIds long...) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type resourceId : long to resourceIds : long... in method private acquireSharedOnMaster(resourceType Locks.ResourceType, resourceIds long...) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient | From | To | |
| Change Parameter Type resourceId : long to resourceIds : long... in method private acquireExclusiveOnMaster(resourceType Locks.ResourceType, resourceIds long...) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient | From | To | |
| Change Parameter Type lockSet : Set<Resource> to exclusive : boolean in method private queueLock(resourceType ResourceType, resourceId long, exclusive boolean) : boolean in class org.neo4j.kernel.impl.locking.DeferringLocks.DeferringLockClient | From | To | |
| Rename Variable | 1 | ||
| Rename Variable resource : Resource to other : Resource in method public equals(obj Object) : boolean in class org.neo4j.kernel.impl.locking.DeferringLocks.Resource | From | To | |
| Change Return Type | 3 | ||
| Change Return Type boolean to void in method private acquireExclusiveOnMaster(resourceType Locks.ResourceType, resourceIds long...) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient | From | To | |
| Change Return Type boolean to void in method private acquireSharedOnMaster(resourceType Locks.ResourceType, resourceIds long...) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient | From | To | |
| Change Return Type boolean to void in method private receiveLockResponse(response Response<LockResult>) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient | From | To | |
| Extract Variable | 1 | ||
| Extract Variable prime : int in method public hashCode() : int from class org.neo4j.kernel.impl.locking.DeferringLocks.Resource | From | To | |
| Extract Method | 3 | ||
| Extract Method private onlyFirstTimeLocks(lockMap Map<Long,AtomicInteger>, resourceIds long[]) : long[] extracted from public acquireExclusive(resourceType Locks.ResourceType, resourceIds long...) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient | From | To | |
| Extract Method private onlyFirstTimeLocks(lockMap Map<Long,AtomicInteger>, resourceIds long[]) : long[] extracted from public acquireShared(resourceType Locks.ResourceType, resourceIds long...) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient | From | To | |
| Extract Method private flushLocks(current long[], cursor int, currentType ResourceType, currentExclusive boolean) : boolean extracted from public prepare() : void in class org.neo4j.kernel.impl.locking.DeferringLocks.DeferringLockClient | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter lockSet : Set<Resource> to exclusive : boolean in method private queueLock(resourceType ResourceType, resourceId long, exclusive boolean) : boolean in class org.neo4j.kernel.impl.locking.DeferringLocks.DeferringLockClient | From | To | |
| Rename Parameter o : Object to obj : Object in method public equals(obj Object) : boolean in class org.neo4j.kernel.impl.locking.DeferringLocks.Resource | From | To | |
| Rename Parameter resourceId : long to resourceIds : long... in method private acquireSharedOnMaster(resourceType Locks.ResourceType, resourceIds long...) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient | From | To | |
| Rename Parameter resourceId : long to resourceIds : long... in method private acquireExclusiveOnMaster(resourceType Locks.ResourceType, resourceIds long...) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient | From | To |